[Bug 359881] Re: Main inclusion request for odt2txt
This has an embedded unzipping library (kunzip/*). I would be happier if it could be ported to libzip instead. Since this is only a Recommends, if porting to libzip is not possible, I would rather that tracker move it to a Suggests. Outside of that, the code seems fairly defensive when handling the odt data, so I would approve it after the libzip porting. ** Changed in: odt2txt (Ubuntu Jaunty) Status: New = Incomplete -- Main inclusion request for odt2txt https://bugs.launchpad.net/bugs/359881 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 359881] Re: Main inclusion request for odt2txt
And now I know how to use libzip. Ported to system libzip interface, so I'll approve this MIR if the release manage is happy with the debdiff. +1 ** Changed in: odt2txt (Ubuntu Jaunty) Status: Incomplete = Fix Committed -- Main inclusion request for odt2txt https://bugs.launchpad.net/bugs/359881 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 359881] Re: Main inclusion request for odt2txt
** Attachment added: odt2txt_0.4-1ubuntu1.debdiff http://launchpadlibrarian.net/25278907/odt2txt_0.4-1ubuntu1.debdiff -- Main inclusion request for odt2txt https://bugs.launchpad.net/bugs/359881 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 359881] Re: Main inclusion request for odt2txt
This bug was fixed in the package odt2txt - 0.4-1ubuntu1 --- odt2txt (0.4-1ubuntu1) jaunty; urgency=low * Makefile, odt2txt.c: port to using system libzip instead of kunzip (LP: #359881). -- Kees Cook k...@ubuntu.com Sun, 12 Apr 2009 01:35:36 -0700 ** Changed in: odt2txt (Ubuntu Jaunty) Status: Fix Committed = Fix Released -- Main inclusion request for odt2txt https://bugs.launchpad.net/bugs/359881 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 359881] Re: Main inclusion request for odt2txt
Patch looks correct to me, except for this: +(r = zip_name_locate(zip, filename, ZIP_FL_NOCASE)) 0 || The original code appears to do case-sensitive filename matches, and the above line does a case-insensitive match instead. This should be a non- issue for any well-formed odt file, but it does seem to diverge unnecessarily and was presumably an oversight. Accepting, anyway; if you want to correct this, I'll accept that change as well. -- Main inclusion request for odt2txt https://bugs.launchpad.net/bugs/359881 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 359881] Re: Main inclusion request for odt2txt
Looks like kunzip.h and kunzip.c documented the meaning of bits in opposite ways, and then didn't actually implement it at all. I've uploaded a version that does not set ZIP_FL_NOCASE now. Thanks! -- Main inclusion request for odt2txt https://bugs.launchpad.net/bugs/359881 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
