[Bug 367214] Re: utils.calculate_cloud() can leave font_size unset for most frequent tag
** Changed in: python-django-tagging (Ubuntu) Status: Fix Committed = Fix Released -- utils.calculate_cloud() can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 367214] Re: utils.calculate_cloud() can leave font_size unset for most frequent tag
Uploaded. Maybe you can make use of https://wiki.ubuntu.com/UbuntuDevelopment/PatchTaggingGuidelines the next time? :-) -- utils.calculate_cloud() can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 367214] Re: utils.calculate_cloud() can leave font_size unset for most frequent tag
This bug was fixed in the package python-django-tagging - 0.2.1+svn154-0ubuntu2.1 --- python-django-tagging (0.2.1+svn154-0ubuntu2.1) jaunty-proposed; urgency=low * debian/patches/02_fix_calculate_tag_weight.patch: Fix error in _calculate_tag_weight which in some cases may lead to font_size attribute of most frequent used tag set to None. (LP: #367214) -- Krzysztof Klimonda kklimo...@syntaxhighlighted.com Sun, 26 Apr 2009 23:39:17 +0200 ** Changed in: python-django-tagging (Ubuntu Jaunty) Status: Fix Committed = Fix Released -- utils.calculate_cloud() can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 367214] Re: utils.calculate_cloud() can leave font_size unset for most frequent tag
** Changed in: python-django-tagging (Ubuntu) Status: Triaged = Fix Committed ** Changed in: python-django-tagging (Ubuntu) Assignee: (unassigned) = Krzysztof Klimonda (kklimonda) -- utils.calculate_cloud() can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 367214] Re: utils.calculate_cloud() can leave font_size unset for most frequent tag
** Tags added: verification-done ** Tags removed: verification-needed -- utils.calculate_cloud() can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 367214] Re: utils.calculate_cloud() can leave font_size unset for most frequent tag
As sync is impossible I'm attaching a debdiff against python-django- tagging_0.2.1+svn154-0ubuntu2 for KK (It's the same as previous with changed release name. ** Attachment added: python-django-tagging_0.2.1+svn154-0ubuntu2.1.debdiff http://launchpadlibrarian.net/26949070/python-django-tagging_0.2.1%2Bsvn154-0ubuntu2.1.debdiff -- utils.calculate_cloud() can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 367214] Re: utils.calculate_cloud() can leave font_size unset for most frequent tag
** Changed in: python-django-tagging (Ubuntu) Importance: Undecided = Low ** Changed in: python-django-tagging (Ubuntu) Status: New = Triaged -- utils.calculate_cloud() can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 367214] Re: utils.calculate_cloud() can leave font_size unset for most frequent tag
** Changed in: python-django-tagging (Ubuntu) Assignee: Krzysztof Klimonda (kklimonda) = (unassigned) -- utils.calculate_cloud() can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 367214] Re: utils.calculate_cloud() can leave font_size unset for most frequent tag
This bug will be fixed in KK when sync (LP #373845) is done. -- utils.calculate_cloud() can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 367214] Re: utils.calculate_cloud() can leave font_size unset for most frequent tag
I've tested updated package using my testcase in clean jaunty environment and it fixes the issue. More feedback would be great. :) -- utils.calculate_cloud() can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 367214] Re: utils.calculate_cloud can leave font_size unset for most frequent tag
** Attachment added: patch to fix tag cloud generation (issue 91) http://launchpadlibrarian.net/25991637/dtcw.patch -- utils.calculate_cloud can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 367214] Re: utils.calculate_cloud can leave font_size unset for most frequent tag
I'll ask MOTU if this bug qualifies for a SRU. In the meantime could You provide a test case that illustrates it? ** Changed in: python-django-tagging (Ubuntu) Assignee: (unassigned) = Krzysztof Klimonda (kklimonda) -- utils.calculate_cloud can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 367214] Re: utils.calculate_cloud() can leave font_size unset for most frequent tag
** Summary changed: - utils.calculate_cloud can leave font_size unset for most frequent tag + utils.calculate_cloud() can leave font_size unset for most frequent tag ** Description changed: Binary package hint: python-django-tagging - This is a long standing issue on Google Code, issue 91: + Current version of package ``python-django-tagging'' has a long standing + bug in a _calculate_tag_weight() method. - http://code.google.com/p/django-tagging/issues/detail?id=91 + When a programmer creates tag cloud using method util.calculate_cloud() + or Tag.objects.cloud_for_model() and sets distribution argument to + ``LOGARITHMIC'' (or leave it empty as it is default value) + _calculate_tag_weight() in some cases may return result which is greater + than max_weight - because of that Tag object (the one most frequently + used in model) will be missing argument ``font_size'' and throw + AttributeError exception. It happens because of the way a floating point + division is done in Python. - This issue has been reported on Google Code quite some time ago, and - although there has been a patch available for well over a year, the - patch just doesn't seem to get applied. Without this patch, many - websites written in Django will often crash when generating a tag cloud, - because the font_size field does not always get set, and this does seem - to happen quite a lot. + The proposed patch address this issue by returning ``max_weight'' in + case when result of computation is greater than it. - I am not sure why this patch has not been applied for so long, maybe the - upstream author will need to be contacted about this. + I'm attaching a testcase in a form of a django project. To use it you + must install python-django-tagging and then from project root execute + ``./manage.py test''. AssertionError will be thrown. After fixing this + issue test passes. - I have created a package myself with this patch applied in my own PPA - should anyone need it for the time being: - - https://launchpad.net/~robvdl/+archive/ppa + A link to upstream bugreport: http://code.google.com/p/django- + tagging/issues/detail?id=91 ** Attachment added: testcase_367214.tgz http://launchpadlibrarian.net/26012610/testcase_367214.tgz -- utils.calculate_cloud() can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 367214] Re: utils.calculate_cloud() can leave font_size unset for most frequent tag
** Attachment added: python-django-tagging_0.2.1+svn154-0ubuntu2.1.debdiff http://launchpadlibrarian.net/26012616/python-django-tagging_0.2.1%2Bsvn154-0ubuntu2.1.debdiff -- utils.calculate_cloud() can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 367214] Re: utils.calculate_cloud() can leave font_size unset for most frequent tag
ACK from MOTU-SRU. ** Also affects: python-django-tagging (Ubuntu Jaunty) Importance: Undecided Status: New ** Changed in: python-django-tagging (Ubuntu Jaunty) Status: New = Confirmed -- utils.calculate_cloud() can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 367214] Re: utils.calculate_cloud() can leave font_size unset for most frequent tag
Accepted into jaunty-proposed, the package will build now and be available in a few hours.Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance! ** Changed in: python-django-tagging (Ubuntu Jaunty) Status: Confirmed = Fix Committed ** Tags added: verification-needed -- utils.calculate_cloud() can leave font_size unset for most frequent tag https://bugs.launchpad.net/bugs/367214 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
