[Bug 579669] Re: Creates sources.list.d file with illegal character in name
** Branch unlinked: lp:software-properties -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/579669 Title: Creates sources.list.d file with illegal character in name To manage notifications about this bug go to: https://bugs.launchpad.net/software-properties/+bug/579669/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 579669] Re: Creates sources.list.d file with illegal character in name
This bug was fixed in the package software-properties - 0.76 --- software-properties (0.76) maverick; urgency=low [ Jonathan Harker ] * Improve documentation for apt-add-repository (LP: #586790) [ mac9416 ] * Fixed bug LP: #446216: added --remove option to add-apt-reporitory. * Fixed Bug LP: #579669 which points out that add-apt-repository will create a sources.list.d file with illegal characters if there are illegal characters in a PPA name [ Andrea Corbellini ] * Automatically create a deb-src line when adding a new repository (LP: 399711) [ Michael Vogt ] * add test for LP: #579669 and use re.sub() instead of urllib.quote() * merged lp:~alexzak/software-properties/fixes, many thanks [ Erik B. Andersen ] * Fixed depreciation warnings [ Brandon Tomlinson ] * Altered data/glade/main.glade Put the bottom buttons in a button box to make the buttons assume the correct width (LP: #515990) -- Michael Vogt michael.v...@ubuntu.com Fri, 13 Aug 2010 17:38:45 +0200 ** Changed in: software-properties (Ubuntu) Status: Confirmed = Fix Released -- Creates sources.list.d file with illegal character in name https://bugs.launchpad.net/bugs/579669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 579669] Re: Creates sources.list.d file with illegal character in name
** Branch linked: lp:ubuntu/software-properties -- Creates sources.list.d file with illegal character in name https://bugs.launchpad.net/bugs/579669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 579669] Re: Creates sources.list.d file with illegal character in name
** Branch linked: lp:software-properties -- Creates sources.list.d file with illegal character in name https://bugs.launchpad.net/bugs/579669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 579669] Re: Creates sources.list.d file with illegal character in name
I went ahead and submitted a merge request for the patch. It seems to do what its supposed to do. If there's anything wrong, the software- properties folks will catch it. Here's the request: https://code.launchpad.net/~mac9416/software-properties/illegalcharfix/+merge/30334 ** Tags added: patch-forwarded-upstream ** Branch linked: lp:~mac9416/software-properties/illegalcharfix -- Creates sources.list.d file with illegal character in name https://bugs.launchpad.net/bugs/579669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 579669] Re: Creates sources.list.d file with illegal character in name
That's correct. The patch uses percent encoding (http://en.wikipedia.org/wiki/Percent-encoding), except '%' is also a reserved character here, so we escape '-' and then use '-' and the escape character by replacing '%' with '-'. The patch can be tidied slightly by using urllib2.quote rather than urllib.quote, thus removing the need to import urllib (I didn't realise urllib2 exposed urlib's quote at the time I wrote the patch) -- Creates sources.list.d file with illegal character in name https://bugs.launchpad.net/bugs/579669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 579669] Re: Creates sources.list.d file with illegal character in name
* as the escape character -- Creates sources.list.d file with illegal character in name https://bugs.launchpad.net/bugs/579669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 579669] Re: Creates sources.list.d file with illegal character in name
Hi, Adam, What does your patch change the + in sources.list.d lists to? For me, sevenmachines-release+1-lucid.list became sevenmachines-release- 2B1-lucid.list. Is this what should happen? -- Creates sources.list.d file with illegal character in name https://bugs.launchpad.net/bugs/579669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 579669] Re: Creates sources.list.d file with illegal character in name
Marking as confirmed due to the duplicate bug ** Changed in: software-properties Status: Incomplete = Confirmed ** Changed in: software-properties (Ubuntu) Status: Incomplete = Confirmed -- Creates sources.list.d file with illegal character in name https://bugs.launchpad.net/bugs/579669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 579669] Re: Creates sources.list.d file with illegal character in name
Here's a patch to fix this issue. ** Patch added: ppa.py.patch http://launchpadlibrarian.net/48430701/ppa.py.patch -- Creates sources.list.d file with illegal character in name https://bugs.launchpad.net/bugs/579669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 579669] Re: Creates sources.list.d file will illegal character in name
** Also affects: software-properties Importance: Undecided Status: New ** Description changed: For example: apt-add-repository ppa:sevenmachines/release+1 creates a file /etc/apt/sources.list.d/sevenmachines- release+1-lucid.list. However, man sources.list says File names need to end with .list and may only contain letters (a-z and A-Z), digits (0-9), underscore (_), hyphen (-) and period (.) characters. Otherwise they will be silently ignored. - So that's what happens. + So therefore this newly created list file is silently ignored (verify by + apt-get update and looking in /var/lib/apt/lists) Ubuntu 10.04 python-software-properties 0.75.10 -- Creates sources.list.d file will illegal character in name https://bugs.launchpad.net/bugs/579669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 579669] Re: Creates sources.list.d file with illegal character in name
** Summary changed: - Creates sources.list.d file will illegal character in name + Creates sources.list.d file with illegal character in name -- Creates sources.list.d file with illegal character in name https://bugs.launchpad.net/bugs/579669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 579669] Re: Creates sources.list.d file with illegal character in name
** Changed in: software-properties Status: New = Incomplete -- Creates sources.list.d file with illegal character in name https://bugs.launchpad.net/bugs/579669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 579669] Re: Creates sources.list.d file will illegal character in name
(+) may be seen as an invalid character for a sources.list entry. You have already pointed out valid characters and (+) is not one of those. -- Creates sources.list.d file will illegal character in name https://bugs.launchpad.net/bugs/579669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 579669] Re: Creates sources.list.d file will illegal character in name
(+) may be seen as an invalid character for a sources.list entry. You have already pointed out valid characters and (+) is not one of those. -- Creates sources.list.d file will illegal character in name https://bugs.launchpad.net/bugs/579669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 579669] Re: Creates sources.list.d file will illegal character in name
** Changed in: software-properties (Ubuntu) Status: New = Incomplete -- Creates sources.list.d file will illegal character in name https://bugs.launchpad.net/bugs/579669 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
