[Bug 59342] Re: hal don't find that I'm on a laptop
For the record:
pitti curious - the place you patched out of osspec.c already tries to not
overwrite the value with 'unknown'
pitti this almost looks as if the inner if should be fixed
pitti if (strcmp
(hal_device_property_get_string (d, system.formfactor), unknown))
pitti - to !strcmp
pitti and an alternative added, for the case if the property does not exist
yet
pitti anyway, I'm applying your patch for now, but can you please take
another look at this?
pitti it should be something like
pitti if (!hal_device_property_exists(formfactor) ||
!strcmp(h_d_p_get_string(formfactor), unknown) { overwrite formfactor };
** Changed in: hal (Ubuntu)
Status: In Progress = Fix Committed
--
hal don't find that I'm on a laptop
https://launchpad.net/bugs/59342
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 59342] Re: hal don't find that I'm on a laptop
hal (0.5.7.1-0ubuntu10) edgy; urgency=low . * Add debian/patches/00upstream-01-music-players-fdi.patch: Update 10-usb-music-players.fdi from GIT head to support many more music players (this supersedes the current 17-mp3-player-fdi.patch). Closes: LP#59022 * debian/patches/17-mp3-player-fdi.patch: Add information for the Philips GoGear SA1330, thanks to Juri Pakaste! Closes: LP#58077 * debian/10-storage-policy.fdi: Remove enabling of hal-addon-storage, since 20-storage-methods.fdi already does that. We don't need two h-a-s processes for each drive. Closes: LP#58935 * debian/hald.8: Remove --retain-privileges documentation, this option does not exist any more. Closes: LP#44770 * Add debian/patches/00upstream-02-mWh-conversion.patch: - Properly convert mAh to mWh rather than uWh. - Taken from GIT head: http://gitweb.freedesktop.org/?p=hal.git;a=commit;h=b30d1320614564d226018b8a491ee4f70567db64 - Closes: LP#53719 * Add debian/patches/00upstream-03-fs-on-partitioned-devices.patch: - Do not probe for a file system on a device which already has partitions created. This fixes empty bogus mounts for somewhat unclean partition tables. - Taken from GIT head: http://gitweb.freedesktop.org/?p=hal.git;a=commit;h=2c98ffc8dac7ee161042355790256d836e4028f9 - Closes: LP#19390 * Add debian/patches/19_dont_overwrite_formfactor.patch: Do not overwrite the form factor as set by PMU/ACPI/DMI with an 'unknown' value from computer_probing_pcbios_helper_done(). Thanks to VETSEL Patrice for this patch! Closes: LP#59342 ** Changed in: hal (Ubuntu) Status: Fix Committed = Fix Released -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 59342] Re: hal don't find that I'm on a laptop
Reopening, upstream has a better patch: http://gitweb.freedesktop.org/?p=hal.git;a=commitdiff;h=f70301c8f426618d52a31d33c846989b1c8e7a52 ** Changed in: hal (Ubuntu) Status: Fix Released = Fix Committed -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 59342] Re: hal don't find that I'm on a laptop
Fixed in Ubuntu hal package bzr head, upload awaiting main freeze release (after Knot-3) -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 59342] Re: hal don't find that I'm on a laptop
laptop-detect also find that i'm on a laptop (/proc/acpi/battery test success). Hal already contain many differents tests in sources : /hald/linux2/ - apm.c pmu.c osspec.c and acpi.c) -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 59342] Re: hal don't find that I'm on a laptop
Patrice has a patch, will be fixed in Edgy soon. ** Changed in: hal (Ubuntu) Assignee: (unassigned) = Martin Pitt Status: Confirmed = In Progress -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 59342] Re: hal don't find that I'm on a laptop
All is in hald/linux2/osspec.c I'v added a test because i suspect that computer_probing_pcbios_helper_done is relaunched on computer object. So if system.formfactor has already be set (by pmu/acpi/dmi) it's not overwrited. ** Attachment added: ensure that system.formfactor is not overwrited if already set http://librarian.launchpad.net/4222393/system.formfactor.patch -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 59342] Re: hal don't find that I'm on a laptop
** Changed in: hal (Ubuntu) Status: Unconfirmed = Confirmed -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 59342] Re: hal don't find that I'm on a laptop
** Attachment added: output of lshal http://librarian.launchpad.net/4183328/lshal.txt -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 59342] Re: hal don't find that I'm on a laptop
dmidecode output ** Attachment added: output of dmidecode http://librarian.launchpad.net/4166331/dmidecode.txt -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 59342] Re: hal don't find that I'm on a laptop
For informations : as dmidecode don't find informations for the chassis (bad bios i think), there is a workaround in acpi.c This workaround look if there is a battery bay or a LID button, and if yes, set formfactor to laptop. In devicemanager i'v battery bay. -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 59342] Re: hal don't find that I'm on a laptop
if i do a : sudo hal-set-property --udi /org/freedesktop/Hal/devices/computer --key system.formfactor --string laptop and relaunch gnome-power-manager, all is ok. ** Changed in: hal (Ubuntu) Importance: High = Medium -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 59342] Re: hal don't find that I'm on a laptop
I've got the same problem on my Acer Aspire 5672, dmidecode also not being able to find info about the chasis. laptop-detect correctly detects I have a laptop, though... Maybe hal needs workarounds similar to what laptop-detect uses? -- hal don't find that I'm on a laptop https://launchpad.net/bugs/59342 -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
