[Bug 783383] Re: [upstream] "Increase font" and "decrease font" could work even if the selection contains differing font sizes

2019-05-14 Thread Marcus Tomlinson
** Changed in: libreoffice (Ubuntu)
   Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] "Increase font" and "decrease font" could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 783383]

2014-11-03 Thread Libreoffice-commits
Daniel Sikeler committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=98c95ce3a759a6f691c20cb1e376fa54a9dfdbc0

fdo#35862 De-/Increase font when multi-sized text

It will be available in 4.4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383] Re: [upstream] Increase font and decrease font could work even if the selection contains differing font sizes

2014-11-03 Thread Bug Watch Updater
** Changed in: df-libreoffice
   Status: Confirmed = Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383] Re: [upstream] Increase font and decrease font could work even if the selection contains differing font sizes

2014-09-14 Thread crysman
@jimc-6:
you say: ...The button could be disabled if a multi sized string is selected 
because it is likely to be a little used feature...

I highly disagree. Moreover, I consider it right opposite - it is the
very core feature. Just imagine you want to make your document fit into
4 pages instead of 5. With here being discussed feature properly
implemented (or in MS Word), it is just question of Ctrl+A and
your_shortcut_to_decrease_font_size. Done. On the contrary... I am
asking: how you do it so effectively now in current implementation?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383] Re: [upstream] Increase font and decrease font could work even if the selection contains differing font sizes

2014-09-14 Thread crysman
@jimc-6:
you say: ...The button could be disabled if a multi sized string is selected 
because it is likely to be a little used feature...

I highly disagree. Moreover, I consider it right opposite - it is the
very core feature. Just imagine you want to make your document fit into
4 pages instead of 5. With here being discussed feature properly
implemented (or in MS Word), it is just question of Ctrl+A and
your_shortcut_to_decrease_font_size. Done. On the contrary... I am
asking: how you do it so effectively now in current implementation?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383]

2014-09-14 Thread crysman
@jimc-6:
you say: ...The button could be disabled if a multi sized string is selected 
because it is likely to be a little used feature...

I highly disagree. Moreover, I consider it right opposite - it is the
very core feature. Just imagine you want to make your document fit into
4 pages instead of 5. With here being discussed feature properly
implemented (or in MS Word), it is just question of Ctrl+A and
your_shortcut_to_decrease_font_size. Done. On the contrary... I am
asking: how you do it so effectively now in current implementation?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383]

2014-09-11 Thread D-sikeler94
In Impress the function is already implemented. When you select text with 
different sizes and then press the button all the text get the same size 
(smallest of the selected text) in the first step. Afterwards you can increase 
or decrease the size. Is this the way it should be done in Writer as well? An 
other way to handle this, would be to increase or decrease every part with the 
same size independent from the other parts.
When should the button be disabled? When any part of the selected text already 
has the smallest/biggest size? Or when all the text has the smallest/biggest 
size?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383]

2014-09-11 Thread Jim Cobley
As the function is to Decrease or Increase font size it should do 
what it says - that implies it must NOT change all characters to the 
same size!
I gather then that Impress could annoy me a LOT?

The button could be disabled if a multi sized string is selected because 
it is likely to be a little used feature but if it exists it could be a 
useful feature for some.
The button should be disabled if one of the character sizes couldn't be 
increased or decreased further - ie if pressing it would not provide the 
expected function.

Thinking further it could be handy for changing font size if I had a 
whole paragraph with a bold/large header line - great now that's 
embedded in my expectaion when I hadn't considered it before.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383] Re: [upstream] Increase font and decrease font could work even if the selection contains differing font sizes

2014-07-23 Thread crysman
It's not an enhancement, I consider it a bug. If its working in MS
Word, it should work here, too. This feature is almost useless until not
working with multiple paragraphs...

If you are willing to fix it, please, consider make it customisable (the
step) - not just default 2 or how many it's there now...

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383]

2014-06-19 Thread Momonasmon
*** Bug 79796 has been marked as a duplicate of this bug. ***

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383]

2014-01-15 Thread Jorendc
*** Bug 73414 has been marked as a duplicate of this bug. ***

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383]

2013-11-16 Thread Danny-w
Sorry, going to have to let this part of the project go. My University
final year project has taken more and more of my time recently, and that
has to come first...

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383] Re: [upstream] Increase font and decrease font could work even if the selection contains differing font sizes

2013-11-16 Thread Bug Watch Updater
** Changed in: df-libreoffice
   Status: In Progress = Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383]

2013-10-19 Thread Danny-w
Active development on this bug has started :)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383]

2013-10-08 Thread Björn Michaelsen
adding LibreOffice developer list as CC to unresolved EasyHacks for
better visibility.

see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-
td4076214.html for details

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383]

2013-10-03 Thread Danny-w
I've assigned this bug to myself, and will undertake development this
week. I've read the above comments and tips and will report back if I
experience any difficulties :)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383] Re: [upstream] Increase font and decrease font could work even if the selection contains differing font sizes

2013-10-03 Thread Bug Watch Updater
** Changed in: df-libreoffice
   Status: Confirmed = In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383]

2013-05-01 Thread Joren-libreoffice
*** Bug 63942 has been marked as a duplicate of this bug. ***

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383]

2013-05-01 Thread Joren-libreoffice
@Jordan Chin: I reset the Assigned To field + bug status. Following
the history you are assigned more then a year now. I'm freeing this bug,
so others can work on it. If you are working on it, or would like to
work on it again, please feel free to re-assign.

I hope you understand.

Kind regards,
Joren

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383] Re: [upstream] Increase font and decrease font could work even if the selection contains differing font sizes

2013-05-01 Thread Bug Watch Updater
** Changed in: df-libreoffice
   Status: In Progress = Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383] Re: [upstream] Increase font and decrease font could work even if the selection contains differing font sizes

2013-03-12 Thread Bug Watch Updater
Launchpad has imported 15 comments from the remote bug at
https://bugs.freedesktop.org/show_bug.cgi?id=35862.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.


On 2011-04-01T03:39:27+00:00 Bug-1 wrote:

Hi all!
 Why increase font and decrease font from the formatting toolbar can't 
manage block of text of various font size?

 To reproduce this, just make visible increase font and decrease
font on the formatting toolbar, then write some text and change size
only to a part of it. If you now select all what you wrote, you'll be no
more able to use those buttons.

 It could be very useful, especially when we have to fit piece of text
already formatted over spaces predefined, such as articles, etc.

Thanks to all over the community for such a useful software.
--Nicola

Reply at:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/783383/comments/0


On 2011-05-10T23:34:39+00:00 Tlillqvist-k wrote:

Something that, as you say yourself, could be very useful, is hardly
of high importance. Also, this is clearly an enhancement request, not
a bug report. I agree it would be very useful, sure. Perhaps this could
be an EasyHack?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/783383/comments/1


On 2011-12-23T11:43:18+00:00 Björn Michaelsen wrote:

[This is an automated message.]
This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it
started right out as NEW without ever being explicitly confirmed. The bug is
changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back
to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 
prereleases.
Details on how to test the 3.5.0 beta1 can be found at:
http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1

more detail on this bulk operation: http://nabble.documentfoundation.org
/RFC-Operation-Spamzilla-tp3607474p3607474.html

Reply at:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/783383/comments/3


On 2011-12-23T12:57:26+00:00 Björn Michaelsen wrote:

An EasyHack should have been checked by developers and thus is confirmed
regardless of age. Moving back to NEW from NEEDINFO again. Sorry for the
hassle.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/783383/comments/4


On 2012-01-05T16:34:18+00:00 R6btzkgnhs wrote:

I agree this would be a nice feature to implement, it is especially
useful for old documents or imported documents that may not already be
formatted using Styles.

And I do believe it fits the category of bug as well.  The functions
are called 'Increase Font' and 'Reduce Font', not 'Increase just this
font size' and 'Reduce just this font size' ;-)

Reply at:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/783383/comments/5


On 2012-02-04T08:48:01+00:00 greggory.hz wrote:

Where would someone interested in working on this find the relevant code
(whatever code is run when either button is clicked)? I haven't got any
experience with the libreoffice code base and it is slightly
overwhelming to try and decide where something like this might hide. Any
help would be greatly appreciated.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/783383/comments/6


On 2012-03-13T20:09:45+00:00 Jordan Chin wrote:

I would like to take a look into this.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/783383/comments/7


On 2012-03-21T11:10:10+00:00 Ametrix-bg wrote:

I'am interested in this bug, can i work on it ?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/783383/comments/8


On 2012-03-25T11:11:56+00:00 Jordan Chin wrote:

Ahmed, as this should not be a difficult bug, if you are able to
complete it, go ahead with this. I was not able to get very far and have
emailed the mailing list with my current findings (as of this time it
was caught by the auto-spam filter so is awaiting a moderator's eye).
Until then I'll keep moving forward with this.

So far I have found that the ID of the button is something like
FN_GROW_FONT_SIZE, and from that the code that is run whenever it is
clicked. However, I have not found what decides whether the button is
enabled or disabled

[Bug 783383] Re: Increase font and decrease font could work even if the selection contains differing font sizes

2013-03-08 Thread Bryan Quigley
You reported this to upstream LibreOffice.   Good job!  In the future
you can actually link this bug to the upstream bug so that it is easier
to realize it has been confirmed.

** Bug watch added: freedesktop.org Bugzilla #35862
   https://bugs.freedesktop.org/show_bug.cgi?id=35862

** Also affects: df-libreoffice via
   https://bugs.freedesktop.org/show_bug.cgi?id=35862
   Importance: Unknown
   Status: Unknown

** Changed in: libreoffice (Ubuntu)
   Status: New = Confirmed

** Summary changed:

- Increase font and decrease font could work even if the selection contains 
differing font sizes
+ [upstream] Increase font and decrease font could work even if the 
selection contains differing font sizes

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  [upstream] Increase font and decrease font could work even if the
  selection contains differing font sizes

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/783383/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 783383] [NEW] Increase font and decrease font could work even if the selection contains differing font sizes

2011-05-16 Thread Nicola Battilani
Public bug reported:

Binary package hint: libreoffice

Hi all!
 Why increase font and decrease font from the formatting toolbar can't 
manage block of text of various font size?

 To reproduce this, just make visible increase font and decrease
font on the formatting toolbar, then write some text and change size
only to a part of it. If you now select all what you wrote, you'll be no
more able to use those buttons.

 It could be very useful, especially when we have to fit piece of text
already formatted over spaces predefined, such as articles, etc.

Thanks to all over the community for such a useful software.
--Nicola

** Affects: libreoffice (Ubuntu)
 Importance: Undecided
 Status: New

** Description changed:

  Binary package hint: libreoffice
  
  Hi all!
-  Why increase font and decrease font from the formatting toolbar can't
- manage block of text of various font size?
+  Why increase font and decrease font from the formatting toolbar can't 
manage block of text of various font size?
  
-  To reproduce this, just make visible increase font and decrease font on
- the formatting toolbar, then write some text and change size only to a part of
- it. If you now select all what you wrote, you'll be no more able to use those
- buttons.
+  To reproduce this, just make visible increase font and decrease
+ font on the formatting toolbar, then write some text and change size
+ only to a part of it. If you now select all what you wrote, you'll be no
+ more able to use those buttons.
  
-  It could be very useful, especially when we have to fit piece of text already
- formatted over spaces predefined, such as articles, etc.
+  It could be very useful, especially when we have to fit piece of text
+ already formatted over spaces predefined, such as articles, etc.
  
  Thanks to all over the community for such a useful software.
  --Nicola

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/783383

Title:
  Increase font and decrease font could work even if the selection
  contains differing font sizes

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs