[Bug 923409] Re: [Both front and rear Line-In] No sound (codec parsing fails)
Many thanks to David Henningsson for fixing this bug and to Leann Ogasawara for pulling the fix into the kernel. I've installed it and can confirm that the problem is fixed. Thanks once again. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/923409 Title: [Both front and rear Line-In] No sound (codec parsing fails) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/923409/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 923409] Re: [Both front and rear Line-In] No sound (codec parsing fails)
** Tags added: rls-p-tracking -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/923409 Title: [Both front and rear Line-In] No sound (codec parsing fails) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/923409/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 923409] Re: [Both front and rear Line-In] No sound (codec parsing fails)
Hi David, I've gone ahead an fetched the patch noted in comment #22 from takashi's tree and applied it to the Precise master-next branch. It should be available in the next Ubuntu Preicse kernel upload. Thanks. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/923409 Title: [Both front and rear Line-In] No sound (codec parsing fails) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/923409/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 923409] Re: [Both front and rear Line-In] No sound (codec parsing fails)
This bug was fixed in the package linux - 3.2.0-13.22 --- linux (3.2.0-13.22) precise; urgency=low [ Alex Deucher ] * (pre-stable): drm/radeon/kms: move panel mode setup into encoder mode set - LP: #925538 * (pre-stable): drm/radeon/kms: rework modeset sequence for DCE41 and DCE5 - LP: #925538 [ Andy Whitcroft ] * [Config] review IPv6 configuration options and enable [ David Henningsson ] * SAUCE: ALSA: HDA: Remove quirk for Toshiba Qosmio G50 - LP: #923316 * SAUCE: ALSA: HDA: Fix jack creation for codecs with front and rear Line In - LP: #923409 [ James M. Leddy ] * SAUCE: Bluetooth: Add support for BCM20702A0 [0a5c:21e6] - LP: #906832 [ Manoj Iyer ] * SAUCE: Bluetooth: Add support for BCM20702A0 [0a5c:21e1] - LP: #906832 * SAUCE: Add vendor specific ID (0a5c 21f3) for BCM20702A0. - LP: #925552 [ Seth Forshee ] * (pre-stable): drm/radeon/kms: disable output polling when suspended - LP: #925570 [ Tim Gardner ] * [Config] CONFIG_BLK_DEV_PCIESSD_MTIP32XX=m - LP: #91 * [Config] Add mtip32xx to d-i block modules - LP: #91 * [Config] Enable USB3.0 in d-i [ Upstream Kernel Changes ] * block: Add driver for Micron RealSSD pcie flash cards - LP: #91 * mtip32xx: fix warnings/errors on 32-bit compiles - LP: #91 * mtip32xx: cleanup compat ioctl handling - LP: #91 * mtip32xx: ensure that all local functions are static - LP: #91 * mtip32xx: mark a few more items static - LP: #91 * mtip32xx: add module.h include to avoid conflict with moduleh tree - LP: #91 * mtip32xx: update to new -make_request() API - LP: #91 * mtip32xx: updates based on feedback - LP: #91 * mtip32xx: uninitialized variable in mtip_quiesce_io() - LP: #91 * mtip32xx: do rebuild monitoring asynchronously - LP: #91 * watchdog: iTCO_wdt: add Intel Lynx Point DeviceIDs - LP: #900119 * drm/i915: mask transcoder select bits before setting them on LVDS - LP: #924989 * (pre-stable) USB: Realtek cr: fix autopm scheduling while atomic - LP: #917962 * nouveau: properly check for _DSM function support - LP: #925608 * nouveau: Support Optimus models for vga_switcheroo - LP: #925608 -- Leann Ogasawara leann.ogasaw...@canonical.com Thu, 02 Feb 2012 13:26:59 -0800 ** Changed in: linux (Ubuntu) Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/923409 Title: [Both front and rear Line-In] No sound (codec parsing fails) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/923409/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 923409] Re: [Both front and rear Line-In] No sound (codec parsing fails)
If a codec has both a front and a rear Line In, two controls both
named Line Jack will be created, which causes parsing to fail.
While a long term solution might be to name the jacks differently,
this extra check is consistent with what is already being done in many
auto-parsers, and will also protect against other cases when two
inputs have the same label.
BugLink: https://bugs.launchpad.net/bugs/923409
Signed-off-by: David Henningsson david.hennings...@canonical.com
---
sound/pci/hda/hda_jack.c | 24 +++-
1 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/sound/pci/hda/hda_jack.c b/sound/pci/hda/hda_jack.c
index d8a35da..9d819c4 100644
--- a/sound/pci/hda/hda_jack.c
+++ b/sound/pci/hda/hda_jack.c
@@ -282,7 +282,8 @@ int snd_hda_jack_add_kctl(struct hda_codec *codec,
hda_nid_t nid,
EXPORT_SYMBOL_HDA(snd_hda_jack_add_kctl);
static int add_jack_kctl(struct hda_codec *codec, hda_nid_t nid,
-const struct auto_pin_cfg *cfg)
+const struct auto_pin_cfg *cfg,
+char *lastname, int *lastidx)
{
unsigned int def_conf, conn;
char name[44];
@@ -298,6 +299,10 @@ static int add_jack_kctl(struct hda_codec *codec,
hda_nid_t nid,
return 0;
snd_hda_get_pin_label(codec, nid, cfg, name, sizeof(name), idx);
+ if (!strcmp(name, lastname) idx == *lastidx)
+ idx++;
+ strncpy(lastname, name, 44);
+ *lastidx = idx;
err = snd_hda_jack_add_kctl(codec, nid, name, idx);
if (err 0)
return err;
@@ -311,41 +316,42 @@ int snd_hda_jack_add_kctls(struct hda_codec *codec,
const struct auto_pin_cfg *cfg)
{
const hda_nid_t *p;
- int i, err;
+ int i, err, lastidx = 0;
+ char lastname[44] = ;
for (i = 0, p = cfg-line_out_pins; i cfg-line_outs; i++, p++) {
- err = add_jack_kctl(codec, *p, cfg);
+ err = add_jack_kctl(codec, *p, cfg, lastname, lastidx);
if (err 0)
return err;
}
for (i = 0, p = cfg-hp_pins; i cfg-hp_outs; i++, p++) {
if (*p == *cfg-line_out_pins) /* might be duplicated */
break;
- err = add_jack_kctl(codec, *p, cfg);
+ err = add_jack_kctl(codec, *p, cfg, lastname, lastidx);
if (err 0)
return err;
}
for (i = 0, p = cfg-speaker_pins; i cfg-speaker_outs; i++, p++) {
if (*p == *cfg-line_out_pins) /* might be duplicated */
break;
- err = add_jack_kctl(codec, *p, cfg);
+ err = add_jack_kctl(codec, *p, cfg, lastname, lastidx);
if (err 0)
return err;
}
for (i = 0; i cfg-num_inputs; i++) {
- err = add_jack_kctl(codec, cfg-inputs[i].pin, cfg);
+ err = add_jack_kctl(codec, cfg-inputs[i].pin, cfg, lastname,
lastidx);
if (err 0)
return err;
}
for (i = 0, p = cfg-dig_out_pins; i cfg-dig_outs; i++, p++) {
- err = add_jack_kctl(codec, *p, cfg);
+ err = add_jack_kctl(codec, *p, cfg, lastname, lastidx);
if (err 0)
return err;
}
- err = add_jack_kctl(codec, cfg-dig_in_pin, cfg);
+ err = add_jack_kctl(codec, cfg-dig_in_pin, cfg, lastname, lastidx);
if (err 0)
return err;
- err = add_jack_kctl(codec, cfg-mono_out_pin, cfg);
+ err = add_jack_kctl(codec, cfg-mono_out_pin, cfg, lastname, lastidx);
if (err 0)
return err;
return 0;
--
1.7.8.3
** Changed in: linux (Ubuntu)
Status: Confirmed = In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/923409
Title:
[Both front and rear Line-In] No sound (codec parsing fails)
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/923409/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 923409] Re: [Both front and rear Line-In] No sound (codec parsing fails)
Hi! Thanks for testing the development version of Ubuntu! Given your logs, I was able to track the bug down, send it to upstream, who has now committed it. However upstream has also asked for alsa-info ( https://wiki.ubuntu.com/Audio/AlsaInfo ) to aid regression tests later. Could you please attach an alsa-info as well? Thanks! ** Changed in: linux (Ubuntu) Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/923409 Title: [Both front and rear Line-In] No sound (codec parsing fails) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/923409/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 923409] Re: [Both front and rear Line-In] No sound (codec parsing fails)
Hi David, thanks for fixing this bug. I'll provide feedback as soon as an patched kernel is available. The requested alsa-info can be found here: http://www.alsa- project.org/db/?f=f4a8312f34573a24f60011109e18f0c7371129e0 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/923409 Title: [Both front and rear Line-In] No sound (codec parsing fails) To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/923409/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
