[Bug 954692] Re: cannot detach volume from terminated instance

2012-04-05 Thread Thierry Carrez
** Changed in: nova Milestone: essex-rc1 = 2012.1 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance To manage

[Bug 954692] Re: cannot detach volume from terminated instance

2012-04-05 Thread Thierry Carrez
** Changed in: nova Milestone: essex-rc1 = 2012.1 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance To manage notifications about this

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-20 Thread Thierry Carrez
** Changed in: nova Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance To manage

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-20 Thread Chuck Short
** Changed in: nova (Ubuntu) Status: Confirmed = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance To

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-20 Thread Thierry Carrez
** Changed in: nova Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance To manage notifications

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-20 Thread Chuck Short
** Changed in: nova (Ubuntu) Status: Confirmed = Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance To manage

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Thierry Carrez
fwiw following recent fix might have changed the issue: commit 22b484a6d0b65c2a41fd4c730a5ebddf98c70c84 Author: Vishvananda Ishaya vishvana...@gmail.com Date: Wed Mar 14 09:26:40 2012 -0700 Allow errored volumes to be deleted * Allow volumes with no host set to be deleted from db

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Vish Ishaya
we discussed on irc. This is a separate bug ** Changed in: nova Importance: Undecided = Medium ** Tags added: essec-rc-potential -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu.

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Adam Gandelman
Bogged down with other things ATM, but spent some time looking at this last night. nova.compute.manager._shutdown_instance() raises an exception if the instance is already in POWEROFF state. It looks like this conditional has existed forever: if current_power_state ==

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Vish Ishaya
** Changed in: nova Milestone: None = essex-rc1 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance To manage notifications

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Chris Behrens
I think removing that block of code makes sense. However, a few lines below, I would add a try/except around the call to self.driver.destroy(). It looks like it could raise if the instance is not created at the driver level, which could be the case for an instance that's in ERROR state. --

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Adam Gandelman
Chris- I'm a little uncomfortable wrapping self.driver.destroy in a try/except block until there is a common exception language virt drivers can use to raise specific, fatal exceptions. I'm thinking of a scenario where libvirt/xs cannot shutdown instance, raises, and compute continues on with

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Chris Behrens
Makes sense. Thanks. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance To manage notifications about this bug go to:

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread OpenStack Hudson
** Changed in: nova Assignee: Adam Gandelman (gandelman-a) = Vish Ishaya (vishvananda) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Vish Ishaya
** Changed in: nova Assignee: Vish Ishaya (vishvananda) = Adam Gandelman (gandelman-a) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread OpenStack Hudson
Reviewed: https://review.openstack.org/5437 Committed: http://github.com/openstack/nova/commit/6657f70ee3e792b39e45a2a96fb5d4b380f0ae91 Submitter: Jenkins Branch:master commit 6657f70ee3e792b39e45a2a96fb5d4b380f0ae91 Author: Adam Gandelman ad...@canonical.com Date: Thu Mar 15 18:08:35

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Thierry Carrez
fwiw following recent fix might have changed the issue: commit 22b484a6d0b65c2a41fd4c730a5ebddf98c70c84 Author: Vishvananda Ishaya vishvana...@gmail.com Date: Wed Mar 14 09:26:40 2012 -0700 Allow errored volumes to be deleted * Allow volumes with no host set to be deleted from db

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Vish Ishaya
we discussed on irc. This is a separate bug ** Changed in: nova Importance: Undecided = Medium ** Tags added: essec-rc-potential -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/954692 Title:

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Adam Gandelman
Bogged down with other things ATM, but spent some time looking at this last night. nova.compute.manager._shutdown_instance() raises an exception if the instance is already in POWEROFF state. It looks like this conditional has existed forever: if current_power_state ==

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Vish Ishaya
** Changed in: nova Milestone: None = essex-rc1 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance To manage notifications about this bug

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Chris Behrens
I think removing that block of code makes sense. However, a few lines below, I would add a try/except around the call to self.driver.destroy(). It looks like it could raise if the instance is not created at the driver level, which could be the case for an instance that's in ERROR state. --

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Adam Gandelman
Chris- I'm a little uncomfortable wrapping self.driver.destroy in a try/except block until there is a common exception language virt drivers can use to raise specific, fatal exceptions. I'm thinking of a scenario where libvirt/xs cannot shutdown instance, raises, and compute continues on with

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread OpenStack Hudson
** Changed in: nova Assignee: Adam Gandelman (gandelman-a) = Vish Ishaya (vishvananda) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Vish Ishaya
** Changed in: nova Assignee: Vish Ishaya (vishvananda) = Adam Gandelman (gandelman-a) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread Chris Behrens
Makes sense. Thanks. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance To manage notifications about this bug go to:

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-15 Thread OpenStack Hudson
Reviewed: https://review.openstack.org/5437 Committed: http://github.com/openstack/nova/commit/6657f70ee3e792b39e45a2a96fb5d4b380f0ae91 Submitter: Jenkins Branch:master commit 6657f70ee3e792b39e45a2a96fb5d4b380f0ae91 Author: Adam Gandelman ad...@canonical.com Date: Thu Mar 15 18:08:35

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-14 Thread Serge Hallyn
** Changed in: nova (Ubuntu) Importance: Undecided = Medium -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance To manage

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-14 Thread Adam Gandelman
** Changed in: nova (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance To manage

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-14 Thread Adam Gandelman
Steps to reproduce: 1. create volume 2. boot an instance (tested with cirros) 3. attach volume 4. in instance: 'sudo poweroff' 5. after kvm machine has stopped on compute node, terminate instance. results in traceback on compute.log: (nova.rpc.amqp): TRACE: File

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-14 Thread Adam Gandelman
** Changed in: nova Status: New = In Progress ** Changed in: nova Assignee: (unassigned) = Adam Gandelman (gandelman-a) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to nova in Ubuntu. https://bugs.launchpad.net/bugs/954692

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-14 Thread Serge Hallyn
** Changed in: nova (Ubuntu) Importance: Undecided = Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance To manage notifications

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-14 Thread Adam Gandelman
** Changed in: nova (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: cannot detach volume from terminated instance To manage notifications about

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-14 Thread Adam Gandelman
Steps to reproduce: 1. create volume 2. boot an instance (tested with cirros) 3. attach volume 4. in instance: 'sudo poweroff' 5. after kvm machine has stopped on compute node, terminate instance. results in traceback on compute.log: (nova.rpc.amqp): TRACE: File

[Bug 954692] Re: cannot detach volume from terminated instance

2012-03-14 Thread Adam Gandelman
** Changed in: nova Status: New = In Progress ** Changed in: nova Assignee: (unassigned) = Adam Gandelman (gandelman-a) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/954692 Title: