[Bug 1958770] Re: Aquantia GbE LAN driver causes UBSAN error during kernel boot

2022-04-26 Thread populationless
I'm not 100% sure if I loaded the new module correctly, but I believe that I did. Here are the steps I took to compile the module and load it, which resulted in the output of #21: git clone git://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/jammy linux-jammy cd linux-jammy/ uname

[Bug 1958770] Re: Aquantia GbE LAN driver causes UBSAN error during kernel boot

2022-04-25 Thread populationless
I'm gonna chime in too. I have applied both patches from #18 and #20 and recompiled the module, however I still get the UBSAN: array-index-out- of-bounds messsage. NIC seems to work though. I am not a programmer, so unfortunately I can't come up with a solution, but I am willing to test. Kernel:

[Bug 1958770] Re: Aquantia GbE LAN driver causes UBSAN error during kernel boot

2022-05-12 Thread populationless
Sorry. Like this? for (tc = 0U; tc < self->aq_nic_cfg.tcs; tc++) { for (i = 0U; self->aq_vecs > i; ++i) { aq_vec = self->aq_vec[i]; if (!aq_vec) break; data += count; count = aq_vec_get_sw_stats(aq_vec, tc, data); } } -- You received this bug notification because you are

[Bug 1958770] Re: Aquantia GbE LAN driver causes UBSAN error during kernel boot

2022-05-12 Thread populationless
I have implemented your suggestion, so far no issues. I'm going to kick off my backup now and do some more testing later. ** Patch added: "aq_nic.c.patch" https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1958770/+attachment/5589366/+files/aq_nic.c.patch -- You received this bug

[Bug 1958770] Re: Aquantia GbE LAN driver causes UBSAN error during kernel boot

2022-05-18 Thread populationless
How would I go about doing so, while giving credit to bsdz and you? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1958770 Title: Aquantia GbE LAN driver causes UBSAN error during kernel boot To

[Bug 1958770] Re: Aquantia GbE LAN driver causes UBSAN error during kernel boot

2022-05-13 Thread populationless
OK, so far everything seems to be working great. Performance is good, no UBSAN messages, no other abnormalities. I think we are good now. ** Patch added: "aq_nic.c.patch" https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1958770/+attachment/5589555/+files/aq_nic.c.patch -- You received

[Bug 1958770] Re: Aquantia GbE LAN driver causes UBSAN error during kernel boot

2022-05-12 Thread populationless
Thank you @bsdz, compiles and works flawlessly since yesterday. UBSAN is happy, performance is as expected. @kaihengfeng, is this patch suitable for inclusion upstream? ** Patch added: "aq_nic.c.patch"

[Bug 1958770] Re: Aquantia GbE LAN driver causes UBSAN error during kernel boot

2022-05-11 Thread populationless
I tried changing the function, now the module doesn't compile. EDIT: Sorry, forgot to close the curly bracket... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1958770 Title: Aquantia GbE LAN

[Bug 1958770] Re: Aquantia GbE LAN driver causes UBSAN error during kernel boot

2022-05-11 Thread populationless
I have successfully modified two of the mentioned three functions and tested the module, so far UBSAN does not complain anymore :) Unfdortunately I can't rewrite the third function, since it does not match the pattern (and I have no idea what I'm doing) for (tc = 0U; tc < self->aq_nic_cfg.tcs;

[Bug 1958770] Re: Aquantia GbE LAN driver causes UBSAN error during kernel boot

2022-05-09 Thread populationless
Sorry for the delay, life happened... After mucking about with this for the past few days and not being able to get the module to compile on 5.15 for the life of me (always same error "implicit declaration of function ‘platform_get_ethdev_address’ [-Werror=implicit-function-declaration]"), I have

[Bug 1958770] Re: Aquantia GbE LAN driver causes UBSAN error during kernel boot

2022-05-09 Thread populationless
** Attachment added: "dmesg.log" https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1958770/+attachment/5588060/+files/dmesg.log -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1958770 Title: