subject:"\[Bug 1367241\] Re\: Incorrect udev\-fallback\-graphics.conf"

Utopic fix committed to git, thanks! I keep this open for trusty, but as
it's neither a data loss nor critical bug and just a cosmetical corner
case I keep it as low importance.

You say since 3.13.0-16.36 which is trusty -- i. e. precise's kernel
still has it as a module? So it seems to me that this doesn't affect
precise at all. But even if it would, if such a cosmetical bug hasn't
caused trouble in 2.5 years, it's certainly going to be fine for the
other 1.5 years.

** Also affects: udev (Ubuntu Trusty)
   Importance: Undecided
   Status: New

** Also affects: systemd (Ubuntu Trusty)
   Importance: Undecided
   Status: New

** Also affects: udev (Ubuntu Utopic)
   Importance: Undecided
 Assignee: Dariusz Gadomski (dgadomski)
   Status: Confirmed

** Also affects: systemd (Ubuntu Utopic)
   Importance: Undecided
 Assignee: Dariusz Gadomski (dgadomski)
   Status: New

** Changed in: systemd (Ubuntu Utopic)
   Status: New = Fix Committed

** Changed in: systemd (Ubuntu Trusty)
   Status: New = Triaged

** Changed in: systemd (Ubuntu Trusty)
   Importance: Undecided = Low

** No longer affects: udev (Ubuntu Utopic)

** No longer affects: udev (Ubuntu Trusty)

** Also affects: udev (Ubuntu Precise)
   Importance: Undecided
   Status: New

** Also affects: systemd (Ubuntu Precise)
   Importance: Undecided
   Status: New

** Changed in: udev (Ubuntu)
   Status: Confirmed = Invalid

** Changed in: udev (Ubuntu Precise)
   Status: New = Incomplete

** No longer affects: systemd (Ubuntu Precise)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

Thanks Martin for taking a look.

In my precise (12.04.5) install the default kernel is 3.13.0-32-generic, which 
is affected by the issue:
$ grep FB_VESA /boot/config-3.13.0-32-generic
CONFIG_FB_VESA=y

In fact initially this has been reported by a CTS customer for precise.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

I'm still not fully convinced about the SRUs -- this might have a
potential to break existing setups if they run custom kernels? It's ok
to add the expectancy to build in vesafb for a new release (utopic), but
not for existing stables?

Or is it impossible to build vesafb as a module now?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

Ah right, that's the backported trusty kernels I figure (12.04.4 or
later).

** Changed in: udev (Ubuntu Precise)
   Status: Incomplete = Triaged

** Changed in: udev (Ubuntu Precise)
   Importance: Undecided = Low

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

Building vesafb as a module should still be possible.

Trusty had vesafb build in the kernel from the very first release, so I
believe the assumption is safe here.

Regarding precise:
Instead of removing the script I could leave it but alter it to check the 
feature (e.g. kernel version number or the option in /boot/config-`uname-r`) 
and undertake no actions in the script if we have this module compiled in.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

 do some 2/dev/null to quiesce the error.

or if that's not possible (because it's the kernel who spits out errors,
but that's unlikely), it could also do if modinfo vesafb /dev/null
21; then modprobe -q vesafb; fi

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

 Trusty had vesafb build in the kernel from the very first release, so
I believe the assumption is safe here.

Well no, one could still run a self-built kernel.

So I think for an SRU it would be safer to not drop the script, but
instead do some 2/dev/null to quiesce the error.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

Actually I think the second approach would be better, since the error
comes not from the message (which is redirected to upstart logs anyway),
but from the return code of the script.

Unfortunately, according to my knowledge, the upstart scripts are
executed with the -e switch making it stop with a failure on a first
failed call. This ties our hands a bit as we cannot have any failing
commands there (even those we expect to fail in a particular
configuration) and makes our potential script less flexible.

So in any case we would be interested in not returning anything other than 0. A 
commonly used work-around for this limitation could be used like this:
modprobe -q -b vesafb || true

This would load the module if available, but would remain quiet (-q
switch to modprobe with additional || true) if the module is not there.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

Right, protecting this with || true sounds perfectly fine and safe for
an SRU.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

Adding new SRU proposal for Precise.

** Patch removed: systemd_204-5ubuntu20.7.debdiff
   
https://bugs.launchpad.net/ubuntu/+source/udev/+bug/1367241/+attachment/4201485/+files/systemd_204-5ubuntu20.7.debdiff

** Patch removed: udev_175-0ubuntu9.7.debdiff
   
https://bugs.launchpad.net/ubuntu/+source/udev/+bug/1367241/+attachment/4201483/+files/udev_175-0ubuntu9.7.debdiff

** Patch added: udev_175-0ubuntu9.7.debdiff
   
https://bugs.launchpad.net/ubuntu/+source/udev/+bug/1367241/+attachment/4202152/+files/udev_175-0ubuntu9.7.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

I have uploaded new patches updated as agreed.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

Adding new SRU proposal for Trusty.

** Patch added: systemd_204-5ubuntu20.7.debdiff
   
https://bugs.launchpad.net/ubuntu/+source/udev/+bug/1367241/+attachment/4202154/+files/systemd_204-5ubuntu20.7.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

I sponsored these with changing the changelog to

  * udev-fallback-graphics.conf: Avoid failure if vesafb module is compiled
in. (LP: #1367241).

as removed the script isn't true with those.

** Changed in: systemd (Ubuntu Trusty)
   Status: Triaged = In Progress

** Changed in: udev (Ubuntu Precise)
   Status: Triaged = In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

Adding SRU proposal for Utopic.

** Patch added: systemd_208-8ubuntu3.debdiff
   
https://bugs.launchpad.net/ubuntu/+source/udev/+bug/1367241/+attachment/4201487/+files/systemd_208-8ubuntu3.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/udev/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

Adding SRU proposal for Trusty.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/udev/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

Adding SRU proposal for Trusty.

** Patch added: systemd_204-5ubuntu20.7.debdiff
   
https://bugs.launchpad.net/ubuntu/+source/udev/+bug/1367241/+attachment/4201485/+files/systemd_204-5ubuntu20.7.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/udev/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

Adding SRU proposal for Precise.

** Description changed:

+ [Impact]
+
+ * When setting up primary display driver fails an attempt to load vesafb
+module is undertaken. This fails since from 3.13.0-16.36 version
+vesafb is compiled in the kernel (so no actual modprobing is needed).
+This causes false alert in the log:
+Starting load fallback graphic devices: [fail]
+
+ [Test Case]
+
+ * Start Ubuntu unable to load primary graphics driver (the simplest way is
to remove module responsible for the device).
+ * Wait for loading graphics devices.
+ * If the primary device module has failed to load, falling back to vesafb
will be attempted.
+
+ [Regression Potential]
+
+ * Implemented by the bug reported.
+
+ * Affects only the debian/ directory.
+
+ [Other Info]
+
+ * Original bug description:
+
The udev-fallback-graphics.conf script tries to load vesafb module if
PRIMARY_DEVICE_FOR_DISPLAY has not been set earlier.

The problem is that from kernel version 3.13.0-16.36 vesafb is compiled
in permanently into the kernel (CONFIG_FB_VESA=y), so whenever the
fallback mode is triggered this script will FAIL confusing the users.

Most probably this file is no longer needed (or it just be used to print
informative message).

** Patch added: udev_175-0ubuntu9.7.debdiff

https://bugs.launchpad.net/ubuntu/+source/udev/+bug/1367241/+attachment/4201483/+files/udev_175-0ubuntu9.7.debdiff

--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/udev/+bug/1367241/+subscriptions

--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf

** Also affects: systemd (Ubuntu)
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1367241

Title:
  Incorrect udev-fallback-graphics.conf

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1367241/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1367241] Re: Incorrect udev-fallback-graphics.conf