[Bug 1438014] Re: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts
** Tags removed: artful zesty -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1438014 Title: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/1438014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1438014] Re: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts
** Package changed: gtk+3.0 (Ubuntu) => ubuntu -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1438014 Title: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+bug/1438014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1438014] Re: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts
Reported to gnome's gitlab: https://gitlab.gnome.org/GNOME/gtk/issues/180 Reference: GNOME/gtk#180 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1438014 Title: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/1438014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1438014] Re: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts
Hello. I had some debugging with valgrind and gdb for the error with stacktrace top g_type_check_instance_is_a glib2.0-2.43.92/./gobject/gtype.c:4016 gtk_widget_get_toplevel gtk+3.0-3.14.9/./gtk/gtkwidget.c:11382 window_group_cleanup_grabs gtk+3.0-3.14.9/./gtk/gtkwindowgroup.c:110 gtk_window_group_add_window gtk+3.0-3.14.9/./gtk/gtkwindowgroup.c:169 gtk_window_set_transient_for gtk+3.0-3.14.9/./gtk/gtkwindow.c:3134 This is use-after-free due to incorrect grab deregistration (gtk_grab_remove tries to remove the grab not from the same window_group where it was added by gtk_grab_add) Results were posted to Bug #1667227 and Bug #1667232 https://bugs.launchpad.net/ubuntu/+source/mate-terminal/+bug/1667227 and https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/1667232 I think that gnome-terminal grab use-after-free after editing keyboard shortcuts may be not related to the patch "debian/patches/016_no_offscreen_widgets_grabbing.patch" (it only helps to report Critical to the log). Both gtk_grab_add and gtk_grab_remove calls gtk_main_get_window_group function, but it returns different results for these two calls (more details at https://bugs.launchpad.net/ubuntu/+source/mate- terminal/+bug/1667227/comments/8) static GtkWindowGroup * gtk_main_get_window_group (GtkWidget *widget) ... if (GTK_IS_WINDOW (toplevel)) return gtk_window_get_group (GTK_WINDOW (toplevel)); else return gtk_window_get_group (NULL); At the time of gtk_grab_add (called from gtk_cell_renderer_accel_start_editing which is called from gtk_cell_renderer_start_editing) this widget had window = 0x0 and parent = 0x0 And at time of gtk_grab_remove (called from gtk_cell_editable_event_box_key_press_event) same widget had window = 0x55e507e0 (parent = 0x55e183f0) which leads to incorrect deregistration of the grab. Parent of the widget was changed by gtk_tree_view_multipress_gesture_pressed -> .. -> gtk_cell_area_activate_cell -> gtk_cell_area_add_editable -> ..signal.. -> gtk_tree_view_column_add_editable_callback -> _gtk_tree_view_add_editable -> gtk_tree_view_put -> gtk_widget_set_parent So, gtk_cell_area_activate_cell of gtk+3 (3.22.7) has some kind of incorrect ordering of actions which broke gtk_grab_add / gtk_grab_remove pair https://github.com/GNOME/gtk/blob/6cc08d60efeb02afc0d67982c3dc205dfd16d7cd/gtk/gtkcellarea.c#L3388 3428 gtk_cell_renderer_start_editing (renderer, ... 3444 gtk_cell_area_add_editable (area, priv->focus_cell, editable_widget, cell_area); (There was also quick and probably incorrect fix in Bug #1667227 for this use-after-free with additional removing of grab from gtk_window_get_group (NULL) https://launchpadlibrarian.net/308873213/lp1667227_quick_fix_gtk_grab_remove.gtk+3.22.8.patch ) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1438014 Title: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/1438014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1438014] Re: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts
Altered keyboard shortcuts for opening new terminals and copy/paste. [11742.029806] gnome-terminal-[4755]: segfault at 7001e ip 7f82140be77e sp 7ffce1ff6fe8 error 4 in libgobject-2.0.so.0.5400.1[7f8214089000+52000] [11785.274354] gnome-terminal-[27857]: segfault at 7001e ip 7fdbbe5da77e sp 7ffee0b8a418 error 4 in libgobject-2.0.so.0.5400.1[7fdbbe5a5000+52000] [12226.667034] gnome-terminal-[27916]: segfault at 7001e ip 7fe13759c77e sp 7ffd2f2b76b8 error 4 in libgobject-2.0.so.0.5400.1[7fe137567000+52000] 17.10 (Artful Aardvark) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1438014 Title: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/1438014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1438014] Re: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts
^ gnome-terminal version 3.18.3-1ubuntu1 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1438014 Title: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/1438014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1438014] Re: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts
Experienced this today, had a couple terminals open and was using chrome. gnome-terminal-server crashed with SIGSEGV in g_cclosure_marshal_VOID__OBJECTv() im on 16.04 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1438014 Title: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/1438014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1438014] Re: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts
I'm also using "Artful Aardwark" got many crashes with different circumstances. After some work in the background. When I'm opening and try to interact: - Trying to open Preferences - Trying to right-click on highlighted link to select "Open Link" (crash just after right click) - Trying to switch tab -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1438014 Title: gnome-terminal-server and mate-terminal crash when setting keyboard shortcuts To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/1438014/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
