[Bug 1512608] Re: No thumbnails generated for OGG audio

2016-02-01 Thread Fred Vkigg
The fix works fine. Album and Artist thumbnails are being retrieved now even where there are empty tags. I have checked a few cases where I get no artwork in Music app, and they all correspond to where the webservice does not deliver a result. Thanks for the work and the release! -- You

[Bug 1512608] Re: No thumbnails generated for OGG audio

2016-02-01 Thread Michi Henning
Thanks for the confirmation, Fred. Glad it works for you now! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512608 Title: No thumbnails generated for OGG audio To manage notifications about this

[Bug 1512608] Re: No thumbnails generated for OGG audio

2016-01-27 Thread Pat McGowan
** Changed in: canonical-devices-system-image Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512608 Title: No thumbnails generated for OGG audio To

[Bug 1512608] Re: No thumbnails generated for OGG audio

2016-01-09 Thread Fred Vkigg
Great, Will give you feedback as soon as OTA-9 is available. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512608 Title: No thumbnails generated for OGG audio To manage notifications about this

[Bug 1512608] Re: No thumbnails generated for OGG audio

2016-01-06 Thread Michi Henning
Fred, the fix for this will become available with OTA-9, maybe a week or two away. When you update, please run thumbnailer-admin clear f Otherwise, old failures will keep hanging around in the cache. -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-12-27 Thread Michi Henning
The Bad Request response issue is definitely fixed by the linked branch. I'm seeing much more robust behavior now. We still have an issue with the error back-off being too aggressive when an individual request to the server times out. I'll work on that and try to get this into OTA-9. We have a

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-12-14 Thread Michi Henning
** Changed in: thumbnailer (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512608 Title: No thumbnails generated for OGG audio To manage

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-12-03 Thread Michi Henning
** Branch linked: lp:~michihenning/thumbnailer/http-response-codes -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512608 Title: No thumbnails generated for OGG audio To manage notifications about

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-12-03 Thread Michi Henning
OK, that pretty much makes it clear that your problem matches the one exposed by my test data. The hits are from other requests that were in flight around the same time. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-12-03 Thread Fred Vkigg
I certainly seeing the failure mode you suggest. The third lookup in this log has an empty artist. There are a variety of other responses after this including HIT, NO ARTWORK and FAILED PREVIOUSLY. thumbnailer-service: [21:20:04.256] "album: Joan Baez/Queen of Hearts (512,512): 0.003812 sec

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-12-02 Thread Fred Vkigg
Michi, looks like your 7000 files are behaving similar to what I saw. When I get some time I shall see if with a clear cache I also get Bad Request responses. Saldly nothing in /var/crash. I know where to look now! Good luck. I shall monitor the bug in case you need more feedback/ beta testing.

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-12-02 Thread Michi Henning
If you try with your own collection and scan the log, if you find a bad request followed by loads of "failed previously", we are dealing with the same issue. If not, I'd still like to get my hands on your collection, but let's hold off with that for now. I'm working on a fix at the moment. The

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-30 Thread Michi Henning
OK, probably no need for the flash card, I think I have reproduced the problem. I'm attaching an archive that contains 7000 MP3 files, in subdirs of 1000 files each. Each MP3 is one second of silence, with exactly two tags, album and artist. The tags were created from server trace files (thanks

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-30 Thread Michi Henning
MP3 attachment. ** Attachment added: "7000 tagged MP3s without embedded artwork" https://bugs.launchpad.net/ubuntu/+source/thumbnailer/+bug/1512608/+attachment/4527816/+files/music-no-artwork.tar.gz -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-30 Thread Michi Henning
Actually, no entries in the failure cache. Instead, the first Bad Request response from the server means that we stop trying again for two hours. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512608

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-30 Thread Michi Henning
** Changed in: thumbnailer (Ubuntu) Status: New => In Progress ** Changed in: music-app (Ubuntu) Status: New => Invalid -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512608 Title:

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-29 Thread Fred Vkigg
Hi Michi, thanks for the interest! The experience was interesting. After the upgrade I went into the Music app. It was interesting to watch as all the entries dispersed in front of my eyes :-% After a few application restart the Music app simple crashed on startup. Quick solution to this was

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-29 Thread Michi Henning
Hi Fred, thank you for taking the time to help diagnose this! > On subsequent runs you see the corresponding FAILED PREVIOUSLY responses. Since there about 400 artists and 600 albums the behaviour seems reasonable assuming the backend server was not responding in time to all requests. Hmmm… We

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-23 Thread Michi Henning
Fred, any change with OTA-8? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512608 Title: No thumbnails generated for OGG audio To manage notifications about this bug go to:

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-12 Thread Michi Henning
"Fred, thanks for getting bad to us!" Bloody auto-correct. My apologies, that should have read "... getting back to us!" -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512608 Title: No thumbnails

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-11 Thread Fred Vkigg
Thanks for the feedback. Sorry to respond so slowly. I'm still still seeing a slow increase in thumbnails. I suspect it will not converge to a complete coverage! I need to further analyse the logs. One possibility is that I see a lot of OOM killer activity when Music app is open. I need to

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-11 Thread Michi Henning
Fred, thanks for getting bad to us! If the music app gets killed, it might be because it asks for more than it can eat. If it sends a large number of requests to the thumbnailer, and lots of requests get a cache hit, the thumbnailer will deliver close to a thousand images per second, which can

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-04 Thread Michi Henning
Thanks for the update, Fred! If one of the files causes a crash or hang during extraction, the thumbnailer is robust against that and will kill off the offending process. (We thumbnail out-of-process for audio and video precisely to guard against this issue.) But, if that happens, you should find

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-04 Thread Michi Henning
I've confirmed that your file works just fine when I drop it onto the phone. We successful fetch both album and artist art for it. I suspect that we need to focus on the fact that tons of files are being added all at once. -- You received this bug notification because you are a member of Ubuntu

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-04 Thread Fred Vkigg
Michi thanks for the feedback. Hopefully it will help me determine the root cause of the strang behaviour. > I'm pretty sure that there is nothing wrong with extraction from ogg files Agreed. > So, I'm wondering whether what you are seeing is simply due to the fact that a lot of files are added

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-04 Thread Fred Vkigg
Further.. My cut down sd card with only music files is slowly covering to have a large percentage of Album and Artist art even on the OGG files -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512608

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-04 Thread Michi Henning
I'm pretty sure that there is nothing wrong with extraction from ogg files; we have tests for this. But, if most of these files do not contain artwork and you add an SD card with thousands of songs and run up the music app, the music app will send hundreds of requests to the thumbnailer. No

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-03 Thread Michi Henning
** Also affects: thumbnailer (Ubuntu) Importance: Undecided Status: New ** No longer affects: thumbnailer -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1512608 Title: No thumbnails

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-03 Thread Michi Henning
** Changed in: thumbnailer (Ubuntu) Assignee: (unassigned) => Michi Henning (michihenning) ** Changed in: thumbnailer (Ubuntu) Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-03 Thread Fred Vkigg
Just cut down to just a few files on the sdcard and managed to get a thumbnail hit on an OGG file. So you should not see a problem with the OGG gile I attached, I'll expand the trials a little to see if I can actually find the failure mode. I normally have several thousand files! I'll try and

[Bug 1512608] Re: No thumbnails generated for OGG audio

2015-11-03 Thread Fred Vkigg
OGG audio file attached. Rhythmbox shows following tags: Title: A Whiter Shade of Pale Artist: Annie Lennox Album: Medusa Album Artist is empty. I'm going to try if setting this helps the thumbnailer. This evening (UTC) I will cut down the music collection on the sdcard to just a few files, clear