[Bug 1523817] Re: ComboButton needs keyboard support
** Changed in: canonical-devices-system-image Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
This bug was fixed in the package ubuntu-ui-toolkit - 1.3.2060+16.10.20160814 --- ubuntu-ui-toolkit (1.3.2060+16.10.20160814) yakkety; urgency=medium [ Zoltan Balogh ] * Fix OptionSelectorTestCase tests. * Fix more OptionSelector autopilot tests [ Timo Jyrinki ] * Disable documentation building for GLES builds. Fixes LP: #1606222. * Replace abs with qFabs due to GCC6 breakage. Fixes LP: #1610943. * Limit s390x dependencies more due to upstart/s390x problems and removed packages in archives. Fixes LP: #1610951 [ Andrea Bernabei ] * ListItemLayout doc: add elide mode change example and add section about labels default properties values. Fixes LP: #1603450. * ListItemLayout doc: add explicit note about the need to bind ListItem's height to layout's height. * More Scrollbar optimizations: 20% faster creation time. Fixes LP: #1606451 * Scrollbar: fix wrong thumb color on tap/mouse release and increase coverage of hover states unit tests. Fixes LP: #1608897 [ Zsombor Egri ] * Fix null pointer property initializer used with 1.3 PageWrapper. Fixes LP: #1604780. * Fix BottomEdge content URL preloading. Fixes LP: #1604509. [Albert Astals Cid ] * UCUnits::resolveResource: Prefer image path if it exists. This saves searching the disk for @gu images, which is a big speedup. According to callgrind loading 100 images from a folder that contains 380 images goes from around 3 million instructions per UCUnits::resolveResource call down to around 10 thousand. This optimization is ok since it is not correct to ship both image.png and im...@20.png. You either have to ship gu-enabled files or not, but mixing them is not allowed. Searched for cases in which that may be happening in my phone and found none. Fixes LP: #1604029. [ Tim Peeters ] * Configure colors of the buttons in the ActionBar and PageHeader through their Styles. Fixes LP: #1597774. * Fix assigning of constant values to a grouped property in StyleHints. Fixes LP: #1602836. * Fix list view keyboard navigation for RightToLeft and BottomToTop directions. Fixes LP: #1605634 * Use external QML files instead of embedded QML strings for autopilot tests. Fixes LP: #1578319 * Fix failing autopilot header tests. * Fix ActionSelectionPopover Autopilot CPO tests. [Christian Dywan ] * Include indexes in "offline" docs and filter out link errors. Fixes LP: #1603937. * Increase focus ring thickness from 1dp to 2dp. Fixes LP: #1602690. * Add a snippet about tests to the toplevel README * Enter/Return to trigger, Space to expand ComboButton. Fixes LP: #1523817. * Initialize engine variable before using it in the _engine case. * Use Qt.rgba instead of # checking ListItem default color. Fixes LP: #1560004 * Don't use a different .desktop file in the gallery tests. Fixes LP: #1578319 * Update scaling docs, set QT_SCALE_FACTOR and unset GRID_UNIT_PX. Fixes LP: #1610208 [ Florian Boucault ] * Sections: load Icons asynchronously. -- Zoltán Balogh Sun, 14 Aug 2016 09:06:46 + ** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Changed in: canonical-devices-system-image Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
This bug was fixed in the package ubuntu-ui-toolkit 1.3.2060+15.04.20160814 in https://launchpad.net/~ci-train-ppa- service/+archive/ubuntu/stable-phone-overlay --- ubuntu-ui-toolkit (1.3.2060+15.04.20160814) vivid; urgency=medium [ Zoltan Balogh ] * Fix OptionSelectorTestCase tests. * Fix more OptionSelector autopilot tests [ Timo Jyrinki ] * Disable documentation building for GLES builds. Fixes LP: #1606222. * Replace abs with qFabs due to GCC6 breakage. Fixes LP: #1610943. * Limit s390x dependencies more due to upstart/s390x problems and removed packages in archives. Fixes LP: #1610951 [ Andrea Bernabei ] * ListItemLayout doc: add elide mode change example and add section about labels default properties values. Fixes LP: #1603450. * ListItemLayout doc: add explicit note about the need to bind ListItem's height to layout's height. * More Scrollbar optimizations: 20% faster creation time. Fixes LP: #1606451 * Scrollbar: fix wrong thumb color on tap/mouse release and increase coverage of hover states unit tests. Fixes LP: #1608897 [ Zsombor Egri ] * Fix null pointer property initializer used with 1.3 PageWrapper. Fixes LP: #1604780. * Fix BottomEdge content URL preloading. Fixes LP: #1604509. [Albert Astals Cid ] * UCUnits::resolveResource: Prefer image path if it exists. This saves searching the disk for @gu images, which is a big speedup. According to callgrind loading 100 images from a folder that contains 380 images goes from around 3 million instructions per UCUnits::resolveResource call down to around 10 thousand. This optimization is ok since it is not correct to ship both image.png and im...@20.png. You either have to ship gu-enabled files or not, but mixing them is not allowed. Searched for cases in which that may be happening in my phone and found none. Fixes LP: #1604029. [ Tim Peeters ] * Configure colors of the buttons in the ActionBar and PageHeader through their Styles. Fixes LP: #1597774. * Fix assigning of constant values to a grouped property in StyleHints. Fixes LP: #1602836. * Fix list view keyboard navigation for RightToLeft and BottomToTop directions. Fixes LP: #1605634 * Use external QML files instead of embedded QML strings for autopilot tests. Fixes LP: #1578319 * Fix failing autopilot header tests. * Fix ActionSelectionPopover Autopilot CPO tests. [Christian Dywan ] * Include indexes in "offline" docs and filter out link errors. Fixes LP: #1603937. * Increase focus ring thickness from 1dp to 2dp. Fixes LP: #1602690. * Add a snippet about tests to the toplevel README * Enter/Return to trigger, Space to expand ComboButton. Fixes LP: #1523817. * Initialize engine variable before using it in the _engine case. * Use Qt.rgba instead of # checking ListItem default color. Fixes LP: #1560004 * Don't use a different .desktop file in the gallery tests. Fixes LP: #1578319 * Update scaling docs, set QT_SCALE_FACTOR and unset GRID_UNIT_PX. Fixes LP: #1610208 [ Florian Boucault ] * Sections: load Icons asynchronously. -- Zoltán Balogh Sun, 14 Aug 2016 09:06:46 + ** Changed in: ubuntu-ui-toolkit (Ubuntu RTM) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Branch linked: lp:~ci-train-bot/ubuntu-ui-toolkit/ubuntu-ui-toolkit- ubuntu-yakkety-landing-070 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
Discussed this with Femma. The behaviour for focus and select is correct. I would like to increase the weight of the focus frame but I will log this as a separate bug. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
It's looking good. I've a few wee questions… 1. The first is more a 'focus frame' question. I can see the line weight is now consistent but I think it's too thin. It breaks up when it goes around corners of objects. Are you able to adjust this on another demo? Should I speak to someone here (Pierre or Andrea)? 2. More combo-button related. When you open a menu with the button using the keyboard (space) the first item is selected (blue) Would it be more accurate to just have the focus frame and then change the visual state of the selected item to blue when a user has selected it. I think it follows the List Item way of doing things so would be good to understand this. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Changed in: canonical-devices-system-image Milestone: 12 => 13 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Branch linked: lp:~ubuntu-sdk-team/ubuntu-ui- toolkit/acceptTheComboButton -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Changed in: canonical-devices-system-image Milestone: 11 => 12 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Branch linked: lp:~ubuntu-sdk-team/ubuntu-ui- toolkit/comboButtonInOuterSpaceTrunks -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
Just to note, the work had been paused for a while, but I'm back on it. There's prerequisite bugs to be fixed in ListItem and AbstractButton to fully make this work and it's less straight-forward than it looks to get everything working. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Changed in: canonical-devices-system-image Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Changed in: canonical-devices-system-image Status: In Progress => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Changed in: ubuntu-ui-toolkit (Ubuntu RTM) Status: New => In Progress ** Changed in: ubuntu-ui-toolkit (Ubuntu RTM) Assignee: (unassigned) => Christian Dywan (kalikiana) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Changed in: canonical-devices-system-image Milestone: ww08-2016 => 11 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Changed in: canonical-devices-system-image Status: Confirmed => In Progress ** Changed in: ubuntu-ui-toolkit (Ubuntu) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Changed in: ubuntu-ui-toolkit (Ubuntu) Importance: High => Medium ** Changed in: ubuntu-ui-toolkit (Ubuntu RTM) Importance: Undecided => Medium -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Branch linked: lp:~ubuntu-sdk-team/ubuntu-ui- toolkit/comboInOuterSpace -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Changed in: canonical-devices-system-image Status: New => Confirmed ** Changed in: canonical-devices-system-image Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Also affects: ubuntu-ui-toolkit (Ubuntu RTM) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1523817] Re: ComboButton needs keyboard support
** Also affects: canonical-devices-system-image Importance: Undecided Status: New ** Changed in: canonical-devices-system-image Assignee: (unassigned) => Zoltan Balogh (bzoltan) ** Changed in: canonical-devices-system-image Milestone: None => ww08-2016 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1523817 Title: ComboButton needs keyboard support To manage notifications about this bug go to: https://bugs.launchpad.net/canonical-devices-system-image/+bug/1523817/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
