[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Launchpad Bug Tracker]

This bug was fixed in the package grub2-signed - 1.66.17

---
grub2-signed (1.66.17) xenial; urgency=medium

  * Rebuild against grub2 2.02~beta2-36ubuntu3.17. (LP: #1527727)

 -- Scott Moser   Thu, 25 Jan 2018 10:05:01 -0500

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Launchpad Bug Tracker]

This bug was fixed in the package grub2 - 2.02~beta2-36ubuntu3.17

---
grub2 (2.02~beta2-36ubuntu3.17) xenial; urgency=medium

  * Signal to zpool that it should emit full names of constituent devices.
(LP: #1527727)

 -- Scott Moser   Wed, 24 Jan 2018 16:21:35 -0500

** Changed in: grub2 (Ubuntu Xenial)
   Status: Fix Committed => Fix Released

** Changed in: grub2-signed (Ubuntu Xenial)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Scott Moser]

>From the install log you can see that we install grub2 at 
>2.02~beta2-36ubuntu3.17.
   ..
   Unpacking grub2-common (2.02~beta2-36ubuntu3.17)
   ..


'dpkg-reconfigure grub-pc' and 'grub-install /dev/vda' are run

And also:

  run-parts: executing /etc/kernel/postinst.d/zz-update-grub 4.4.0-116-generic 
/boot/vmlinuz-4.4.0-116-generic
  Generating grub configuration file ...
  Found linux image: /boot/vmlinuz-4.4.0-9025-euclid
  Found initrd image: /boot/initrd.img-4.4.0-9025-euclid
  Found linux image: /boot/vmlinuz-4.4.0-116-generic
  Found initrd image: /boot/initrd.img-4.4.0-116-generic
/run/lvm/lvmetad.socket: connect failed: No such file or directory

Then during boot we see

[0.00] Command line:
BOOT_IMAGE=/ROOT/zfsroot@/boot/vmlinuz-4.4.0-9025-euclid
root=ZFS=rpool/ROOT/zfsroot ro console=ttyS0

So we have successfully booted from root on a zfs system.





** Tags removed: verification-needed verification-needed-xenial
** Tags added: verification-done verification-done-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Scott Moser]

Hi.
I've confirmed this fix by using curtin's "vmtest" test harness.

I've applied the attached patch to curtin at 82622f129b.
The patch does:
a.) remove the work arounds we had in place to make zfs root work on xenial.
b.) enable proposed

Then I've run an install of a system that does a installation of zfs on root.
   ./tools/jenkins-runner 
examples/tests/zfsroot.yaml:tests/vmtests/test_zfsroot.py:XenialGATestZfsRoot

I'll attach the boot and install logs of that system also.



** Patch added: "applied curtin diff"
   
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+attachment/5060820/+files/curtin.diff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Scott Moser]

** Attachment added: "first boot console log"
   
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+attachment/5060822/+files/boot-serial.log

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Scott Moser]

** Attachment added: "installation console log"
   
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+attachment/5060821/+files/install-serial.log

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Scott Moser]

I've removed the verification-failed-xenial tag.
The problem reported in bug 1750732 may be related to a grub upgrade, but
surely is not related to this specific grub upgrade.

Please see the changes 
 
http://launchpadlibrarian.net/354651271/grub2_2.02~beta2-36ubuntu3.16_2.02~beta2-36ubuntu3.17.diff.gz
for justification.

The only change made there is a 'setenv' call.


** Tags removed: verification-failed-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Łukasz Zemczak]

Hello Chad, or anyone else affected,

Accepted grub2 into xenial-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/grub2/2.02~beta2-36ubuntu3.17 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-xenial to verification-done-xenial. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-xenial. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: grub2 (Ubuntu Xenial)
   Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-xenial

** Changed in: grub2-signed (Ubuntu Xenial)
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Scott Moser]

I've uploaded just now grub2 (2.02~beta2-36ubuntu3.17) and
grub2-signed (1.66.17) to the xenial SRU queue.

There are currently versions in xenial-proposed for these packages with
fixes for bug 722950 and bug 1708245.

Hopefully after those uploads clear xenial-proposed the fix for this bug will
get into xenial-proposed.

I've also put a PPA up with the changes at
 https://launchpad.net/~smoser/+archive/ubuntu/lp1527727
which I hope will have builds some time today.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Scott Moser]

I've marked this 'Fix Released' in xenial as Ubuntu's package in xenial
at 0.6.5.6-0ubuntu3 which has the fix at [1] as mentioned in comment 29.
Further, my experience with our zfs work in curtin indicates that it is
fixed.

--
https://github.com/zfsonlinux/zfs/commit/d2f3e292dccab23e47ade3c67677a10f353b9e85

** Changed in: zfs-linux (Ubuntu Xenial)
   Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Launchpad Bug Tracker]

** Merge proposal linked:
   
https://code.launchpad.net/~smoser/ubuntu/+source/grub2/+git/grub2/+merge/336577

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Michael Schnaitter]

bumping for Jens' post...
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1687664

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Jens Elkner]

Done - see 1687664.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

Jens, as far as I know, you shouldn't have gotten an error. Please file
a new bug report, and include version numbers of 'grub2' and 'zfs-
linux'.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Jens Elkner]

Just encountered the same problem with xenial:

grub-probe: error: failed to get canonical path of `/dev/HDD0p2'
See also http://savannah.gnu.org/bugs/?50896

IMHO "zpool status -P $pool" should be used, everything else is a
kludge, which will fail sooner or later.

** Bug watch added: GNU Savannah Bug Tracker #50896
   http://savannah.gnu.org/bugs/?50896

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Mathieu Trudel-Lapierre]

Currently blocked on a grub SRU in xenial-proposed that isn't completely
verified.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Timo Aaltonen]

cyphermox: Those uploads seem to have been dropped in favor of some
other changes, so this needs to be reuploaded

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Richard Laager]

Colin, with grub2 in yakkety being patched, we should be ready for
zfsutils-linux in yakkety to drop /lib/udev/rules.d/69-vdev.rules and
"Conflicts: grub2 << 2.02~beta2-36ubuntu5".

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Richard Laager]

[My previous comment was incorrect. I had the wrong file in the wrong
package.]

Colin, with grub2 in yakkety being patched, we should be ready for zfs-
initramfs in yakkety to drop /lib/udev/rules.d/60-zpool.rules and
"Conflicts: grub2 << 2.02~beta2-36ubuntu5".

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Richard Laager]

cyphermox: Any progress? It's been three months since your last comment
where it was close to ready.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Launchpad Bug Tracker]

Status changed to 'Confirmed' because the bug affects multiple users.

** Changed in: zfs-linux (Ubuntu Xenial)
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Mathieu Trudel-Lapierre]

This doesn't really depend on any extra steps -- I've just uploaded
grub2 and grub2-signed to xenial-proposed queue, so as soon as it's
reviewed by a member of the SRU team it will be available in proposed.

>From there, we'll need people to test this carefully to make sure
nothing is broken and that it's fulfilling its intended purposed (ie.
fixing the issue), after that we'll be able to make it available to the
general public in -updates.

** Also affects: grub2-signed (Ubuntu)
   Importance: Undecided
   Status: New

** Changed in: grub2-signed (Ubuntu)
   Status: New => Fix Released

** Changed in: grub2-signed (Ubuntu Xenial)
   Status: New => In Progress

** Changed in: grub2-signed (Ubuntu Xenial)
 Assignee: (unassigned) => Mathieu Trudel-Lapierre (cyphermox)

** Changed in: grub2-signed (Ubuntu Xenial)
   Importance: Undecided => Medium

** Changed in: grub2-signed (Ubuntu)
   Importance: Undecided => Medium

** Changed in: zfs-linux (Ubuntu Xenial)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Richard Laager]

I confirmed the package in yakkety works (on Xenial). That is, I can
successfully run update-grub without having the special-case
"/dev/disk"-style symlink in /dev.

Is the next step to upload this to xenial-proposed?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Mathieu Trudel-Lapierre]

Uploaded to yakkety:

grub2 (2.02~beta2-36ubuntu5) yakkety; urgency=medium

  * debian/patches/zpool_full_device_name.patch: Signal to zpool that
it should emit full names of constituent devices.

** Changed in: grub2 (Ubuntu)
   Status: In Progress => Fix Released

** Description changed:

+ [Impact]
+ Installs over ZFS where a ZFS disk is expected to be used as a root device.
+ 
+ [Test case]
+ - Run update-grub on a system with a ZFS root filesystem.
+ 
+ [Regression Potential]
+ Installs relying on the current broken behavior to avoid listing other 
operating systems in grub menu may find that new entries are added.
+ 
+ ---
+ 
  update-grub runs /usr/sbin/grub-probe
  
  Without libzfslinux support compiled in, /usr/sbin/grub-probe runs
  ["zpool", "status", poolname] to find out ZFS info.
  
  zpool responds with device names as used at (I think!) pool creation
  time. Often, this is /dev/disk/by-id/... names, without the path.
  
  grub-probe then parses the output, and takes the names of devices, and
  if they do not start with a "/", it prepends "/dev/".
  
  It then tests the existence of the path name of the device. it fails.
  
  grub-probe then returns  something like
  
  /usr/sbin/grub-probe: error: failed to get canonical path of `/dev/ata-
  ST31000333AS_-part1'.
  
  The actual path is of course /dev/disk/by-id/ST31000333AS_-part1
  
  It can prepend smarter than "/dev" or it can understand ZFS natively, to
  fix the problem.

** Also affects: grub2 (Ubuntu Xenial)
   Importance: Undecided
   Status: New

** Also affects: zfs-linux (Ubuntu Xenial)
   Importance: Undecided
   Status: New

** Changed in: grub2 (Ubuntu Xenial)
   Importance: Undecided => Medium

** Changed in: grub2 (Ubuntu Xenial)
 Assignee: (unassigned) => Mathieu Trudel-Lapierre (cyphermox)

** Changed in: grub2 (Ubuntu Xenial)
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Colin Ian King]

** Changed in: zfs-linux (Ubuntu)
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Colin Ian King]

Thanks, I'm keenly aware of this and I'm working on it :-)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Hajo Möller]

Colin, 0.6.5.6 is out now:
https://github.com/zfsonlinux/zfs/releases/tag/zfs-0.6.5.6
https://github.com/zfsonlinux/spl/releases/tag/spl-0.6.5.6

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Colin Ian King]

Any idea when 0.6.5.6 will be out? I'll sync up with that as soon as it
lands as a Feature Freeze Exception.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Hajo Möller]

It is my understanding that upgrading to a new upstream ZFS version
would require a FFe.

I have asked ZFS on Linux's release manager Ned Bass whether he plans to
tag a point release which includes the relevant commits soon.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Hajo Möller]

Ned replied to my mail already, he plans to release 0.6.5.6 soon:

"I hadn't planned to, but it seems worthwhile to get this into 16.04 if it 
fixes grub-probe.
I'll get a 0.6.5.6 release out in the next few days that includes these 
patches."

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Clint Silvester]

Looks like the needed changes could go into the next release.
https://github.com/zfsonlinux/zfs/issues/4414

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Richard Laager]

Is this going to make the Xenial release?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

Thanks, Richard. Okay, so first thing to change is grub.

After changing grub, at any time we can change zfs-linux to
simultaneously, drop the symlink udev rule, accept the environment
variable to change output, and Conflict on grub older than the one that
starts emitting the new environment variable.


** Patch added: "include environment var to get best zpool output"
   
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+attachment/4581895/+files/grub2__2.02~beta2-36__2.02~beta2-36ubuntu1.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Richard Laager]

** Patch added: "zfs-1527727.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1527727/+attachment/4581527/+files/zfs-1527727.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Richard Laager]

The upstream change was merged. I propose the following:

1) Update zfs-linux in Xenial with the patch:
https://github.com/zfsonlinux/zfs/commit/d2f3e292dccab23e47ade3c67677a10f353b9e85

2) Patch grub2 in Xenial to setenv("ZPOOL_VDEV_NAME_PATH", "YES")

3) Remove the udev rules from zfs-initramfs in Xenial.

I'll attach debdiffs which accomplish this. They could use a second set
of eyes, as I made these changes quickly. Rather than edit the patch of
the ZFS commit to make it apply, I backported additional man page fixes.

** Patch added: "grub-1527727.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1527727/+attachment/4581525/+files/grub-1527727.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Marlin Cremers]

That'd be great! I hope both ZoL and Ubuntu are able to pull that in in
time for 16.04.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Richard Laager]

This is related:
https://github.com/zfsonlinux/zfs/pull/4343

If that was merged, then GRUB could be patched to use -L and/or -p.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

Re: [Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Marlin Cremers]

Technically I'd consider it more of a workaround. The actual issue in GRUB
hasn't been resolved.
On 22 Feb 2016 12:16 p.m., "Colin Ian King" <1527...@bugs.launchpad.net>
wrote:

> Chad, can you check if comment #24 is correct, and if so, we can close
> this bug
>
> ** Changed in: zfs-linux (Ubuntu)
>  Assignee: Chad Miller (cmiller) => Colin Ian King (colin-king)
>
> ** Changed in: zfs-linux (Ubuntu)
>Importance: Undecided => Medium
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1527727
>
> Title:
>   grub-probe for zfs assumes all devices prefix with /dev, ignoring
>   /dev/disk/...
>
> Status in grub:
>   Unknown
> Status in grub2 package in Ubuntu:
>   In Progress
> Status in zfs-linux package in Ubuntu:
>   In Progress
>
> Bug description:
>   update-grub runs /usr/sbin/grub-probe
>
>   Without libzfslinux support compiled in, /usr/sbin/grub-probe runs
>   ["zpool", "status", poolname] to find out ZFS info.
>
>   zpool responds with device names as used at (I think!) pool creation
>   time. Often, this is /dev/disk/by-id/... names, without the path.
>
>   grub-probe then parses the output, and takes the names of devices, and
>   if they do not start with a "/", it prepends "/dev/".
>
>   It then tests the existence of the path name of the device. it fails.
>
>   grub-probe then returns  something like
>
>   /usr/sbin/grub-probe: error: failed to get canonical path of `/dev
>   /ata-ST31000333AS_-part1'.
>
>   The actual path is of course /dev/disk/by-
>   id/ST31000333AS_-part1
>
>   It can prepend smarter than "/dev" or it can understand ZFS natively,
>   to fix the problem.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions
>

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Colin Ian King]

Chad, can you check if comment #24 is correct, and if so, we can close
this bug

** Changed in: zfs-linux (Ubuntu)
 Assignee: Chad Miller (cmiller) => Colin Ian King (colin-king)

** Changed in: zfs-linux (Ubuntu)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Hajo Möller]

Chad, as of now Ubuntu's shipped ZFS comes with a custom udev rule to
generate the required links under /dev/, so this patch may not be
required.

See https://bugs.launchpad.net/ubuntu/+source/zfs-
initramfs/+bug/1530953/comments/28 for details.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

** Patch added: "grub2 debdiff to add environment variable to suggest full 
paths to zfs zpool command"
   
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+attachment/4572933/+files/grub2__2.02~beta2-36__2.02~beta2-36ubuntu1.compat-envvar.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

Okay, so making grub ask for zfs details using a new, nonstandard
command-line parameter is bad because I can't depend on zfs version Foo
in grub, and I don't want to Conflict on older versions, and I don't
want zfs zpool status to fail on an unknown parameter.

So, this makes zfs zpool peek at the environment for an optional
variable "WITH_FULL_PATHS" and not truncate the emitted path names if it
is set. This change is compatible with everyone.

** Patch added: "zfs-linux patch to emit full paths"
   
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1527727/+attachment/4572906/+files/grub2__2.02~beta2-35ubuntu1__2.02~beta2-35ubuntu2.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

Okay, so making grub ask for zfs details using a new, nonstandard
command-line parameter is bad because I can't depend on zfs version Foo
in grub, and I don't want to Conflict on older versions, and I don't
want zfs zpool status to fail on an unknown parameter.

So, this makes zfs zpool peek at the environment for an optional
variable "WITH_FULL_PATHS" and not truncate the emitted path names if it
is set. This change is compatible with everyone.

** Patch added: "zfs-linux patch to emit full paths"
   
https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1527727/+attachment/4572907/+files/zfs-linux__0.6.5.4-0ubuntu2__0.6.5.4-0ubuntu3.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

** Also affects: zfs-linux (Ubuntu)
   Importance: Undecided
   Status: New

** Changed in: zfs-linux (Ubuntu)
   Status: New => Confirmed

** Changed in: zfs-linux (Ubuntu)
 Assignee: (unassigned) => Chad Miller (cmiller)

** Changed in: zfs-linux (Ubuntu)
   Status: Confirmed => In Progress

** Changed in: grub2 (Ubuntu)
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Marlin Cremers]

The idea behind the short name is readability and simplicity. The
recommended way to set up a zpool is to use partitions using device
labels that allow you to identify devices in the chassis. Adding the
full device name would add a lot of unnecessary clutter in the UI.

I kind of support the idea for a machine-readable flag but it might be
better a improve zdb rather than the zpool command.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Martin Pitt]

Just prepending /dev to the device name is obviously wrong indeed, but
slapping random other prefixes onto it does not make it better really.
This hardcodes udev rules and kernel/driver behaviour, which is always
going to be brittle or incomplete -- people might set up their own
device namings, or use a funny device driver. For example, in this patch
/dev/mapper/ is missing.

So this is a hack which I wouldn't like to see in an LTS release --
let's please fix the ZFS CLI tools by either

  - show the full path by default. It's more useful for human users, and
the current behaviour of showing only the basename of a device node is
completely useless for tools that parse the output

 - add a new option --machine-readable or similar which shows full
paths, if not changing the default output format is important

Alternatively it might be possible to pry this information out of /sys
somewhere?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

What it looks like without this patch:

Setting up grub-efi-amd64 (2.02~beta2-36) ...
Installing for x86_64-efi platform.
grub-install: error: failed to get canonical path of 
`/dev/ata-ST31000333AS_-part1'.
Failed: grub-install --target=x86_64-efi --force-extra-removable
WARNING: Bootloader is not properly installed, system may not be bootable
/usr/sbin/grub-probe: error: failed to get canonical path of 
`/dev/ata-ST31000333AS_-part1'.
dpkg: error processing package grub-efi-amd64 (--configure):
 subprocess installed post-installation script returned error exit status 1
dpkg: dependency problems prevent configuration of 
linux-image-extra-4.4.0-4-generic:
 linux-image-extra-4.4.0-4-generic depends on linux-image-4.4.0-4-generic; 
however:
  Package linux-image-4.4.0-4-generic is not configured yet.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

dasjoe, that's not bad, but I don't know enough of "zdb" to propose it.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

** Patch added: "diff against xenial, again"
   
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+attachment/4572495/+files/grub2__2.02~beta2-36__2.02~beta2-36ubuntu1.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Hajo Möller]

As the pool name is known we could run:
zdb -C poolname
to get the pool's configuration, which includes the path to all members of all 
(available) vdevs.

To get the configuration of a known, exported pool we could use:
zdb -C -e poolname
This will work as long as the pool is not imported and its devices can be found 
in /dev/.

Sample output follows:
root@sbooblehat:~/zfs# zdb -C sbooblehat-rpool

MOS Configuration:
version: 5000
name: 'sbooblehat-rpool'
state: 0
txg: 3550165
pool_guid: 13767226917234919597
errata: 0
hostid: 2831164860
hostname: 'sbooblehat'
vdev_children: 1
vdev_tree:
type: 'root'
id: 0
guid: 13767226917234919597
children[0]:
type: 'disk'
id: 0
guid: 2058733885599967477
path: 
'/dev/disk/by-id/ata-Samsung_SSD_850_EVO_120GB_S21UNSAG310692M-part1'
whole_disk: 1
metaslab_array: 35
metaslab_shift: 29
ashift: 13
asize: 90011336704
is_log: 0
DTL: 59
create_txg: 4
features_for_read:


root@sbooblehat:~/zfs# zdb -C -e sbooblehat-rpool
zdb: can't open 'sbooblehat-rpool': File exists


root@sbooblehat:~/zfs# zdb -C -e TEMP
zdb: can't open 'TEMP': No such file or directory


root@sbooblehat:~/zfs# zdb -C -e -p . TEMP

MOS Configuration:
version: 5000
name: 'TEMP'
state: 1
txg: 8
pool_guid: 6410361307144069801
errata: 0
hostid: 2831164860
hostname: 'sbooblehat'
vdev_children: 1
vdev_tree:
type: 'root'
id: 0
guid: 6410361307144069801
create_txg: 4
children[0]:
type: 'file'
id: 0
guid: 15915301152600074830
path: '/root/zfs/A'
metaslab_array: 34
metaslab_shift: 24
ashift: 9
asize: 100139008
is_log: 0
create_txg: 4
features_for_read:
com.delphix:hole_birth
com.delphix:embedded_data

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Mathew Hodson]

** Bug watch removed: GNU Savannah Bug Tracker #46755
   http://savannah.gnu.org/bugs/?46755

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

** Patch added: "debdiff against ubuntu xenial"
   
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+attachment/4562558/+files/grub2__2.02~beta2-35ubuntu1__2.02~beta2-35ubuntu2.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

As noted on IRC, upstream doesn't want this patch. "Use libzfs! We can't
anticipate all device names, so we don't want to add any more. Or,
change zpool to emit full names."

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Mathieu Trudel-Lapierre]

Have you sent this to grub upstream? Ideally we should sent it there for
inclusion, then we can upload the fix to Debian and sync it to Ubuntu.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

(See also https://bugs.launchpad.net/ubuntu/+source/zfs-
initramfs/+bug/1530953 )

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Colin Ian King]

Chad,  OK, sounds good to me. Do you want me to SRU this for wily? or
are we looking at just for Xenial?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

Here's the short summary:

libzfs has a license that (most people agree) does not let grub link
against it.

Linking against it is assumed by grub upstream to be the right way. But
they have a fallback way that involves running a zfs utils command to
list its devices.

The devices the zfs utils program prints are not full device names but
things like "hda1" or "ata-ST12346124623-ajqwers". Those are names that
were scanned when you fabricated and imported the zfs device pool.
There's no way to get exact paths.

Grub assumes they're all device names that are directly within /dev/
directory, and that's often wrong if the user used /dev/by-id/ paths to
set up zfs pools. ZFS-knowledgeable people are *really* likely to have
used unambiguous device names.

So, this patch in #4 takes the professed device file name and tests
whether a name exists before printing it. It goes from most unique names
to least unique names. It's incredibly unlikely to collide. bus-model-
serial names are unlike uuid names, and unlike sdx names. It should be
safe in all cases.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

Colin, I don't think many people expect last release to be capable of
ZFS root installation, so I'm happy with ignoring it in 15.10.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

So, back to patch in #4.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

License for libzfs is incompatible with grub. Also, main vs universe.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

The correct fix for this is to link in libzfslinux-dev to get smarter
zfs polling, instead of parsing output of "zpool" command.

** Changed in: grub2 (Ubuntu)
 Assignee: (unassigned) => Chad Miller (cmiller)

** Bug watch added: GNU Savannah Bug Tracker #43653
   http://savannah.gnu.org/bugs/?43653

** Changed in: grub
 Remote watch: GNU Savannah Bug Tracker #46755 => GNU Savannah Bug Tracker 
#43653

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

** Description changed:

  update-grub runs /usr/sbin/grub-probe
  
- /usr/sbin/grub-probe runs ["zpool", "status", poolname]
+ Without libzfslinux support compiled in, /usr/sbin/grub-probe runs
+ ["zpool", "status", poolname] to find out ZFS info.
  
  zpool responds with device names as used at (I think!) pool creation
  time. Often, this is /dev/disk/by-id/... names, without the path.
  
  grub-probe then parses the output, and takes the names of devices, and
  if they do not start with a "/", it prepends "/dev/".
  
  It then tests the existence of the path name of the device. it fails.
  
  grub-probe then returns  something like
  
  /usr/sbin/grub-probe: error: failed to get canonical path of `/dev/ata-
  ST31000333AS_-part1'.
  
  The actual path is of course /dev/disk/by-id/ST31000333AS_-part1
+ 
+ It can prepend smarter than "/dev" or it can understand ZFS natively, to
+ fix the problem.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

A better change. Commented, manage memory, changelog better.

** Patch added: "2.02~beta2-32ubuntu1 +1 debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+attachment/4540155/+files/grub2_2.02%7Ebeta2-32ubuntu1___2.02%7Ebeta2-32ubuntu2.debdiff

** Patch removed: "xenial debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+attachment/4537081/+files/diff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

** Bug watch added: GNU Savannah Bug Tracker #46755
   http://savannah.gnu.org/bugs/?46755

** Also affects: grub via
   http://savannah.gnu.org/bugs/?46755
   Importance: Unknown
   Status: Unknown

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

** Description changed:

  update-grub runs /usr/sbin/grub-probe
  
  /usr/sbin/grub-probe runs ["zpool", "status", poolname]
  
  zpool responds with device names as used at (I think!) pool creation
  time. Often, this is /dev/disk/by-id/... names, without the path.
  
  grub-probe then parses the output, and takes the names of devices, and
  if they do not start with a "/", it prepends "/dev".
  
  It then tests the existence of the path name of the device. it fails.
  
  grub-probe then returns  something like
  
  /usr/sbin/grub-probe: error: failed to get canonical path of `/dev/ata-
  ST31000333AS_-part1'.
+ 
+ The actual path is of course /dev/disk/by-id/ST31000333AS_-part1

** Description changed:

  update-grub runs /usr/sbin/grub-probe
  
  /usr/sbin/grub-probe runs ["zpool", "status", poolname]
  
  zpool responds with device names as used at (I think!) pool creation
  time. Often, this is /dev/disk/by-id/... names, without the path.
  
  grub-probe then parses the output, and takes the names of devices, and
- if they do not start with a "/", it prepends "/dev".
+ if they do not start with a "/", it prepends "/dev/".
  
  It then tests the existence of the path name of the device. it fails.
  
  grub-probe then returns  something like
  
  /usr/sbin/grub-probe: error: failed to get canonical path of `/dev/ata-
  ST31000333AS_-part1'.
  
  The actual path is of course /dev/disk/by-id/ST31000333AS_-part1

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

** Description changed:

  update-grub runs /usr/sbin/grub-probe
  
  /usr/sbin/grub-probe runs ["zpool", "status", poolname]
  
  zpool responds with device names as used at pool creation time. Often,
- this is /dev/disk/by-id/... names.
+ this is /dev/disk/by-id/... names, without the path.
  
  grub-probe then parses the output, and takes the names of devices, and
  if they do not start with a "/", it prepends "/dev".
  
  It then tests the existence of the path name of the device. it fails.
  
  grub-probe then returns  something like
  
  /usr/sbin/grub-probe: error: failed to get canonical path of `/dev/ata-
  ST31000333AS_-part1'.

** Description changed:

  update-grub runs /usr/sbin/grub-probe
  
  /usr/sbin/grub-probe runs ["zpool", "status", poolname]
  
- zpool responds with device names as used at pool creation time. Often,
- this is /dev/disk/by-id/... names, without the path.
+ zpool responds with device names as used at (I think!) pool creation
+ time. Often, this is /dev/disk/by-id/... names, without the path.
  
  grub-probe then parses the output, and takes the names of devices, and
  if they do not start with a "/", it prepends "/dev".
  
  It then tests the existence of the path name of the device. it fails.
  
  grub-probe then returns  something like
  
  /usr/sbin/grub-probe: error: failed to get canonical path of `/dev/ata-
  ST31000333AS_-part1'.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

Bug confirmed here:

https://github.com/zfsonlinux/grub/issues/5

and step 2 of

https://github.com/zfsonlinux/pkg-zfs/wiki/HOWTO-install-Ubuntu-14.04---
15.04-to-a-Native-ZFS-Root-Filesystem

which advocates some craziness with udev to copy /dev/disk/by-id/ names
to /dev/ .

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

Attached is debdiff. Important change is in grub-
core/osdep/unix/getroot.c, function
grub_util_find_root_devices_from_poolname


+--- a/grub-core/osdep/unix/getroot.c
 b/grub-core/osdep/unix/getroot.c
+@@ -305,8 +305,18 @@ grub_util_find_root_devices_from_poolnam
+ }
+   if (name[0] == '/')
+ devices[ndevices++] = xstrdup (name);
+-  else
+-devices[ndevices++] = xasprintf ("/dev/%s", name);
++  else {
++const char *middles[] = { "disk/by-id/", "disk/by-uuid/", 
"disk/by-partuuid/", "disk/by-label/", "disk/by-partlabel/", "disk/by-path/", 
"/", NULL };
++
++for (const char **cursor = middles; *cursor != NULL; cursor++) {
++  char *proposed = xasprintf ("/dev/%s/%s", *cursor, name);
++  struct stat stt;
++  if (lstat (proposed, ) == 0) {
++devices[ndevices++] = proposed;
++break;
++  }
++}
++  }
+ }
+   break;
+ }


** Attachment added: "xenial debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+attachment/4537081/+files/diff

** Changed in: grub2 (Ubuntu)
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Chad Miller]

Rationale for the order is that it should go in most unique to least
unique order. Use device model and serial , then uuid, then human names,
then assigned numbers.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

[Mathew Hodson]

** Changed in: grub2 (Ubuntu)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1527727/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs