Public bug reported: tst_orientation does not test that settings are actually effective, because there is a QSKIP in there that skips the useful tests. It is only tested that there are no warnings when initializing OrientationHelper.
The test that follows the QSKIP is not valid because contentOrientation (enum) is compared with orientationAngle (degrees). So that will fail when QSKIP is removed. We need a proper test for the effectiveness of the OrientationHelper, if we still use the OrientationHelper. ** Affects: ubuntu-ui-toolkit (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1626063 Title: OrientationHelper tests are useless To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1626063/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs