[Bug 1632047] Re: DistUpgradeViewNonInteractive except hook hides the traceback
This bug was fixed in the package ubuntu-release-upgrader - 1:16.04.17 --- ubuntu-release-upgrader (1:16.04.17) xenial; urgency=medium * DistUpgradeViewNonInteractive.py: When handling an exception also log what the traceback causing the exception was. (LP: #1632047) -- Brian Murray Mon, 10 Oct 2016 11:41:01 -0700 ** Changed in: ubuntu-release-upgrader (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1632047 Title: DistUpgradeViewNonInteractive except hook hides the traceback To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1632047/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1632047] Re: DistUpgradeViewNonInteractive except hook hides the traceback
I tested an upgrade from Trusty to Xenial using the upgrader tarball from -proposed, version 16.04.17, with DistUpgradeViewNonInteractive and can confirm that there were no regressions. Subsequently, I'm going to mark this as verification-done. ** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1632047 Title: DistUpgradeViewNonInteractive except hook hides the traceback To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1632047/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1632047] Re: DistUpgradeViewNonInteractive except hook hides the traceback
** Tags removed: verification-failed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1632047 Title: DistUpgradeViewNonInteractive except hook hides the traceback To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1632047/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1632047] Re: DistUpgradeViewNonInteractive except hook hides the traceback
** Tags removed: verification-failed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1632047 Title: DistUpgradeViewNonInteractive except hook hides the traceback To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1632047/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1632047] Re: DistUpgradeViewNonInteractive except hook hides the traceback
On Thu, Oct 13, 2016 at 06:04:16PM -, Meenesh Kapadia wrote: > Regarding comment #2: This affects Trusty to Xenial updates, is there > going to be a fix for Trusty as well? There doesn't need to be because the release upgrade process downloads a tarball of ubuntu-release-upgrader for the release which you are going to upgrade to, in this example Xenial. -- Brian Murray -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1632047 Title: DistUpgradeViewNonInteractive except hook hides the traceback To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1632047/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1632047] Re: DistUpgradeViewNonInteractive except hook hides the traceback
Regarding comment #2: This affects Trusty to Xenial updates, is there going to be a fix for Trusty as well? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1632047 Title: DistUpgradeViewNonInteractive except hook hides the traceback To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1632047/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1632047] Re: DistUpgradeViewNonInteractive except hook hides the traceback
Hello Brian, or anyone else affected, Accepted ubuntu-release-upgrader into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source /ubuntu-release-upgrader/1:16.04.17 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: ubuntu-release-upgrader (Ubuntu Xenial) Status: In Progress => Fix Committed ** Tags added: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1632047 Title: DistUpgradeViewNonInteractive except hook hides the traceback To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1632047/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1632047] Re: DistUpgradeViewNonInteractive except hook hides the traceback
** Changed in: ubuntu-release-upgrader (Ubuntu Xenial) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1632047 Title: DistUpgradeViewNonInteractive except hook hides the traceback To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1632047/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1632047] Re: DistUpgradeViewNonInteractive except hook hides the traceback
This bug was fixed in the package ubuntu-release-upgrader - 1:16.10.6 --- ubuntu-release-upgrader (1:16.10.6) yakkety; urgency=medium * DistUpgradeViewNonInteractive.py: When handling an exception also log what the traceback causing the exception was. (LP: #1632047) -- Brian Murray Mon, 10 Oct 2016 11:05:13 -0700 ** Changed in: ubuntu-release-upgrader (Ubuntu Yakkety) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1632047 Title: DistUpgradeViewNonInteractive except hook hides the traceback To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1632047/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1632047] Re: DistUpgradeViewNonInteractive except hook hides the traceback
** Description changed:
+ Test Case
+ -
+ This is a pretty obvious fix to just log more information when there is a
crash.
+
+ Regression Potential
+
+ Little as we are just logging more information.
+
The non-interactive version of the dist upgrade process has its own
special except hook handler, but that handler ends up hiding the
traceback. This should be fixed so that we have more details about why
the upgrade failed. Here's the code in question:
249 class DistUpgradeViewNonInteractive(DistUpgradeView):
250 " non-interactive version of the upgrade view "
251 def __init__(self, datadir=None, logdir=None):
252 DistUpgradeView.__init__(self)
253 self.config = DistUpgradeConfig(".")
254 self._acquireProgress = NonInteractiveAcquireProgress()
255 self._installProgress = NonInteractiveInstallProgress(logdir)
256 self._opProgress = apt.progress.base.OpProgress()
257 sys.__excepthook__ = self.excepthook
258 def excepthook(self, type, value, traceback):
259 " on uncaught exceptions -> print error and reboot "
260 logging.exception("got exception '%s': %s " % (type, value))
261 #sys.excepthook(type, value, traceback)
262 self.confirmRestart()
Notice nothing is done with traceback in line 260.
** Also affects: ubuntu-release-upgrader (Ubuntu Xenial)
Importance: Undecided
Status: New
** Changed in: ubuntu-release-upgrader (Ubuntu Xenial)
Status: New => Triaged
** Changed in: ubuntu-release-upgrader (Ubuntu Xenial)
Importance: Undecided => Medium
** Changed in: ubuntu-release-upgrader (Ubuntu Xenial)
Assignee: (unassigned) => Brian Murray (brian-murray)
** Changed in: ubuntu-release-upgrader (Ubuntu Yakkety)
Status: Triaged => In Progress
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1632047
Title:
DistUpgradeViewNonInteractive except hook hides the traceback
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1632047/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1632047] Re: DistUpgradeViewNonInteractive except hook hides the traceback
** Branch linked: lp:ubuntu-release-upgrader -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1632047 Title: DistUpgradeViewNonInteractive except hook hides the traceback To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1632047/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1632047] Re: DistUpgradeViewNonInteractive except hook hides the traceback
Actually only to Xenial since we aren't testing upgrades from Precise to Trusty. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1632047 Title: DistUpgradeViewNonInteractive except hook hides the traceback To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1632047/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1632047] Re: DistUpgradeViewNonInteractive except hook hides the traceback
This should be SRU'ed to Trusty and Xenial for automatic upgrade testing. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1632047 Title: DistUpgradeViewNonInteractive except hook hides the traceback To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1632047/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
