[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
Did some major cleanup of this bug. Debdiffs attached for review. In general, the primary change for the backport was to modify the package to build against Python 2 instead of Python 3; one code change was needed in certbot to disable API documentation as the necessary sphinx module is not available. We're still sorting out the letsencrypt compat shims but I wanted to get these debdiffs reviewed as they are final or very close to. ** No longer affects: python-acme (Ubuntu Yakkety) ** No longer affects: python-acme (Ubuntu Zesty) ** Changed in: python-acme (Ubuntu Xenial) Status: Fix Committed => In Progress ** Changed in: python-acme (Ubuntu Xenial) Assignee: (unassigned) => Michael Casadevall (mcasadevall) ** No longer affects: python-certbot (Ubuntu Yakkety) ** No longer affects: python-certbot (Ubuntu Zesty) ** Changed in: python-certbot (Ubuntu Xenial) Status: Fix Committed => In Progress ** Changed in: python-certbot (Ubuntu Xenial) Assignee: (unassigned) => Michael Casadevall (mcasadevall) ** No longer affects: python-certbot-apache (Ubuntu Yakkety) ** No longer affects: python-certbot-apache (Ubuntu Zesty) ** Changed in: python-certbot-apache (Ubuntu Xenial) Status: Fix Committed => In Progress ** Changed in: python-certbot-apache (Ubuntu Xenial) Assignee: (unassigned) => Michael Casadevall (mcasadevall) ** No longer affects: python-certbot-nginx (Ubuntu Yakkety) ** No longer affects: python-certbot-nginx (Ubuntu Zesty) ** Changed in: python-certbot-nginx (Ubuntu Xenial) Assignee: (unassigned) => Michael Casadevall (mcasadevall) ** Changed in: python-certbot-nginx (Ubuntu Xenial) Importance: Undecided => High ** Changed in: python-certbot-nginx (Ubuntu Xenial) Milestone: None => xenial-updates ** Changed in: python-certbot-nginx (Ubuntu Xenial) Status: Fix Committed => In Progress ** Changed in: python-letsencrypt (Ubuntu Xenial) Importance: Undecided => High ** Changed in: python-letsencrypt (Ubuntu Xenial) Milestone: None => xenial-updates ** Changed in: python-letsencrypt (Ubuntu Xenial) Assignee: (unassigned) => Michael Casadevall (mcasadevall) ** Changed in: python-letsencrypt (Ubuntu Xenial) Status: Fix Committed => In Progress ** Changed in: python-letsencrypt-apache (Ubuntu Xenial) Importance: Undecided => High ** Changed in: python-letsencrypt-apache (Ubuntu Xenial) Status: Fix Committed => In Progress ** Changed in: python-letsencrypt-apache (Ubuntu Xenial) Milestone: None => xenial-updates ** Changed in: python-certbot-apache (Ubuntu Xenial) Importance: Undecided => High ** Changed in: python-certbot (Ubuntu Xenial) Importance: Undecided => High ** Changed in: python-acme (Ubuntu Xenial) Importance: Undecided => High ** Summary changed: - [SRU] Backport letsencrypt 0.14.2 + [SRU] Backport letsencrypt from bionic ** Tags removed: verification-needed-zesty ** Patch added: "python-acme.debdiff" https://bugs.launchpad.net/ubuntu/xenial/+source/python-acme/+bug/1640978/+attachment/5220643/+files/python-acme.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt from bionic To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
** Tags added: upgrade-software-version -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
Unless we want this package to suddenly break for approximately 10,000 users in February, I think we probably want to do an SRU to Certbot version 0.21.1 or higher. I wrote more about the problem in the relevant issue at https://bugs.launchpad.net/ubuntu/+source/python- letsencrypt/+bug/1745126. While we may not want to do regular SRUs for Certbot due to the amount of work involved, I think it probably makes sense to do one now due to breaking changes server side. Please let me know if there's anything I can do on my end to help get this resolved. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
FYI pushed some backporting from bionic to xenial without touching existing Python dependencies: https://launchpad.net/~kraut.hosting/+archive/ubuntu/certbot/+packages Would recommend to rebase this SRU effort on the packages we have in bionic now anyway. So far my push does only cover Certbot it self but not all the plugins and integrations. Feedback on this effort is welcome and i am open for some more polishing ;) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
This is still a valid issue for everyone want to do a proper QA chain in software delivery. Both the recent Snap package from Robie as the certbot PPA by our Debian heroes have the problem on different install times you have different versions installed. On a big bunch of boxes this gives us the pain ensuring QA of new versions before roll out to production. Doing cheap cherry picking from the certbot PPA in the past i just gave the packages from proposed a rebuilt try. Could at first not reproduce the build failure in my pbuilder chain of crap with the rebuilt order of python-letsencrypt, python-acme, python- certbot. But when rebuilding python-letsencrypt then with python- acme_0.14.2-0ubuntu0.16.04.1 as an Build-Depends (without an updated version require) i hit it as well: dh_auto_test -O--buildsystem=pybuild I: pybuild base:184: python2.7 setup.py test running test Searching for acme==0.4.1 Note: Bypassing https://pypi.python.org/simple/acme/ (disallowed host; see http://bit.ly/1dg9ijs for details). Couldn't find index page for 'acme' (maybe misspelled?) Scanning index of all packages (this may take a while) Note: Bypassing https://pypi.python.org/simple/ (disallowed host; see http://bit.ly/1dg9ijs for details). No local packages or download links found for acme==0.4.1 error: Could not find suitable distribution for Requirement.parse('acme==0.4.1') E: pybuild pybuild:274: test: plugin distutils failed with: exit code=1: python2.7 setup.py test dh_auto_test: pybuild --test -i python{version} -p 2.7 --dir . returned exit code 13 debian/rules:8: recipe for target 'build' failed make: *** [build] Error 25 Just like in: https://launchpadlibrarian.net/335455860/buildlog_ubuntu- xenial-amd64.python-letsencrypt_0.4.1-1ubuntu0.16.04.1_BUILDING.txt.gz Unfortunately i am not too deep into Python here for fixing the fix easily. But as this build failure is the blocker for an SRU i hope someone of the involved rock stars here might figured out easy how to fix it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
I agree it would be a shame, but we need someone to sort out the build failures and make sure the packages are in proper shape. Robie, since you were the original backporter, would you be able to drive this forward? The point release is nearing and I'd prefer not to have stale packages in -proposed that I don't intend to release for the point- release. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
As a developer of letsencrypt/certbot, it'll be pretty disappointing to us if we can't some kind of update here. In addition to the many bugs listed in the original description that would be fixed by this SRU, the python-letsencrypt-apache package has been unable to obtain new certificates since January due to https://bugs.launchpad.net/ubuntu/+source/python-certbot/+bug/1745227. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
Please someone look into the build failures in the nearest days. If there will be no movement on these packages I will be removing them from xenial-proposed and marking the bug as Won't Fix (as per SRU policy). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
Oh, I see the Xenial update was blocked by build failures. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
Should this update just be let into Xenial now? Someone needs to start yet another backport of certbot for LP: #1745227. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
While I didn't look any more into the build failure for the letsencrypt package (let me know if you'd like me to), I added a check to https://wiki.ubuntu.com/StableReleaseUpdates/Certbot/TestScript testing that a symlink is properly created in the user's PATH. The test passes on the letsencrypt package in xenial-proposed. Also after talking to racb in IRC last week, I think we should include a python-letsencrypt package in Xenial similar to the one we have at https://pypi.python.org/pypi/letsencrypt. This allows other Python code to continue to import Certbot through the name letsencrypt. While the majority of letsencrypt/certbot's internals do not have stable interfaces for other packages to use, there is a plugin interface, base classes, and utilities that are used by Certbot's third party plugins listed at https://certbot.eff.org/docs/using.html#third-party-plugins. Doing this for python-letsencrypt-apache might also be a good idea so users can continue to install Certbot and our Apache plugin through this package name. This could also allow Python code to import the plugin through the name "letsencrypt_apache", however, the plugin is not expected to be used this way by third parties. If we do this for the Apache plugin as well, our Python wrapper is available at https://pypi.python.org/pypi/letsencrypt-apache. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
Thanks for approving the binary. Tests passed for the proposed Xenial packages using https://wiki.ubuntu.com/StableReleaseUpdates/Certbot/TestScript. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
Unfortunately the test script at https://wiki.ubuntu.com/StableReleaseUpdates/Certbot/TestScript cannot be used to test the Xenial packages yet because the python-certbot-nginx binary still needs to be accepted. See https://launchpad.net/ubuntu/xenial/+queue. Is someone able to approve this binary? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
** No longer affects: python-letsencrypt (Ubuntu Yakkety) ** No longer affects: python-letsencrypt (Ubuntu) ** No longer affects: python-letsencrypt-apache (Ubuntu) ** No longer affects: python-letsencrypt-apache (Ubuntu Yakkety) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
Hello Peter, or anyone else affected, Accepted python-letsencrypt into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/python- letsencrypt/0.4.1-1ubuntu0.16.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: python-letsencrypt (Ubuntu Xenial) Status: In Progress => Fix Committed ** Changed in: python-letsencrypt-apache (Ubuntu Xenial) Status: Invalid => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
Hello Peter, or anyone else affected, Accepted python-certbot-apache into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source /python-certbot-apache/0.14.2-0ubuntu0.16.04.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: python-certbot-apache (Ubuntu Xenial) Status: In Progress => Fix Committed ** Changed in: python-certbot (Ubuntu Xenial) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
Hi Peter, Robie is on leave the next few days, but here's what I know: 1) As far as I can tell all the packages we expect to see in Zesty are in zesty-proposed now. They bake for at least a week there. Someone needs to go through the testing of the packages from proposed and update the metadata in this bug (see any of the messages from Brian Murray on August 10). 2) https://launchpad.net/ubuntu/xenial/+queue indicates the packages we expect to see in Xenial (as noted by Brian in c#69) are in the NEW queue. I am not sure if the SRU team can accept those themselves, or if an AA is needed. @brian-murray, if you need me to ask an AA to help here, please let me know. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
What are next steps here? Is the Zesty SRU ready to go? Does Robie (or someone else) need to make a python-certbot package for Xenial? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
I just successfully ran the test script I provided earlier on the proposed Ubuntu Zesty packages. I had to make a couple modifications to properly install the packages from the proposed archive. An updated version of the script is attached. ** Attachment added: "ubuntu-test.sh" https://bugs.launchpad.net/ubuntu/+source/python-letsencrypt/+bug/1640978/+attachment/4930959/+files/ubuntu-test.sh -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1640978] Re: [SRU] Backport letsencrypt 0.14.2
I don't see an upload of the python-certbot package in the -proposed queue for Xenial, am I missing something? +python-letsencrypt (0.4.1-1ubuntu0.16.04.1) xenial; urgency=medium + + * Drop letsencrypt binary package; this is now produced by the +python-certbot package (LP: #1640978) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1640978 Title: [SRU] Backport letsencrypt 0.14.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/python-acme/+bug/1640978/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs