[Bug 1669578] Re: Get ttyname() to work properly in containers

@Jose Manuel Santamaria Lema (panfaust) can you please send the patch upstream so they integrate it in a new release? We don't get emails for bugs that are closed, and I don't understand the need of an Ubuntu only patch. I can sponsor once you report and get it acked by upstream. G. -- You

[Bug 1669578] Re: Get ttyname() to work properly in containers

Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: multitail (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title:

[Bug 1669578] Re: Get ttyname() to work properly in containers

Here's a possible fix. I tested it on bionic and it seems it works. For my xenial machines I had to workaround it disabling completely the check because the glibc there doesn't behave the same way. So I'm attaching a debdiff with the proposed upload for bionic; it would be nice if someone could

[Bug 1669578] Re: Get ttyname() to work properly in containers

Hello, I got this problem also in multitail but I think I know how to patch it. I will attach the debdiff as soon as I can test it properly. ** Also affects: multitail (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu

[Bug 1669578] Re: Get ttyname() to work properly in containers

Wohoo, great job gentleman. :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers To manage notifications about this bug go to:

[Bug 1669578] Re: Get ttyname() to work properly in containers

So the screen testsuite I wrote 2.5 years ago actually found a bug? Cool! :-) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers To manage

[Bug 1669578] Re: Get ttyname() to work properly in containers

yeah :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers To manage notifications about this bug go to:

[Bug 1669578] Re: Get ttyname() to work properly in containers

This bug was fixed in the package screen - 4.5.1-3ubuntu2 --- screen (4.5.1-3ubuntu2) artful; urgency=medium [ Christian Brauner ] * debian/patches/0001-screen-don-t-stat.patch: - fix testsuite error when tty is "" -- Gianfranco Costamagna Wed,

[Bug 1669578] Re: Get ttyname() to work properly in containers

lets see if now this bug gets closed :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers To manage notifications about this bug go to:

[Bug 1669578] Re: Get ttyname() to work properly in containers

Patch send to upstream as well. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers To manage notifications about this bug go to:

[Bug 1669578] Re: Get ttyname() to work properly in containers

@LocutusOfBorg, the patch I appended is applicable directly to the deb source used in the package. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in

[Bug 1669578] Re: Get ttyname() to work properly in containers

@LocutusOfBorg, thanks for taking a close look at this. Found the bug. I'm appending a patch that fixes it and makes the autopkgtestsuite pass for me! ** Patch added: "0001-screen-don-t-stat.patch"

[Bug 1669578] Re: Get ttyname() to work properly in containers

I did get the same result (pbuilder artful clean environment) I also did try to reproduce autopkgtestsuite in an lxc container and the test has failed sudo autopkgtest-build-lxc ubuntu artful autopkgtest --shell-fail --apt-upgrade screen_4.5.1-3ubuntu1.dsc -- lxc --sudo autopkgtest-artful the

[Bug 1669578] Re: Get ttyname() to work properly in containers

Hm, the test all pass locally for me So I downloaded the package https://launchpad.net/ubuntu/+archive/primary/+files/screen_4.5.1-3ubuntu1_amd64.deb from the proposed https://launchpad.net/ubuntu/+source/screen repo and ran the tests locally and get: chb@conventiont|~/mnt/C/screen-debian >

[Bug 1669578] Re: Get ttyname() to work properly in containers

@LocutusOfBorg, thanks for sponsoring I'm looking into it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers To manage notifications about

[Bug 1669578] Re: Get ttyname() to work properly in containers

@Christian, I sponsored it, but it fails the testsuite http://autopkgtest.ubuntu.com/packages/screen -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in

Re: [Bug 1669578] Re: Get ttyname() to work properly in containers

On Fri, May 05, 2017 at 05:04:18PM -, LocutusOfBorg wrote: > >If you're referring to screen . The screen version right now with my > >compat-layer patch applied > >should be fully backwards compatible. > > so, you mean, it didn't work before and still doesn't work with older > glibc? TL;DR:

[Bug 1669578] Re: Get ttyname() to work properly in containers

>If you're referring to screen . The screen version right now with my >compat-layer patch applied >should be fully backwards compatible. so, you mean, it didn't work before and still doesn't work with older glibc? -- You received this bug notification because you are a member of Ubuntu Bugs,

Re: [Bug 1669578] Re: Get ttyname() to work properly in containers

On Fri, May 5, 2017 at 4:57 PM, LocutusOfBorg wrote: > I don't think we should upload without having retro-compatibility with > older and still supported Ubuntu releases. What are you referring to now? The glibc patch? That doesn't break anything otherwise glibc

[Bug 1669578] Re: Get ttyname() to work properly in containers

I don't think we should upload without having retro-compatibility with older and still supported Ubuntu releases. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work

Re: [Bug 1669578] Re: Get ttyname() to work properly in containers

On Fri, May 5, 2017 at 1:34 PM, Christian Brauner wrote: > On Fri, May 5, 2017 at 12:40 PM, Christian Brauner > wrote: >> This version of screen doesn't work in containers for me anymore. > > @LocutusOfBorg, nevermind I tested

Re: [Bug 1669578] Re: Get ttyname() to work properly in containers

On Fri, May 5, 2017 at 12:40 PM, Christian Brauner wrote: > This version of screen doesn't work in containers for me anymore. @LocutusOfBorg, nevermind I tested this on Xenial which doesn't seem to come with a version of glibc the path that Serge and I wrote. The

Re: [Bug 1669578] Re: Get ttyname() to work properly in containers

This version of screen doesn't work in containers for me anymore. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers To manage notifications

[Bug 1669578] Re: Get ttyname() to work properly in containers

I had to tweak the upstream commits, because they weren't applying on top of Debian changes, and uploaded the following in my ppa. https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/locutusofborg-ppa/+sourcepub/7773744/+listing-archive-extra can you please test it? ** Patch added:

[Bug 1669578] Re: Get ttyname() to work properly in containers

@LocutusOfBorg, can you please tell me exactly what you need? From looking at git clone https://anonscm.debian.org/git/collab-maint/screen.git git checkout debian/4.5.1-3 none of the patches that I've pushed upstream are available in this repo. For this to work you'd need: 1. commit

[Bug 1669578] Re: Get ttyname() to work properly in containers

@LocutusOfBorg, I can give you a screen 4-5.1-3 compatible patch based on the Debian package. One thing to note is that even my compat-layer patch will be of no help once {Debian,Ubuntu} breaks the message protocol which they eventually *will* have to do. Upstream screen uses at least message

[Bug 1669578] Re: Get ttyname() to work properly in containers

@cbrauner, do you have a patch that needs sponsoring? We are discussing merging 4.5.1-3 from Debian experimental, but your patch can't apply e.g. we have no tty.c and tty.h in our packaging. Feel free to upload in a ppa or a patch here and I'll look/sponsor it (anybody is free to steal the

[Bug 1669578] Re: Get ttyname() to work properly in containers

I sent a patch to musl upstream to align them with glibc. The patch is merged: https://git.musl- libc.org/cgit/musl/commit/?id=e1232f5b5185e8f337806841018369407e32e77d . ** Also affects: musl (Ubuntu) Importance: Undecided Status: New ** No longer affects: musl (Ubuntu) -- You

[Bug 1669578] Re: Get ttyname() to work properly in containers

An upstream-compatible version of 0001-add-compat-layer-to-handle-both- fifos-and-sockets.patch is now merged upstream into screen v4. See https://lists.gnu.org/archive/html/screen-devel/2017-04/msg00023.html . -- You received this bug notification because you are a member of Ubuntu Bugs, which

[Bug 1669578] Re: Get ttyname() to work properly in containers

This bug was fixed in the package glibc - 2.24-9ubuntu2 --- glibc (2.24-9ubuntu2) zesty; urgency=medium * debian/patches/any/cvs-resolv-internal-qtype.diff: Revert to avoid failure in name resolution on upgrades from yakkety (LP: #1674532) -- Adam Conrad

[Bug 1669578] Re: Get ttyname() to work properly in containers

Updated version of fifo-socket-compat patch that removes left-behind debugging statement. ** Patch added: "0001-add-compat-layer-to-handle-both-fifos-and-sockets.patch"

[Bug 1669578] Re: Get ttyname() to work properly in containers

I tested the screen-fifo-socket compatibility patch here https://asciinema.org/a/111692 . -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers

[Bug 1669578] Re: Get ttyname() to work properly in containers

So, Stéphane brought to my attention that we're not including the patch because it switches screen to use sockets instead of fifos and thus makes it impossible to switch to existing fifo-based screen sessions. I've written a patch that adds a compatibility layer to support both fifo-based and

[Bug 1669578] Re: Get ttyname() to work properly in containers

The screen patch is now also upstream http://git.savannah.gnu.org/cgit/screen.git/commit/?id=565b8901cad828d921038cd6235501c42d1c9a32 . @stgraber, did you get around to pushing to to the archive as well so that we can land this in zesty? ** Changed in: screen (Ubuntu) Status: In Progress

[Bug 1669578] Re: Get ttyname() to work properly in containers

The tmux patch is now also upstream. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers To manage notifications about this bug go to:

[Bug 1669578] Re: Get ttyname() to work properly in containers

Since the Ubuntu screen package was synced with Debian yesterday the attached patch does not apply cleanly anymore. So here's a new version of it that also is much closer to what I've pushed upstream. ** Patch added: "0001-screen-handle-pts-devices-in-different-namespaces.patch"

[Bug 1669578] Re: Get ttyname() to work properly in containers

** Changed in: tmux (Ubuntu) Status: In Progress => Fix Released ** Changed in: screen (Ubuntu) Status: Fix Released => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578

[Bug 1669578] Re: Get ttyname() to work properly in containers

This bug was fixed in the package screen - 4.5.0-5ubuntu1 --- screen (4.5.0-5ubuntu1) zesty; urgency=low * Merge from Debian unstable. Remaining changes: - 83_handle_pty_device_namespace.patch (LP: #1669578) -- Gianfranco Costamagna Tue, 04 Apr

[Bug 1669578] Re: Get ttyname() to work properly in containers

Here's a patch for the current tmux version of Ubuntu. We should get this sorted before this Thursday. ** Patch added: "0001-handle-pty-devices-in-different-namespaces.patch"

[Bug 1669578] Re: Get ttyname() to work properly in containers

About the tmux patch. Nicholas plans to merge a patch that is nearly identical into tmux master sometime next week but this might be too late for final freeze. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1669578] Re: Get ttyname() to work properly in containers

** Changed in: tmux (Ubuntu) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers To manage notifications

[Bug 1669578] Re: Get ttyname() to work properly in containers

Here's an updated version of the patch and a comment explaining in a little more detail what is happening: Subject: [PATCH] screen: handle pts devices in different namespaces Various programs that deal with namespaces will use pty devices that exist in another namespace. One obvious candiate are

Re: [Bug 1669578] Re: Get ttyname() to work properly in containers

I'll likely add another patch to this soon to handle some more corner- cases. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers To manage

[Bug 1669578] Re: Get ttyname() to work properly in containers

Here's a patch for screen that got things working for me. I've tested screen startup and various ways of attach (screen -r, screen -rx, and screen -rxD). Would be nice if people are able to test this. So if we could get it into proposed that be +1. The patch in its current form is directly

[Bug 1669578] Re: Get ttyname() to work properly in containers

So aside from the Ubuntu package being outdated (The codebase has indeed changed massively.) the patch we need to get screen working properly is way more intrusive then originally thought and there might even be the case that we have to do some additional lower-level plumbing in the kernel or

Re: [Bug 1669578] Re: Get ttyname() to work properly in containers

Hi Michael, Michael Sparmann wrote: > That ifndef has been removed from upstream code in > http://git.savannah.gnu.org/cgit/screen.git/commit/?id=d965ff1d92e2bd57d24b68cfbd6990486024baa3 > almost 2 years ago, but that apparently hasn't landed in the ubuntu > package yet. That commit is only

[Bug 1669578] Re: Get ttyname() to work properly in containers

The fix does not seem to work, it just changes the error message to "Cannot open your terminal '' - please check." for me. The reason seems to be that the patch relies on attach_fd to be set by code that's inside an ifndef NAMEDPIPE block, which isn't being compiled for the ubuntu package. That

[Bug 1669578] Re: Get ttyname() to work properly in containers

This bug was fixed in the package screen - 4.5.0-3ubuntu1 --- screen (4.5.0-3ubuntu1) zesty; urgency=medium * Cherry-pick bugfix for screen in containers: - 83_handle_pty_device_namespace.patch (LP: #1669578) -- Stéphane Graber Fri, 24 Mar 2017 14:35:41

[Bug 1669578] Re: Get ttyname() to work properly in containers

** Changed in: screen (Ubuntu) Assignee: Christian Brauner (cbrauner) => Stéphane Graber (stgraber) ** Changed in: screen (Ubuntu) Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1669578] Re: Get ttyname() to work properly in containers

** Changed in: screen (Ubuntu) Status: Fix Committed => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers To manage

[Bug 1669578] Re: Get ttyname() to work properly in containers

Fix for screen merged upstream: https://lists.gnu.org/archive/html/screen-devel/2017-03/msg00014.html -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in

[Bug 1669578] Re: Get ttyname() to work properly in containers

** Changed in: screen (Ubuntu) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers To manage

[Bug 1669578] Re: Get ttyname() to work properly in containers

Upstream screen patch: https://lists.gnu.org/archive/html/screen-devel/2017-03/msg00013.html ** Changed in: screen (Ubuntu) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1669578] Re: Get ttyname() to work properly in containers

** Changed in: glibc (Ubuntu) Status: Triaged => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers To manage

[Bug 1669578] Re: Get ttyname() to work properly in containers

Adam will take care of doing an upload for Ubuntu 17.04 with 5e9a4f378c8607c2ae1aa465436af4321db0e23 included. ** Changed in: glibc (Ubuntu) Assignee: (unassigned) => Adam Conrad (adconrad) ** Also affects: screen (Ubuntu) Importance: Undecided Status: New ** Also affects: tmux

[Bug 1669578] Re: Get ttyname() to work properly in containers

And my team will take care of distro patching screen and tmux to work with this. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers To manage

[Bug 1669578] Re: Get ttyname() to work properly in containers

After discussing this on IRC with Adam, Ubuntu will only include the upstreamed patch and we'll instead resort on patching all affected downstream pieces of software to deal with the unfortunate new glibc behavior. -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 1669578] Re: Get ttyname() to work properly in containers

** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578 Title: Get ttyname() to work properly in containers To manage notifications about this bug go to:

[Bug 1669578] Re: Get ttyname() to work properly in containers

stgraber@dakara:~$ lxc exec zesty bash root@zesty:~# tmux lost server root@zesty:~# tty not a tty root@zesty:~# echo $? 0 root@zesty:~# dpkg -i *.deb (Reading database ... 26464 files and directories currently installed.) Preparing to unpack libc-bin_2.24-7ubuntu3_amd64.deb ... Unpacking libc-bin

[Bug 1669578] Re: Get ttyname() to work properly in containers

** Attachment added: "debdiff" https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1669578/+attachment/4830204/+files/debdiff ** Changed in: glibc (Ubuntu) Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1669578] Re: Get ttyname() to work properly in containers

For screen, we'll need to fix their own checking logic a bit but we'll work on that patch and send it upstream (and have it also deal with just getting ENODEV while we're at it). With the fixed glibc screen reports "Bad tty '/proc/self/fd/0'" because of it trying to readlink the path it's

[Bug 1669578] Re: Get ttyname() to work properly in containers

I'm building a patched glibc now with the two patches we'd like included in Ubuntu. Once that's built and tested, I'll attach the debdiff. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1669578

[Bug 1669578] Re: Get ttyname() to work properly in containers

Upstream threads: https://sourceware.org/cgi- bin/search.cgi?q=ttyname+and+ttyname_r=Search%21=extended=all=10=long=wrd=1=1=2221==no=%2Fml %2Flibc-alpha%2F%25 We've been getting about a report a week about things failing due to this bug so we really need it sorted this time (most reports are for