[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2020-05-24 Thread Daniel van Vugt
I would like to continue working on this bug but it's just not a priority right now. ** Tags added: focal groovy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1691678 Title: Scrollbars escape the

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2020-05-23 Thread Mohammad Anwar Shah
What is the current status of this bug? Can we have any workaround for this bug? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1691678 Title: Scrollbars escape the bottom and right side of the

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2020-03-19 Thread Daniel van Vugt
Actually the proper solution to comment #28 would be to change to overlay scrollbars, which is already covered by bug 1451924. It's still a different bug to this one, but if implemented it would close this bug nicely. If we just wanted to work on this bug without doing bug 1451924 then that would

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2020-03-12 Thread Daniel van Vugt
Possibly the pixels under the scrollbar are being painted as white before the scrollbar itself gets painted. So any transparency in the theme won't come out right, but is still technically transparent. -- You received this bug notification because you are a member of Ubuntu Bugs, which is

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2020-03-06 Thread Daniel van Vugt
I don't think that's necessary and probably not helpful. There are already multiple moving parts here so it would be easier to deal with if the theme was not changed simultaneously. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2020-03-06 Thread Carlo Lobrano
Hi Daniel, do you think that removing Yaru's style would have a positive impact on this issue or it would be useless? The slice of css you reported comes from a file containing specific style for applications that can be dropped easily if not necessary (and even more easily if harmful) -- You

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2020-03-06 Thread Daniel van Vugt
I'm not familiar with gnome-terminal and not much with CSS, but I have decided to dig into this bug and see what's happening. My first finding is that yes we should just drop the 'scrollbar- background-theming.patch' from gnome-terminal and fix the theme. So I made that change to

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2020-03-06 Thread Daniel van Vugt
** Changed in: gtk+3.0 (Ubuntu) Status: Confirmed => Invalid ** Changed in: ubuntu-themes (Ubuntu) Status: Confirmed => Invalid ** No longer affects: gtk+3.0 (Ubuntu) ** No longer affects: ubuntu-themes (Ubuntu) ** Changed in: gnome-terminal (Ubuntu) Status: Confirmed =>

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2020-03-06 Thread Egmont Koblinger
> but dropping the change creates a regression on the Ubuntu session/theme So the situation is: Unpatched gnome-terminal looks perfect on the default GTK theme and on many others, except Ubuntu's. Conclusion: Let's patch gnome-terminal! Wow. I'm wondering: Has anyone considered fixing the

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2020-03-05 Thread Sebastien Bacher
The issue is due to the patch scrollbar-background-theming.patch but dropping the change creates a regression on the Ubuntu session/theme which is what most users will see. It would be nice to see the problem resolved by removing the change is not the solution -- You received this bug

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2020-03-04 Thread Mohammad Anwar Shah
I support the idea in the last para. of @egmont-gmail. If a patch introduce a regression which is worse than the improvement made by the patch, the patch should be dropped. I'm getting tired of Ubuntu fixing something and breaking some other things. Ubuntu LTS was rock solid once upon a time, but

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2020-03-04 Thread Mohammad Anwar Shah
It's not an upstream bug. I checked several other distribution with different themes, none of them is affected. Only Ubuntu's gnome-terminal is affected. I don't understand why this simple bug is still around after realizing it was reported 3 years ago! I am retrying to home on Ubuntu after

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2020-03-03 Thread Egmont Koblinger
> It appears we would need a new upstream bug to track this because the old one didn't go anywhere. This is not true. The old one did go somewhere: It examined the behavior and clearly concluded that upstream gnome-terminal is NOT buggy here, it never was. It's one of the Ubuntu patches that

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2020-03-03 Thread Daniel van Vugt
It appears we would need a new upstream bug to track this because the old one didn't go anywhere. Please create one in: https://gitlab.gnome.org/GNOME/gnome-terminal/issues or https://gitlab.gnome.org/GNOME/gtk/issues and then tell us the URL. -- You received this bug notification

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2020-03-03 Thread Mohammad Anwar Shah
What's the current status of this bug? Where is the fix? One of my report is made duplicate to this bug but I think this is much older. I'm using 19.10 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2019-10-29 Thread Daniel van Vugt
Still a problem with upstream Adwaita so it would be nice to find a universal solution. ** Tags added: desktop-lts-wishlist -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1691678 Title: Scrollbars

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2019-09-09 Thread Bug Watch Updater
** Changed in: gnome-terminal Status: Unknown => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1691678 Title: Scrollbars escape the bottom and right side of the Terminal window

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2019-09-09 Thread Daniel van Vugt
FYI, there's a workaround hacked into Yaru: https://github.com/ubuntu/yaru/blob/master/gtk/src/light/gtk-3.20/_apps.scss#L174 ** Also affects: yaru-theme (Ubuntu) Importance: Undecided Status: New ** Changed in: yaru-theme (Ubuntu) Status: New => Fix Released ** Changed in:

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2019-05-27 Thread Jean-Christophe Baptiste
upstream bug report confirms that this is a bug in Ubuntu: https://gitlab.gnome.org/GNOME/gnome-terminal/issues/132 ** Bug watch added: gitlab.gnome.org/GNOME/gnome-terminal/issues #132 https://gitlab.gnome.org/GNOME/gnome-terminal/issues/132 -- You received this bug notification because

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2019-05-27 Thread Egmont Koblinger
I confirm the previous suspicion: This is _not_ an upstream bug. Upstream gnome-terminal draws the scrollbar perfectly. This bug is introduced by one of the Ubuntu patches. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2019-04-03 Thread Daniel van Vugt
In 19.04 right now the bug appears with Adwaita but not with Yaru. That doesn't mean it's a theme bug though -- it might be a universal bug and something about the Yaru design is hiding it. ** Tags added: disco ** Changed in: gtk+3.0 (Ubuntu) Importance: Medium => Low -- You received this

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2019-04-03 Thread amano
Adwaita? What about Yaru? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1691678 Title: Scrollbars escape the bottom and right side of the Terminal window by 1px To manage notifications about

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2019-04-03 Thread mbrennwa
This issue is still there in in the current beta of Ubuntu 19.04 (Gnome 3.32 with Adwaita). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1691678 Title: Scrollbars escape the bottom and right side

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2018-09-15 Thread amano
Nope. Not completely sure, sorry. I didn't compile GNOME apps before, so that would probably be a rather heavy task for me ;) I had a quick look at the 3.30.0 source but couldn't even find out which lines were changed by the Debian patch. Aren't the patches included within the source tar? -- You

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2018-09-14 Thread Didier Roche
Are you sure this is due to the above patch, can you try without it? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1691678 Title: Scrollbars escape the bottom and right side of the Terminal window

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2018-09-14 Thread amano
https://4.bp.blogspot.com/-CKw5ikw4WNo/WWo7WrezseI/KC4/CPbs48OQj0A2hMNY5_Ivu6iTaRzClDYMQCLcBGAs/s1600/07%2BGNOME%2BTerminal.jpg This is a gnome-terminal screenshot from Fedora 26. There everything seems ok. Can we drop the Debian patch above to see if that fixes the issue? -- You

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2018-09-14 Thread amano
Is this an upstream issue (does Fedora show that behavior as well?) or the outcome of a Debian patch? There is at least one which is scrollbar related: + Add scrollbar-background-theming.patch: - Draw background under the scrollbar that matches the actual terminal background color.

[Bug 1691678] Re: Scrollbars escape the bottom and right side of the Terminal window by 1px

2018-09-10 Thread Daniel van Vugt
** Summary changed: - Scrollbars escape the bottom and right side of the Terminal window + Scrollbars escape the bottom and right side of the Terminal window by 1px -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.