[Bug 1703662] Re: [MIR] rhythmbox-plugin-alternative-toolbar

2017-08-22 Thread Matthias Klose
Override component to main
rhythmbox-plugin-alternative-toolbar 0.17.4-1 in artful: universe/misc -> main
rhythmbox-plugin-alternative-toolbar 0.17.4-1 in artful amd64: 
universe/misc/optional/100% -> main
rhythmbox-plugin-alternative-toolbar 0.17.4-1 in artful arm64: 
universe/misc/optional/100% -> main
rhythmbox-plugin-alternative-toolbar 0.17.4-1 in artful armhf: 
universe/misc/optional/100% -> main
rhythmbox-plugin-alternative-toolbar 0.17.4-1 in artful i386: 
universe/misc/optional/100% -> main
rhythmbox-plugin-alternative-toolbar 0.17.4-1 in artful ppc64el: 
universe/misc/optional/100% -> main
rhythmbox-plugin-alternative-toolbar 0.17.4-1 in artful s390x: 
universe/misc/optional/100% -> main
7 publications overridden.


** Changed in: rhythmbox-plugin-alternative-toolbar (Ubuntu)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1703662

Title:
  [MIR] rhythmbox-plugin-alternative-toolbar

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/1703662/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1703662] Re: [MIR] rhythmbox-plugin-alternative-toolbar

2017-08-22 Thread Mathieu Trudel-Lapierre
** Changed in: rhythmbox-plugin-alternative-toolbar (Ubuntu)
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1703662

Title:
  [MIR] rhythmbox-plugin-alternative-toolbar

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/1703662/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1703662] Re: [MIR] rhythmbox-plugin-alternative-toolbar

2017-08-22 Thread Matthias Klose
** Changed in: rhythmbox-plugin-alternative-toolbar (Ubuntu)
   Status: Fix Committed => New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1703662

Title:
  [MIR] rhythmbox-plugin-alternative-toolbar

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/1703662/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1703662] Re: [MIR] rhythmbox-plugin-alternative-toolbar

2017-08-21 Thread Sebastien Bacher
** Changed in: rhythmbox-plugin-alternative-toolbar (Ubuntu)
   Status: Fix Released => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1703662

Title:
  [MIR] rhythmbox-plugin-alternative-toolbar

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/1703662/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1703662] Re: [MIR] rhythmbox-plugin-alternative-toolbar

2017-08-10 Thread Launchpad Bug Tracker
This bug was fixed in the package rhythmbox - 3.4.1-2ubuntu5

---
rhythmbox (3.4.1-2ubuntu5) artful; urgency=medium

  * debian/control.in: typo fix from the previous upload

 -- Sebastien Bacher   Thu, 10 Aug 2017 23:33:53
+0200

** Changed in: rhythmbox (Ubuntu)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1703662

Title:
  [MIR] rhythmbox-plugin-alternative-toolbar

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/1703662/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1703662] Re: [MIR] rhythmbox-plugin-alternative-toolbar

2017-08-10 Thread Launchpad Bug Tracker
This bug was fixed in the package ubuntu-settings - 17.10.10

---
ubuntu-settings (17.10.10) artful; urgency=medium

  * debian/ubuntu-settings.gsettings-override:
- enabled the rhythmbox alternative-toolbar plugin (lp: #1703662)

 -- Sebastien Bacher   Thu, 10 Aug 2017 17:40:11
+0200

** Changed in: ubuntu-settings (Ubuntu)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1703662

Title:
  [MIR] rhythmbox-plugin-alternative-toolbar

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/1703662/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1703662] Re: [MIR] rhythmbox-plugin-alternative-toolbar

2017-08-10 Thread Sebastien Bacher
** Also affects: ubuntu-settings (Ubuntu)
   Importance: Undecided
   Status: New

** Changed in: ubuntu-settings (Ubuntu)
   Importance: Undecided => Wishlist

** Changed in: ubuntu-settings (Ubuntu)
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1703662

Title:
  [MIR] rhythmbox-plugin-alternative-toolbar

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/1703662/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1703662] Re: [MIR] rhythmbox-plugin-alternative-toolbar

2017-08-10 Thread Sebastien Bacher
Thanks, rhythmbox recommends it now so I guess we can close the bug

** Changed in: rhythmbox-plugin-alternative-toolbar (Ubuntu)
   Status: Fix Committed => Fix Released

** Also affects: rhythmbox (Ubuntu)
   Importance: Undecided
   Status: New

** Changed in: rhythmbox (Ubuntu)
   Importance: Undecided => Wishlist

** Changed in: rhythmbox (Ubuntu)
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1703662

Title:
  [MIR] rhythmbox-plugin-alternative-toolbar

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/1703662/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1703662] Re: [MIR] rhythmbox-plugin-alternative-toolbar

2017-08-10 Thread Mathieu Trudel-Lapierre
Looks good to me, thanks! MIR approved.

** Changed in: rhythmbox-plugin-alternative-toolbar (Ubuntu)
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1703662

Title:
  [MIR] rhythmbox-plugin-alternative-toolbar

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rhythmbox-plugin-alternative-toolbar/+bug/1703662/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1703662] Re: [MIR] rhythmbox-plugin-alternative-toolbar

2017-08-10 Thread Sebastien Bacher
The review comments should be addressed in 
https://launchpad.net/ubuntu/+source/rhythmbox-plugin-alternative-toolbar/0.17.4-1

The desktop-bugs team is subscribed to the package

Let me know if you want me to add the recommends to rhythmbox now or
after the MIR is approved


** Changed in: rhythmbox-plugin-alternative-toolbar (Ubuntu)
   Status: Incomplete => New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1703662

Title:
  [MIR] rhythmbox-plugin-alternative-toolbar

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rhythmbox-plugin-alternative-toolbar/+bug/1703662/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1703662] Re: [MIR] rhythmbox-plugin-alternative-toolbar

2017-08-07 Thread Sebastien Bacher
Thanks for the review Mathieu. I'm going to have a look at the packaging
issue and come back once those are resolved

> Finally, nothing currently Depends/Recommends rhythmbox-plugin-
alternative-toolbar. This means it would not stay in main if promoted.

right, I though we wanted the MIR approved first before adding a
recommend but we can do it the other way around if that's preferred

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1703662

Title:
  [MIR] rhythmbox-plugin-alternative-toolbar

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rhythmbox-plugin-alternative-toolbar/+bug/1703662/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1703662] Re: [MIR] rhythmbox-plugin-alternative-toolbar

2017-08-04 Thread Mathieu Trudel-Lapierre
I'm a bit concerned with the way this is packaged.

Why is it necessary to remove the LICENSE file, for instance? This is no
the only source to ship one; it should probably remain and live with the
rest of the documentation (such as with copyright). The right way to fix
this would obviously be upstream, and since the upstream is also
packaging for Debian and Ubuntu, this should be a simple fix.

There are also extra postinst, prerm files which I expect should not be
needed. Again, this is not the first python package, isn't python3
already doing all that is necessary? Building the package should be done
when the package is being built, not when it is installed or removed.

There is a relevant warning in the build logs:
E: dh_python3 dh_python3:173: no package to act on (python3-foo or one with 
${python3:Depends} in Depends)

Finally, nothing currently Depends/Recommends rhythmbox-plugin-
alternative-toolbar. This means it would not stay in main if promoted.

Please fix for the above. I see no other issues with this package.


** Changed in: rhythmbox-plugin-alternative-toolbar (Ubuntu)
   Status: New => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1703662

Title:
  [MIR] rhythmbox-plugin-alternative-toolbar

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rhythmbox-plugin-alternative-toolbar/+bug/1703662/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs


[Bug 1703662] Re: [MIR] rhythmbox-plugin-alternative-toolbar

2017-08-02 Thread Sebastien Bacher
Could somebody from the MIR team review this one? It shouldn't be a too
difficult one...

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1703662

Title:
  [MIR] rhythmbox-plugin-alternative-toolbar

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rhythmbox-plugin-alternative-toolbar/+bug/1703662/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs