[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
Hi, I'm having the same issue on Focal Fossa using ubuntu-20.04-legacy- server-amd64.iso (md5sum 9d2b54506f8f9fdad6b72e45aff0f0de). The only workaround which helps overcome the issue of not taking into account d-i netcfg/hostname string from preseed file is to specify hostname= on kernel boot command line. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
** Changed in: debian-installer (Ubuntu) Status: In Progress => Fix Released ** Tags removed: verification-needed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
** Branch linked: lp:~ubuntu-core-dev/debian-installer/trusty-proposed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
** Changed in: debian-installer (Ubuntu Bionic) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
** Tags added: id-5ab94d853c3f9bad14e58f87 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
This bug was fixed in the package preseed - 1.62ubuntu1.2 --- preseed (1.62ubuntu1.2) trusty; urgency=medium * Fix for netcfg/hostname, if set, to take precedence. (LP: #1745531) - Modify debian/network-preseed.postinst to make it more robust -- Hua Zhang Thu, 25 Jan 2018 15:09:28 +0800 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
This bug was fixed in the package preseed - 1.71ubuntu1.2 --- preseed (1.71ubuntu1.2) xenial; urgency=medium * Fix for netcfg/hostname, if set, to take precedence. (LP: #1745531) - Modify debian/network-preseed.postinst to make it more robust -- Hua Zhang Thu, 25 Jan 2018 15:16:39 +0800 ** Changed in: debian-installer (Ubuntu Trusty) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
This bug was fixed in the package debian-installer - 20101020ubuntu318.43 --- debian-installer (20101020ubuntu318.43) trusty; urgency=medium * Include $efi_name in shim filename. (LP: #1743787) * Rebuild to pick up the latest change in preseed. (LP: #1745531) -- Eric Desrochers Fri, 19 Jan 2018 09:20:25 -0500 ** Changed in: preseed (Ubuntu Trusty) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
This bug was fixed in the package debian-installer - 20101020ubuntu451.19 --- debian-installer (20101020ubuntu451.19) xenial; urgency=medium * No change rebuild to pick up the latest change in preseed (LP: #1745531) -- Zhang Hua Tue, 16 Jan 2018 21:58:04 +0800 ** Changed in: debian-installer (Ubuntu Xenial) Status: Fix Committed => Fix Released ** Changed in: preseed (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
I have tested the following mini.iso and can confirm they work for me http://archive.ubuntu.com/ubuntu/dists/xenial-proposed/main/installer-amd64/20101020ubuntu451.19/images/netboot/mini.iso http://archive.ubuntu.com/ubuntu/dists/trusty-proposed/main/installer-amd64/20101020ubuntu318.43/images/netboot/mini.iso ** Tags removed: verification-needed-trusty verification-needed-xenial ** Tags added: verification-done-trusty verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
Hello Hua, or anyone else affected, Accepted debian-installer into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/debian- installer/20101020ubuntu451.19 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: debian-installer (Ubuntu Xenial) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
Hello Hua, or anyone else affected, Accepted debian-installer into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/debian- installer/20101020ubuntu318.43 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-trusty to verification-done-trusty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-trusty. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: debian-installer (Ubuntu Trusty) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
This bug was fixed in the package preseed - 1.71ubuntu5.1 --- preseed (1.71ubuntu5.1) artful; urgency=medium * Fix for netcfg/hostname, if set, to take precedence. (LP: #1745531) - Modify debian/network-preseed.postinst to make it more robust -- Zhang Hua Fri, 26 Jan 2018 13:32:11 +0800 ** Changed in: preseed (Ubuntu Artful) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
This bug was fixed in the package debian-installer - 20101020ubuntu523.2 --- debian-installer (20101020ubuntu523.2) artful; urgency=medium * No change rebuild to pick up the latest change in preseed (LP: #1745531) -- Zhang Hua Fri, 26 Jan 2018 13:53:02 +0800 ** Changed in: debian-installer (Ubuntu Artful) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
Hello Hua, or anyone else affected, Accepted preseed into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/preseed/1.71ubuntu1.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: preseed (Ubuntu Xenial) Status: In Progress => Fix Committed ** Tags added: verification-needed-xenial ** Changed in: preseed (Ubuntu Trusty) Status: In Progress => Fix Committed ** Tags added: verification-needed-trusty -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
Hello, I have also tested the 523.2 netboot ISO and can confirm that it works for me. Cristian -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
I have tested the following mini.iso, it works for me. http://archive.ubuntu.com/ubuntu/dists/artful-proposed/main/installer- amd64/20101020ubuntu523.2/images/netboot/mini.iso Joshua ** Tags removed: verification-needed-artful ** Tags added: verification-done-artful -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
Presumably this works in bionic but I don't see any information (its not required for the SRU process) indicating that it is fixed. However, I'd like to see Artful verified before accepting it into other releases. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
Hello Hua, or anyone else affected, Accepted debian-installer into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/debian- installer/20101020ubuntu523.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: debian-installer (Ubuntu Artful) Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
Hello Hua, or anyone else affected, Accepted preseed into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/preseed/1.71ubuntu5.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: preseed (Ubuntu Artful) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-artful -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
I have also uploaded d-i for T/X/A which will be needed after the preseed build for the mini.iso for instance. It is now waiting on the SRU verification team approval for the new packages to start building in $RELEASE-proposed. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
I have uploaded preseed for T/X/A. It is now waiting on the SRU
verification team approval for the new packages to start building in
$RELEASE-proposed.
** Description changed:
+ [Special notes]
+
+ Rebuilding debian-installer will be necessary in order to get a new
+ mini.iso (Minimal ISO image of Ubuntu) containing this particular fix.
+
+ Despite the fact that a full ISO are no longer built for some of the
+ affected stable releases, one can use what is called a minimal ISO image
+ (mini.iso) of Ubuntu. This mini.iso uses a text-based installer,
+ resulting in a smaller image. The minimal ISO image will download
+ packages from online archives at installation time instead of providing
+ them on the install media itself.
+
[Impact]
This is the same issue reported in
https://bugs.launchpad.net/ubuntu/+source/preseed/+bug/1452202
However that is marked as 'Fix Released' and the issue is still occurring so
it seems best to just open a new bug according to Eric's comment.
The present hostname preseed regex looks like:
if ! echo "$RET" | grep -q 'ubuntu'; then
...
/bin/sed -i "s/$CURRENT_HOSTNAME/$NETCFG_HOSTNAME/" /etc/hosts
...
fi
There are still multiple problems with them according to Peter's comment
(https://bugs.launchpad.net/ubuntu/+source/preseed/+bug/1452202/comments/64)
and Mathieu's comment
(https://bugs.launchpad.net/ubuntu/+source/preseed/+bug/1452202/comments/93).
- The default hostname is 'ubuntu', and is the value you will get if
nothing is preseeded -- we *do* need to skip it in this case, although
the grep may need to be more precise. A name like 'ubuntuxenial' should
match this grep.
- The sed needs to be fixed to more appropriately catch for the exact
string, rather than any substring -- ie. it should not match
'ipv6-allnodes' if the name received from DHCP was 'node'. It should
only match and replace for 'node'.
So the fix will try to:
1) Keep the if statement and add the -w option to grep to be more robust
2) Modify the sed cmd with word boundaries (\b) to be more robust as well.
[Test Case]
Install Ubuntu using a preseed[1] file[2] and add the following line in the
preseed recipe :
d-i netcfg/hostname string
Change the HOSTNAME to see if the hostname in /etc/hosts can be updated
correctly.
[1] - url=http:///
[2] - https://help.ubuntu.com/lts/installation-guide/example-preseed.txt
[Regression Potential]
* none expected, the actual changes are as follows:
-if ! echo "$RET" | grep -q 'ubuntu'; then
+if ! echo "$RET" | grep -qw 'ubuntu'; then
...
- /bin/sed -i "s/$CURRENT_HOSTNAME/$NETCFG_HOSTNAME/" /etc/hosts
+ /bin/sed -i "s/\b${CURRENT_HOSTNAME}\b/${NETCFG_HOSTNAME}/g"
/etc/hosts
In other words, we simply make it more robust to select only pattern
containing matches that form whole word... catching 'ubuntu' hostname
as-is but not catching pattern where ubuntu is part of the user chosen
hostname as follow :
"sometextubuntu"
"sometextubuntusometext"
"ubuntusometext"
...
[Original Description]
** Tags removed: sts-sponsor-slashd
** Tags added: sts-sponsor-slashd-done
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1745531
Title:
[SRU] Reinforce hostname preseed regex
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
** Description changed:
[Impact]
This is the same issue reported in
https://bugs.launchpad.net/ubuntu/+source/preseed/+bug/1452202
However that is marked as 'Fix Released' and the issue is still occurring so
it seems best to just open a new bug according to Eric's comment.
The present hostname preseed regex looks like:
if ! echo "$RET" | grep -q 'ubuntu'; then
...
/bin/sed -i "s/$CURRENT_HOSTNAME/$NETCFG_HOSTNAME/" /etc/hosts
...
fi
There are still multiple problems with them according to Peter's comment
(https://bugs.launchpad.net/ubuntu/+source/preseed/+bug/1452202/comments/64)
and Mathieu's comment
(https://bugs.launchpad.net/ubuntu/+source/preseed/+bug/1452202/comments/93).
- The default hostname is 'ubuntu', and is the value you will get if
nothing is preseeded -- we *do* need to skip it in this case, although
the grep may need to be more precise. A name like 'ubuntuxenial' should
match this grep.
- The sed needs to be fixed to more appropriately catch for the exact
string, rather than any substring -- ie. it should not match
'ipv6-allnodes' if the name received from DHCP was 'node'. It should
only match and replace for 'node'.
So the fix will try to:
1) Keep the if statement and add the -w option to grep to be more robust
2) Modify the sed cmd with word boundaries (\b) to be more robust as well.
[Test Case]
Install Ubuntu using a preseed[1] file[2] and add the following line in the
preseed recipe :
d-i netcfg/hostname string
Change the HOSTNAME to see if the hostname in /etc/hosts can be updated
correctly.
[1] - url=http:///
[2] - https://help.ubuntu.com/lts/installation-guide/example-preseed.txt
[Regression Potential]
- * none expected, the actual changes are as follows:
+ * none expected, the actual changes are as follows:
-if ! echo "$RET" | grep -q 'ubuntu'; then
+if ! echo "$RET" | grep -qw 'ubuntu'; then
...
- /bin/sed -i "s/$CURRENT_HOSTNAME/$NETCFG_HOSTNAME/" /etc/hosts
+ /bin/sed -i "s/\b${CURRENT_HOSTNAME}\b/${NETCFG_HOSTNAME}/g"
/etc/hosts
+ In other words, we simply make it more robust to select only pattern
+ containing matches that form whole word... catching 'ubuntu' hostname
+ as-is but not catching pattern where ubuntu is part of the user chosen
+ hostname as follow :
+
+ "sometextubuntu"
+ "sometextubuntusometext"
+ "ubuntusometext"
+ ...
[Original Description]
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1745531
Title:
[SRU] Reinforce hostname preseed regex
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
** Changed in: debian-installer (Ubuntu Xenial) Assignee: Eric Desrochers (slashd) => Hua Zhang (zhhuabj) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
** Changed in: debian-installer (Ubuntu Bionic) Assignee: Eric Desrochers (slashd) => Hua Zhang (zhhuabj) ** Changed in: debian-installer (Ubuntu Artful) Assignee: Eric Desrochers (slashd) => Hua Zhang (zhhuabj) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
This bug was fixed in the package preseed - 1.71ubuntu7 --- preseed (1.71ubuntu7) bionic; urgency=medium * Fix for netcfg/hostname, if set, to take precedence. (LP: #1745531) - Modify debian/network-preseed.postinst to make it more robust -- Hua Zhang Thu, 25 Jan 2018 15:12:38 +0800 ** Changed in: preseed (Ubuntu Bionic) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
** Changed in: debian-installer (Ubuntu Bionic) Importance: Undecided => Medium ** Changed in: debian-installer (Ubuntu Artful) Importance: Undecided => Medium ** Changed in: debian-installer (Ubuntu Xenial) Importance: Undecided => Medium ** Changed in: debian-installer (Ubuntu Trusty) Importance: Undecided => Medium ** Changed in: debian-installer (Ubuntu Artful) Status: New => In Progress ** Changed in: debian-installer (Ubuntu Xenial) Status: New => In Progress ** Changed in: debian-installer (Ubuntu Trusty) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
** Patch added: "d-i_bionic.debdiff" https://bugs.launchpad.net/ubuntu/+source/preseed/+bug/1745531/+attachment/5044886/+files/d-i_bionic.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1745531] Re: [SRU] Reinforce hostname preseed regex
** Patch added: "lp_1745531_bonic.debdiff" https://bugs.launchpad.net/ubuntu/+source/preseed/+bug/1745531/+attachment/5044885/+files/lp_1745531_bonic.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1745531 Title: [SRU] Reinforce hostname preseed regex To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1745531/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
