[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-06-10 Thread Bo Kersey
Thanks!  I've just installed it on one of my Xenial servers for
testing...  I'll let you know how it goes...

Cheers!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-06-10 Thread Launchpad Bug Tracker
This bug was fixed in the package cups - 2.1.3-4ubuntu0.9

---
cups (2.1.3-4ubuntu0.9) xenial; urgency=medium

  * d/p/0045-Fix-an-issue-with-PreserveJobHistory-and-time-values.patch
Fix an issue with `PreserveJobHistory` and time values
(Issue #5538, Closes: #921741, LP: #1747765)

 -- Dariusz Gadomski   Thu, 30 May 2019
11:33:26 +0200

** Changed in: cups (Ubuntu Xenial)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-06-10 Thread Launchpad Bug Tracker
This bug was fixed in the package cups - 2.2.8-5ubuntu1.4

---
cups (2.2.8-5ubuntu1.4) cosmic; urgency=medium

  * d/p/0045-Fix-an-issue-with-PreserveJobHistory-and-time-values.patch
Fix an issue with `PreserveJobHistory` and time values
(Issue #5538, Closes: #921741, LP: #1747765)

 -- Dariusz Gadomski   Thu, 30 May 2019
14:11:53 +0200

** Changed in: cups (Ubuntu Cosmic)
   Status: Fix Committed => Fix Released

** Changed in: cups (Ubuntu Bionic)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-06-10 Thread Launchpad Bug Tracker
This bug was fixed in the package cups - 2.2.7-1ubuntu2.6

---
cups (2.2.7-1ubuntu2.6) bionic; urgency=medium

  * d/p/0045-Fix-an-issue-with-PreserveJobHistory-and-time-values.patch
Fix an issue with `PreserveJobHistory` and time values
(Issue #5538, Closes: #921741, LP: #1747765)

 -- Dariusz Gadomski   Thu, 30 May 2019
10:02:17 +0200

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-06-10 Thread Launchpad Bug Tracker
This bug was fixed in the package cups - 2.2.10-4ubuntu2

---
cups (2.2.10-4ubuntu2) disco; urgency=medium

  * d/p/0045-Fix-an-issue-with-PreserveJobHistory-and-time-values.patch
Fix an issue with `PreserveJobHistory` and time values
(Issue #5538, Closes: #921741, LP: #1747765)

 -- Dariusz Gadomski   Thu, 30 May 2019
09:51:37 +0200

** Changed in: cups (Ubuntu Disco)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-06-10 Thread Łukasz Zemczak
Thank you for verifying all the test cases!

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-06-04 Thread Dariusz Gadomski
** Tags removed: verification-needed verification-needed-xenial
** Tags added: verification-done verification-done-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-06-04 Thread Dariusz Gadomski
Despite some build failures for i386 and s390 which I believe are not
related to the scope of the change I have successfully verified it for
amd64.

apt-cache policy cups-daemon
cups:
  Installed: 2.1.3-4ubuntu0.9

lp -d PDF /usr/share/cups/data/default.pdf

PreserveJobHistory 30:
I [04/Jun/2019:13:19:56 +] [Job 1] Job completed.
D [04/Jun/2019:13:20:27 +] [Job 1] Removing from history.

PreserveJobHistory No:
I [04/Jun/2019:13:22:32 +] [Job 2] Job completed.
D [04/Jun/2019:13:22:32 +] [Job 2] Removing from history.

PreserveJobHistory Yes:
I [04/Jun/2019:13:23:41 +] [Job 3] Job completed.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-06-04 Thread Dariusz Gadomski
** Changed in: cups (Ubuntu Disco)
 Assignee: Dariusz Gadomski (dgadomski) => (unassigned)

** Description changed:

  [Impact]
  
   The documentation allows the following types of arguments for the 
PreserveJobHistory parameter:
  PreserveJobHistory Yes
  PreserveJobHistory No
  PreserveJobHistory seconds
  
  The value in seconds is treated in the same as 'No' resulting in
  immediate removing of jobs from history, while it is supposed to save it
  for .
  
  [Test Case]
  
   1. Set PreserveJobHistory to 30. Set LogLevel to debug.
   2. Schedule a job for printing.
   3. Check the error_log.
-  4. Set PreserveJobHistory to Yes. Repeat 2-3.
-  5. Set PreserveJobHistory to No. Repeat 2-3.
+  4. Set PreserveJobHistory to No. Repeat 2-3.
+  5. Set PreserveJobHistory to Yes. Repeat 2-3.
+  
  
  Expected result (for PreserveJobHistory values):
  30: Job is save for at least 30 seconds.
+ No: Job is removed right after processing.
  Yes: Job is never removed.
- No: Job is removed right after processing.
  
  Actual results (for PreserveJobHistory values):
  30: Job is immediately removed from history.
+ No: Job is removed right after processing.
  Yes: Job is never removed.
- No: Job is removed right after processing.
  
  [Regression Potential]
  
   * With the fix the jobs will be saved longer than before, so in tight
  conditions (low disk space) and heavy workload it may affect memory/disk
  space consumption and lead to running out of free space in worst case.
  
  [Other Info]
  
   * Original bug description:
  
  1) Ubuntu Release
  Description:  Ubuntu 16.04.3 LTS
  Release:  16.04
  
  2) Version of the package
  cups:
    Installed: 2.1.3-4ubuntu0.3
    Candidate: 2.1.3-4ubuntu0.3
    Version table:
   *** 2.1.3-4ubuntu0.3 500
  500 http://us.archive.ubuntu.com/ubuntu xenial-updates/main amd64 
Packages
  
  3) What I expected to happen:
  from man cupsd.conf
  
    PreserveJobFiles Yes
  
     PreserveJobFiles No
  
     PreserveJobFiles seconds
  Specifies  whether  job files (documents) are preserved after a 
job is printed.  If a numeric value is specified, job files are preserved
  for the indicated number of seconds after printing.  The default 
is "86400" (preserve 1 day).
  
     PreserveJobHistory Yes
  
     PreserveJobHistory No
  
     PreserveJobHistory seconds
  Specifies whether the job history is preserved after a job is 
printed.  If a numeric value is specified, the job history is preserved for
  the  indicated number of seconds after printing.  If "Yes", the 
job history is preserved until the MaxJobs limit is reached.  The default
  is "Yes".
  
  4) What happens instead
  
  If I put the following directives in cupsd.conf the job files and
  history are deleted immediately.
  
  PreserveJobFiles 604800
  PreserveJobHistory 604800
  
  Debug log showing history being purged:
  d [06/Feb/2018:15:11:59 -0600] cupsdCheckJobs: 0 active jobs, sleeping=0, 
ac-power=-1, reload=0, curtime=1517951519
  d [06/Feb/2018:15:11:59 -0600] cupsdCleanJobs: MaxJobs=100, 
JobHistory=604800, JobFiles=604800
  D [06/Feb/2018:15:11:59 -0600] [Job 106] Removing from history.
  D [06/Feb/2018:15:11:59 -0600] [Job 106] Unloading...

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-06-04 Thread Dariusz Gadomski
Verified for cosmic:

apt-cache policy cups-daemon
cups-daemon:
  Installed: 2.2.8-5ubuntu1.4

lp -d PDF /usr/share/cups/data/default.pdf

PreserveJobHistory 30:
I [04/Jun/2019:09:12:13 +] [Job 1] Job completed.
D [04/Jun/2019:09:12:44 +] [Job 1] Removing from history.

PreserveJobHistory No:
I [04/Jun/2019:09:13:03 +] [Job 2] Job completed.
D [04/Jun/2019:09:13:03 +] [Job 2] Removing from history.

PreserveJobHistory Yes:
I [04/Jun/2019:09:13:30 +] [Job 3] Job completed.

** Tags removed: verification-needed-cosmic
** Tags added: verification-done-cosmic

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-06-04 Thread Dariusz Gadomski
Verified for disco:

apt-cache policy cups-daemon
cups-daemon:
  Installed: 2.2.10-4ubuntu2

lp -d PDF /usr/share/cups/data/default.pdf

PreserveJobHistory 30:
I [04/Jun/2019:09:03:14 +] [Job 1] Job completed.
D [04/Jun/2019:09:03:45 +] [Job 2] Removing from history.

PreserveJobHistory No:
I [04/Jun/2019:09:04:06 +] [Job 2] Job completed.
D [04/Jun/2019:09:04:06 +] [Job 2] Removing from history.

PreserveJobHistory Yes:
I [04/Jun/2019:09:04:50 +] [Job 3] Job completed.

** Tags removed: verification-needed-disco
** Tags added: verification-done-disco

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-06-04 Thread Dariusz Gadomski
Verified for bionic.
apt-cache policy cups-daemon
cups-daemon:
  Installed: 2.2.7-1ubuntu2.6

lp -d PDF /usr/share/cups/data/default.pdf

PreserveJobHistory 30:
I [04/Jun/2019:08:52:25 +] [Job 1] Job completed
D [04/Jun/2019:08:52:56 +] [Job 1] Removing from history.

PreserveJobHistory No:
I [04/Jun/2019:08:53:58 +] [Job 2] Job completed.
D [04/Jun/2019:08:53:58 +] [Job 2] Removing from history.

PreserveJobHistory Yes:
I [04/Jun/2019:08:54:55 +] [Job 5] Job completed.
(...)

** Description changed:

  [Impact]
  
-  The documentation allows the following types of arguments for the 
PreserveJobHistory parameter:
+  The documentation allows the following types of arguments for the 
PreserveJobHistory parameter:
  PreserveJobHistory Yes
  PreserveJobHistory No
  PreserveJobHistory seconds
- 
- The value in seconds is treated in the same as 'No' resulting in immediate 
removing of jobs from history, while it is supposed to save it for .
+ 
+ The value in seconds is treated in the same as 'No' resulting in
+ immediate removing of jobs from history, while it is supposed to save it
+ for .
  
  [Test Case]
  
-  * Set PreserveJobHistory to 300.
-  * Schedule a job for printing.
-  * Check the error_log.
+  1. Set PreserveJobHistory to 300.
+  2. Schedule a job for printing.
+  3. Check the error_log.
+  4. Set PreserveJobHistory to Yes. Repeat 2-3.
+  5. Set PreserveJobHistory to No. Repeat 2-3.
+  
  
- Expected result:
- Job is save for at least 300 seconds.
+ Expected result (for PreserveJobHistory values):
+ 300: Job is save for at least 300 seconds.
+ Yes: Job is never removed.
+ No: Job is removed right after processing.
  
- Actual results:
- Job is immediately removed from history.
+ 
+ Actual results (for PreserveJobHistory values):
+ 300: Job is immediately removed from history.
+ Yes: Job is never removed.
+ No: Job is removed right after processing.
  
  [Regression Potential]
  
-  * With the fix the jobs will be saved longer than before, so in tight
+  * With the fix the jobs will be saved longer than before, so in tight
  conditions (low disk space) and heavy workload it may affect memory/disk
  space consumption and lead to running out of free space in worst case.
  
  [Other Info]
-  
-  * Original bug description:
+ 
+  * Original bug description:
  
  1) Ubuntu Release
  Description:  Ubuntu 16.04.3 LTS
  Release:  16.04
  
  2) Version of the package
  cups:
    Installed: 2.1.3-4ubuntu0.3
    Candidate: 2.1.3-4ubuntu0.3
    Version table:
   *** 2.1.3-4ubuntu0.3 500
  500 http://us.archive.ubuntu.com/ubuntu xenial-updates/main amd64 
Packages
  
  3) What I expected to happen:
  from man cupsd.conf
  
    PreserveJobFiles Yes
  
     PreserveJobFiles No
  
     PreserveJobFiles seconds
  Specifies  whether  job files (documents) are preserved after a 
job is printed.  If a numeric value is specified, job files are preserved
  for the indicated number of seconds after printing.  The default 
is "86400" (preserve 1 day).
  
     PreserveJobHistory Yes
  
     PreserveJobHistory No
  
     PreserveJobHistory seconds
  Specifies whether the job history is preserved after a job is 
printed.  If a numeric value is specified, the job history is preserved for
  the  indicated number of seconds after printing.  If "Yes", the 
job history is preserved until the MaxJobs limit is reached.  The default
  is "Yes".
  
  4) What happens instead
  
  If I put the following directives in cupsd.conf the job files and
  history are deleted immediately.
  
  PreserveJobFiles 604800
  PreserveJobHistory 604800
  
  Debug log showing history being purged:
  d [06/Feb/2018:15:11:59 -0600] cupsdCheckJobs: 0 active jobs, sleeping=0, 
ac-power=-1, reload=0, curtime=1517951519
  d [06/Feb/2018:15:11:59 -0600] cupsdCleanJobs: MaxJobs=100, 
JobHistory=604800, JobFiles=604800
  D [06/Feb/2018:15:11:59 -0600] [Job 106] Removing from history.
  D [06/Feb/2018:15:11:59 -0600] [Job 106] Unloading...

** Description changed:

  [Impact]
  
   The documentation allows the following types of arguments for the 
PreserveJobHistory parameter:
  PreserveJobHistory Yes
  PreserveJobHistory No
  PreserveJobHistory seconds
  
  The value in seconds is treated in the same as 'No' resulting in
  immediate removing of jobs from history, while it is supposed to save it
  for .
  
  [Test Case]
  
-  1. Set PreserveJobHistory to 300.
+  1. Set PreserveJobHistory to 30.
   2. Schedule a job for printing.
   3. Check the error_log.
-  4. Set PreserveJobHistory to Yes. Repeat 2-3.
-  5. Set PreserveJobHistory to No. Repeat 2-3.
-  
+  4. Set PreserveJobHistory to Yes. Repeat 2-3.
+  5. Set PreserveJobHistory to No. Repeat 2-3.
  
  Expected result (for PreserveJobHistory values):
- 300: Job is save for at least 300 seconds.
+ 300: Job is save for at least 30 seconds.
  Yes: Job is never removed.
  No: Job is 

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-06-03 Thread Łukasz Zemczak
Hello Bo, or anyone else affected,

Accepted cups into bionic-proposed. The package will build now and be
available at https://launchpad.net/ubuntu/+source/cups/2.2.7-1ubuntu2.6
in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-bionic to verification-done-bionic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-bionic. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: cups (Ubuntu Bionic)
   Status: In Progress => Fix Committed

** Tags added: verification-needed-bionic

** Changed in: cups (Ubuntu Xenial)
   Status: In Progress => Fix Committed

** Tags added: verification-needed-xenial

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-06-03 Thread Łukasz Zemczak
Hello Bo, or anyone else affected,

Accepted cups into cosmic-proposed. The package will build now and be
available at https://launchpad.net/ubuntu/+source/cups/2.2.8-5ubuntu1.4
in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
to enable and use -proposed.  Your feedback will aid us getting this
update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested and change the tag from
verification-needed-cosmic to verification-done-cosmic. If it does not
fix the bug for you, please add a comment stating that, and change the
tag to verification-failed-cosmic. In either case, without details of
your testing we will not be able to proceed.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance for helping!

N.B. The updated package will be released to -updates after the bug(s)
fixed by this package have been verified and the package has been in
-proposed for a minimum of 7 days.

** Changed in: cups (Ubuntu Cosmic)
   Status: In Progress => Fix Committed

** Tags added: verification-needed-cosmic

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-06-03 Thread Łukasz Zemczak
Thanks for the SRU! The upload looks good, but could I request that the
new packages are tested against the PreserveJobHistory Yes/No values
additionally to the 'seconds' case? As an additional safety check.

I will accept this upload but please include those 2 additional tests in
the Test Case.

** Changed in: cups (Ubuntu Disco)
   Status: In Progress => Fix Committed

** Tags added: verification-needed verification-needed-disco

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-05-31 Thread Dan Streetman
** Tags added: sts

** Changed in: cups (Ubuntu Disco)
 Assignee: (unassigned) => Dariusz Gadomski (dgadomski)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-05-30 Thread Till Kamppeter
SRU for Cosmic sponsored, thanks.

** Changed in: cups (Ubuntu Xenial)
   Status: New => In Progress

** Changed in: cups (Ubuntu Bionic)
   Status: New => In Progress

** Changed in: cups (Ubuntu Cosmic)
   Status: New => In Progress

** Changed in: cups (Ubuntu Disco)
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-05-30 Thread Dariusz Gadomski
Thanks Till. I've fixed cosmic debdiff, sorry about the mistake.

** Patch removed: "cosmic_cups_2.2.8-5ubuntu1.4.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+attachment/5267676/+files/cosmic_cups_2.2.8-5ubuntu1.4.debdiff

** Patch added: "cosmic_cups_2.2.8-5ubuntu1.4.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+attachment/5267712/+files/cosmic_cups_2.2.8-5ubuntu1.4.debdiff

** Changed in: cups (Ubuntu Xenial)
 Assignee: Dariusz Gadomski (dgadomski) => (unassigned)

** Changed in: cups (Ubuntu Cosmic)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-05-30 Thread Till Kamppeter
I have sponsored the Xenial SRU now, but the one for Cosmic is missing
the addition of the patch to debian/patches/series.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-05-30 Thread Dariusz Gadomski
SRU proposal for Cosmic.

** Patch added: "cosmic_cups_2.2.8-5ubuntu1.4.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+attachment/5267676/+files/cosmic_cups_2.2.8-5ubuntu1.4.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-05-30 Thread Dariusz Gadomski
** Also affects: cups (Ubuntu Cosmic)
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-05-30 Thread Dariusz Gadomski
SRU proposal for Xenial.

** Patch added: "xenial_cups_2.1.3-4ubuntu0.9.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+attachment/5267662/+files/xenial_cups_2.1.3-4ubuntu0.9.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-05-30 Thread Till Kamppeter
Sponsored SRUs for Bionic and Disco.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-05-30 Thread Dariusz Gadomski
The patch doesn't apply cleanly to Xenial, working on backport.

** Changed in: cups (Ubuntu Xenial)
 Assignee: (unassigned) => Dariusz Gadomski (dgadomski)

** Changed in: cups (Ubuntu Xenial)
   Importance: Undecided => Medium

** Changed in: cups (Ubuntu Bionic)
   Importance: Undecided => Medium

** Changed in: cups (Ubuntu Disco)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-05-30 Thread Dariusz Gadomski
@sponsors: Eoan already has the fix from Debian.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-05-30 Thread Dariusz Gadomski
SRU proposal for Bionic

** Patch added: "bionic_cups_2.2.7-1ubuntu2.6.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+attachment/5267600/+files/bionic_cups_2.2.7-1ubuntu2.6.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-05-30 Thread Dariusz Gadomski
SRU proposal for Disco

** Patch added: "disco_cups_2.2.10-4ubuntu2.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+attachment/5267599/+files/disco_cups_2.2.10-4ubuntu2.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-05-30 Thread Dariusz Gadomski
** Description changed:

+ [Impact]
+ 
+  The documentation allows the following types of arguments for the 
PreserveJobHistory parameter:
+ PreserveJobHistory Yes
+ PreserveJobHistory No
+ PreserveJobHistory seconds
+ 
+ The value in seconds is treated in the same as 'No' resulting in immediate 
removing of jobs from history, while it is supposed to save it for .
+ 
+ [Test Case]
+ 
+  * Set PreserveJobHistory to 300.
+  * Schedule a job for printing.
+  * Check the error_log.
+ 
+ Expected result:
+ Job is save for at least 300 seconds.
+ 
+ Actual results:
+ Job is immediately removed from history.
+ 
+ [Regression Potential]
+ 
+  * With the fix the jobs will be saved longer than before, so in tight
+ conditions (low disk space) and heavy workload it may affect memory/disk
+ space consumption and lead to running out of free space in worst case.
+ 
+ [Other Info]
+  
+  * Original bug description:
+ 
  1) Ubuntu Release
  Description:  Ubuntu 16.04.3 LTS
  Release:  16.04
  
  2) Version of the package
  cups:
-   Installed: 2.1.3-4ubuntu0.3
-   Candidate: 2.1.3-4ubuntu0.3
-   Version table:
-  *** 2.1.3-4ubuntu0.3 500
- 500 http://us.archive.ubuntu.com/ubuntu xenial-updates/main amd64 
Packages
+   Installed: 2.1.3-4ubuntu0.3
+   Candidate: 2.1.3-4ubuntu0.3
+   Version table:
+  *** 2.1.3-4ubuntu0.3 500
+ 500 http://us.archive.ubuntu.com/ubuntu xenial-updates/main amd64 
Packages
  
  3) What I expected to happen:
  from man cupsd.conf
  
-   PreserveJobFiles Yes
+   PreserveJobFiles Yes
  
-PreserveJobFiles No
+    PreserveJobFiles No
  
-PreserveJobFiles seconds
- Specifies  whether  job files (documents) are preserved after a 
job is printed.  If a numeric value is specified, job files are preserved
- for the indicated number of seconds after printing.  The default 
is "86400" (preserve 1 day).
+    PreserveJobFiles seconds
+ Specifies  whether  job files (documents) are preserved after a 
job is printed.  If a numeric value is specified, job files are preserved
+ for the indicated number of seconds after printing.  The default 
is "86400" (preserve 1 day).
  
-PreserveJobHistory Yes
+    PreserveJobHistory Yes
  
-PreserveJobHistory No
+    PreserveJobHistory No
  
-PreserveJobHistory seconds
- Specifies whether the job history is preserved after a job is 
printed.  If a numeric value is specified, the job history is preserved for
- the  indicated number of seconds after printing.  If "Yes", the 
job history is preserved until the MaxJobs limit is reached.  The default
- is "Yes".
+    PreserveJobHistory seconds
+ Specifies whether the job history is preserved after a job is 
printed.  If a numeric value is specified, the job history is preserved for
+ the  indicated number of seconds after printing.  If "Yes", the 
job history is preserved until the MaxJobs limit is reached.  The default
+ is "Yes".
  
  4) What happens instead
  
  If I put the following directives in cupsd.conf the job files and
  history are deleted immediately.
  
  PreserveJobFiles 604800
  PreserveJobHistory 604800
  
- 
  Debug log showing history being purged:
  d [06/Feb/2018:15:11:59 -0600] cupsdCheckJobs: 0 active jobs, sleeping=0, 
ac-power=-1, reload=0, curtime=1517951519
  d [06/Feb/2018:15:11:59 -0600] cupsdCleanJobs: MaxJobs=100, 
JobHistory=604800, JobFiles=604800
  D [06/Feb/2018:15:11:59 -0600] [Job 106] Removing from history.
  D [06/Feb/2018:15:11:59 -0600] [Job 106] Unloading...

** Changed in: cups (Ubuntu)
   Importance: Undecided => Medium

** Also affects: cups (Ubuntu Disco)
   Importance: Undecided
   Status: New

** Also affects: cups (Ubuntu Xenial)
   Importance: Undecided
   Status: New

** Also affects: cups (Ubuntu Bionic)
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-05-30 Thread Dariusz Gadomski
This has been fixed in 19.10 for cups 2.2.10-6 (backport from upstream).

** Changed in: cups (Ubuntu)
   Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1747765] Re: PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs

2019-05-30 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users.

** Changed in: cups (Ubuntu)
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1747765

Title:
  PreserveJobHistory and PreserveJobLog do not respect numeric input as
  outlined in the docs

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cups/+bug/1747765/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs