[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2020-08-13 Thread Rafael David Tinoco
** Merge proposal linked: https://code.launchpad.net/~rafaeldtinoco/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/389234 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-11-08 Thread Scott Moser
** Description changed: [Impact]  * Service is running uselessly which is consuming a few cycles/memory as    well as raising general concerns e.g. on minimizing attack surface of    a system.  * This is also the only service in a default server install which pulls in the

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-10-02 Thread Launchpad Bug Tracker
This bug was fixed in the package open-iscsi - 2.0.874-5ubuntu2.2 --- open-iscsi (2.0.874-5ubuntu2.2) bionic; urgency=medium * make iscsid socket activated to only activate it as-needed (LP: #1755858) - debian/iscsid.socket: systemd socket file for iscsid -

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-10-01 Thread Scott Moser
Here is my verification of bionic proposed. It should be considered in cooperation with open-iscsi dep8 tests which do a iscsi root boot: http://autopkgtest.ubuntu.com/packages/o/open-iscsi/bionic/amd64 Below is sufficient for the 'Test Case' section of the SRU Template, it would be nice to see

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-10-01 Thread Scott Moser
@Chris, For what its worth, there is a process to build maas images with -proposed enabled at https://gist.github.com/smoser/8a34b1713badb643dee3a25e5cf134b8 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-10-01 Thread Chris Gregan
We do not usually do this type of validation as there is no Proposed pocket MAAS image or cloud image. An image would need to be build for just this package. The only alternative is to manually upgrade the images after they are applied to the nodes/pods/and instances. -- You received this bug

Re: [Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-10-01 Thread Chris Gregan
We do not typically pull from proposed. I would need to look into the process. The usual trouble is that once you turn on proposed, you On Mon, Oct 1, 2018 at 10:47 AM Dan Streetman wrote: > @cgregan are you able to verify the bionic-proposed pkg? > > -- > You received this bug notification

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-10-01 Thread Dan Streetman
@cgregan are you able to verify the bionic-proposed pkg? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-09-25 Thread Steve Langasek
Hello Steve, or anyone else affected, Accepted open-iscsi into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/open- iscsi/2.0.874-5ubuntu2.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package.

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-09-25 Thread Steve Langasek
** Description changed: [Impact]  * Service is running uselessly which is consuming a few cycles/memory as -    well as rasising general concerns e.g. on minimizing attack surfcae of +    well as raising general concerns e.g. on minimizing attack surface of    a system.  * This is

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-09-21 Thread Dan Streetman
@smoser, @paelzer, your bionic upload has been sitting for ~10 days in the upload queue, and it's blocking upload for bug 1791108. Can you shake the sru trees to get that upload approved, or can you ask for it to be rejected so i can upload for the other bug? -- You received this bug

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-09-10 Thread  Christian Ehrhardt 
FYI - Smoser and I started to prep SRU work for this. But once we agree on the content I'd be really happy if someone who was affected by the upgrade issue (and therefore has a valid and "real" iscsi setup) would test from the PPA before shoving that into the SRU queue. I subscribed Chris

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-09-09 Thread  Christian Ehrhardt 
** Description changed: [Impact]  * Service is running uselessly which is consuming a few cycles/memory as    well as rasising general concerns e.g. on minimizing attack surfcae of    a system. - * This is also the only service in a default server install which pulls +  * This is

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-09-07 Thread Scott Moser
I prepared merge proposals for both xenial and bionic. Also: - tested autopkgtest on both xenial and bionic - uploaded to [my ppa](https://launchpad.net/~smoser/+archive/ubuntu/ppa) for xenial and bionic - uploaded bionic to SRU queue -- You received this bug notification because you are a

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-09-07 Thread Scott Moser
** Merge proposal linked: https://code.launchpad.net/~smoser/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/354478 ** Merge proposal linked: https://code.launchpad.net/~smoser/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/354483 -- You received this bug notification because you are

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-09-06 Thread Steve Langasek
To be explicit, I don't think that the risk of regression here is such that we should not SRU this to bionic. I think anyone checking for the running status of an open-iscsi service, on a system that does not have any iscsi targets configured, is writing buggy code and that should not be catered

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-09-05 Thread Scott Moser
Nominated this for xenial based on bug 1651497. ** Also affects: open-iscsi (Ubuntu Xenial) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title:

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-06-07 Thread Steve Langasek
** Changed in: open-iscsi (Ubuntu Bionic) Assignee: (unassigned) => Dimitri John Ledkov (xnox) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-06-07 Thread Steve Langasek
** Description changed: [Impact] - * Service is running uselessly which is consuming a few cycles/memory as -well as rasising general concerns e.g. on minimizing attack surfcae of -a system. +  * Service is running uselessly which is consuming a few cycles/memory as +    well as

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-06-07 Thread  Christian Ehrhardt 
** Description changed: + [Impact] + + * Service is running uselessly which is consuming a few cycles/memory as +well as rasising general concerns e.g. on minimizing attack surfcae of +a system. + + * Fix by switching to socket activation + + [Test Case] + + * After installing

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-06-01 Thread Steve Langasek
** Changed in: open-iscsi (Ubuntu Bionic) Status: Won't Fix => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-06-01 Thread  Christian Ehrhardt 
Done for Cosmic. Steve has mentioned he'd like to see an SRU of this to Bionic, but I think the change carries too much regression potential for an SRU. Please feel free to discuss. To make it clear I'm not working on Bionic, I'll set Won't Fix for now. ** Changed in: open-iscsi (Ubuntu

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-06-01 Thread Launchpad Bug Tracker
This bug was fixed in the package open-iscsi - 2.0.874-5ubuntu4 --- open-iscsi (2.0.874-5ubuntu4) cosmic; urgency=medium * debian/tests/install: ignore the potential stderr of the probing command that is meant to activate iscsid indirectly via the socket. open-iscsi

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-31 Thread  Christian Ehrhardt 
Ok, the forth was a charm - so on LP Infra it seems to be flaky which is a separate issue. This is the working log from the ppa:

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-31 Thread  Christian Ehrhardt 
This now worked a few times locally (4/4) but never on Infra (3/3). I first thought it would be a timeout for qemu-system-x86_64: terminating on signal 15 from pid 25607 (timeout) xkvm returned 124 in 3600s But that is only because it boots into emergency console and hangs there: You are in

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-30 Thread  Christian Ehrhardt 
The hit in "testsuite" is more complex, as it does not reproduce for me. >From the log: == ERROR: test_tgt_boot (__main__.CloudImageTest) -- Traceback (most

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-30 Thread  Christian Ehrhardt 
To be a bit faster (in case it is a race) than last time running with 4CPU and 2G memory this time. $ autopkgtest --apt-upgrade --shell-fail --no-built-binaries --apt-pocket=proposed=src:open-iscsi open-iscsi_2.0.874-5ubuntu3.dsc -- qemu --qemu-options='-cpu host' --cpus 4 --ram-size=2048

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-30 Thread  Christian Ehrhardt 
This worked in https://bileto.ubuntu.com/#/ticket/3268 when tested before (ppa now abandoned due to upload taking the version). I also had amd64 tests running locally (due to that the fix to the tests that I had added) But on the final migration it stumbles over it on LP Infra. So it might be a

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-30 Thread Bug Watch Updater
** Changed in: open-iscsi (Debian) Status: Unknown => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid autostarts on all servers when it has nothing to do To manage

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-30 Thread  Christian Ehrhardt 
Also reported to Debian and linked up their bug. It should help them just as much. And if they accept it maintenance/merges will be easier, while OTOH if they find issues we can fix them in our Delta - so either way it is good to make it known there. ** Bug watch added: Debian Bug tracker

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-30 Thread  Christian Ehrhardt 
MP is reviewed and accepted, new version pushed to Cosmic as https://launchpad.net/ubuntu/+source/open-iscsi/2.0.874-5ubuntu3 I ran and adapted the tests, but lets see how migration works if there are any surprises. ** Changed in: open-iscsi (Ubuntu) Status: Triaged => Fix Committed **

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-29 Thread Scott Moser
** Description changed: In bionic, the open-iscsi systemd unit has the following guards to keep it from running on systems with no iscsi targets configured: # Must have some pre-defined targets to login to ConditionDirectoryNotEmpty=|/etc/iscsi/nodes # or have a session to use via

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-25 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/346739 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-24 Thread Launchpad Bug Tracker
** Merge proposal unlinked: https://code.launchpad.net/~paelzer/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/346739 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-24 Thread  Christian Ehrhardt 
FYI: on the MP I'm iterating on different degrees of not-fun I have with dh_* in regard to control them to do exactly what I need for open-iscsi. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-24 Thread  Christian Ehrhardt 
Lets get it right in Cosmic also to see what we come up with and if you then say this should be safe for an SRU I'll follow your guidance :-) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858

Re: [Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-23 Thread Steve Langasek
On Wed, May 23, 2018 at 01:58:05PM -,  Christian Ehrhardt  wrote: > Fortunately we are so early in the cycle that I'd say if reviews and > tests seem good we can change it. And if on any image/maas/cloud tests > we break things we didn't expect there is time enough to revert it > before

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-23 Thread  Christian Ehrhardt 
Fortunately we are so early in the cycle that I'd say if reviews and tests seem good we can change it. And if on any image/maas/cloud tests we break things we didn't expect there is time enough to revert it before cosmic is entering any Freeze. -- You received this bug notification because you

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-23 Thread  Christian Ehrhardt 
I have a test branch and build + * make iscsid socket activated to only activate it as-needed (LP: #1755858) +- debian/open-iscsi.socket: systemd socket file for iscsid +- debian/open-iscsi.service: do not start or check iscsid.service +- debian/rules: install and enable iscsid.socket

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-23 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/open-iscsi/+git/open-iscsi/+merge/346739 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1755858 Title: iscsid

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-23 Thread  Christian Ehrhardt 
Interesting, this worked just fine without the iscsid.conf entry as in Fedora: iscsid.startup = /bin/systemctl start iscsid.socket I need to check the code for what this is used. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-23 Thread  Christian Ehrhardt 
Ok, this is the code path that tries to connect. It has a fallback to run this command. I think we would want anyway that this is not started in a random context, but from the socket/service. The following connect will then pick and start via the socket. -- You received this bug notification

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-23 Thread  Christian Ehrhardt 
Test 1: iscsiadm -m discovery -t sendtargets -p 127.0.0.1 worked to activate it as needed Test 2: /sbin/iscsiadm -m node --loginall=automatic Not activating it, but that is fine if nothing is defined Test 3: - define something with tgt, and configure it Note: remember to load iscsi_tcp in the

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-23 Thread  Christian Ehrhardt 
Most basic tests cross check on Fedora: First I tried a safe no-op $ iscsiadm -m discovery -t sendtargets -p 127.0.0.1 This is working fine on fedora to activate the service Then I tried on the fedora setup if the cmd we call would activate it. $ /sbin/iscsiadm -m node --loginall=automatic

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-23 Thread  Christian Ehrhardt 
Trying a hacky POC: 1. define iscsid.socket $ cat > /lib/systemd/system/iscsid.socket << EOF [Unit] Description=Open-iSCSI iscsid Socket Documentation=man:iscsid(8) man:iscsiadm(8) [Socket] ListenStream=@ISCSIADM_ABSTRACT_NAMESPACE [Install] WantedBy=sockets.target EOF $ systemctl enable

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-05-23 Thread  Christian Ehrhardt 
Status of a clean install in a VM and/or Container, so testable rather trivial: $ systemctl status iscsid open-iscsi ● iscsid.service - iSCSI initiator daemon (iscsid) Loaded: loaded (/lib/systemd/system/iscsid.service; enabled; vendor preset: enabled) Active: active (running) since Wed

[Bug 1755858] Re: iscsid autostarts on all servers when it has nothing to do

2018-04-18 Thread Steve Langasek
** Changed in: open-iscsi (Ubuntu) Importance: Undecided => High ** Changed in: open-iscsi (Ubuntu) Status: New => Triaged ** Changed in: open-iscsi (Ubuntu) Assignee: (unassigned) => Mathieu Trudel-Lapierre (cyphermox) ** Also affects: open-iscsi (Ubuntu Bionic) Importance: