[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-08-06 Thread Launchpad Bug Tracker
This bug was fixed in the package vte2.91 - 0.52.2-1ubuntu1~18.04.2 --- vte2.91 (0.52.2-1ubuntu1~18.04.2) bionic; urgency=medium * Revert the changes to revert-pcre2.patch in the previous SRU since they introduced API incompatibilies which aren't OK in an SRU (LP: #1780501).

Re: [Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-08-03 Thread Brian Murray
On Fri, Aug 03, 2018 at 11:06:38AM -, Egmont Koblinger wrote: > Hey guys, > > Hope I'm not speaking up too late. > > It's indeed a bit nasty situation we're in, and I am also a little bit > responsible for this. When updating the PCRE fixes for 0.52 I focused on > the actual work, and

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-08-03 Thread Alexander Perry
New here, found this while trying to resolve a problem running execute- command in guake. I enabled the proposed repository and upgraded to the version of vte2.91 found there. Problem was indeed fixed. Thanks for all your hard work guys! -- You received this bug notification because you are a

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-08-03 Thread Egmont Koblinger
Hey guys, Hope I'm not speaking up too late. It's indeed a bit nasty situation we're in, and I am also a little bit responsible for this. When updating the PCRE fixes for 0.52 I focused on the actual work, and ignored (just ported blindly in "autopilot" mode) the annotation changes. I should've

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-08-02 Thread Brian Murray
** Tags removed: verification-needed verification-needed-bionic ** Tags added: verification-done verification-done-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1780501 Title: Traceback

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-08-02 Thread Brian Murray
Here is a crash in terminator which occurs with the version of vte2.91 in bionic-updates: https://errors.ubuntu.com/problem/13b5b72882f409d035b674102f45b0eae419ab2d Here are some in guake: https://errors.ubuntu.com/problem/a15ca647934a403f748dad5b3400f805a59a0de7 (count of 52)

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-08-01 Thread Launchpad Bug Tracker
This bug was fixed in the package ubuntu-release-upgrader - 1:18.10.6 --- ubuntu-release-upgrader (1:18.10.6) cosmic; urgency=medium * DistUpgradeQuirks.py: - make sure that snapd is installed before trying to use it. (LP: #1783589) - update the view with information

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-08-01 Thread Launchpad Bug Tracker
** Branch linked: lp:ubuntu-release-upgrader -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1780501 Title: Traceback calling Vte.Terminal.feed_child() To manage notifications about this bug go to:

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-08-01 Thread Brian Murray
** Changed in: ubuntu-release-upgrader (Ubuntu) Status: Triaged => In Progress ** Changed in: ubuntu-release-upgrader (Ubuntu) Assignee: (unassigned) => Brian Murray (brian-murray) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-23 Thread Brian Murray
I've verified the test case for an upgrade from Bionic to Cosmic. bdmurray@clean-bionic-amd64:~$ grep vte /var/log/dist-upgrade/apt-term.log Preparing to unpack .../143-libvte-2.91-common_0.52.2-1ubuntu1_all.deb ... Unpacking libvte-2.91-common (0.52.2-1ubuntu1) over (0.52.2-1ubuntu1~18.04.2)

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-23 Thread Adam Conrad
Hello Brian, or anyone else affected, Accepted vte2.91 into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/vte2.91/0.52.2-1ubuntu1~18.04.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-19 Thread Brian Murray
** Description changed: - I was upgrading from Bionic to Cosmic when I received a conffile prompt - regarding /etc/update-initramfs/initramfs.conf, I clicked keep and then - saw this Traceback: + [Test Case] + 1) Ensure the following packages from -updates (version 0.52.2-1ubuntu1~18.04.1) are

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-17 Thread Iain Lane
** Changed in: vte2.91 (Ubuntu Bionic) Assignee: (unassigned) => Iain Lane (laney) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1780501 Title: Traceback calling Vte.Terminal.feed_child() To

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-17 Thread Francis Ginther
** Tags added: id-5b4d29002c528628776accad -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1780501 Title: Traceback calling Vte.Terminal.feed_child() To manage notifications about this bug go to:

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-16 Thread Iain Lane
It's uploaded. Please do test this; I gave it a bit of a go but I probably didn't exercise everything. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1780501 Title: Traceback calling

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-16 Thread Iain Lane
Oh and it would be helpful if you could write the SRU description since you have the real test case and I don't. Or waive it if you want. The regression potential is that I messed up the upload and everything using feed* breaks. -- You received this bug notification because you are a member of

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-16 Thread Iain Lane
OK. For the record, it's not an assumption. Catching TypeError is a way to deal with the fact that there were two versions of this function around. The version of Vte in bionic, because of the MIR team's refusal to let us have PCRE 2 in main, accidentally had an API break relative to the same

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-16 Thread Brian Murray
I agree that having downstream API differences is bad and that it shouldn't be fixed for cosmic. However, projects / packages other than ubuntu-release-upgrader have had to do extra work because of the SRU of this in Ubuntu 18.04. See https://bugs.launchpad.net/cubic/+bug/1779015 and the changes

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-11 Thread Iain Lane
s/addition/change/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1780501 Title: Traceback calling Vte.Terminal.feed_child() To manage notifications about this bug go to:

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-11 Thread Iain Lane
OK, my feeling is that we shouldn't fix vte2.91 for this. We had accidental downstream API differences here, which projects had to deal with and it's a good thing they don't any more. Definitely not for cosmic, although possibly more debatable in bionic- updates. Given that, u-r-u is going to

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-10 Thread Rico Tzschichholz
For reference https://lazka.github.io/pgi- docs/#Vte-2.91/classes/Terminal.html#Vte.Terminal.feed_child -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1780501 Title: Traceback calling

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-10 Thread Iain Lane
It'd be much nicer if you could ask before assigning bugs to me. Thanks. I'll ask Rico if he can take a look. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1780501 Title: Traceback calling

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-10 Thread Brian Murray
This may end of being an issue for terminator as it calls feed_child a couple of times. ** Changed in: vte2.91 (Ubuntu) Assignee: (unassigned) => Iain Lane (laney) ** Also affects: ubuntu-release-upgrader (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: vte2.91

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-09 Thread Brian Murray
And here is how guake deals with this: 121 def feed_child(self, resolved_cmdline): 122 if (Vte.MAJOR_VERSION, Vte.MINOR_VERSION) >= (0, 42): 123 encoded = resolved_cmdline.encode("utf-8") 124 try: 125 super().feed_child_binary(encoded) 126

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-09 Thread Brian Murray
Calling feed_child() with the version of vte2.91 in bionic-updates this way works: term.feed_child("n\n".encode("utf-8")) However, it seems that the length argument disappeared even though it continues to be documented. -- You received this bug notification because you are a member of Ubuntu

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-09 Thread Brian Murray
Dropping the patch that appears here: https://launchpadlibrarian.net/366367148/vte2.91_0.52.1-1ubuntu1_0.52.1-1ubuntu2.diff Makes Vte.Terminal.feed_child() work again, the way it has been for several releases of Ubuntu. -- You received this bug notification because you are a member of Ubuntu

[Bug 1780501] Re: Traceback calling Vte.Terminal.feed_child()

2018-07-09 Thread Brian Murray
Calling Vte.Terminal.feed_child() with "n\n", -1 works fine with version 0.52.1-1ubuntu1 on Ubuntu 18.04 but using version in bionic-updates and cosmic I receive the following Traceback: In [10]: term.feed_child("n\n", -1)