[Bug 1785649] Re: [MIR] gupnp-dlna
** Changed in: gupnp-dlna (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1785649 Title: [MIR] gupnp-dlna To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gupnp-dlna/+bug/1785649/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1785649] Re: [MIR] gupnp-dlna
+1 on the MIR side ** Changed in: gupnp-dlna (Ubuntu) Status: New => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1785649 Title: [MIR] gupnp-dlna To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gupnp-dlna/+bug/1785649/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1785649] Re: [MIR] gupnp-dlna
** Changed in: gupnp-dlna (Ubuntu) Status: Expired => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1785649 Title: [MIR] gupnp-dlna To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gupnp-dlna/+bug/1785649/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1785649] Re: [MIR] gupnp-dlna
[Expired for gupnp-dlna (Ubuntu) because there has been no activity for 60 days.] ** Changed in: gupnp-dlna (Ubuntu) Status: Incomplete => Expired -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1785649 Title: [MIR] gupnp-dlna To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gupnp-dlna/+bug/1785649/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1785649] Re: [MIR] gupnp-dlna
on the autopkgtests question, I guess some for each components will be good to have a finer grained migration prevention. (even if those are testing the same thing, duplicated between packages). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1785649 Title: [MIR] gupnp-dlna To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gupnp-dlna/+bug/1785649/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1785649] Re: [MIR] gupnp-dlna
Let's turn those as incomplete to get off the list until we get over them again (probably next cycle). ** Changed in: gupnp-dlna (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1785649 Title: [MIR] gupnp-dlna To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gupnp-dlna/+bug/1785649/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1785649] Re: [MIR] gupnp-dlna
** Changed in: gupnp-dlna (Ubuntu) Assignee: Didier Roche (didrocks) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1785649 Title: [MIR] gupnp-dlna To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gupnp-dlna/+bug/1785649/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1785649] Re: [MIR] gupnp-dlna
Thanks for the review, some of the fixes are commited now, also some tweaks still needed before upload (see question bellow) https://salsa.debian.org/gnome-team/gupnp-dlna/commit/b161b805 > * -doc package: I think we should promote it as well in main ... If so, this > dep should be fixed: Depends: lynx | www-browser Done, changed to a Suggests: devhelp > I think the build-dep on libgupnp-1.0-dev may thus be optional Seems to be indeed, no difference without it, I removed it > * debian/copyright has some missing copyright notices: > Copyright: 2012-2013 Intel Corporation for instance in * as GPL-2.0+ Thanks, fixed now > * 2 of the 4 lintian warning worth fixing IMHO: > W: libgupnp-dlna-2.0-dev: gir-missing-typelib-dependency > usr/share/gir-1.0/GUPnPDLNAGst-2.0.gir gir1.2-gupnpdlnagst-2.0 -> dep from > the -dev on the gir* That's a bit tricky, there is no corresponding gir (which is the cause for the other lintian warning), they preferred to bundle the gir in the same binary and use a provide, in that context I don't think adding the depends makes sense? would you be ok with a lintian override? > W: gir1.2-gupnpdlna-2.0: typelib-package-name-does-not-match usr/lib/x86_64-linux-gnu/girepository-1.0/GUPnPDLNAGst-2.0.typelib gir1.2-gupnpdlnagst-2.0 <- this one worth only an override IMHO + an explanation. k (not done yet, pending on what to do with the other warning) > Minor: > - VCS could be updated in debian/control* done in the Debian vcs already so stagged for the next upload Do you want autopkgtest for that specific component or would be one for the gunpn stack enough? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1785649 Title: [MIR] gupnp-dlna To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gupnp-dlna/+bug/1785649/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1785649] Re: [MIR] gupnp-dlna
Tests are actually ran during package build (but one is skipped, as it needs a more complex setup). So, good in that regard. Should it ran as autopkgtests though? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1785649 Title: [MIR] gupnp-dlna To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gupnp-dlna/+bug/1785649/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1785649] Re: [MIR] gupnp-dlna
* -doc package: I think we should promote it as well in main, if the -dev is promoted. If so, this dep should be fixed: Depends: lynx | www-browser (first is lynx, in universe, www-browser is a virtual package not fullfiled?). In addition, it ships the doc in devhelp format (despite symlink from doc/ to gtk-doc/). I don't think anyway that those are needed, we don't tend to have -doc dep on a browser implementation. * NEWS file has: 0.9.2 - Remove the old gupnp-dlna-1.1.pc.in file. / Remove gupnp and gstreamer-* dependencies from VAPI file generation. I think the build-dep on libgupnp-1.0-dev may thus be optional (only used for VAPI file, see "Note to self" below). Do you mind checking? * Any progress on getting the usptream testsuite running during package build and autopkgtests? * debian/copyright has some missing copyright notices: Copyright: 2012-2013 Intel Corporation for instance in * as GPL-2.0+ I think that's the only missing one, but better to double check * 2 of the 4 lintian warning worth fixing IMHO: W: libgupnp-dlna-2.0-dev: gir-missing-typelib-dependency usr/share/gir-1.0/GUPnPDLNAGst-2.0.gir gir1.2-gupnpdlnagst-2.0 -> dep from the -dev on the gir* W: gir1.2-gupnpdlna-2.0: typelib-package-name-does-not-match usr/lib/x86_64-linux-gnu/girepository-1.0/GUPnPDLNAGst-2.0.typelib gir1.2-gupnpdlnagst-2.0 <- this one worth only an override IMHO + an explanation. Minor: - VCS could be updated in debian/control* Note to self/remarks: * I was surprised to find the build-dep on libgupnp-1.0-dev on this universe package. I checked the binary packages though, and there is no dep on libgupnp-1.0-4. It's not statically linked either, but only used for generated the vapi file. I think some of the stuff should be addressed like test running before I give my +1. Then, as this is a network protocole (as for the whole dlna stack), I will defer to the security team for a review from a security perspective. I didn't spot anything crazy in the code itself, but I prefer deferring to experts :) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1785649 Title: [MIR] gupnp-dlna To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gupnp-dlna/+bug/1785649/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1785649] Re: [MIR] gupnp-dlna
** Changed in: gupnp-dlna (Ubuntu) Assignee: (unassigned) => Didier Roche (didrocks) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1785649 Title: [MIR] gupnp-dlna To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gupnp-dlna/+bug/1785649/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1785649] Re: [MIR] gupnp-dlna
** Changed in: gupnp-dlna (Ubuntu) Status: Confirmed => New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1785649 Title: [MIR] gupnp-dlna To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gupnp-dlna/+bug/1785649/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1785649] Re: [MIR] gupnp-dlna
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: gupnp-dlna (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1785649 Title: [MIR] gupnp-dlna To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/gupnp-dlna/+bug/1785649/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
