[Bug 1800566] Re: Make reset_devices parameter default for kdump
This bug was fixed in the package makedumpfile - 1:1.6.3-2~16.04.2 --- makedumpfile (1:1.6.3-2~16.04.2) xenial; urgency=medium * Let the kernel decide the crashkernel offset for ppc64el (LP: #1741860) * Reload kdump after memory/CPU hotplug. (LP: #1655280) * Use a different service for vmcore dump. (LP: #1811692) * Reload kdump when CPU is brought online. (LP: #1828596) * Add a reload command. (LP: #1828596) * kdump-config: implement try-reload (LP: #1828596) * udev: hotplug: use try-reload (LP: #1828596) * Use reset_devices as a cmdline parameter. (LP: #1800566) -- Thadeu Lima de Souza Cascardo Wed, 18 Dec 2019 16:06:16 -0300 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump
This bug was fixed in the package makedumpfile - 1:1.6.5-1ubuntu1~18.04.4 --- makedumpfile (1:1.6.5-1ubuntu1~18.04.4) bionic; urgency=medium [ Thadeu Lima de Souza Cascardo ] * Fixes for DLPAR cpu add operation (LP: #1828596) - d/kdump-config.in: Add a reload command. - d/kdump-config.in: implement try-reload. - d/50-kdump-tools.rules: Use kdump-config reload after cpu or memory hotplug - d/50-kdump-tools.rules: use try-reload instead. * d/rules: Use reset_devices as a cmdline parameter. (LP: #1800566) [ Guilherme G. Piccoli ] * d/kdump-tools-dump.service: Add a systemd-resolved service dependency in order to make kdump-tool able to resolve DNS when in kdump boot. (LP: #1856323) * Fix an error due to makedumpfile being out-of-sync with recent kernels. (LP: #1857616) - d/p/0004-x86_64-fix-get_kaslr_offset_x86_64-to-return-kaslr_offset-correctly.patch - d/p/0005-Increase-SECTION_MAP_LAST_BIT-to-4.patch -- gpicc...@canonical.com (Guilherme G. Piccoli) Fri, 03 Jan 2020 13:14:39 -0300 ** Changed in: makedumpfile (Ubuntu Bionic) Status: Fix Committed => Fix Released ** Changed in: makedumpfile (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump
This bug was fixed in the package makedumpfile - 1:1.6.6-2ubuntu2 --- makedumpfile (1:1.6.6-2ubuntu2) eoan; urgency=medium [ Thadeu Lima de Souza Cascardo ] * Fixes for DLPAR cpu add operation (LP: #1828596) - d/kdump-config.in: Add a reload command. - d/kdump-config.in: implement try-reload. - d/50-kdump-tools.rules: Use kdump-config reload after cpu or memory hotplug - d/50-kdump-tools.rules: use try-reload instead. * d/rules: Use reset_devices as a cmdline parameter. (LP: #1800566) [ Guilherme G. Piccoli ] * d/kdump-tools-dump.service: Add a systemd-resolved service dependency in order to make kdump-tool able to resolve DNS when in kdump boot. (LP: #1856323) * d/p/0003-Increase-SECTION_MAP_LAST_BIT-to-4.patch: x86_64: Fix an error due to makedumpfile being out-of-sync with recent kernels. (LP: #1857616) -- gpicc...@canonical.com (Guilherme G. Piccoli) Fri, 03 Jan 2020 16:10:19 -0300 ** Changed in: makedumpfile (Ubuntu Eoan) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump
I've verified this LP in all 3 releases, by installing the package sin -proposed and checking the command-line of kdump kernel, which contains "reset_devices" for all the 3 versions tested: 1:1.6.3-2~16.04.2 for xenial, 1:1.6.5-1ubuntu1~18.04.4 for bionic, 1:1.6.6-2ubuntu2 for eoan. Cheers, Guilherme ** Changed in: makedumpfile (Ubuntu Trusty) Importance: High => Undecided ** Changed in: makedumpfile (Ubuntu Trusty) Assignee: Guilherme G. Piccoli (gpiccoli) => (unassigned) ** Tags removed: verification-needed verification-needed-bionic verification-needed-eoan verification-needed-xenial ** Tags added: verification-done verification-done-bionic verification-done-eoan verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump
Sorry for the typo in last comment: "package sin - proposed" -> "packages in -proposed" ! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump
Hello Guilherme, or anyone else affected, Accepted makedumpfile into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/makedumpfile/1:1.6.3-2~16.04.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: makedumpfile (Ubuntu Xenial) Status: In Progress => Fix Committed ** Tags added: verification-needed-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump
Hello Guilherme, or anyone else affected, Accepted makedumpfile into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/makedumpfile/1:1.6.5-1ubuntu1~18.04.4 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: makedumpfile (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags added: verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump
Hello Guilherme, or anyone else affected, Accepted makedumpfile into eoan-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/makedumpfile/1:1.6.6-2ubuntu2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-eoan to verification-done-eoan. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-eoan. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: makedumpfile (Ubuntu Eoan) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-eoan -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump
** Changed in: makedumpfile (Ubuntu Disco) Status: In Progress => Won't Fix ** Changed in: makedumpfile (Ubuntu Disco) Importance: High => Undecided ** Changed in: makedumpfile (Ubuntu Disco) Assignee: Guilherme G. Piccoli (gpiccoli) => (unassigned) ** Changed in: makedumpfile (Ubuntu Cosmic) Importance: High => Undecided ** Changed in: makedumpfile (Ubuntu Cosmic) Assignee: Guilherme G. Piccoli (gpiccoli) => (unassigned) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump
For this LP SRU submission, the following candidate packages were tested in amd64 arch: * Xenial, candidate version 1.6.3-2~16.04.2; * Bionic, candidate version 1.6.5-1ubuntu1~18.04.4; * Disco, candidate version 1.6.5-1ubuntu1.4; * Eoan, candidate version 1.6.6-2ubuntu2; The test consisted in installing the package and check "kdump-config show" output to validate if the "reset_devices" parameter was added to kdump command-line. Cheers, Guilherme -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump
This bug was fixed in the package makedumpfile - 1:1.6.6-4ubuntu1 --- makedumpfile (1:1.6.6-4ubuntu1) focal; urgency=medium [ Thadeu Lima de Souza Cascardo ] * Merge from Debian unstable. Remaining changes: - Bump amd64 crashkernel from 384M-:128M to 512M-:192M. * Use reset_devices as a cmdline parameter. (LP: #1800566) * Use kdump-config reload after cpu or memory hotplug. (LP: #1828596) [ Guilherme G. Piccoli ] * Add a systemd-resolved service dependency in order kdump-tools is able to resolve DNS when in kdump boot. (LP: #1856323) makedumpfile (1:1.6.6-4) unstable; urgency=medium * Let the kernel decide the crashkernel offset for ppc64el (LP: #1741860) * kdump-config: implement try-reload * udev: hotplug: use try-reload * Set Rules-Requires-Root to no makedumpfile (1:1.6.6-3) unstable; urgency=medium * Add a reload command. * Use kdump-config reload after cpu or memory hotplug. * Use reset_devices as a cmdline parameter. -- Thadeu Lima de Souza Cascardo Wed, 18 Dec 2019 14:38:51 -0300 ** Changed in: makedumpfile (Ubuntu Focal) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump
After some attempt to merge the work needed in LP #1816743 here, we decided to split the bugs and only work the 'reset_devices' addition here. Cheers, Guilherme ** Summary changed: - Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND + Make reset_devices parameter default for kdump ** Description changed: [Impact] * Kdump does not configure by default the crash kernel to perform a - device reset by default, by passing the "reset_devices" parameter. Also, - the systemd service "kdump-tools-dump" is tightly-coupled with - KDUMP_CMDLINE_APPEND and it shouldn't, to prevent user confusion. + device reset by default, by passing the "reset_devices" parameter. * Kernel has the "reset_devices" parameter that drivers can opt-in, and perform special activity in case this parameter is parsed from command- line. For example, in kdump kernels it hints the drivers that they are booting from a non-healthy condition and needs to issue some form of reset to the adapter, like clearing DMA mapping in their firmware for - example. Users currently (kernel v5.2) are: aacraid, hpsa, ipr, + example. Users currently (kernel v5.5-rc2) are: aacraid, hpsa, ipr, megaraid_sas, mpt3sas, smartpqi, xenbus. This should be enabled by default in the kdump config file to be added in the kdump kernel command-line for all versions. - * The systemd service"kdump-tools-dump" is responsible for triggering the execution of the makedumpfile tool ultimately. Kdump from Xenial+ releases rely on systemd as their init system, so this service is the way to trigger the kdump mechanism. Currently it is configured as any other parameter in KDUMP_CMDLINE_APPEND, meaning if user decides to change the line they need to remember adding the systemd service back. It's not really a parameter that should be easily manipulated in kdump line, since there's no use for it except to instruct systemd to load kdump; the only - reasonable case for removing it is to debug kdump itself. - - [Test Case] - 1) Deploy a Disco VM e.g. with uvt-kvm + 1) Deploy a Bionic VM e.g. with uvt-kvm 2) Install the kdump-tools package 3) Run `kdump-config test`and check for the 'reset_devices' parameter: $ kdump-config test ... kexec command to be used: /sbin/kexec -p --command-line="BOOT_IMAGE=/boot/vmlinuz-4.15.0-45-generic root=LABEL=cloudimg-rootfs ro console=tty1 console=ttyS0 nr_cpus=1 systemd.unit=kdump-tools.service irqpoll nousb ata_piix.prefer_ms_hyperv=0" /var/lib/kdump/vmlinuz - - Also, by changing the KDUMP_CMDLINE_APPEND we can see "systemd.unit - =kdump-tools.service" to be removed. [Regression Potential] The regression potential is low, since it doesn't need any changes in makedumpfile code and we're only adding a parameter on the crash kernel command-line. The risks are related with bad behavior with the kernel when using "reset_devices", like if the driver has bugs in this path. It's considered safer to have the option (and this way prevent problems for booting a unhealthy kernel with potential stuck DMAs in the devices) than not having it. - - Regarding the other change, about the systemd service, it'll only affect - users the are debugging kdump itself and it has no known regression - potential. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND
** Changed in: makedumpfile (Ubuntu Disco) Status: Won't Fix => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND
** Changed in: makedumpfile (Ubuntu Disco) Status: Confirmed => Won't Fix ** Changed in: makedumpfile (Ubuntu Focal) Status: Confirmed => In Progress ** Changed in: makedumpfile (Ubuntu Eoan) Status: Confirmed => In Progress ** Changed in: makedumpfile (Ubuntu Bionic) Status: Confirmed => In Progress ** Changed in: makedumpfile (Ubuntu Xenial) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND
** Changed in: makedumpfile (Ubuntu Eoan) Status: In Progress => Confirmed ** Changed in: makedumpfile (Ubuntu Focal) Status: In Progress => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND
** Also affects: makedumpfile (Ubuntu Focal) Importance: High Assignee: Guilherme G. Piccoli (gpiccoli) Status: In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND
** Changed in: makedumpfile (Ubuntu Cosmic) Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND
The attachment "lp1800566_eoan.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND
This is the debdiff with this LP's proposed modifications. I'd like to specially thanks Cascardo and Heitor for the discussions and joint work in this issue. ** Changed in: makedumpfile (Ubuntu Eoan) Status: Confirmed => In Progress ** Patch added: "lp1800566_eoan.debdiff" https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+attachment/5275118/+files/lp1800566_eoan.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND
** Description changed: [Impact] - Crash kernels do not advise some subsystems to perform a reset by default. - [Description] - Kernel has the "reset_devices" parameter that drivers can opt-in, and perform special activity in case this parameter is parsed from command-line. For example, in kdump kernels it hints the drivers that they (maybe) are booting from a non-healthy condition and needs to issue some reset to the adapter. Users currently (kernel v4.19) are: hpsa, ipr, megaraid_sas, mpt3sas, smartpqi, xenbus. + * Kdump does not configure by default the crash kernel to perform a + device reset by default, by passing the "reset_devices" parameter. Also, + the systemd service "kdump-tools-dump" is tightly-coupled with + KDUMP_CMDLINE_APPEND and it shouldn't, to prevent user confusion. + + * Kernel has the "reset_devices" parameter that drivers can opt-in, and + perform special activity in case this parameter is parsed from command- + line. For example, in kdump kernels it hints the drivers that they are + booting from a non-healthy condition and needs to issue some form of + reset to the adapter, like clearing DMA mapping in their firmware for + example. Users currently (kernel v5.2) are: aacraid, hpsa, ipr, + megaraid_sas, mpt3sas, smartpqi, xenbus. This should be enabled by default in the kdump config file to be added in the kdump kernel command-line for all versions. + * The systemd service"kdump-tools-dump" is responsible for triggering the execution of the makedumpfile tool ultimately. Kdump from Xenial+ releases rely on systemd as their init system, so this service is the way to trigger the kdump mechanism. Currently it is configured as any other parameter in KDUMP_CMDLINE_APPEND, meaning if user decides to change the line they need to remember adding the systemd service back. It's not really a parameter that should be easily manipulated in kdump line, since there's no use for it except to instruct systemd to load kdump; the only + reasonable case for removing it is to debug kdump itself. + + [Test Case] + 1) Deploy a Disco VM e.g. with uvt-kvm 2) Install the kdump-tools package 3) Run `kdump-config test`and check for the 'reset_devices' parameter: $ kdump-config test ... kexec command to be used: /sbin/kexec -p --command-line="BOOT_IMAGE=/boot/vmlinuz-4.15.0-45-generic root=LABEL=cloudimg-rootfs ro console=tty1 console=ttyS0 nr_cpus=1 systemd.unit=kdump-tools.service irqpoll nousb ata_piix.prefer_ms_hyperv=0" /var/lib/kdump/vmlinuz + Also, by changing the KDUMP_CMDLINE_APPEND we can see "systemd.unit + =kdump-tools.service" to be removed. + + [Regression Potential] - The regression potential is very low, since it doesn't need any changes in makedumpfile code and we're only adding a parameter on the crashkernel cmdline. - The fix will be tested with autopkgtests and normal kdump use-case scenarios. + + The regression potential is low, since it doesn't need any changes in + makedumpfile code and we're only adding a parameter on the crash kernel + command-line. The risks are related with bad behavior with the kernel + when using "reset_devices", like if the driver has bugs in this path. + It's considered safer to have the option (and this way prevent problems + for booting a unhealthy kernel with potential stuck DMAs in the devices) + than not having it. + + Regarding the other change, about the systemd service, it'll only affect + users the are debugging kdump itself and it has no known regression + potential. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1800566] Re: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND
** Summary changed: - Make the reset_devices parameter default for kdump kernels + Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1800566 Title: Make reset_devices parameter default for kdump and decouple kdump systemd service from the KDUMP_CMDLINE_APPEND To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/makedumpfile/+bug/1800566/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
