[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
** Changed in: debian-installer (Ubuntu Cosmic) Status: New => Won't Fix ** Changed in: debian-installer (Ubuntu Bionic) Status: New => Won't Fix ** Changed in: debian-installer (Ubuntu) Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
** Tags added: vroc -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
This bug was fixed in the package mdadm - 4.1~rc1-3~ubuntu18.04.2 --- mdadm (4.1~rc1-3~ubuntu18.04.2) bionic; urgency=medium * d/p/lp-1811228-imsm-Block-volume-creation-with-empty-name.patch: avoid creating whitespaced or empty names (LP: #1811228) * d/p/lp-1811795-remove-external-arrays-and-devices.patch: fix removal of failing disks with external metadata (LP: #1811795) -- Christian Ehrhardt Wed, 10 Apr 2019 16:14:17 +0200 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
This bug was fixed in the package mdadm - 4.1~rc1-4ubuntu1.1 --- mdadm (4.1~rc1-4ubuntu1.1) cosmic; urgency=medium * d/p/lp-1811228-imsm-Block-volume-creation-with-empty-name.patch: avoid creating whitespaced or empty names (LP: #1811228) * d/p/lp-1811795-remove-external-arrays-and-devices.patch: fix removal of failing disks with external metadata (LP: #1811795) -- Christian Ehrhardt Wed, 10 Apr 2019 16:14:17 +0200 ** Changed in: mdadm (Ubuntu Cosmic) Status: Fix Committed => Fix Released ** Changed in: mdadm (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
Hi, I have tested issue in cosmic-proposed. It is fixed. Regards, Krzysztof -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
Thanks Mariusz! Since this verification needs special HW which at least I currently have none of - do you see a chance to also do the verification for cosmic-proposed? Lacking that it can't be really released for Bionic as it would then become an upgrade-regression. ** Tags removed: verification-needed-bionic ** Tags added: verification-done-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
Hi, the issue is fixed in bionic-proposed. Thanks Mariusz -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
Hello Roman, or anyone else affected, Accepted mdadm into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mdadm/4.1~rc1-3~ubuntu18.04.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: mdadm (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags added: verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
Hello Roman, or anyone else affected, Accepted mdadm into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mdadm/4.1~rc1-4ubuntu1.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: mdadm (Ubuntu Cosmic) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-cosmic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
Thanks for checking the PPA Mariusz. This will now go to the review by the SRU Team. Once accepted they will ask for a verification in -proposed (of both affected releases). Once that is complete this can be released to all users. ** Changed in: mdadm (Ubuntu Bionic) Status: Incomplete => In Progress ** Changed in: mdadm (Ubuntu Cosmic) Status: Incomplete => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
Hi, The issue is fixed in PPA. Thanks, Mariusz -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
Incomplete waiting for PAP verification ** Changed in: mdadm (Ubuntu Bionic) Status: New => Incomplete ** Changed in: mdadm (Ubuntu Cosmic) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
Hi, I need your help in testing this. I have created a PPA [1] with the fixes for this issue, but I lack a IMSM HW. I'd ask the people affected/subscribed to test the PPA. While doing so please a) ensure the test steps you have trigger the bug without the PPA b) ensure the PPA fixes the issue Test steps on this bug seemed already good to me, but if you have issues using those to confirm it please let me know that we can fix the Description. [1]: https://launchpad.net/~paelzer/+archive/ubuntu/bug-1811228-1811795 -mdadm-imsm ** Description changed: + [Impact] + + * Due to a lack of input checking mdadm could program the IMSM +with empty "" names for the storage devices causing issues +later on. + + * Fix by backporting a fix that was committed shortly after what made +it into Bionic/Disco + + [Test Case] + + * This needs a Intel(R) Matrix Storage Hardware which limits the +systems this can be tested. Below in the original report is example +output of these commands. +$ mdadm --create /dev/md/imsm0 --metadata=imsm --raid-devices=2 /dev/nvme11n1 /dev/nvme12n1 --run +$ mdadm --create /dev/md/r0d2 --level=0 --chunk=128 --raid-devices=2 /dev/nvme11n1 /dev/nvme12n1 --run +$ mdadm -D /dev/md/imsm0 +$ mdadm --stop /dev/md/r0d2 +$ mdadm --update-subarray=0 --update=name -N "" /dev/md/imsm0 +# the command above should not be allowed, empty of non-trimmed names cause issues down the road. +$ mdadm --assemble --scan +$ mdadm -D /dev/md/imsm0 + + [Regression Potential] + + * The fixes are local to the support of the Intel(R) Matrix Storage +Manager through mdadm. As much as that makes testing harder it also +limits the fallout of regressions to other components. +The one regression I could think of is automation/scripts that +expects to work with whitespaces, but since that is known to +fail it is better to force them off of that. + + [Other Info] + + * n/a + + --- + Description: Mdadm allows to change the name of the volume to any, including empty, too short and too long. White spaces in the begin or end of the correct name are not trimmed properly. Steps to reproduce: 1.Create the volume: # mdadm --create /dev/md/imsm0 --metadata=imsm --raid-devices=2 /dev/nvme11n1 /dev/nvme12n1 --run # mdadm --create /dev/md/r0d2 --level=0 --chunk=128 --raid-devices=2 /dev/nvme11n1 /dev/nvme12n1 --run 2.Check if volume name is correct: # mdadm -D /dev/md/imsm0 /dev/md/imsm0: -Version : imsm - Raid Level : container - Total Devices : 2 + Version : imsm + Raid Level : container + Total Devices : 2 -Working Devices : 2 + Working Devices : 2 + UUID : 6dce006b:086ce0fa:bdcf4f9e:d8bd68c4 + Member Arrays : /dev/md/r0d2 - UUID : 6dce006b:086ce0fa:bdcf4f9e:d8bd68c4 - Member Arrays : /dev/md/r0d2 + Number Major Minor RaidDevice - Number Major Minor RaidDevice - -- 259 13-/dev/nvme12n1 -- 259 12-/dev/nvme11n1 + - 259 13-/dev/nvme12n1 + - 259 12-/dev/nvme11n1 root@gklab-94-128:~# mdadm -D /dev/md/r0d2 /dev/md/r0d2: - Container : /dev/md/imsm0, member 0 - Raid Level : raid0 - Array Size : 781412352 (745.21 GiB 800.17 GB) - Raid Devices : 2 - Total Devices : 2 + Container : /dev/md/imsm0, member 0 + Raid Level : raid0 + Array Size : 781412352 (745.21 GiB 800.17 GB) + Raid Devices : 2 + Total Devices : 2 - State : clean - Active Devices : 2 -Working Devices : 2 - Failed Devices : 0 - Spare Devices : 0 + State : clean + Active Devices : 2 + Working Devices : 2 + Failed Devices : 0 + Spare Devices : 0 - Chunk Size : 128K + Chunk Size : 128K Consistency Policy : none - - UUID : 9608dbcd:e4668ab4:015e7469:a263e5e0 - Number Major Minor RaidDevice State -0 259 120 active sync /dev/nvme11n1 -1 259 131 active sync /dev/nvme12n1 + UUID : 9608dbcd:e4668ab4:015e7469:a263e5e0 + Number Major Minor RaidDevice State + 0 259 120 active sync /dev/nvme11n1 + 1 259 131 active sync /dev/nvme12n1 3.Stop the volume: # mdadm --stop /dev/md/r0d2 4.Try to change the name of the volume. New name should not be allowed by mdadm (ex. empty), or shuld start or end with whitespaces: # mdadm --update-subarray=0 --update=name -N "" /dev/md/imsm0 5.Assembly the volume: # mdadm --assemble --scan mdadm: Started /dev/md126 with 2 devices 6. Check the volume name. Expected result: Mdam should not allow to
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/mdadm/+git/mdadm/+merge/365794 ** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/mdadm/+git/mdadm/+merge/365795 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
** Changed in: mdadm (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
** Also affects: debian-installer (Ubuntu Cosmic) Importance: Undecided Status: New ** Also affects: mdadm (Ubuntu Cosmic) Importance: Undecided Status: New ** Also affects: debian-installer (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: mdadm (Ubuntu Bionic) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
Hi, It is fixed in 19.04 (mdadm there is 4.1). Any chances to include the fix in 18.04 LTS? Thanks Pawel -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
Patch which fix this issue: https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/commit/?id=9bd99a90e110bd39beaa539cb44a70ee3264a270 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
** Information type changed from Private to Public -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1811228] Re: Mdadm allows to change the name of the volume to empty and not trim whitespaces.
This issue was already fixed in released mdadm-4.1. https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/commit/?id=20e8fe52e7190b3ffda127566852eac2eb7fa1f7 Actually there is "mdadm - v4.1-rc1 - 2018-03-22" in Ubuntu 18.04.2. Please update mdadm package to mdadm-4.1. ** Information type changed from Public to Private ** Package changed: debian-installer (Ubuntu) => mdadm (Ubuntu) ** Also affects: debian-installer (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1811228 Title: Mdadm allows to change the name of the volume to empty and not trim whitespaces. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/debian-installer/+bug/1811228/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
