[Bug 1813059] Re: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2
This bug was fixed in the package fwts - 18.03.00-0ubuntu4 --- fwts (18.03.00-0ubuntu4) bionic; urgency=medium [Colin Ian King] * efi_runtime: fix access_ok build issues on 5.0 kernels (LP: #1813059) - add Linux 5.0 compat fix to access_ok to fix dkms build issue -- Colin Ian King Thu, 24 Jan 2019 09:25:11 + ** Changed in: fwts (Ubuntu Bionic) Status: Fix Committed => Fix Released ** Changed in: fwts (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813059 Title: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/1813059/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813059] Re: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2
This bug was fixed in the package fwts - 16.03.00-0ubuntu1.3 --- fwts (16.03.00-0ubuntu1.3) xenial; urgency=low [Colin Ian King] * efi_runtime: fix access_ok build issues on 5.0 kernels (LP: #1813059) - add Linux 5.0 compat fix to access_ok to fix dkms build issue -- Colin Ian King Thu, 24 Jan 2019 09:25:11 + -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813059 Title: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/1813059/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813059] Re: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2
This bug was fixed in the package fwts - 18.09.00-0ubuntu2 --- fwts (18.09.00-0ubuntu2) cosmic; urgency=medium [Colin Ian King] * efi_runtime: fix access_ok build issues on 5.0 kernels (LP: #1813059) - add Linux 5.0 compat fix to access_ok to fix dkms build issue -- Colin Ian King Thu, 24 Jan 2019 09:25:11 + ** Changed in: fwts (Ubuntu Cosmic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813059 Title: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/1813059/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813059] Re: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2
tested fwts 18.09.00-0ubuntu2 on cosmic against 4.18 and 5.0 linux headers and module builds and works OK as well. ** Tags removed: verification-needed verification-needed-bionic verification-needed-cosmic verification-needed-xenial ** Tags added: verification-done verification-done-bionic verification-done-cosmic verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813059 Title: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/1813059/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813059] Re: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2
tested fwts 16.03.00-0ubuntu1.3 on xenial against 4.4 and 5.0 linux headers and module builds and works OK. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813059 Title: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/1813059/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813059] Re: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2
tested fwts 18.04.00-0ubuntu4 on bionic against 4.15 and 5.0 linux headers and module builds and works OK too. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813059 Title: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/1813059/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813059] Re: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2
Hello Seth, or anyone else affected, Accepted fwts into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwts/18.09.00-0ubuntu2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: fwts (Ubuntu Cosmic) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-cosmic ** Changed in: fwts (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags added: verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813059 Title: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/1813059/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813059] Re: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2
** Changed in: fwts (Ubuntu Cosmic) Assignee: (unassigned) => Colin Ian King (colin-king) ** Changed in: fwts (Ubuntu Bionic) Assignee: (unassigned) => Colin Ian King (colin-king) ** Changed in: fwts (Ubuntu Xenial) Assignee: (unassigned) => Colin Ian King (colin-king) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813059 Title: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/1813059/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813059] Re: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2
This bug was fixed in the package fwts - 19.01.00-0ubuntu2 --- fwts (19.01.00-0ubuntu2) disco; urgency=medium [Colin Ian King] * efi_runtime: fix access_ok build issues on 5.0 kernels (LP: #1813059) - add Linux 5.0 compat fix to access_ok to fix dkms build issue -- Colin Ian King Thu, 24 Jan 2019 09:25:11 + ** Changed in: fwts (Ubuntu Disco) Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813059 Title: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/1813059/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813059] Re: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2
** Description changed: + == SRU Justification, Xenial, Bionic, Cosmic == + + The DKMS kernel module fails to build if new 5.0 kernels are used + because of an API change in access_ok(). + + == Fix == + + Add a kernel version detection and a macro compat fix to paper over the + API differences between the two version: + + +#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 0, 0) + +#define ACCESS_OK(type, addr, size)access_ok(addr, size) + +#else + +#define ACCESS_OK(type, addr, size)access_ok(type, addr, size) + +#endif + + and use ACCESS_OK instead of access_ok. + + == Regression Potential == + + Minimal - this build time change will select the appropriate API, so the + final resultant compiled code will be identical to the original before + the patch for current kernels, and only different for 5.0+ kernels. + + == How To test == + + Install fwts with a 5.0 kernel. Without the fix the dkms build of the + efi driver will fail. With the fix it will succeed. + + -- + + Testing failed on: - amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/amd64/f/fwts/20190123_163310_2b561@/log.gz - arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/arm64/f/fwts/20190123_164249_2b561@/log.gz - armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/armhf/f/fwts/20190123_164402_2b561@/log.gz - i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/i386/f/fwts/20190123_163518_2b561@/log.gz - ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/ppc64el/f/fwts/20190123_163508_2b561@/log.gz + amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/amd64/f/fwts/20190123_163310_2b561@/log.gz + arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/arm64/f/fwts/20190123_164249_2b561@/log.gz + armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/armhf/f/fwts/20190123_164402_2b561@/log.gz + i386: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/i386/f/fwts/20190123_163518_2b561@/log.gz + ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-disco-canonical-kernel-team-unstable/disco/ppc64el/f/fwts/20190123_163508_2b561@/log.gz ** Changed in: fwts (Ubuntu Xenial) Importance: Undecided => Low ** Changed in: fwts (Ubuntu Bionic) Importance: Undecided => Low ** Changed in: fwts (Ubuntu Cosmic) Importance: Undecided => Low ** Changed in: fwts (Ubuntu Xenial) Status: New => In Progress ** Changed in: fwts (Ubuntu Bionic) Status: New => In Progress ** Changed in: fwts (Ubuntu Cosmic) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813059 Title: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/1813059/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813059] Re: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2
** Also affects: fwts (Ubuntu Bionic) Importance: Undecided Status: New ** Also affects: fwts (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: fwts (Ubuntu Disco) Importance: High Assignee: Colin Ian King (colin-king) Status: In Progress ** Also affects: fwts (Ubuntu Cosmic) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813059 Title: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/1813059/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1813059] Re: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2
** Changed in: fwts (Ubuntu) Assignee: (unassigned) => Colin Ian King (colin-king) ** Changed in: fwts (Ubuntu) Importance: Undecided => High ** Changed in: fwts (Ubuntu) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1813059 Title: fwts 19.01.00-0ubuntu1 ADT test failure with linux 5.0.0-1.2 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/1813059/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
