[Bug 1825194] Re: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls
This bug was fixed in the package resolvconf - 1.78ubuntu7 --- resolvconf (1.78ubuntu7) xenial; urgency=medium * bin/resolvconf: use flock so resolvconf can be called in parallel safely (LP: #1825194). -- Alfonso Sanchez-Beato (email Canonical) Mon, 06 May 2019 10:39:40 +0200 ** Changed in: resolvconf (Ubuntu Xenial) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1825194 Title: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1825194] Re: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls
I have tested on xenial, the problem is solved with the change. ubuntu@xenial:~$ apt policy resolvconf resolvconf: Installed: 1.78ubuntu7 Candidate: 1.78ubuntu7 Version table: *** 1.78ubuntu7 500 500 http://archive.ubuntu.com/ubuntu xenial-proposed/main amd64 Packages 100 /var/lib/dpkg/status 1.78ubuntu6 500 500 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages 1.78ubuntu2 500 500 http://archive.ubuntu.com/ubuntu xenial/main amd64 Packages ubuntu@xenial:~$ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 16.04.6 LTS Release:16.04 ** Tags removed: verification-needed-xenial ** Tags added: verification-done-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1825194 Title: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1825194] Re: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls
On Wed, May 15, 2019 at 12:42:24PM -, Steve Langasek wrote: > Per > https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/comments/4, > I believe this is "uninteresting" to fix for releases other than xenial; > xenial needs it because UC16 is netplan+resolvconf and may have both > networkd and NetworkManager backends on some devices, UC18 does not use > resolvconf, and Ubuntu 18.04 classic is unlikely to have users making use of > resolvconf+netplan (since resolvconf is only present by default on upgrade > for users who have their network configured using ifupdown). Ah sorry. I remember reading that when I looked at that last time, but missed that today. Fair enough. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1825194 Title: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1825194] Re: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls
On Wed, May 15, 2019 at 12:22:20PM -, Robie Basak wrote: > Unsubscribing ~ubuntu-sponsors. > Are you planning on fixing Bionic, Cosmic or Disco? Per https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/comments/4, I believe this is "uninteresting" to fix for releases other than xenial; xenial needs it because UC16 is netplan+resolvconf and may have both networkd and NetworkManager backends on some devices, UC18 does not use resolvconf, and Ubuntu 18.04 classic is unlikely to have users making use of resolvconf+netplan (since resolvconf is only present by default on upgrade for users who have their network configured using ifupdown). -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1825194 Title: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1825194] Re: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls
Unsubscribing ~ubuntu-sponsors. Are you planning on fixing Bionic, Cosmic or Disco? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1825194 Title: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1825194] Re: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls
Hello Alfonso, or anyone else affected, Accepted resolvconf into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/resolvconf/1.78ubuntu7 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance! ** Changed in: resolvconf (Ubuntu Xenial) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-xenial -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1825194 Title: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1825194] Re: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls
Thanks Robie, good catch. Please find attached the new patch for xenial: I have moved a bit below the call to flock to ensure the dir was created - the lines now out of the lock do not change any files so that should not be a problem. ** Patch added: "xenial-debdiff.patch" https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/+attachment/5261798/+files/xenial-debdiff.patch -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1825194 Title: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1825194] Re: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls
On Wed, May 01, 2019 at 05:25:22PM -, Robie Basak wrote: > Will this also need addressing in the development release? It looks like it to me. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1825194 Title: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1825194] Re: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls
Will this also need addressing in the development release? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1825194 Title: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1825194] Re: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls
Thanks Robie, that's a very good point and something I didn't notice while sponsoring. Alfonso, do you want to adjust the patch to address this? (That will also give us a chance to reupload the SRU and remove the misapplied diff cruft.) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1825194 Title: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1825194] Re: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls
Review question: what ensures that /run/resolvconf exists before flock is called? I only see an "mkdir -p" inside the block, not outside it. flock doesn't seem to create parent directories automatically in my test, and I don't see a tmpfiles.d entry. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1825194 Title: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1825194] Re: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls
(please note that the changelog had to be adjusted; the current version of resolvconf in xenial-updates is 1.78ubuntu6.) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1825194 Title: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1825194] Re: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls
uploaded to the SRU queue. ** Changed in: resolvconf (Ubuntu Xenial) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1825194 Title: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1825194] Re: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls
** Changed in: resolvconf (Ubuntu) Importance: Undecided => Critical ** Changed in: resolvconf (Ubuntu Xenial) Importance: Undecided => Critical -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1825194 Title: [SRU] resolvconf is racy, which leads to broken resolv.conf in parallel calls To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/resolvconf/+bug/1825194/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
