[Bug 1829860] Re: APT unlocks in same order as it locks
** Changed in: apt (Ubuntu Xenial) Status: New => Won't Fix -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829860 Title: APT unlocks in same order as it locks To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1829860/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829860] Re: APT unlocks in same order as it locks
This bug was fixed in the package apt - 1.6.12 --- apt (1.6.12) bionic; urgency=medium [ TilmanK ] * Fix typo in German manpage translation [ Michael Zhivich ] * methods: https: handle requests for TLS re-handshake (LP: #1829861) [ Julian Andres Klode ] * Unlock dpkg locks in reverse locking order (LP: #1829860) [ Simon Körner ] * http: Fix Host header in proxied https connections (LP: #1838771) [ Brian Murray ] * Do not include squashfs file systems in df output. (LP: #1756595) -- Julian Andres Klode Tue, 03 Sep 2019 12:05:35 +0200 ** Changed in: apt (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829860 Title: APT unlocks in same order as it locks To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1829860/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829860] Re: APT unlocks in same order as it locks
This bug was fixed in the package apt - 1.8.3 --- apt (1.8.3) unstable; urgency=medium [ Simon Körner ] * http: Fix Host header in proxied https connections (LP: #1838771) [ Brian Murray ] * Do not include squashfs file systems in df output. (LP: #1756595) apt (1.8.2) unstable; urgency=medium [ Alwin Henseler ] * Flip /: in documented default value of DPkg::Path (Closes: #917986) [ TilmanK ] * Fix typo in German manpage translation [ Américo Monteiro ] * Portuguese manpages translation update (Closes: #926614) [ Jean-Pierre Giraud ] * French manpages translation update (Closes: #929290) [ Michael Zhivich ] * methods: https: handle requests for TLS re-handshake (LP: #1829861) [ Julian Andres Klode ] * Unlock dpkg locks in reverse locking order (LP: #1829860) -- Julian Andres Klode Fri, 09 Aug 2019 11:16:15 +0200 ** Changed in: apt (Ubuntu Disco) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829860 Title: APT unlocks in same order as it locks To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1829860/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829860] Re: APT unlocks in same order as it locks
Oh, as I wrote on the other bugs, autopkgtest regressions all went away, except for apport, which had the usual random failure also present in earlier failures. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829860 Title: APT unlocks in same order as it locks To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1829860/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829860] Re: APT unlocks in same order as it locks
Same for bionic 1.6.12:
openat(AT_FDCWD, "/var/lib/dpkg/lock-frontend", O_RDWR|O_CREAT|O_NOFOLLOW,
0640) = 4
fcntl(4, F_SETFD, FD_CLOEXEC) = 0
fcntl(4, F_SETLK, {l_type=F_WRLCK, l_whence=SEEK_SET, l_start=0, l_len=0}) = 0
openat(AT_FDCWD, "/var/lib/dpkg/lock", O_RDWR|O_CREAT|O_NOFOLLOW, 0640) = 5
fcntl(5, F_SETFD, FD_CLOEXEC) = 0
fcntl(5, F_SETLK, {l_type=F_WRLCK, l_whence=SEEK_SET, l_start=0, l_len=0}) = 0
end of run:
close(5) = 0
close(4) = 0
close(3) = 0
** Tags removed: verification-needed verification-needed-bionic
** Tags added: verification-done verification-done-bionic
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1829860
Title:
APT unlocks in same order as it locks
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1829860/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829860] Re: APT unlocks in same order as it locks
So disco, 1.8.3:
at the start:
openat(AT_FDCWD, "/var/lib/dpkg/lock-frontend", O_RDWR|O_CREAT|O_NOFOLLOW,
0640) = 4
fcntl(4, F_SETFD, FD_CLOEXEC) = 0
fcntl(4, F_SETLK, {l_type=F_WRLCK, l_whence=SEEK_SET, l_start=0, l_len=0}) = 0
openat(AT_FDCWD, "/var/lib/dpkg/lock", O_RDWR|O_CREAT|O_NOFOLLOW, 0640) = 5
fcntl(5, F_SETFD, FD_CLOEXEC) = 0
fcntl(5, F_SETLK, {l_type=F_WRLCK, l_whence=SEEK_SET, l_start=0, l_len=0}) = 0
end of run:
close(5)= 0
close(4)= 0
close(3)= 0
=> we unlock in reverse as we want.
** Tags removed: verification-needed-disco
** Tags added: verification-done-disco
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1829860
Title:
APT unlocks in same order as it locks
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1829860/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829860] Re: APT unlocks in same order as it locks
Hello Julian, or anyone else affected, Accepted apt into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apt/1.6.12 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: apt (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags added: verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829860 Title: APT unlocks in same order as it locks To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1829860/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829860] Re: APT unlocks in same order as it locks
** Changed in: apt (Ubuntu Bionic) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829860 Title: APT unlocks in same order as it locks To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1829860/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829860] Re: APT unlocks in same order as it locks
Hello Julian, or anyone else affected, Accepted apt into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apt/1.8.3 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: apt (Ubuntu Disco) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-disco -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829860 Title: APT unlocks in same order as it locks To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1829860/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829860] Re: APT unlocks in same order as it locks
** Description changed: [Impact] APT releases the locks in the same order it acquires them, rather than reverse order. Given that we have no waiting for locks, this is not _super_ problematic, but it might be wrong: You'd get a lock failure on dpkg's lock, rather than lock-frontend. [Test case] Watch lock release with strace and see that it unlocks the right way. [Regression potential] - ... + Some other locking races or something? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829860 Title: APT unlocks in same order as it locks To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1829860/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829860] Re: APT unlocks in same order as it locks
** Description changed: [Impact] APT releases the locks in the same order it acquires them, rather than reverse order. Given that we have no waiting for locks, this is not _super_ problematic, but it might be wrong: You'd get a lock failure on dpkg's lock, rather than lock-frontend. [Test case] - ... + Watch lock release with strace and see that it unlocks the right way. [Regression potential] ... ** Changed in: apt (Ubuntu Disco) Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829860 Title: APT unlocks in same order as it locks To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1829860/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829860] Re: APT unlocks in same order as it locks
** Also affects: apt (Ubuntu Xenial) Importance: Undecided Status: New ** Also affects: apt (Ubuntu Disco) Importance: Undecided Status: New ** Also affects: apt (Ubuntu Bionic) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829860 Title: APT unlocks in same order as it locks To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1829860/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1829860] Re: APT unlocks in same order as it locks
This bug was fixed in the package apt - 1.8.2+19.10 --- apt (1.8.2+19.10) eoan; urgency=medium * Upload to eoan apt (1.8.2) unstable; urgency=medium [ Alwin Henseler ] * Flip /: in documented default value of DPkg::Path (Closes: #917986) [ TilmanK ] * Fix typo in German manpage translation [ Américo Monteiro ] * Portuguese manpages translation update (Closes: #926614) [ Jean-Pierre Giraud ] * French manpages translation update (Closes: #929290) [ Michael Zhivich ] * methods: https: handle requests for TLS re-handshake (LP: #1829861) [ Julian Andres Klode ] * Unlock dpkg locks in reverse locking order (LP: #1829860) -- Julian Andres Klode Tue, 28 May 2019 23:25:22 +0200 ** Changed in: apt (Ubuntu) Status: New => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1829860 Title: APT unlocks in same order as it locks To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1829860/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
