This bug was fixed in the package util-linux - 2.27.1-6ubuntu3.9
---
util-linux (2.27.1-6ubuntu3.9) xenial; urgency=medium
* d/p/libblkid-nilfs2-add-length-check-before-crc32.patch:
Fix misdetection/false-positive of nilfs2 filesystem on
device with magic bytes
** Tags removed: sts-sponsor-slashd
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1842437
Title:
Xenial: libblkid: fix false-positive/misdetection of nilfs2 filesystem
with udev
To manage
Verification done with xenial-proposed.
# dpkg -s libblkid1 | grep -i version
Version: 2.27.1-6ubuntu3.9
# apt-cache madison libblkid1 | grep xenial-proposed
libblkid1 | 2.27.1-6ubuntu3.9 | http://archive.ubuntu.com/ubuntu
xenial-proposed/main amd64 Packages
Test steps are described in
No problems with the autopkgtest results for this SRU:
- nplan xenial/s390x [1] is failing since September 1st
- nplan xenial/armhf [2] is failing since May 14th
- systemd xenial/amd [3] passed with a re-run [4] (thanks ddstret)
cheers,
Mauricio
[1]
The reported failures for autopkgtest are unrelated
to this change on the probe of the nilfs filesystem.
Two are apparently failures in handling test reboot,
and another is lack of a kernel module.
I'll ask for retries on these, and do a quick check
on this module error.
Details:
---
Hello Mauricio, or anyone else affected,
Accepted util-linux into xenial-proposed. The package will build now and
be available at https://launchpad.net/ubuntu/+source/util-
linux/2.27.1-6ubuntu3.9 in a few hours, and then in the -proposed
repository.
Please help us by testing this new package.
[STS-Sponsor]
Sponsored in Bionic.
Thanks Mauricio for your great work on this bug and the FTBFS situation.
- Eric
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1842437
Title:
Xenial: libblkid:
And this debdiff / util-linux on xenial builds fine again!
Built on all architectures on PPA [1].
cheers,
Mauricio
[1] https://launchpad.net/~mfo/+archive/ubuntu/lp1842437
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
Eric,
The fix to xenial livecd-rootfs / launchpad buildd chroot has been
rolled out.
I just confirmed that /dev/ptmx is OK with a test package build on
Launchpad PPA.
...
dh_clean
# Check /dev/ptmx|pts/
ls -l /dev/ptmx
crw-rw-rw- 1 root root 5, 2 Oct 4 08:13 /dev/ptmx
ls -l
Eric, thanks! Really appreciate your help debugging this issue.
Per Colin's comment, he mentions on #launchpad-ops (internal)
when there are launchpad chroot changes -- so we can confirm
it's been updated after the package becomes Fix Released.
--
You received this bug notification because you
@mfo,
I will gladly resume the sponsoring as soon as LP: #1844504 is "Fix
Released" and util-linux builds fine.
Thanks for your good work on this Mauricio !
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
The real fix for the openpty() problem on Launchpad xenial buildd
is in livecd-rootfs currently in xenial-proposed, and is verified.
(LP 1844504 comment 15)
Once the Launchpad builders are updated with that, we can proceed
with another build attempt, and hopefully move this SRU forward.
Thanks
LP: #1844504
** Tags added: ftbfs
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1842437
Title:
Xenial: libblkid: fix false-positive/misdetection of nilfs2 filesystem
with udev
To manage
Workaround of disabling the 4 tests in the 'script' component
(which calls openpty() upfront and thus cause the failure)
makes the test-suite finish successfully.
$ ./tests/run.sh \
--srcdir=/build/util-linux-kzgHhT/util-linux-2.27.1 \
--builddir=/build/util-linux-kzgHhT/util-linux-2.27.1 \
s/this is bug/this is _similar_ to/
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1842437
Title:
Xenial: libblkid: fix false-positive/misdetection of nilfs2 filesystem
with udev
To manage
Ah, this is bug 1843674, checking for similar fixes.
(thanks Matthew Ruffell for pointing it out on IRC.)
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1842437
Title:
Xenial: libblkid: fix
The problem is reproducible in the sbuild-launchpad-chroot for xenial/amd64,
using the source package for util-linux currently in xenial-updates
(i.e., no regression from debdiff, as expected since changes/error are
unrelated)
The minimal command-line for that is:
$
Eric, thanks for reporting that.
I couldn't reproduce the build failure on LXC with apt dist-upgrade on
xenial-updates nor xenial-proposed, and it built successfully on PPAs a
while ago (for the test packages), so it seems something changed in the
PPA builders.
I'll investigate this as per our
@mfo,
Unfortunately the build ftbfs as follow:
https://launchpadlibrarian.net/443016838/buildlog_ubuntu-xenial-amd64.util-linux_2.27.1-6ubuntu3.9_BUILDING.txt.gz
...
masks:
script: openpty failed: No such file or directory
Makefile:11211: recipe for target 'check-recursive' failed
make[3]:
Maybe a kernel change between your successful built and my today
sponsoring build failure ?
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1842437
Title:
Xenial: libblkid: fix
** Tags added: sts-sponsor-slashd
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1842437
Title:
Xenial: libblkid: fix false-positive/misdetection of nilfs2 filesystem
with udev
To manage
The reporter confirmed the boot problem doesn't happen anymore.
Moving forward with the SRU.
** Changed in: util-linux (Ubuntu Xenial)
Assignee: Guilherme G. Piccoli (gpiccoli) => Mauricio Faria de Oliveira
(mfo)
** Tags added: sts
--
You received this bug notification because you are a
Attaching the debdiff with the fix.
This is waiting on validation from the reported user
that the boot problem does not happen anymore -- but
has already been validated on the running system to
produce the correct/expected behavior (UUID / other
values are printed by 'udevadm test-builtin
This problem can be reproduced with a synthetic test case.
Essentially,
1) create a zero-filled disk image with one partition.
2) format it as ext4.
3) insert the nilfs2 magic bytes at the right position.
4) insert the nilfs2 bytes field at the right position.
--
Step 1)
# dd
original package:
# dpkg -s libblkid1 | grep ^Version:
Version: 2.27.1-6ubuntu3.8
# LIBBLKID_DEBUG=all udevadm test-builtin blkid /sys/block/loop0/loop0p1
...
4924: libblkid: LOWPROBE: [28] ext4:
4924: libblkid: LOWPROBE: reuse
udev builtin blkid ignores the checksum error:
nilfs_valid_sb() @ nilfs.c:96
return blkid_probe_verify_csum(pr, crc, le32_to_cpu(sb->s_sum));
blkid_probe_verify_csum() @ probe.c:1576-1687
if (csum != expected) {
...
DBG(LOWPROBE, ul_debug(
modified package:
# dpkg -s libblkid1 | grep ^Version:
Version: 2.27.1-6ubuntu3.8+test20190903b1
# LIBBLKID_DEBUG=all udevadm test-builtin blkid /sys/block/loop0/loop0p1
...
7289: libblkid: LOWPROBE: [28] ext4:
7289: libblkid: LOWPROBE:
with debug we could confirm that other fields in the backup superblock are
invalid,
such as the device size, which was not checked for not being a whole-disk
device,
and the bytes length, which is greater than the superblock structure size (8243
vs 1024).
so, the fix to check for the bytes
Problem:
- the ext4 filesystem is detected correctly at the beginning of the partition.
- the nilfs2 filesystem is detected incorrectly at the end of the partition.
- the nilfs2 checksum is invalid, but that is ignored by udev builtin blkid.
- the detection of more than one filesystems causes an
29 matches
Mail list logo
