[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol
This bug was fixed in the package qemu - 1:4.2-3ubuntu6.7 --- qemu (1:4.2-3ubuntu6.7) focal; urgency=medium * d/p/ubuntu/lp-1882774-*: add newer EPYC processor types (LP: #1887490) * d/p/u/lp-1896751-exec-rom_reset-Free-rom-data-during-inmigrate-skip.patch: fix reboot after migration (LP: #1896751) * d/p/u/lp-1849644-io-channel-websock-treat-binary-and-no-sub-protocol-.patch: fix websocket compatibility with newer versions of noVNC (LP: #1849644) -- Christian Ehrhardt Mon, 27 Jul 2020 11:45:26 +0200 ** Changed in: qemu (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1849644 Title: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1849644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol
Trying to connect using novnc latest/stable:1.2.0 2020-07-31 (6) 18MB - as-is failing to connect Keeping VNC up and refreshing qemu. Updating to the new qemu from focal proposed (by now resolved the archive publishing issues we had before this morning). Get:67 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 qemu-utils amd64 1:4.2-3ubuntu6.7 [975 kB] Get:68 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 qemu-system-common amd64 1:4.2-3ubuntu6.7 [1056 kB] Get:69 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 qemu-block-extra amd64 1:4.2-3ubuntu6.7 [53.8 kB] Get:70 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 qemu-system-data all 1:4.2-3ubuntu6.7 [563 kB] Get:71 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 qemu-kvm amd64 1:4.2-3ubuntu6.7 [13.1 kB] Get:72 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 qemu-system-x86 amd64 1:4.2-3ubuntu6.7 [6720 kB] Get:73 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 qemu-system-gui amd64 1:4.2-3ubuntu6.7 [40.8 kB] Get:74 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 qemu-system-mips amd64 1:4.2-3ubuntu6.7 [12.9 MB] Now the same novnc1.2 can connect to it \o/ Setting verified ** Tags removed: verification-needed verification-needed-focal ** Tags added: verification-done verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1849644 Title: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1849644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol
Hello Samuel, or anyone else affected, Accepted qemu into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/1:4.2-3ubuntu6.7 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: qemu (Ubuntu Focal) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1849644 Title: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1849644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol
SRU Template for qemu added and MP linked to fix this in Ubuntu 20.04 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1849644 Title: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1849644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/qemu/+git/qemu/+merge/391348 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1849644 Title: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1849644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol
** Description changed: - When running a machine using "-vnc" and the "websocket" option QEMU - seems to require the subprotocol called 'binary'. This subprotocol does - not exist in the WebSocket specification. In fact it has never existed - in the spec, in one of the very early drafts of WebSockets it was - briefly mentioned but it never made it to a final version. + [Impact] + + * The exact details of the protocol/subprotocal was slightly unclear +between the projects. So qemu ended up insisting on "binary" being +used but newer noVNC clients no more used it. + + * Qemu got fixed in 5.0 to be more tolerant and accept an empty sub- +protocol as well. This SRU backports that fix to Focal. + + [Test Case] + + * Without the fix the following will "Failed to connect", but with the + fix it will work. + + $ sudo apt install qemu-system-x86 + # will only boot into a failing bootloader, but that is enough + $ qemu-system-x86_64 -vnc :0,websocket + # We need version 1.2 or later, so use the snap + $ snap install novnc + $ novnc --vnc localhost:5700 + Connect browser to http://:6080/vnc.html + Click "Connect" + + * Cross check with an older noVNC (e.g. the one in Focal) if the +connectivity still works on those as well + +- Reminders when switching between the noVNC implementations + - always refresh the browser with all clear ctrl+alt+f5 + - start/stop the snapped one via snap.novnc.novncsvc.service + + [Regression Potential] + + * This is exclusive to the functionality of noVNC, so regressions would +have to be expected in there. The tests try to exercise the basics, but +e.g. Openstack would be a major product using + + [Other Info] + + * The noVNC in Focal itself does not yet have the offending change, but +we want the qemu in focal to be connecteable from ~any type of client + + + --- + + + + When running a machine using "-vnc" and the "websocket" option QEMU seems to require the subprotocol called 'binary'. This subprotocol does not exist in the WebSocket specification. In fact it has never existed in the spec, in one of the very early drafts of WebSockets it was briefly mentioned but it never made it to a final version. When the WebSocket server requires a non-standard subprotocol any WebSocket client that works correctly won't be able to connect. One example of such a client is noVNC, it tells the server that it doesn't want to use any subprotocol. QEMU's WebSocket proxy doesn't let noVNC connect. If noVNC is modified to ask for 'binary' it will work, this is, however, incorrect behavior. Looking at the code in "io/channel-websock.c" it seems it's quite hard- coded to binary: Look at line 58 and 433 here: https://git.qemu.org/?p=qemu.git;a=blob;f=io/channel-websock.c This code has to be made more dynamic, and shouldn't require binary. ** Changed in: qemu (Ubuntu Focal) Status: Confirmed => Triaged ** Changed in: qemu (Ubuntu Focal) Status: Triaged => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1849644 Title: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1849644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol
I can confirm the test steps mentioned above. In an unchanged scenario a formerly failing-to-connect case got working when replacing the qemu (on Focal) in use with a patched one. Adding an SRU Template for Focal to the bug description ... -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1849644 Title: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1849644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol
Repro steps: $ sudo apt install qemu-system-x86 novnc /usr/share/novnc python3 -m http.server Connect browser to http://:8000/vnc.html Click "Settings" Open "advanced" Open "websocket" Set port 5700 Clear path Click "Connect" And it works ... Turns out my former check on the offending noVNC commit was wrong. There are https://github.com/novnc/noVNC/commit/f8318361b1b62c4d76b091132d4a8ccfdd2957e4 (referenced on this bug before) $ git tag --contains f8318361b1b62c4d76b091132d4a8ccfdd2957e4 v1.0.0 But only really gone later with: https://github.com/novnc/noVNC/commit/c912230309806aacbae4295faf7ad6406da97617 $ git tag --contains c912230309806aacbae4295faf7ad6406da97617 v1.2.0 So the novnc of Focal isn't affected but anyone who uses a newer noVNC >=1.2 would be. => lower SRU priority => Modify above repro steps to not use noVNC from Focal via apt but use 1.2 from snaps Repro steps: $ snap install novnc $ novnc --vnc localhost:5700 Connect browser to http://:6080/vnc.html Click "Connect" TODO: repro steps to be verified with a qemu that has the fix applied ** Changed in: qemu (Ubuntu Focal) Importance: Undecided => Low -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1849644 Title: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1849644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol
This is in v5.0.0 so fixed in Groovy. The related noVNC change is in upstream version >=v1.0.0 which correlates with Ubuntu >=20.04, threfore fixing this in Focals Qemu seems good. ** Also affects: qemu (Ubuntu) Importance: Undecided Status: New ** Also affects: qemu (Ubuntu Focal) Importance: Undecided Status: New ** Changed in: qemu (Ubuntu) Status: New => Fix Released ** Changed in: qemu (Ubuntu Focal) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1849644 Title: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1849644/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
