[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-06-09 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 6.0.0-0ubuntu8.1 --- libvirt (6.0.0-0ubuntu8.1) focal; urgency=medium * d/p/ubuntu/lp-1879325-*: avoid issues with apparmor metadata labeling (LP: #1879325) -- Christian Ehrhardt Wed, 20 May 2020 06:59:57 +0200 ** Changed in:

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-06-07 Thread Christian Ehrhardt 
** Tags removed: verification-needed verification-needed-focal ** Tags added: verification-done verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1879325 Title: Unable to remove

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-06-05 Thread Riccardo Pittau
Hey Brian, I tested the new packages in our CI and I can confirm the original issues are both gone. This is a recent libvirt log file:

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-06-02 Thread Brian Murray
Hello Riccardo, or anyone else affected, Accepted libvirt into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvirt/6.0.0-0ubuntu8.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-28 Thread Christian Ehrhardt 
Now that the fix migrated in groovy I uploaded it to focal-unapproved for the consideration by the SRU Team. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1879325 Title: Unable to remove disk

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-28 Thread Launchpad Bug Tracker
This bug was fixed in the package libvirt - 6.0.0-0ubuntu9 --- libvirt (6.0.0-0ubuntu9) groovy; urgency=medium * d/p/ubuntu/lp-1879325-*: avoid issues with apparmor metadata labeling (LP: #1879325) -- Christian Ehrhardt Wed, 20 May 2020 06:59:57 +0200 ** Changed in:

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-28 Thread Christian Ehrhardt 
FYI: Fix uploaded to groovy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1879325 Title: Unable to remove disk metadata on vm To manage notifications about this bug go to:

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-27 Thread Christian Ehrhardt 
Ok Riccardo, could you - once you find the other issue - file a new bug then. I'll take this bug here to drive the issue(s) identified to far to a conclusion. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-27 Thread Riccardo Pittau
Hi Christian, I ran a test in our CI with the packages: 2020-05-26 16:52:02.258571 | controller | Get:1 http://ppa.launchpad.net/ci-train-ppa-service/4068/ubuntu focal/main amd64 libvirt-dev amd64 6.0.0-0ubuntu8.2~ppa1 [161 kB] 2020-05-26 16:52:02.486631 | controller | Get:2

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-27 Thread Christian Ehrhardt 
** Description changed: [Impact] - * The impact is log flooding with warnings for every guest start/stop +  * The impact is log flooding with warnings for every guest start/stop - * Maybe the impact also has in some cases worse effects due to the bad RC -of the function e.g.

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-27 Thread Christian Ehrhardt 
The extra change we need is now pushed upstream => https://libvirt.org/git/?p=libvirt.git;a=commit;h=55029d93150e33d70b02b6de2b899c05054c5d3a My PPA builds include this final version of the change and the initially referred fix for the warning. Waiting for MP review by the team now. @Riccardo

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-26 Thread Christian Ehrhardt 
Got a Review-by already, will wait another 24h or so before pushing and preparing a build with it. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1879325 Title: Unable to remove disk metadata on vm

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-26 Thread Christian Ehrhardt 
In my testing all errors of the following kind are gone now: - internal error: child reported (status=125) - Unable to remove disk metadata on vm testguest from /var/lib/uvtool/libvirt/images/testguest.qcow (disk target vda) @Riccardo - does this make your CI happy as well? -- You received

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-26 Thread Christian Ehrhardt 
FYI - The commits mentioned above were a copy accident - they are not important to be mentioned. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1879325 Title: Unable to remove disk metadata on vm

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-26 Thread Christian Ehrhardt 
5243d34b4f (paelzer/fix-lp-1879325-metadata-FOCAL, fix-lp-1879325-metadata-FOCAL) changelog: avoid issues with apparmor metadata labeling (LP: #1879325) ad0478c226 I have put a version with that fix in the PPA [1] for Focal: 6.0.0-0ubuntu8.2~ppa1 Groovy: 6.0.0-0ubuntu10~ppa1 That way I can

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-26 Thread Christian Ehrhardt 
Discussion went on until https://www.redhat.com/archives/libvir-list/2020-May/msg01088.html Fix submitted as https://www.redhat.com/archives/libvir-list/2020-May/msg01089.html and waiting for feedback. ** Changed in: libvirt (Ubuntu Focal) Status: Incomplete => Triaged ** Changed in:

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-25 Thread Christian Ehrhardt 
Replied to the referred fix describing what happens here outlining that the overall case isn't fixed yet. => https://www.redhat.com/archives/libvir-list/2020-May/msg01067.html -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu.

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-25 Thread Christian Ehrhardt 
To be clear on the severity, the change won't make the meta data now being applied. We never did and we don't need that. But that failing un- labelling does flood the error logs and it's bad return code might cause other steps on e.g. shutdown to be skipped. -- You received this bug notification

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-25 Thread Christian Ehrhardt 
I've checked some releases back and we build with: --without-attr since what seems forever. Maybe the code can't handle !HAVE_LIBATTR as good as the old did. And configure confirms showing configure: attr: no throughout all the builds. That theory LGTM as the metadata

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-25 Thread Christian Ehrhardt 
At -O2 the function seems to be inlined which makes debugging a bit harder. This is the function returning the bad RC, but not only itself but also most of its callees are inlined virSecurityGetRefCountAttrName virSecurityGetAttrName virSecurityGetTimestampAttrName. 461 if

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-25 Thread Christian Ehrhardt 
1129if (!priv->dynamicOwnership) is set 1132if (src && virStorageSourceIsLocalStorage(src)) is true and sets (gdb) p data.src $18 = 0x7f8c500271e0 "/var/lib/uvtool/libvirt/images/testguest.qcow" 1135 if (dst && virStorageSourceIsLocalStorage(dst))

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-25 Thread Christian Ehrhardt 
Since that is a fork this needs (gdb) set detach-on-fork off (gdb) set follow-fork-mode child To be able to track the virSecurityDACMoveImageMetadataHelper Inside of virSecurityDACMoveImageMetadataHelper we have (gdb) p *data $27 = {mgr = 0x7f8c1805cf10, src = 0x7f8c50031a10

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-25 Thread Christian Ehrhardt 
I reach the upper virFileGetXAttrQuiet Thread 3.1 "libvirtd" hit Breakpoint 10, virFileGetXAttrQuiet (path=path@entry=0x7f8c50041390 "/var/lib/uvtool/libvirt/images/testguest-ds.qcow", name=name@entry=0x7f8c1803dc40 "trusted.libvirt.security.ref_dac", value=value@entry=0x7f8c29b605e0) at

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-25 Thread Christian Ehrhardt 
I was debugging the case in gdb to check what exactly fail qemuBlockRemoveImageMetadata (the one that emits the warning) -> qemuSecurityMoveImageMetadata -> virSecurityManagerMoveImageMetadata (where the former function was missing) The first hit is the stacked security, which has an

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-25 Thread Christian Ehrhardt 
It calls: virProcessRunInFork for virSecurityDACMoveImageMetadataHelper And I was able to confirm that this is the "remaining" source of a negative return code that was formerly hidden behind the missing function. Thread 18 "libvirtd" hit Breakpoint 4, virSecurityDACMoveImageMetadata

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-25 Thread Christian Ehrhardt 
Yeah those two you still see, that was expected. The fix you referred to only eliminated the former messages in regard to "this function is not supported" I agree in my repro that the following two kind of messages stay (for now): internal error: child reported (status=125): Unable to

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-25 Thread Riccardo Pittau
Hi Christian, thank you for your patience, I just finished testing the new package in our ci and unfortunately I'm still seeing the same message about disk metadata: 2020-05-22 09:21:40.896+: 96720: error : virProcessRunInFork:1159 : internal error: child reported (status=125): 2020-05-22

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-20 Thread Riccardo Pittau
Hi Christian, thanks for the quick answer and fix, I'll test that in our CI as soon as possible. What actually worries me is the message "unable to remove disk metadata", but I guess we'll have to wait for the CI jobs to complete to see if there was an improvement on the related error that

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-20 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/libvirt/+git/libvirt/+merge/384244 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1879325 Title: Unable to remove

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-20 Thread Christian Ehrhardt 
I tested the PPA and it works to eliminate the warnings. No more appear: Mai 20 07:24:40 Keschdeichel libvirtd[2638]: this function is not supported by the connection driver: virSecurityManagerMoveImageMetadata Mai 20 07:24:40 Keschdeichel libvirtd[2638]: internal error: child reported

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-20 Thread Launchpad Bug Tracker
** Merge proposal linked: https://code.launchpad.net/~paelzer/ubuntu/+source/libvirt/+git/libvirt/+merge/384243 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1879325 Title: Unable to remove

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-19 Thread Christian Ehrhardt 
Added an SRU template in preparation. @Riccardo - in addition to trying the PPA, would you let me know if in your environment this is "just the warning flooding the log" or does it also have more severe impact like a function failing? If so does the PPA only fix the warning or also the formerly

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-19 Thread Christian Ehrhardt 
Incomplete for now waiting on user reply in regard to the PPA fix. ** Changed in: libvirt (Ubuntu) Status: Triaged => Incomplete ** Changed in: libvirt (Ubuntu Focal) Status: Triaged => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs,

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-19 Thread Christian Ehrhardt 
Note: related upstream issue https://gitlab.com/libvirt/libvirt/-/issues/25 Hi Riccardo, thanks for the report and the discussion until there was a fix. I have prepared PPAs for Groovy and Focal including that fix for you to try if that change alone is really sufficient for your case as well. If

[Bug 1879325] Re: Unable to remove disk metadata on vm

2020-05-19 Thread Lucas Kanashiro
** Changed in: libvirt (Ubuntu) Status: New => Triaged -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1879325 Title: Unable to remove disk metadata on vm To manage notifications about this