[Bug 1879339] Re: test_310_config_security_perf_events_restrict / test_400_refcount_config in ubuntu_qrt_kernel_security failed on F-OEM-5.6

2021-05-10 Thread Steve Beattie
Sorry for the lag on this issue.

Timo, while the added hooks are useful, they don't for the time being
obviate the need for the larger hammer of the sysctl, so we'd still like
to keep the referred to patch available, until we are forced to make a
choice if and when upstream drops the sysctl entirely.

Po-Hsu, if it's easier for tracking for it to be a separate bug report,
that's fine. Am hoping ot have more time soon to focus on qa-r-t issues
when they come up.

Thanks.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1879339

Title:
  test_310_config_security_perf_events_restrict /
  test_400_refcount_config in ubuntu_qrt_kernel_security failed on
  F-OEM-5.6

To manage notifications about this bug go to:
https://bugs.launchpad.net/qa-regression-testing/+bug/1879339/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1879339] Re: test_310_config_security_perf_events_restrict / test_400_refcount_config in ubuntu_qrt_kernel_security failed on F-OEM-5.6

2021-05-10 Thread Kelsey Skunberg
** Tags added: 5.6 oem oem-5.6 sru-20210412

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1879339

Title:
  test_310_config_security_perf_events_restrict /
  test_400_refcount_config in ubuntu_qrt_kernel_security failed on
  F-OEM-5.6

To manage notifications about this bug go to:
https://bugs.launchpad.net/qa-regression-testing/+bug/1879339/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1879339] Re: test_310_config_security_perf_events_restrict / test_400_refcount_config in ubuntu_qrt_kernel_security failed on F-OEM-5.6

2020-06-22 Thread Po-Hsu Lin
Hello Steve, 
test_310_config_security_perf_events_restrict is still failing with F-OEM-5.6, 
do you want me to open a new bug for it?

Thanks

** Tags added: sru-20200608

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1879339

Title:
  test_310_config_security_perf_events_restrict /
  test_400_refcount_config in ubuntu_qrt_kernel_security failed on
  F-OEM-5.6

To manage notifications about this bug go to:
https://bugs.launchpad.net/qa-regression-testing/+bug/1879339/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1879339] Re: test_310_config_security_perf_events_restrict / test_400_refcount_config in ubuntu_qrt_kernel_security failed on F-OEM-5.6

2020-05-21 Thread Timo Aaltonen
does this upstream change replace the sauce patch?

commit da97e18458fb42d7c00fac5fd1c56a3896ec666e
Author: Joel Fernandes (Google) 
Date:   Mon Oct 14 13:03:08 2019 -0400

perf_event: Add support for LSM and SELinux checks

In current mainline, the degree of access to perf_event_open(2) system
call depends on the perf_event_paranoid sysctl.  This has a number of
limitations:

1. The sysctl is only a single value. Many types of accesses are controlled
   based on the single value thus making the control very limited and
   coarse grained.
2. The sysctl is global, so if the sysctl is changed, then that means
   all processes get access to perf_event_open(2) opening the door to
   security issues.

This patch adds LSM and SELinux access checking which will be used in
Android to access perf_event_open(2) for the purposes of attaching BPF
programs to tracepoints, perf profiling and other operations from
userspace. These operations are intended for production systems.

5 new LSM hooks are added:
1. perf_event_open: This controls access during the perf_event_open(2)
   syscall itself. The hook is called from all the places that the
   perf_event_paranoid sysctl is checked to keep it consistent with the
   systctl. The hook gets passed a 'type' argument which controls CPU,
   kernel and tracepoint accesses (in this context, CPU, kernel and
   tracepoint have the same semantics as the perf_event_paranoid sysctl).
   Additionally, I added an 'open' type which is similar to
   perf_event_paranoid sysctl == 3 patch carried in Android and several 
other
   distros but was rejected in mainline [1] in 2016.

2. perf_event_alloc: This allocates a new security object for the event
   which stores the current SID within the event. It will be useful when
   the perf event's FD is passed through IPC to another process which may
   try to read the FD. Appropriate security checks will limit access.

3. perf_event_free: Called when the event is closed.

4. perf_event_read: Called from the read(2) and mmap(2) syscalls for the 
event.

5. perf_event_write: Called from the ioctl(2) syscalls for the event.

[1] https://lwn.net/Articles/696240/

Since Peter had suggest LSM hooks in 2016 [1], I am adding his
Suggested-by tag below.

To use this patch, we set the perf_event_paranoid sysctl to -1 and then
apply selinux checking as appropriate (default deny everything, and then
add policy rules to give access to domains that need it). In the future
we can remove the perf_event_paranoid sysctl altogether.

Suggested-by: Peter Zijlstra 
Co-developed-by: Peter Zijlstra 
Signed-off-by: Joel Fernandes (Google) 
Signed-off-by: Peter Zijlstra (Intel) 
Acked-by: James Morris 
Cc: Arnaldo Carvalho de Melo 
Cc: rost...@goodmis.org
Cc: Yonghong Song 
Cc: Kees Cook 
Cc: Ingo Molnar 
Cc: Alexei Starovoitov 
Cc: je...@google.com
Cc: Jiri Olsa 
Cc: Daniel Borkmann 
Cc: primi...@google.com
Cc: Song Liu 
Cc: rsavit...@google.com
Cc: Namhyung Kim 
Cc: Matthew Garrett 
Link: 
https://lkml.kernel.org/r/20191014170308.70668-1-j...@joelfernandes.org

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1879339

Title:
  test_310_config_security_perf_events_restrict /
  test_400_refcount_config in ubuntu_qrt_kernel_security failed on
  F-OEM-5.6

To manage notifications about this bug go to:
https://bugs.launchpad.net/qa-regression-testing/+bug/1879339/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1879339] Re: test_310_config_security_perf_events_restrict / test_400_refcount_config in ubuntu_qrt_kernel_security failed on F-OEM-5.6

2020-05-21 Thread Steve Beattie
** Changed in: qa-regression-testing
   Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1879339

Title:
  test_310_config_security_perf_events_restrict /
  test_400_refcount_config in ubuntu_qrt_kernel_security failed on
  F-OEM-5.6

To manage notifications about this bug go to:
https://bugs.launchpad.net/qa-regression-testing/+bug/1879339/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1879339] Re: test_310_config_security_perf_events_restrict / test_400_refcount_config in ubuntu_qrt_kernel_security failed on F-OEM-5.6

2020-05-21 Thread Steve Beattie
The test_400_refcount_config failure has been addressed in 
qa-regression-testing commit
https://git.launchpad.net/qa-regression-testing/commit/?id=480aaab47c0e7e11ab5bad5b56f61742ac8fdf9e

Thanks.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1879339

Title:
  test_310_config_security_perf_events_restrict /
  test_400_refcount_config in ubuntu_qrt_kernel_security failed on
  F-OEM-5.6

To manage notifications about this bug go to:
https://bugs.launchpad.net/qa-regression-testing/+bug/1879339/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1879339] Re: test_310_config_security_perf_events_restrict / test_400_refcount_config in ubuntu_qrt_kernel_security failed on F-OEM-5.6

2020-05-20 Thread Steve Beattie
For the test_310_config_security_perf_events_restrict -- missing
SECURITY_PERF_EVENTS_RESTRICT option; it appears the linux-oem-5.6
kernel is missing the following Ubuntu SAUCE patch:

  commit 4e6246de75c468397327fa741b380c926020c81f
  Author: Ben Hutchings 
  Date:   Tue Aug 16 10:27:00 2016 -0600

UBUNTU: SAUCE: security,perf: Allow further restriction of
perf_event_open

For the test_400_refcount_config test, the ARCH_HAS_REFCOUNT and
REFCOUNT_FULL config options were removed upstream in the 5.5. kernel
cycle. I'm working on a patch to qrt to address this.

Thanks.

** Changed in: qa-regression-testing
   Status: New => Confirmed

** Changed in: linux-oem-5.6 (Ubuntu)
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1879339

Title:
  test_310_config_security_perf_events_restrict /
  test_400_refcount_config in ubuntu_qrt_kernel_security failed on
  F-OEM-5.6

To manage notifications about this bug go to:
https://bugs.launchpad.net/qa-regression-testing/+bug/1879339/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1879339] Re: test_310_config_security_perf_events_restrict / test_400_refcount_config in ubuntu_qrt_kernel_security failed on F-OEM-5.6

2020-05-19 Thread Timo Aaltonen
** Package changed: linux-signed-oem-5.6 (Ubuntu) => linux-oem-5.6
(Ubuntu)

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1879339

Title:
  test_310_config_security_perf_events_restrict /
  test_400_refcount_config in ubuntu_qrt_kernel_security failed on
  F-OEM-5.6

To manage notifications about this bug go to:
https://bugs.launchpad.net/qa-regression-testing/+bug/1879339/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs