[Bug 1888916] Re: release upgrader can restore sources.list file from a previous release upgrade
This bug was fixed in the package ubuntu-release-upgrader - 1:20.04.25 --- ubuntu-release-upgrader (1:20.04.25) focal; urgency=medium * DistUpgrade/DistUpgradeQuirks.py: Add a check for ROS packages being installed and warn that upgrades with them installed are not likely to work. Thanks to Kyle Fazzari for the patch. (LP: #1611737) * DistUpgrade/DistUpgradeController.py: do what the comment says and really back up /etc/apt/sources.list first. (LP: #1888916) -- Brian Murray Wed, 26 Aug 2020 08:36:39 -0700 ** Changed in: ubuntu-release-upgrader (Ubuntu Focal) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888916 Title: release upgrader can restore sources.list file from a previous release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888916] Re: release upgrader can restore sources.list file from a previous release upgrade
** Merge proposal linked: https://code.launchpad.net/~chad.smith/ubuntu/+source/ubuntu-release-upgrader/+git/ubuntu-release-upgrader/+merge/390056 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888916 Title: release upgrader can restore sources.list file from a previous release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888916] Re: release upgrader can restore sources.list file from a previous release upgrade
I tested a release upgrade from Bionic to Focal and confirm that my sources.list file was not reverted back to Artful. bdmurray@clean-bionic-amd64:/tmp/20.04$ head /var/log/dist-upgrade/main.log 2020-08-31 08:01:42,527 INFO Using config files '['./DistUpgrade.cfg.bionic']' 2020-08-31 08:01:42,527 INFO uname information: 'Linux clean-bionic-amd64 5.4.0-42-generic #46~18.04.1-Ubuntu SMP Fri Jul 10 07:21:24 UTC 2020 x86_64' 2020-08-31 08:01:42,819 INFO apt version: '1.6.12ubuntu0.1' 2020-08-31 08:01:42,820 INFO python version: '3.6.9 (default, Jul 17 2020, 12:50:27) [GCC 8.4.0]' 2020-08-31 08:01:42,822 INFO release-upgrader version '20.04.25' started bdmurray@clean-bionic-amd64:/tmp/20.04$ grep -A12 "no entry" /var/log/dist-upgrade/screenlog.0 While scanning your repository information no entry about bionic could be found. An upgrade might not succeed. Do you want to continue anyway? Continue [yN] n Restoring original system state Aborting Reading package lists... Done bdmurray@clean-bionic-amd64:/tmp/20.04$ cat /etc/apt/sources.list deb http://192.168.10.7/ubuntu focal main restricted universe multiverse deb http://192.168.10.7/ubuntu focal-updates main restricted universe multiverse #deb http://192.168.10.7/ubuntu focal-proposed main restricted universe multiverse deb http://192.168.10.7/ubuntu focal-security main restricted universe multiverse deb-src http://192.168.10.7/ubuntu focal main restricted universe multiverse deb-src http://192.168.10.7/ubuntu focal-updates main restricted universe multiverse #deb-src http://192.168.10.7/ubuntu focal-proposed main restricted universe multiverse deb-src http://192.168.10.7/ubuntu focal-security main restricted universe multiverse Keep in mind the sources.list file is correct as the test case had you modify it to the release which you are upgrading. bdmurray@clean-bionic-amd64:/tmp/20.04$ md5sum /etc/apt/sources.list 6d4439d7fd3f142f81b70e00abd7b95a /etc/apt/sources.list bdmurray@clean-bionic-amd64:/tmp/20.04$ md5sum /etc/apt/sources.list.distUpgrade 6d4439d7fd3f142f81b70e00abd7b95a /etc/apt/sources.list.distUpgrade -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888916 Title: release upgrader can restore sources.list file from a previous release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888916] Re: release upgrader can restore sources.list file from a previous release upgrade
Thanks. I've tested upgrading from focal to groovy: `ubuntu-release-upgrader-core/focal-proposed 1:20.04.25 all [upgradable from: 1:20.04.24]` ```patricia@f-g:~$ dpkg -l |grep ubuntu-release ii ubuntu-release-upgrader-core 1:20.04.25 all manage release upgrades ``` Now, I don't see the same issue anymore even if I press `R` to resurrect the screen session before it closes automatically `[screen is terminating]`. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888916 Title: release upgrader can restore sources.list file from a previous release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888916] Re: release upgrader can restore sources.list file from a previous release upgrade
** Tags removed: verification-needed verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888916 Title: release upgrader can restore sources.list file from a previous release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888916] Re: release upgrader can restore sources.list file from a previous release upgrade
Hello Patricia, or anyone else affected, Accepted ubuntu-release-upgrader into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source /ubuntu-release-upgrader/1:20.04.25 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: ubuntu-release-upgrader (Ubuntu Focal) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888916 Title: release upgrader can restore sources.list file from a previous release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888916] Re: release upgrader can restore sources.list file from a previous release upgrade
** Description changed: Impact -- The distribution upgrader creates a backup of your sources.list named sources.list.distUpgrade before upgrading your system. This file is not cleaned up after the upgrade and under the right set of circumstances (re-attaching to a screen session which starts the dist-upgrade again, or having a strange sources.list file) the sources.list.distUpgrade file will be restored which can result in a mismatch between what you are running and what is in sources.list. Test Case - A simple test case is the following: 1) Copy /etc/apt/sources.list to /etc/apt/sources.list.distUpgrade 2) Modify /etc/apt/sources.list.distUpgrade to contain a previous release of Ubuntu e.g. 's/focal/eoan/'. (This simulates that you upgraded to your current release of Ubuntu.) - 3) Modify /etc/apt/sources.list to contain the release you want to which you want to upgrade (strange right‽) + 3) Modify /etc/apt/sources.list to contain the release to which you want to upgrade (strange right‽) 4) Run do-release-upgrade (with or w/o -d as necessary) 5) When prompted about "No valid sources.list entry found" choose not to upgrade 6) Observe that /etc/apt/sources.list has the same content as /etc/apt/sources.list.distUpgrade and that it doesn't match your current release. With the version of the release upgrader in -proposed sources.list and sources.list.distUpgrade will still have the same content but it will be your current release. A more involved test case would have one complete a release upgrade choose not to reboot then reattach to the screen session (by pressing r). After that they'd see the same thing as in Step 5 and Step 6 but given that its the same code path it seems unnecessary. Regression Potential The fix involves backing up your sources.list file before presenting the error dialog regarding "No valid sources.list entry found". So its literally moving the same two lines before the dialog but the copy and paste could have gone wrong so be observant for any Tracebacks. - Original Description I've upgraded a server via `do-release-upgrade` from Ubuntu Bionic to Focal, with molly-guard installed on it - molly-guard configured to always ask for the hostname. After it has finished: ``` System upgrade is complete. Restart required To finish the upgrade, a restart is required. If you select 'y' the system will be restarted. Continue [yN] y I: molly-guard: reboot is always molly-guarded on this system. Please type in hostname of the machine to reboot: Good thing I asked; I won't reboot bates ... === Command detached from window (Tue Jul 21 15:23:36 2020) === === Command terminated normally (Tue Jul 21 15:23:46 2020) === ``` It doesn't alert you it was restoring original state of sources.list. After rebooting the system and it came back up showing `Welcome to Ubuntu 20.04 LTS`, I've just noticed it was pointing out to bionic instead of focal installing a package. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888916 Title: release upgrader can restore sources.list file from a previous release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888916] Re: release upgrader can restore sources.list file from a previous release upgrade
** Changed in: ubuntu-release-upgrader (Ubuntu Focal) Status: Triaged => In Progress ** Changed in: ubuntu-release-upgrader (Ubuntu Focal) Assignee: (unassigned) => Brian Murray (brian-murray) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888916 Title: release upgrader can restore sources.list file from a previous release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888916] Re: release upgrader can restore sources.list file from a previous release upgrade
This bug was fixed in the package ubuntu-release-upgrader - 1:20.10.10 --- ubuntu-release-upgrader (1:20.10.10) groovy; urgency=medium * DistUpgrade/DistUpgradeController.py: do what the comment says and really back up /etc/apt/sources.list first. (LP: #1888916) * DistUpgrade/screenrc: add 'onerror' to the zombie command so that if the process exits normally the screen window will disappear. -- Brian Murray Tue, 25 Aug 2020 14:17:55 -0700 ** Changed in: ubuntu-release-upgrader (Ubuntu Groovy) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888916 Title: release upgrader can restore sources.list file from a previous release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888916] Re: release upgrader can restore sources.list file from a previous release upgrade
** Also affects: ubuntu-release-upgrader (Ubuntu Focal) Importance: Undecided Status: New ** Changed in: ubuntu-release-upgrader (Ubuntu Focal) Status: New => Triaged ** Changed in: ubuntu-release-upgrader (Ubuntu Focal) Importance: Undecided => High -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888916 Title: release upgrader can restore sources.list file from a previous release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888916] Re: release upgrader can restore sources.list file from a previous release upgrade
** Description changed: - I've upgraded a server via `do-release-upgrade` from Ubuntu Bionic to - Focal, with molly-guard installed on it - molly-guard configured to - always ask for the hostname. + Impact + -- + The distribution upgrader creates a backup of your sources.list named sources.list.distUpgrade before upgrading your system. This file is not cleaned up after the upgrade and under the right set of circumstances (re-attaching to a screen session which starts the dist-upgrade again, or having a strange sources.list file) the sources.list.distUpgrade file will be restored which can result in a mismatch between what you are running and what is in sources.list. + + Test Case + - + A simple test case is the following: + 1) Copy /etc/apt/sources.list to /etc/apt/sources.list.distUpgrade + 2) Modify /etc/apt/sources.list.distUpgrade to contain a previous release of Ubuntu e.g. 's/focal/eoan/'. (This simulates that you upgraded to your current release of Ubuntu.) + 3) Modify /etc/apt/sources.list to contain the release you want to which you want to upgrade (strange right‽) + 4) Run do-release-upgrade (with or w/o -d as necessary) + 5) When prompted about "No valid sources.list entry found" choose not to upgrade + 6) Observe that /etc/apt/sources.list has the same content as /etc/apt/sources.list.distUpgrade and that it doesn't match your current release. + + With the version of the release upgrader in -proposed sources.list and + sources.list.distUpgrade will still have the same content but it will be + your current release. + + A more involved test case would have one complete a release upgrade + choose not to reboot then reattach to the screen session (by pressing + r). After that they'd see the same thing as in Step 5 and Step 6 but + given that its the same code path it seems unnecessary. + + Regression Potential + + The fix involves backing up your sources.list file before presenting the error dialog regarding "No valid sources.list entry found". So its literally moving the same two lines before the dialog but the copy and paste could have gone wrong so be observant for any Tracebacks. + + + Original Description + + I've upgraded a server via `do-release-upgrade` from Ubuntu Bionic to Focal, with molly-guard installed on it - molly-guard configured to always ask for the hostname. After it has finished: ``` System upgrade is complete. Restart required - To finish the upgrade, a restart is required. - If you select 'y' the system will be restarted. + To finish the upgrade, a restart is required. + If you select 'y' the system will be restarted. Continue [yN] y I: molly-guard: reboot is always molly-guarded on this system. - Please type in hostname of the machine to reboot: + Please type in hostname of the machine to reboot: Good thing I asked; I won't reboot bates ... - === Command detached from window (Tue Jul 21 15:23:36 2020) === === Command terminated normally (Tue Jul 21 15:23:46 2020) === ``` - It doesn't alert you it was restoring original state of sources.list. + It doesn't alert you it was restoring original state of sources.list. After rebooting the system and it came back up showing `Welcome to Ubuntu 20.04 LTS`, I've just noticed it was pointing out to bionic instead of focal installing a package. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888916 Title: release upgrader can restore sources.list file from a previous release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1888916] Re: release upgrader can restore sources.list file from a previous release upgrade
** Summary changed: - after the upgrade completes reattaching to the screen session can restore your sources.list file + release upgrader can restore sources.list file from a previous release upgrade -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1888916 Title: release upgrader can restore sources.list file from a previous release upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1888916/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
