[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
This bug was fixed in the package breezy-debian - 2.8.10ubuntu1 --- breezy-debian (2.8.10ubuntu1) bionic; urgency=medium * Fix `bzr dh-make` (LP: #1954595) - dh_make.py: import bzrdir. -- Mauricio Faria de Oliveira Fri, 20 May 2022 11:43:32 -0300 ** Changed in: breezy-debian (Ubuntu Bionic) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
This bug was fixed in the package breezy-debian - 2.8.32ubuntu1.1
---
breezy-debian (2.8.32ubuntu1.1) focal; urgency=medium
* Fix `bzr dh-make` (LP: #1954595)
- dh_make.py: import bzrdir.
- cmds.py: cmd_dh_make(): don't encode version;
breezy-debian commit 0c79e2e ("Fix dh-make.").
-- Mauricio Faria de Oliveira Thu, 20 May 2022
12:12:49 -0300
** Changed in: breezy-debian (Ubuntu Focal)
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1954595
Title:
bzr dh-make crash - no attribute 'initialize_on_transport'
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
The doc updates have been merged and are live. [1] [1] https://packaging.ubuntu.com/html/packaging-new-software.html ** Changed in: ubuntu-packaging-guide Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
Hey Zakhar, Good news; glad it worked! We should keep the scope of this bug as the 'bzr dh-make' issue and its related doc updates. The SRU/-proposed verification is related to the code change, and has been verified already. (All good on that front / this bug.) The other steps you mentioned (e.g., publishing), in case of issues, should go into another bug. I agree that updating the Packaging Guide for different/modern tooling (e.g., git) would be great! I'm not in a position to help with that at the moment, but if you have the experience and availability, please feel free to open another bug and merge request with the changes for review, and folks in more appropriate roles for that than me will check it out! Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
Dear Mauricio, thanks for the tip. I had to do the following to make it work: After: bzr add debian/source/format I added: bzr add debian/compat The compat file hold only one line with: 10, as in: echo "10" >compat Without this, it fails to compile, but with this line added, all seems well. I get my .deb package with all the files in good place. In my case I don't need a .configure since there is only a Makefile and that is enough for my project. I also get the source packages signed. I didn't try to push them to launchpad though, and will try that when I have a real fix to package (which is hopefully soon!) I will mark it "fixed for me" when I'll have done that launchpad publication, but so far it seems all good! That being said, and since apparently bzr dropped support for making debian packages, wouldn't it be worth it to rewrite completely this "Packaging guide" with newer tooling (like git?) After all, the task of compiling a simple hello.c, be it with the help of a Makefile, is quite basic! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
Hi Zakhar, Thanks for your attention to the quality and correctness of the documentation. I've just submitted updates to it, after testing the steps from start to end. Regarding your questions: Yes, this bug is originally for the `bzr dh-make` error, but since it's not available (some releases) after Ubuntu 20.04, it seemed OK to update steps related to it from this bug as well. And while in there, I've fixed things, to make sure the steps run correctly. That's been my experience with the Chapter 4 / Packaging New Software now. I guess the issues you mentioned are, as you considered, due to uncommitted files, apparently; or maybe other packaging differences from the doc/example. Hope those may be straightforward to figure out! Thanks! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
Submitted a Merge Request [1] with updates to the Ubuntu Packaging Guide for Ubuntu Focal. [1] https://code.launchpad.net/~mfo/ubuntu-packaging-guide/ubuntu- packaging-guide/+merge/423560 ** Branch linked: lp:~mfo/ubuntu-packaging-guide/ubuntu-packaging-guide ** Changed in: ubuntu-packaging-guide Status: Confirmed => In Progress ** Changed in: ubuntu-packaging-guide Importance: Undecided => Medium ** Changed in: ubuntu-packaging-guide Assignee: (unassigned) => Mauricio Faria de Oliveira (mfo) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
Strike it, there is no binary package with those commands (unlike with bzr wrapped) and I am not sure the "source" package is even correct... I'm lost! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
Possible workaround? It seems that after "manually" providing the compat file in debian directory in the buildarea, if I run the "naked" debuild commands: dpkg-buildpackage -us -uc -ui then dpkg-buildpackage -us -uc -ui -S Instead of what is documented: bzr builddeb -- -us -uc and bzr builddeb -S All seems to be working fine and I get a binary deb package (first command) and a source package for launchpad. Although I don't get "lintian" that seemed to be embedded when using the bzr wrapper... although that was anyway failing with my 16.04 install for unknown reason! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
Dear all, not sure if this bug fix is just about dh_make or the full process to make a package for Launchpad that is documented on the Ubuntu documentation. The former now works, the latter still fails further down the process. Here is what now works: $ bzr dh-make 1fichierfs 1.9.2~Focal /tmp/1fichierfs.tar Fetching tarball Looking for a way to retrieve the upstream tarball Upstream tarball already exists in build directory, using that Type of package: (single, indep, library, python) [s/i/l/p]? Maintainer Name : Email-Address : @fr Date: Thu, 26 May 2022 13:50:43 +0200 Package Name: 1fichierfs Version : 1.9.2~Focal License : blank Package Type: single Are the details correct? [Y/n/q] Skipping creating ../1fichierfs_1.9.2~Focal.orig.tar.gz because it already exists Currently there is not top level Makefile. This may require additional tuning Done. Please edit the files in the debian/ subdirectory now. Package prepared in /tmp/build/1fichierfs That's fine. Then further down the process we have $ bzr commit -m "This is a test" Committing to: /tmp/build/1fichierfs/ added debian added debian/1fichierfs-docs.docs missing debian/README.Debian missing debian/README.source added debian/changelog added debian/control added debian/copyright added debian/rules added debian/source added debian/source/format Committed revision 2. (Note the "missing" warning is not an issue, that is because I purposefully removed these files that I didn't fill with useful information so far) You can notice here that there is no "compat" file although I provided one in the debian directory. echo 10 >debian/compat Then further it seems to complain for compatibility level: $ bzr builddeb -- -us -uc Building using working tree Building package in merge mode Looking for a way to retrieve the upstream tarball Using the upstream tarball that is present in /tmp/build Building the package in /tmp/build/build-area/1fichierfs-1.9.2~Focal, using debuild -us -uc dpkg-buildpackage -us -uc -ui dpkg-buildpackage: info: paquet source 1fichierfs dpkg-buildpackage: info: version source 1.9.2~Focal-1 dpkg-buildpackage: info: distribution source focal dpkg-buildpackage: info: source changé par <...@...fr> dpkg-source --before-build . dpkg-buildpackage: info: architecture hôte amd64 fakeroot debian/rules clean dh clean dh: error: Please specify the compatibility level in debian/compat make: *** [debian/rules:18 : clean] Error 25 dpkg-buildpackage: error: fakeroot debian/rules clean subprocess returned exit status 2 debuild: fatal error at line 1182: dpkg-buildpackage -us -uc -ui failed brz: ERROR: The build failed. This was working as of 16.04, although it seemed to use compatibility level 9, and nowadays this seems obsolete. What am I doing wrong (which is then probably missing in the documentation)? Or is there something broken elsewhere with "compat" not being committed although it is present? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
It was probably the 'mirror replication delay', now it is correctly installed after an "apt update" and repeating the above command "apt install brz-debian/focal-proposed" that previously failed. I'll test and report within 24h. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
Yes, that might be it. If that helps, I can confirm that fr.archive.com has the new version now: Package: brz-debian Architecture: all Version: 2.8.32ubuntu1.1 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
Same no luck: $ LANG=C sudo apt install brz-debian/focal-proposed Reading package lists... Done Building dependency tree Reading state information... Done E: Release 'focal-proposed' for 'brz-debian' was not found Could it be because I am using the closest apt mirror, which is in my case: http://fr.archive.ubuntu.com/ubuntu And that is has not yet been replicated up to that mirror? My test is on Focal. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
$ lsb_release -cs bionic $ sudo apt install --yes dh-make bzr-builddeb brz-debian $ bzr whoami "Your Name " $ wget -O hello-2.10.tar.gz "http://ftp.gnu.org/gnu/hello/hello-2.10.tar.gz; Before: $ dpkg -s brz-debian | grep Version: Version: 2.8.10 $ bzr dh-make hello 2.10 hello-2.10.tar.gz Fetching tarball ... Package prepared in /home/ubuntu/hello $ rm -rf hello hello_2.10.orig.tar.gz $ brz dh-make hello 2.10 hello-2.10.tar.gz brz: ERROR: AttributeError: 'NoneType' object has no attribute 'initialize_on_transport' ... $ rm -rf hello hello_2.10.orig.tar.gz After: $ sudo apt install --yes brz-debian/bionic-proposed $ dpkg -s brz-debian | grep Version: Version: 2.8.10ubuntu1 $ bzr dh-make hello 2.10 hello-2.10.tar.gz Fetching tarball ... Package prepared in /home/ubuntu/hello $ rm -rf hello hello_2.10.orig.tar.gz $ brz dh-make hello 2.10 hello-2.10.tar.gz Fetching tarball ... Package prepared in /home/ubuntu/hello $ rm -rf hello hello_2.10.orig.tar.gz ** Tags removed: verification-needed-bionic ** Tags added: verification-done-bionic ** Description changed: [Impact] * The `bzr dh-make` step in the Ubuntu Packaging Guide [1] fails in Focal. * The alternative `brz dh-make` (BReeZy instead of BaZaaR) fails in Focal and Bionic. * The `dh-make` subcommand is not available in Impish/later. The Guide should be updated and ideally use another tool. [Test Plan] * Prepare: $ sudo apt-get install dh-make bzr-builddeb brz-debian $ bzr whoami "Your Name " $ wget -O hello-2.10.tar.gz "http://ftp.gnu.org/gnu/hello/hello-2.10.tar.gz; * Test bazaar: $ bzr dh-make hello 2.10 hello-2.10.tar.gz * Test breezy: $ brz dh-make hello 2.10 hello-2.10.tar.gz - * On success, remove the generated dir/file for next tests. + * Between tests, remove the generated dir/file: $ rm -rf hello hello_2.10.orig.tar.gz [Where problems could occur] * The changes are restricted to the `dh-make` command in bazaar/breezy, which is broken, so it should not make things worse. But, theoretically, `bzr/brz dh-make` is the impact surface for other issues/regressions from previous/ working releases. [Links] * [1] https://packaging.ubuntu.com/html/packaging-new- software.html#starting-a-package [Other Info] * Bionic is not affected in `bzr`, but just in `brz`, due to being from 2 source packages: `bzr-builddeb` and `breezy-debian`. * Focal is affected in both `bzr/brz` per transition from `bzr-builddeb` to `breezy-debian` (1 src pkg). * Impish+ are not "affected" as `dh-make` was dropped by debian-breezy upstream. * The root cause of the regression is a dropped python `import` in breezy-debian following changes in breezy. The `bzrdir` import sets ControlDir's default format: `controldir.ControlDirFormat._default_format = BzrDirMetaFormat1()` Once debian-breezy.git's dh_make.py:_get_tree() moved from BzrDir. to ControlDir.create_branch_convenience() and dropped the bzrlib import, that is not set anymore. Now, create_branch_convenience() calls create(), calls initialize_on_transport() on the default format (None). commit 08fcab340a2cd4f6bf0f5aec65c304a88023a4f8 Author: Jelmer Vernooij Date: Sat Jun 17 14:10:12 2017 + Update for breezy, drop support for older versions of bazaar and for debian_bundle. ... diff --git a/dh_make.py b/dh_make.py ... from ... import ( -bzrdir, +controldir, ... @@ -34,22 +34,22 @@ def _get_tree(package_name): ... -create_branch = bzrdir.BzrDir.create_branch_convenience ... +create_branch = controldir.ControlDir.create_branch_convenience ... + * Focal needs another patch to fix this in `bzr`: - * Focal needs another patch to fix this in `bzr`: - - $ bzr dh-make hello 2.10 hello-2.10.tar.gz - Fetching tarball - Looking for a way to retrieve the upstream tarball - Upstream tarball already exists in build directory, using that - brz: ERROR: TypeError: can only concatenate str (not "bytes") to str + $ bzr dh-make hello 2.10 hello-2.10.tar.gz + Fetching tarball + Looking for a way to retrieve the upstream tarball + Upstream tarball already exists in build directory, using that + brz: ERROR: TypeError: can only concatenate str (not "bytes") to str * Synthetic test cases for this are provided in comment #1. [Original Bug Description] I am following official Ubuntu Packaging Guide: https://packaging.ubuntu.com/html/packaging-new-software.html When I come to the following part, the command crashes: $ bzr dh-make hello 2.10 hello-2.10.tar.gz brz: ERROR: AttributeError: 'NoneType' object has no attribute 'initialize_on_transport' (trackback bellow) My system: Description: Ubuntu 20.04.3 LTS Release:
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
$ lsb_release -cs focal $ sudo apt install --yes dh-make bzr-builddeb brz-debian $ bzr whoami "Your Name " $ wget -O hello-2.10.tar.gz "http://ftp.gnu.org/gnu/hello/hello-2.10.tar.gz; Before: $ dpkg -s brz-debian | grep Version: Version: 2.8.32ubuntu1 $ bzr dh-make hello 2.10 hello-2.10.tar.gz brz: ERROR: AttributeError: 'NoneType' object has no attribute 'initialize_on_transport' ... $ rm -rf hello hello_2.10.orig.tar.gz $ brz dh-make hello 2.10 hello-2.10.tar.gz brz: ERROR: AttributeError: 'NoneType' object has no attribute 'initialize_on_transport' ... $ rm -rf hello hello_2.10.orig.tar.gz After: $ sudo apt install --yes brz-debian/focal-proposed $ dpkg -s brz-debian | grep Version: Version: 2.8.32ubuntu1.1 $ bzr dh-make hello 2.10 hello-2.10.tar.gz Fetching tarball ... Package prepared in /home/ubuntu/hello $ rm -rf hello hello_2.10.orig.tar.gz $ brz dh-make hello 2.10 hello-2.10.tar.gz Fetching tarball ... Package prepared in /home/ubuntu/hello $ rm -rf hello hello_2.10.orig.tar.gz ** Tags removed: verification-needed-focal ** Tags added: verification-done-focal -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
Hi Zakhar, Thanks for the quick response to the verification request! Your steps are likely correct, it's just the name of the binary package with the changes is `brz-debian` (for the `dh-make` subcommand). I had to double check this as well, and can confirm the changes are available at the archive and in effect. cheers! -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
Hi, thanks for the upgrade. Am I doing something wrong? I followed the steps on testing "proposed" from the page you kindly linked. - Ticked "focal-proposed" - Pined priorities to 400 for "proposed" (to avoid getting all the "proposed"!) - ran: $ LANG=C sudo apt update Hit:1 http://fr.archive.ubuntu.com/ubuntu focal InRelease (...) Hit:6 http://fr.archive.ubuntu.com/ubuntu focal-proposed InRelease (...) Fetched 114 kB in 1s (158 kB/s) Reading package lists... Done Building dependency tree Reading state information... Done All packages are up to date. Which was expected since I did a "normal" update/upgrade prior to adding "proposed". Then ran: $ LANG=C sudo apt install bzr/focal-proposed Reading package lists... Done Building dependency tree Reading state information... Done E: Release 'focal-proposed' for 'bzr' was not found So I still have: $ LANG=C sudo apt list bzr Listing... Done bzr/focal,focal,now 2.7.0+bzr6622+brz all [installed] Any advise on how to test the new version... assuming it made its way into the proposed repositories already? -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
Hello Honza, or anyone else affected, Accepted breezy-debian into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/breezy- debian/2.8.32ubuntu1.1 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed- focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed-focal. In either case, without details of your testing we will not be able to proceed. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping! N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days. ** Changed in: breezy-debian (Ubuntu Focal) Status: In Progress => Fix Committed ** Tags added: verification-needed verification-needed-focal ** Changed in: breezy-debian (Ubuntu Bionic) Status: In Progress => Fix Committed ** Tags added: verification-needed-bionic -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
** Tags added: sts-sponsor-mfo -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
Changes submitted to focal/bionic upload queues. ... Bionic: --- Reverse Dependencies: $ apt rdepends brz-debian brz-debian Reverse Depends: Recommends: ubuntu-dev-tools Recommends: ubuntu-dev-tools Autopkgtests for ubuntu-dev-tools don't actually install brz-debian; but anyway, finished successfully. [1] Version 2.8.10ubuntu1 is available / hasn't been used in the archive. [2] 2018-05-20 03:10:11 -03 Deleted Cosmic proposed universemisc2.8.12 2018-05-06 21:13:59 -03 Superseded Cosmic release universemisc2.8.10 2017-12-04 21:23:48 -02 Published Bionic release universemisc2.8.10 Focal: --- Reverse Dependencies: $ apt rdepends brz-debian brz-debian Reverse Depends: Depends: silver-platter (>= 2.8.30) Recommends: ubuntu-dev-tools Recommends: ubuntu-dev-tools Recommends: ubuntu-dev-tools Depends: bzr-builddeb $ apt rdepends bzr-builddeb bzr-builddeb Reverse Depends: Breaks: bzr (<< 2.8.12+brz) Breaks: python-apt (<< 2.4) |Recommends: ubuntu-dev-tools |Recommends: ubuntu-dev-tools Breaks: python-apt (<< 2.4) |Recommends: ubuntu-dev-tools Breaks: python-apt (<< 2.4) Recommends: packaging-dev Recommends: bikeshed Autopkgtests for ubuntu-dev-tools don't actually install brz-debian; but anyway, finished successfully. [3] Autopkgtests for packaging-dev and bikeshed do not exist. Version 2.8.12ubuntu1.1 is available / hasn't been used in the archive. [4] 2020-07-18 21:10:13 -03 Deleted Groovy proposed universemisc2.8.35 2020-05-13 16:03:40 -03 Superseded Groovy release universemisc2.8.32ubuntu1 2020-02-10 21:53:20 -03 Published Focal release universemisc2.8.32ubuntu1 Links: --- [1] https://autopkgtest.ubuntu.com/results/autopkgtest-bionic-mfo-lp1954595/bionic/amd64/u/ubuntu-dev-tools/20220520_165034_0b5fc@/log.gz [2] https://launchpad.net/ubuntu/+source/breezy-debian/+publishinghistory [3] https://autopkgtest.ubuntu.com/results/autopkgtest-focal-mfo-lp1954595/focal/amd64/u/ubuntu-dev-tools/20220520_163817_f2be3@/log.gz [4] https://launchpad.net/ubuntu/+source/breezy-debian/+publishinghistory ** Changed in: breezy-debian (Ubuntu Focal) Status: Confirmed => In Progress ** Changed in: breezy-debian (Ubuntu Bionic) Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
** Description changed:
[Impact]
* The `bzr dh-make` step in the Ubuntu Packaging Guide [1]
fails in Focal.
* The alternative `brz dh-make` (BReeZy instead of BaZaaR)
fails in Focal and Bionic.
- * The `dh-make` subcommand is not available in Impish/later.
-The Guide should be updated and ideally use another tool.
+ * The `dh-make` subcommand is not available in Impish/later.
+ The Guide should be updated and ideally use another tool.
[Test Plan]
* Prepare:
$ sudo apt-get install dh-make bzr-builddeb brz-debian
$ bzr whoami "Your Name "
$ wget -O hello-2.10.tar.gz
"http://ftp.gnu.org/gnu/hello/hello-2.10.tar.gz;
* Test bazaar:
$ bzr dh-make hello 2.10 hello-2.10.tar.gz
* Test breezy:
$ brz dh-make hello 2.10 hello-2.10.tar.gz
* On success, remove the generated dir/file for next tests.
$ rm -rf hello hello_2.10.orig.tar.gz
[Where problems could occur]
* The changes are restricted to the `dh-make` command
in bazaar/breezy, which is broken, so it should not
make things worse.
But, theoretically, `bzr/brz dh-make` is the impact
surface for other issues/regressions from previous/
working releases.
[Links]
* [1] https://packaging.ubuntu.com/html/packaging-new-
software.html#starting-a-package
[Other Info]
* Bionic is not affected in `bzr`, but just in `brz`,
due to being from 2 source packages: `bzr-builddeb`
and `breezy-debian`.
* Focal is affected in both `bzr/brz` per transition
from `bzr-builddeb` to `breezy-debian` (1 src pkg).
* Impish+ are not "affected" as `dh-make` was dropped
by debian-breezy upstream.
* The root cause of the regression is a dropped python
`import` in breezy-debian following changes in breezy.
The `bzrdir` import sets ControlDir's default format:
`controldir.ControlDirFormat._default_format = BzrDirMetaFormat1()`
Once debian-breezy.git's dh_make.py:_get_tree() moved
from BzrDir. to ControlDir.create_branch_convenience()
and dropped the bzrlib import, that is not set anymore.
Now, create_branch_convenience() calls create(), calls
initialize_on_transport() on the default format (None).
commit 08fcab340a2cd4f6bf0f5aec65c304a88023a4f8
Author: Jelmer Vernooij
Date: Sat Jun 17 14:10:12 2017 +
Update for breezy, drop support for older versions of bazaar and
for debian_bundle.
...
diff --git a/dh_make.py b/dh_make.py
...
from ... import (
-bzrdir,
+controldir,
...
@@ -34,22 +34,22 @@ def _get_tree(package_name):
...
-create_branch = bzrdir.BzrDir.create_branch_convenience
...
+create_branch = controldir.ControlDir.create_branch_convenience
...
+
+
+ * Focal needs another patch to fix this in `bzr`:
+
+ $ bzr dh-make hello 2.10 hello-2.10.tar.gz
+ Fetching tarball
+ Looking for a way to retrieve the upstream tarball
+ Upstream tarball already exists in build directory, using that
+ brz: ERROR: TypeError: can only concatenate str (not "bytes") to str
* Synthetic test cases for this are provided in comment #1.
[Original Bug Description]
I am following official Ubuntu Packaging Guide:
https://packaging.ubuntu.com/html/packaging-new-software.html
When I come to the following part, the command crashes:
$ bzr dh-make hello 2.10 hello-2.10.tar.gz
brz: ERROR: AttributeError: 'NoneType' object has no attribute
'initialize_on_transport'
(trackback bellow)
My system:
Description: Ubuntu 20.04.3 LTS
Release: 20.04
dh-make:
Installed: 2.201903
Candidate: 2.201903
Version table:
*** 2.201903 500
500 http://cz.archive.ubuntu.com/ubuntu focal/main amd64 Packages
500 http://cz.archive.ubuntu.com/ubuntu focal/main i386 Packages
100 /var/lib/dpkg/status
$ bzr dh-make hello 2.10 hello-2.10.tar.gz
brz: ERROR: AttributeError: 'NoneType' object has no attribute
'initialize_on_transport'
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/breezy/plugins/debian/dh_make.py",
line 26, in _get_tree
tree = workingtree.WorkingTree.open(".")
File "/usr/lib/python3/dist-packages/breezy/workingtree.py", line 201, in
open
control = controldir.ControlDir.open(path, _unsupported=_unsupported)
File "/usr/lib/python3/dist-packages/breezy/controldir.py", line 706, in
open
return klass.open_from_transport(t, probers=probers,
File "/usr/lib/python3/dist-packages/breezy/controldir.py", line 736, in
open_from_transport
transport, format = _mod_transport.do_catching_redirections(
File "/usr/lib/python3/dist-packages/breezy/transport/__init__.py", line
1613, in do_catching_redirections
return action(transport)
File "/usr/lib/python3/dist-packages/breezy/controldir.py", line
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
** Patch added: "lp1954595_bionic_breezy-debian.debdiff"
https://bugs.launchpad.net/ubuntu/+source/breezy-debian/+bug/1954595/+attachment/5591619/+files/lp1954595_bionic_breezy-debian.debdiff
** Changed in: breezy-debian (Ubuntu)
Status: Won't Fix => Invalid
** Description changed:
[Impact]
* The `bzr dh-make` step in the Ubuntu Packaging Guide [1]
fails in Focal.
- * The alterantive `brz dh-make` (BReeZy instead of BaZaaR)
+ * The alternative `brz dh-make` (BReeZy instead of BaZaaR)
fails in Focal and Bionic.
+
+ * The `dh-make` subcommand is not available in Impish/later.
+The Guide should be updated and ideally use another tool.
[Test Plan]
* Prepare:
$ sudo apt-get install dh-make bzr-builddeb brz-debian
$ bzr whoami "Your Name "
$ wget -O hello-2.10.tar.gz
"http://ftp.gnu.org/gnu/hello/hello-2.10.tar.gz;
* Test bazaar:
$ bzr dh-make hello 2.10 hello-2.10.tar.gz
* Test breezy:
$ brz dh-make hello 2.10 hello-2.10.tar.gz
* On success, remove the generated dir/file for next tests.
$ rm -rf hello hello_2.10.orig.tar.gz
[Where problems could occur]
* The changes are restricted to the `dh-make` command
in bazaar/breezy, which is broken, so it should not
make things worse.
But, theoretically, `bzr/brz dh-make` is the impact
surface for other issues/regressions from previous/
working releases.
[Links]
* [1] https://packaging.ubuntu.com/html/packaging-new-
software.html#starting-a-package
[Other Info]
* Bionic is not affected in `bzr`, but just in `brz`,
due to being from 2 source packages: `bzr-builddeb`
and `breezy-debian`.
* Focal is affected in both `bzr/brz` per transition
from `bzr-builddeb` to `breezy-debian` (1 src pkg).
* Impish+ are not "affected" as `dh-make` was dropped
by debian-breezy upstream.
* The root cause of the regression is a dropped python
`import` in breezy-debian following changes in breezy.
The `bzrdir` import sets ControlDir's default format:
`controldir.ControlDirFormat._default_format = BzrDirMetaFormat1()`
Once debian-breezy.git's dh_make.py:_get_tree() moved
from BzrDir. to ControlDir.create_branch_convenience()
and dropped the bzrlib import, that is not set anymore.
Now, create_branch_convenience() calls create(), calls
initialize_on_transport() on the default format (None).
commit 08fcab340a2cd4f6bf0f5aec65c304a88023a4f8
Author: Jelmer Vernooij
Date: Sat Jun 17 14:10:12 2017 +
Update for breezy, drop support for older versions of bazaar and
for debian_bundle.
...
diff --git a/dh_make.py b/dh_make.py
...
from ... import (
-bzrdir,
+controldir,
...
@@ -34,22 +34,22 @@ def _get_tree(package_name):
...
-create_branch = bzrdir.BzrDir.create_branch_convenience
...
+create_branch = controldir.ControlDir.create_branch_convenience
...
* Synthetic test cases for this are provided in comment #1.
[Original Bug Description]
I am following official Ubuntu Packaging Guide:
https://packaging.ubuntu.com/html/packaging-new-software.html
When I come to the following part, the command crashes:
$ bzr dh-make hello 2.10 hello-2.10.tar.gz
brz: ERROR: AttributeError: 'NoneType' object has no attribute
'initialize_on_transport'
(trackback bellow)
My system:
Description: Ubuntu 20.04.3 LTS
Release: 20.04
dh-make:
Installed: 2.201903
Candidate: 2.201903
Version table:
*** 2.201903 500
500 http://cz.archive.ubuntu.com/ubuntu focal/main amd64 Packages
500 http://cz.archive.ubuntu.com/ubuntu focal/main i386 Packages
100 /var/lib/dpkg/status
$ bzr dh-make hello 2.10 hello-2.10.tar.gz
brz: ERROR: AttributeError: 'NoneType' object has no attribute
'initialize_on_transport'
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/breezy/plugins/debian/dh_make.py",
line 26, in _get_tree
tree = workingtree.WorkingTree.open(".")
File "/usr/lib/python3/dist-packages/breezy/workingtree.py", line 201, in
open
control = controldir.ControlDir.open(path, _unsupported=_unsupported)
File "/usr/lib/python3/dist-packages/breezy/controldir.py", line 706, in
open
return klass.open_from_transport(t, probers=probers,
File "/usr/lib/python3/dist-packages/breezy/controldir.py", line 736, in
open_from_transport
transport, format = _mod_transport.do_catching_redirections(
File "/usr/lib/python3/dist-packages/breezy/transport/__init__.py", line
1613, in do_catching_redirections
return action(transport)
File "/usr/lib/python3/dist-packages/breezy/controldir.py", line 724, in
find_format
return transport, ControlDirFormat.find_format(transport,
File
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
** Patch added: "lp1954595_focal_breezy-debian.debdiff" https://bugs.launchpad.net/ubuntu/+source/breezy-debian/+bug/1954595/+attachment/5591618/+files/lp1954595_focal_breezy-debian.debdiff -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
Attaching debdiffs with the changes; running autopkgtests for reverse dependencies. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
Test case: $ cat
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
** Also affects: breezy-debian (Ubuntu) Importance: Undecided Status: New ** Also affects: breezy-debian (Ubuntu Focal) Importance: Undecided Status: New ** Also affects: breezy-debian (Ubuntu Bionic) Importance: Undecided Status: New ** Changed in: breezy-debian (Ubuntu) Status: New => Won't Fix ** Changed in: breezy-debian (Ubuntu Bionic) Status: New => Confirmed ** Changed in: breezy-debian (Ubuntu Bionic) Importance: Undecided => Low ** Changed in: breezy-debian (Ubuntu Bionic) Assignee: (unassigned) => Mauricio Faria de Oliveira (mfo) ** Changed in: breezy-debian (Ubuntu Focal) Status: New => Confirmed ** Changed in: breezy-debian (Ubuntu Focal) Importance: Undecided => Medium ** Changed in: breezy-debian (Ubuntu Focal) Assignee: (unassigned) => Mauricio Faria de Oliveira (mfo) ** Tags added: sts -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1954595] Re: bzr dh-make crash - no attribute 'initialize_on_transport'
** Package changed: dh-make (Ubuntu) => ubuntu-packaging-guide -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1954595 Title: bzr dh-make crash - no attribute 'initialize_on_transport' To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-packaging-guide/+bug/1954595/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
