[Bug 1963707] Re: [MIR] libqrtr-glib
** Tags added: sec-1057 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963707 Title: [MIR] libqrtr-glib To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libqrtr-glib/+bug/1963707/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963707] Re: [MIR] libqrtr-glib
Review for Package: src:libqrtr-glib [Summary] libqrtr-glib is a glib-based library to use and manage the QRTR (Qualcomm IPC Router) bus. It seems to be in a good shape upstream and was included in Debian/Ubuntu just recently (2022). MIR team ACK under the constraint to resolve the below listed required TODOs and as much as possible having a look at the recommended TODOs. This does need a security review, so I'll assign ubuntu-security List of specific binary packages to be promoted to main: - gir1.2-qrtr-1.0, libqrtr-glib-dev, libqrtr-glib-doc, libqrtr-glib0 Specific binary packages built, but NOT to be promoted to main: Notes: - libqrtr parses packets received from the modem, so I'm signing it up for a security review Required TODOs: #1 Can we please define a better testing story for this package? Both automatic tests provided (build-time & autopkgtests) are only superficial. I understand that an end-to-end test would require special HW (compatible qualcomm modem), so we should probably define a proper test-plan to be run manually every cycle. Can you please provide a test plan/script/log in the comments below? Recommended TODOs: #2 The package should get a team bug subscriber before being promoted #3 please run `update-maintainer` on the package (or sync once the autopkgtest is uploaded to Debian). [Duplication] There is no other package in main providing the same functionality. [Dependencies] OK: - no other Dependencies to MIR due to this - checked with check-mir - not listed in seeded-in-ubuntu - none of the (potentially auto-generated) dependencies (Depends and Recommends) that are present after build are not in main - no -dev/-debug/-doc packages that need exclusion - No dependencies in main that are only superficially tested requiring more tests now. Problems: None [Embedded sources and static linking] OK: - no embedded source present - no static linking - does not have odd Built-Using entries - not a go package, no extra constraints to consider in that regard Problems: None [Security] OK: - history of CVEs does not look concerning - does not run a daemon as root - does not use webkit1,2 - does not use lib*v8 directly - does not open a port/socket - does not process arbitrary web content - does not use centralized online accounts - does not integrate arbitrary javascript into the desktop - does not deal with system authentication (eg, pam), etc) - does not deal with security attestation (secure boot, tpm, signatures) Problems: - parses data formats (packets received from the kernel's QRTR socket) [Common blockers] OK: - does not FTBFS currently - does have a test suite that runs at build time - test suite fails will fail the build upon error. - no new python2 dependency Problems: - build-time tests only check the documentation, not the actual library - only has a superficial test that runs as autopkgtest - special HW (compatible qualcomm modem) needed to do full end-to-end testing [Packaging red flags] OK: - Ubuntu does carry a delta, but it is reasonable and maintenance under control - also, submitted to Debian: https://bugs.debian.org/1011354 - symbols tracking is in place - d/watch is present and looks ok (if needed, e.g. non-native) - Upstream update history is good - Debian/Ubuntu update history is good (but there's not a lot of history) - the current release is packaged - promoting this does not seem to cause issues for MOTUs that so far maintained the package - no massive Lintian warnings - d/rules is rather clean - It is not on the lto-disabled list Problems: - please run `update-maintainer` on the package [Upstream red flags] OK: - no Errors/warnings during the build - no incautious use of malloc/sprintf (as far as we can check it) - no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH - no use of user nobody - no use of setuid - no important open bugs (crashers, etc) in Debian or Ubuntu - no dependency on webkit, qtwebkit, seed or libgoa-* - not part of the UI for extra checks - no translation present, but none needed for this case (user visible)? Problems: None ** Bug watch added: Debian Bug tracker #1011354 https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1011354 ** Changed in: libqrtr-glib (Ubuntu) Assignee: Lukas Märdian (slyon) => Ubuntu Security Team (ubuntu-security) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963707 Title: [MIR] libqrtr-glib To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libqrtr-glib/+bug/1963707/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963707] Re: [MIR] libqrtr-glib
** Changed in: libqrtr-glib (Ubuntu) Assignee: (unassigned) => Lukas Märdian (slyon) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963707 Title: [MIR] libqrtr-glib To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libqrtr-glib/+bug/1963707/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963707] Re: [MIR] libqrtr-glib
** Description changed: [Availability] The package libqrtr-glib is already in Ubuntu universe. The package libqrtr-glib build for the architectures it is designed to work on. It currently builds and works for architetcures: amd64 armhf arm64 ppc64el riscv64 s390x Link to package https://launchpad.net/ubuntu/+source/libqrtr-glib [Rationale] - The package libqrtr-glib is required in Ubuntu main for modemmanager to support qualcomm modems. We current carry a delta over Debian to disable that option - The package libqrtr-glib will be useful only to users owning such hardware but even if that's a limited set of users it's important for us to have Ubuntu supporting the available hardware. - It would be great and useful to community/processes to have the package libqrtr-glib in Ubuntu main, but there is no definitive deadline. [Security] - No CVEs/security issues in this software in the past - no `suid` or `sgid` binaries - no executables in `/sbin` and `/usr/sbin` - Packages does not open privileged ports (ports < 1024) - Packages does not contain extensions to security-sensitive software [Quality assurance - function/usage] - The package works well right after install [Quality assurance - maintenance] - The package is maintained well in Debian/Ubuntu and has no bug open currently - Ubuntu https://bugs.launchpad.net/ubuntu/+source/libqrtr-glib/+bug - Debian https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=libqrtr-glib [Quality assurance - testing] - The package runs a minimal test suite on build time, if it fails it makes the build fail, link to build log https://launchpadlibrarian.net/587268179/buildlog_ubuntu-jammy-amd64.libqrtr-glib_1.2.2-1_BUILDING.txt.gz - There is a basic build autopkgtest for the library + https://autopkgtest.ubuntu.com/packages/libq/libqrtr-glib [Quality assurance - packaging] - debian/watch is present and works - This package only has a minor lintian warning - Link to recent build log including a lintian run # lintian --pedantic running with root privileges is not recommended! W: libqrtr-glib source: superfluous-file-pattern debian/copyright docs/reference/meson.build (Files, line 28) - Lintian overrides are present, but only to silent warnings about gtk-doc being outside of /usr/share/doc - This package does not rely on obsolete or about to be demoted packages. - This package has no python2 or GTK2 dependencies - The package will be installed by default, but does not ask debconf questions - Packaging and build is easy, link to d/rules https://salsa.debian.org/DebianOnMobile-team/libqrtr- glib/-/blob/debian/master/debian/rules [UI standards] - Application is not end-user facing (does not need translation) [Dependencies] - No further depends or recommends dependencies that are not yet in main [Standards compliance] - This package correctly follows FHS and Debian Policy [Maintenance/Owner] - Owning Team will be desktop-packages - Team is not yet, but will subscribe to the package before promotion - This does not use static builds - This does not use vendored code [Background information] The Package description explains the package well Upstream Name is libqrtr-glib Link to upstream project https://www.freedesktop.org/software/libqmi/libqrtr-glib/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963707 Title: [MIR] libqrtr-glib To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libqrtr-glib/+bug/1963707/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963707] Re: [MIR] libqrtr-glib
** Changed in: libqrtr-glib (Ubuntu) Status: Incomplete => New ** Description changed: [Availability] The package libqrtr-glib is already in Ubuntu universe. The package libqrtr-glib build for the architectures it is designed to work on. It currently builds and works for architetcures: amd64 armhf arm64 ppc64el riscv64 s390x Link to package https://launchpad.net/ubuntu/+source/libqrtr-glib [Rationale] - The package libqrtr-glib is required in Ubuntu main for modemmanager to support qualcomm modems. We current carry a delta over Debian to disable that option - The package libqrtr-glib will be useful only to users owning such hardware but even if that's a limited set of users it's important for us to have Ubuntu supporting the available hardware. - It would be great and useful to community/processes to have the package libqrtr-glib in Ubuntu main, but there is no definitive deadline. [Security] - No CVEs/security issues in this software in the past - no `suid` or `sgid` binaries - no executables in `/sbin` and `/usr/sbin` - Packages does not open privileged ports (ports < 1024) - Packages does not contain extensions to security-sensitive software [Quality assurance - function/usage] - The package works well right after install [Quality assurance - maintenance] - The package is maintained well in Debian/Ubuntu and has no bug open currently - Ubuntu https://bugs.launchpad.net/ubuntu/+source/libqrtr-glib/+bug - Debian https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=libqrtr-glib [Quality assurance - testing] - The package runs a minimal test suite on build time, if it fails it makes the build fail, link to build log https://launchpadlibrarian.net/587268179/buildlog_ubuntu-jammy-amd64.libqrtr-glib_1.2.2-1_BUILDING.txt.gz - - The package does not run an autopkgtest but those should be added at least to test a build with the library + + - There is a basic build autopkgtest for the library [Quality assurance - packaging] - debian/watch is present and works - This package only has a minor lintian warning - Link to recent build log including a lintian run # lintian --pedantic running with root privileges is not recommended! W: libqrtr-glib source: superfluous-file-pattern debian/copyright docs/reference/meson.build (Files, line 28) - Lintian overrides are present, but only to silent warnings about gtk-doc being outside of /usr/share/doc - This package does not rely on obsolete or about to be demoted packages. - This package has no python2 or GTK2 dependencies - The package will be installed by default, but does not ask debconf questions - Packaging and build is easy, link to d/rules https://salsa.debian.org/DebianOnMobile-team/libqrtr- glib/-/blob/debian/master/debian/rules [UI standards] - Application is not end-user facing (does not need translation) [Dependencies] - No further depends or recommends dependencies that are not yet in main [Standards compliance] - This package correctly follows FHS and Debian Policy [Maintenance/Owner] - Owning Team will be desktop-packages - Team is not yet, but will subscribe to the package before promotion - This does not use static builds - This does not use vendored code [Background information] The Package description explains the package well Upstream Name is libqrtr-glib Link to upstream project https://www.freedesktop.org/software/libqmi/libqrtr-glib/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963707 Title: [MIR] libqrtr-glib To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libqrtr-glib/+bug/1963707/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963707] Re: [MIR] libqrtr-glib
** Description changed: [Availability] The package libqrtr-glib is already in Ubuntu universe. The package libqrtr-glib build for the architectures it is designed to work on. It currently builds and works for architetcures: amd64 armhf arm64 ppc64el riscv64 s390x Link to package https://launchpad.net/ubuntu/+source/libqrtr-glib [Rationale] - RULE: There must be a certain level of demand for the package - - The package libqrtr-glib is required in Ubuntu main for modemmanager to support qualcomm modems. The current build in proposed is a sync from Debian with the option turned on so it depends on the library. - - The package libqrtr-glib will be useful only to users owning such hardware but even if that's a limited set of users it's important for us to have Ubuntu supporting the hardware available. + - The package libqrtr-glib is required in Ubuntu main for modemmanager to support qualcomm modems. We current carry a delta over Debian to disable that option + - The package libqrtr-glib will be useful only to users owning such hardware but even if that's a limited set of users it's important for us to have Ubuntu supporting the available hardware. - It would be great and useful to community/processes to have the package libqrtr-glib in Ubuntu main, but there is no definitive deadline. [Security] - No CVEs/security issues in this software in the past - no `suid` or `sgid` binaries - no executables in `/sbin` and `/usr/sbin` - Packages does not open privileged ports (ports < 1024) - Packages does not contain extensions to security-sensitive software [Quality assurance - function/usage] - The package works well right after install [Quality assurance - maintenance] - The package is maintained well in Debian/Ubuntu and has no bug open currently - - Ubuntu https://bugs.launchpad.net/ubuntu/+source/libqrtr-glib/+bug - - Debian https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=libqrtr-glib + - Ubuntu https://bugs.launchpad.net/ubuntu/+source/libqrtr-glib/+bug + - Debian https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=libqrtr-glib [Quality assurance - testing] - The package runs a minimal test suite on build time, if it fails it makes the build fail, link to build log https://launchpadlibrarian.net/587268179/buildlog_ubuntu-jammy-amd64.libqrtr-glib_1.2.2-1_BUILDING.txt.gz - The package does not run an autopkgtest but those should be added at least to test a build with the library - [Quality assurance - packaging] - debian/watch is present and works - This package only has a minor lintian warning - Link to recent build log including a lintian run # lintian --pedantic running with root privileges is not recommended! W: libqrtr-glib source: superfluous-file-pattern debian/copyright docs/reference/meson.build (Files, line 28) - Lintian overrides are present, but only to silent warnings about gtk-doc being outside of /usr/share/doc - This package does not rely on obsolete or about to be demoted packages. - This package has no python2 or GTK2 dependencies - The package will be installed by default, but does not ask debconf questions - Packaging and build is easy, link to d/rules https://salsa.debian.org/DebianOnMobile-team/libqrtr- glib/-/blob/debian/master/debian/rules [UI standards] - Application is not end-user facing (does not need translation) [Dependencies] - No further depends or recommends dependencies that are not yet in main [Standards compliance] - This package correctly follows FHS and Debian Policy [Maintenance/Owner] - Owning Team will be desktop-packages - Team is not yet, but will subscribe to the package before promotion - This does not use static builds - This does not use vendored code [Background information] The Package description explains the package well Upstream Name is libqrtr-glib Link to upstream project https://www.freedesktop.org/software/libqmi/libqrtr-glib/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963707 Title: [MIR] libqrtr-glib To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libqrtr-glib/+bug/1963707/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963707] Re: [MIR] libqrtr-glib
libqmi is stuck in jammy-proposed because it added a dependency on libqrtr-glib for the same reasons. ** Tags added: update-excuse ** Tags added: jammy -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963707 Title: [MIR] libqrtr-glib To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libqrtr-glib/+bug/1963707/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1963707] Re: [MIR] libqrtr-glib
Setting as low priority and incomplete, we will eventually want it but we can disable the build option for now. The autopkgtest situation probably needs to be sort out first, also it's unclear what hardware requires it but we haven't see a demand for it yet ** Changed in: libqrtr-glib (Ubuntu) Importance: Undecided => Low ** Changed in: libqrtr-glib (Ubuntu) Status: New => Incomplete -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1963707 Title: [MIR] libqrtr-glib To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/libqrtr-glib/+bug/1963707/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
