[Bug 1965241] Re: Include DPC Fixes in Ubuntu 22.04 and 20.04
** Description changed: SRU Justification: [Impact] Recovery from DownPort Containment events fail and the NVMe endpoint is not accessible in some scenarios. [Fix] These are some of the DPC fixes which help in handling some of the failure cases of DownPort Containment events. Upstream kernel patches to be included into Ubuntu 22.04 and into Ubuntu 20.04.5: Already in Jammy as of Ubuntu-5.15.0-1.1 PCI/portdrv: Enable Bandwidth Notification only if port supports it https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.17-rc6=00823dcbdd415c868390feaca16f0265101efab4 PCI: pciehp: Ignore Link Down/Up caused by error-induced Hot Reset https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.17-rc6=ea401499e943c307e6d44af6c2b4e068643e7884 3134689f98 PCI/portdrv: Rename pm_iter() to pcie_port_device_iter() [Test Case] 1. Disable the memory space of NVMe end point device 2. Issue IO to the device 3. Observe dmesg. dmesg shows that EDR event is generated, link is contained and NVMe device is recovered. 2. Observe the dmesg [Other Info] - https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1965241 + https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/jammy/+ref/test_dpc_1965241 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965241 Title: Include DPC Fixes in Ubuntu 22.04 and 20.04 To manage notifications about this bug go to: https://bugs.launchpad.net/dellserver/+bug/1965241/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1965241] Re: Include DPC Fixes in Ubuntu 22.04 and 20.04
** Description changed: SRU Justification: [Impact] Recovery from DownPort Containment events fail and the NVMe endpoint is not accessible in some scenarios. [Fix] These are some of the DPC fixes which help in handling some of the failure cases of DownPort Containment events. Upstream kernel patches to be included into Ubuntu 22.04 and into Ubuntu 20.04.5: Already in Jammy as of Ubuntu-5.15.0-1.1 PCI/portdrv: Enable Bandwidth Notification only if port supports it https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.17-rc6=00823dcbdd415c868390feaca16f0265101efab4 - PCI: pciehp: Ignore Link Down/Up caused by error-induced Hot Reset https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.17-rc6=ea401499e943c307e6d44af6c2b4e068643e7884 3134689f98 PCI/portdrv: Rename pm_iter() to pcie_port_device_iter() [Test Case] 1. Disable the memory space of NVMe end point device 2. Issue IO to the device 3. Observe dmesg. dmesg shows that EDR event is generated, link is contained and NVMe device is recovered. 2. Observe the dmesg + [Other Info] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1965241 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965241 Title: Include DPC Fixes in Ubuntu 22.04 and 20.04 To manage notifications about this bug go to: https://bugs.launchpad.net/dellserver/+bug/1965241/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1965241] Re: Include DPC Fixes in Ubuntu 22.04 and 20.04
** Description changed: SRU Justification: [Impact] Recovery from DownPort Containment events fail and the NVMe endpoint is not accessible in some scenarios. [Fix] These are some of the DPC fixes which help in handling some of the failure cases of DownPort Containment events. Upstream kernel patches to be included into Ubuntu 22.04 and into Ubuntu 20.04.5: Already in Jammy as of Ubuntu-5.15.0-1.1 PCI/portdrv: Enable Bandwidth Notification only if port supports it https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.17-rc6=00823dcbdd415c868390feaca16f0265101efab4 - Not yet pulled + PCI: pciehp: Ignore Link Down/Up caused by error-induced Hot Reset https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.17-rc6=ea401499e943c307e6d44af6c2b4e068643e7884 + + 3134689f98 PCI/portdrv: Rename pm_iter() to pcie_port_device_iter() [Test Case] 1. Disable the memory space of NVMe end point device 2. Issue IO to the device 3. Observe dmesg. dmesg shows that EDR event is generated, link is contained and NVMe device is recovered. 2. Observe the dmesg [Other Info] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1965241 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965241 Title: Include DPC Fixes in Ubuntu 22.04 and 20.04 To manage notifications about this bug go to: https://bugs.launchpad.net/dellserver/+bug/1965241/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1965241] Re: Include DPC Fixes in Ubuntu 22.04 and 20.04
** Description changed: SRU Justification: [Impact] Recovery from DownPort Containment events fail and the NVMe endpoint is not accessible in some scenarios. [Fix] These are some of the DPC fixes which help in handling some of the failure cases of DownPort Containment events. Upstream kernel patches to be included into Ubuntu 22.04 and into Ubuntu 20.04.5: Already in Jammy as of Ubuntu-5.15.0-1.1 PCI/portdrv: Enable Bandwidth Notification only if port supports it https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.17-rc6=00823dcbdd415c868390feaca16f0265101efab4 Not yet pulled PCI: pciehp: Ignore Link Down/Up caused by error-induced Hot Reset https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.17-rc6=ea401499e943c307e6d44af6c2b4e068643e7884 [Test Case] + 1. Disable the memory space of NVMe end point device + 2. Issue IO to the device + 3. Observe dmesg. dmesg shows that EDR event is generated, link is contained and NVMe device is recovered. + + 2. Observe the dmesg [Other Info] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1965241 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965241 Title: Include DPC Fixes in Ubuntu 22.04 and 20.04 To manage notifications about this bug go to: https://bugs.launchpad.net/dellserver/+bug/1965241/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1965241] Re: Include DPC Fixes in Ubuntu 22.04 and 20.04
Michael, We tried the test kernel from comment #5. From the sanity tests, basic functionality works as expected - On a system where NVMe end point is connected to root port, 1. When an EDR event occurs, the link is contained and system does not crash. 2. The config space of NVMe end point device is restored. The DPC functionality does not work as expected if CONFIG_PCIE_EDR is not enabled. Test Case: 1. Disable the memory space of NVMe end point device 2. Issue IO to the device 3. Observe dmesg. dmesg shows that EDR event is generated, link is contained and NVMe device is recovered. 2. Observe the dmesg -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965241 Title: Include DPC Fixes in Ubuntu 22.04 and 20.04 To manage notifications about this bug go to: https://bugs.launchpad.net/dellserver/+bug/1965241/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1965241] Re: Include DPC Fixes in Ubuntu 22.04 and 20.04
** Changed in: linux (Ubuntu Jammy) Assignee: Jeff Lane (bladernr) => Michael Reed (mreed8855) -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965241 Title: Include DPC Fixes in Ubuntu 22.04 and 20.04 To manage notifications about this bug go to: https://bugs.launchpad.net/dellserver/+bug/1965241/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1965241] Re: Include DPC Fixes in Ubuntu 22.04 and 20.04
I have updated the test kernel with CONFIG_PCIE_EDR enabled. https://people.canonical.com/~mreed/lp_1965241_DPC_Fix/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965241 Title: Include DPC Fixes in Ubuntu 22.04 and 20.04 To manage notifications about this bug go to: https://bugs.launchpad.net/dellserver/+bug/1965241/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1965241] Re: Include DPC Fixes in Ubuntu 22.04 and 20.04
** Description changed: SRU Justification: - Impact: + [Impact] Recovery from DownPort Containment events fail and the NVMe endpoint is not accessible in some scenarios. - Fix: + [Fix] These are some of the DPC fixes which help in handling some of the failure cases of DownPort Containment events. Upstream kernel patches to be included into Ubuntu 22.04 and into Ubuntu 20.04.5: Already in Jammy as of Ubuntu-5.15.0-1.1 PCI/portdrv: Enable Bandwidth Notification only if port supports it https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.17-rc6=00823dcbdd415c868390feaca16f0265101efab4 Not yet pulled PCI: pciehp: Ignore Link Down/Up caused by error-induced Hot Reset https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.17-rc6=ea401499e943c307e6d44af6c2b4e068643e7884 - Test Case: + [Test Case] + + [Other Info] + https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1965241 ** Also affects: linux (Ubuntu Jammy) Importance: Undecided Assignee: Jeff Lane (bladernr) Status: In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965241 Title: Include DPC Fixes in Ubuntu 22.04 and 20.04 To manage notifications about this bug go to: https://bugs.launchpad.net/dellserver/+bug/1965241/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1965241] Re: Include DPC Fixes in Ubuntu 22.04 and 20.04
Here is the latest branch with the changes https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/jammy/+ref/test_dpc_1965241 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965241 Title: Include DPC Fixes in Ubuntu 22.04 and 20.04 To manage notifications about this bug go to: https://bugs.launchpad.net/dellserver/+bug/1965241/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1965241] Re: Include DPC Fixes in Ubuntu 22.04 and 20.04
I have provided test kernels at the following link: https://people.canonical.com/~mreed/lp_1965241_DPC_Fix/ -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965241 Title: Include DPC Fixes in Ubuntu 22.04 and 20.04 To manage notifications about this bug go to: https://bugs.launchpad.net/dellserver/+bug/1965241/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1965241] Re: Include DPC Fixes in Ubuntu 22.04 and 20.04
I found that this additional patch was also needed. Pcie_port_device_iter was added in 5.16 and referenced in the "PCI: pciehp: Ignore Link Down/Up caused by error-induced Hot Reset" patch commit 3134689f98f9e09004a4727370adc46e7635b4be Author: Lukas Wunner Date: Fri Oct 15 13:58:40 2021 -0500 PCI/portdrv: Rename pm_iter() to pcie_port_device_iter() Rename pm_iter() to pcie_port_device_iter() and make it visible outside CONFIG_PM and portdrv_core.c so it can be used for pciehp slot reset recovery. [bhelgaas: split into its own patch] Link: https://lore.kernel.org/linux-pci/08c046b0-c9f2-3489-eeef-7e7aca435...@gmail.com/ Link: https://lore.kernel.org/r/251f4edcc04c14f873ff1c967bc686169cd07d2d.1627638184.git.lu...@wunner.de Signed-off-by: Lukas Wunner Signed-off-by: Bjorn Helgaas -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965241 Title: Include DPC Fixes in Ubuntu 22.04 and 20.04 To manage notifications about this bug go to: https://bugs.launchpad.net/dellserver/+bug/1965241/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1965241] Re: Include DPC Fixes in Ubuntu 22.04 and 20.04
** Also affects: dellserver Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965241 Title: Include DPC Fixes in Ubuntu 22.04 and 20.04 To manage notifications about this bug go to: https://bugs.launchpad.net/dellserver/+bug/1965241/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1965241] Re: Include DPC Fixes in Ubuntu 22.04 and 20.04
** Changed in: linux (Ubuntu) Status: Incomplete => In Progress ** Changed in: linux (Ubuntu) Assignee: (unassigned) => Jeff Lane (bladernr) ** Description changed: + SRU Justification: + Impact: + Recovery from DownPort Containment events fail and the NVMe endpoint is not accessible in some scenarios. - Target kernels: 5.15 + Fix: + These are some of the DPC fixes which help in handling some of the + failure cases of DownPort Containment events. - - - - These are some of the DPC fixes which help in handling some of the failure cases of DownPort Containment events. Without these, recovery from DPC event fails and NVMe endpoint is not accessible for some of the scenarios. - - Upstream kernel patches to be included into Ubuntu 22.04 SRU and into - Ubuntu 20.04.5: + Upstream kernel patches to be included into Ubuntu 22.04 and into Ubuntu + 20.04.5: Already in Jammy as of Ubuntu-5.15.0-1.1 PCI/portdrv: Enable Bandwidth Notification only if port supports it https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.17-rc6=00823dcbdd415c868390feaca16f0265101efab4 Not yet pulled PCI: pciehp: Ignore Link Down/Up caused by error-induced Hot Reset https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.17-rc6=ea401499e943c307e6d44af6c2b4e068643e7884 + + Test Case: -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965241 Title: Include DPC Fixes in Ubuntu 22.04 and 20.04 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1965241/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1965241] Re: Include DPC Fixes in Ubuntu 22.04 and 20.04
** Description changed: - These are some of the DPC fixes which help in handling some of the - failure cases of DownPort Containment events. Without these, recovery - from DPC event fails and NVMe endpoint is not accessible for some of the - scenarios. + Impact: + + Target kernels: 5.15 + + + + + + These are some of the DPC fixes which help in handling some of the failure cases of DownPort Containment events. Without these, recovery from DPC event fails and NVMe endpoint is not accessible for some of the scenarios. Upstream kernel patches to be included into Ubuntu 22.04 SRU and into Ubuntu 20.04.5: + Already in Jammy as of Ubuntu-5.15.0-1.1 PCI/portdrv: Enable Bandwidth Notification only if port supports it https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.17-rc6=00823dcbdd415c868390feaca16f0265101efab4 + Not yet pulled PCI: pciehp: Ignore Link Down/Up caused by error-induced Hot Reset https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.17-rc6=ea401499e943c307e6d44af6c2b4e068643e7884 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1965241 Title: Include DPC Fixes in Ubuntu 22.04 and 20.04 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1965241/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
