[Bug 340106] Re: Dolphin & Konqueror do not support browsing workgroups with spaces in their name
** Changed in: kde-baseapps Status: In Progress => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/340106 Title: Dolphin & Konqueror do not support browsing workgroups with spaces in their name To manage notifications about this bug go to: https://bugs.launchpad.net/kde-baseapps/+bug/340106/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 340106]
Git commit f40191a147c9643717fda1cf9d1f42c526550893 by Harald Sitter. Committed on 06/04/2020 at 09:27. Pushed by sitter into branch 'master'. smb: add hack to support spaces in workgroup names Summary: workgroup names are as best I can tell always still netbios names which means they can contain a bunch of characters ordinarily not found in valid host names. e.g. spaces this causes trouble with the IANA SMB URI draft, as used by libsmbc, since the workgroup would be the host field of the RI when browsing a workgroup (i.e. filtering hosts that are member of a given workgroup) because QUrl does not allow invalid hostnames in the host field. to bypass this problem we now put the workgroup name into the query of the url as `kio-workgroup`, should it cause trouble in the host field. SMBUrl takes this query into account when constructing the url for smbc. since the latter has uniquely exciting potential for breakage this entire dance is only done when absolutely necessary and otherwise we continue with all the same code and behavior as without this commit. on a side note: the awkward name flexibility seems to not extend to computer names anymore (supposedly because of LLMNR) so this entire use case is already very niche as we (and libsmbclient) currently only support workgroup browsing for NT1 networks, and NT1 is by default not supported on windows10 or samba. FIXED-IN: 20.04 Test Plan: builds, test passes, can browse workgroup with space in name Reviewers: ngraham Subscribers: kde-frameworks-devel, kfm-devel, thiago Tags: #dolphin, #frameworks Differential Revision: https://phabricator.kde.org/D27804 M +35 -0smb/autotests/smburltest.cpp M +11 -1smb/kio_smb_browse.cpp M +57 -4smb/smburl.cpp https://commits.kde.org/kio- extras/f40191a147c9643717fda1cf9d1f42c526550893 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/340106 Title: Dolphin & Konqueror do not support browsing workgroups with spaces in their name To manage notifications about this bug go to: https://bugs.launchpad.net/kde-baseapps/+bug/340106/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 340106]
https://phabricator.kde.org/D27804 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/340106 Title: Dolphin & Konqueror do not support browsing workgroups with spaces in their name To manage notifications about this bug go to: https://bugs.launchpad.net/kde-baseapps/+bug/340106/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 340106] Re: Dolphin & Konqueror do not support browsing workgroups with spaces in their name
** Changed in: kde-baseapps Status: New => In Progress -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/340106 Title: Dolphin & Konqueror do not support browsing workgroups with spaces in their name To manage notifications about this bug go to: https://bugs.launchpad.net/kde-baseapps/+bug/340106/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 340106]
(In reply to Harald Sitter from comment #7)
> Thanks.
>
> With that in mind we cannot really support spaces while also following the
> smb URI format [1]. I suppose we'll just have to deviate a bit iff the
> workgroup name contains a space by using a variant of the notation that
> stuffs the workgroup into the userinfo `smb://work group;@/` and then
> translate that back to an smb URI for libsmbclient again. Means the urls
> wont be portable but at least navigation within our tech works.
>
> [1] https://www.iana.org/assignments/uri-schemes/prov/smb
You may need the user info for the actual user name that is being used
to search that work group. I would recommend using the path or query
component instead:
smb://userwg;user:password@/browsed_workgroup
smb://userwg;user:password@/?=search=browsed_workgroup
This searches the workgroup named "browsed_workgroup" with the user
"userwg\user".
The query has the added benefit a server inside the workgroup is a
proper sub-URL:
smb://userwg;user:password@server/share/folder/file.txt?search=browsed_workgroup
That is,
QUrl wg("smb://user@/?search=WG");
QUrl relative("/share/folder/file.txt");
qDebug() << wg.resolved(relative); //
"smb://user@/share/folder/file.txt?search=WG"
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/340106
Title:
Dolphin & Konqueror do not support browsing workgroups with spaces in
their name
To manage notifications about this bug go to:
https://bugs.launchpad.net/kde-baseapps/+bug/340106/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 340106]
QUrl's behaviour is intentional. The hostname component of the URL has to be a valid hostname. Do not store anything in that component that is not a hostname. Like a workgroup name. Store that elsewhere. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/340106 Title: Dolphin & Konqueror do not support browsing workgroups with spaces in their name To manage notifications about this bug go to: https://bugs.launchpad.net/kde-baseapps/+bug/340106/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 340106]
Thanks. With that in mind we cannot really support spaces while also following the smb URI format [1]. I suppose we'll just have to deviate a bit iff the workgroup name contains a space by using a variant of the notation that stuffs the workgroup into the userinfo `smb://work group;@/` and then translate that back to an smb URI for libsmbclient again. Means the urls wont be portable but at least navigation within our tech works. [1] https://www.iana.org/assignments/uri-schemes/prov/smb -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/340106 Title: Dolphin & Konqueror do not support browsing workgroups with spaces in their name To manage notifications about this bug go to: https://bugs.launchpad.net/kde-baseapps/+bug/340106/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 340106]
Outdated RFC, you need to read about IDN and punycode. https://en.wikipedia.org/wiki/Internationalized_domain_name Thiago is the expert about these things. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/340106 Title: Dolphin & Konqueror do not support browsing workgroups with spaces in their name To manage notifications about this bug go to: https://bugs.launchpad.net/kde-baseapps/+bug/340106/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 340106]
CCing David Faure for some input
This is either a bug in QUrl or not a bug at all.
We do
```
QUrl u("smb://");
u.setHost(dirpName);
```
to which QUrl says
> Invalid hostname (contains invalid characters); source was \"FOO BAR\";
> scheme = \"smb\", host = \"\"
https://tools.ietf.org/html/rfc3986#section-3.2
defines host as
> host = IP-literal / IPv4address / reg-name`
of which the only relevant group for the bug is reg-name:
> reg-name= *( unreserved / pct-encoded / sub-delims )
of which no group would allow for spaces except for pct-encoded, assuming the
space is percent-encoded of course.
Which would make this a QUrl bug if the RFC didn't also explicitly say:
> URI producing
> applications must not use percent-encoding in host unless it is used
> to represent a UTF-8 character sequence.
I **think** that is meant to say that one must not percent-encode if the
character is plain ASCII, so by extension a space cannot be part of reg-
name at all.
OTOH I ran smb://FOO%20BAR/ through a bunch of other rfc3986/7
implementation and they all found it to be perfectly valid.
So, I am really not sure.
Iff spaces cannot be expressed, then spaces in workgroup and domains are
probably not supportable as it'd impair URI portability. Also QUrl would
then be behaving correctly in declaring the URI invalid, and we use QUrl
all over the place, so that'd be a bit of a problem.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/340106
Title:
Dolphin & Konqueror do not support browsing workgroups with spaces in
their name
To manage notifications about this bug go to:
https://bugs.launchpad.net/kde-baseapps/+bug/340106/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 340106] Re: Dolphin & Konqueror do not support browsing workgroups with spaces in their name
Launchpad has imported 4 comments from the remote bug at https://bugs.kde.org/show_bug.cgi?id=204423. If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. On 2009-08-19T17:20:29+00:00 Vladimir Hidalgo wrote: Version: 4.3.0 (using KDE 4.3.0) Compiler: deb http://ppa.launchpad.net/kubuntu-ppa/backports/ubuntu jaunty main KDE 4.3.0 downloaded from that PPA. OS:Linux Installed from:Ubuntu Packages I'm in a office network of wich network's domain name was selected long time ago and it included spaces in it. Ej. "Office C.V.". Problem arises when you try to navigate the network using "smb://Office C.V." but you can actually see the Network if you just type "smb://". It seems that Konqueror (and Dolphin too) are unable to process the space in the Domain name and fails to open it. I've had problems mounting shares with spaces in fstab, but that can be worked around by using "\040" instead of the spaces. I've tried everything in Konqueror/Dolphin to access this network, some attempts are: * smb://Office\040C.V. Konqueror complains about wrong URL format Dolphin says it's an invalid URL * smb://Office+C.V. Konqueror & Dolphin says that "server can't be contacted". This is a big bug for me, as I have to do "smbtree" to find the individuals PC on the network and use "smb://" to skip the domain issue. But when it comes to someone having spaces in his network's name... well, there I have to use fstab and the \040 trick. That is impractical to do, it's as impractical as telling everyone to change the domain name just because me. Reply at: https://bugs.launchpad.net/ubuntu/+source/kdebase- runtime/+bug/340106/comments/3 On 2009-08-26T00:41:06+00:00 Vladimir Hidalgo wrote: Well, system crashed and I decided to try Ubuntu, Nautilus does not suffer from this bug and so I don't think I'm going back to KDE while having this inconvenience. I think I'll not be able to test this anymore. Reply at: https://bugs.launchpad.net/ubuntu/+source/kdebase- runtime/+bug/340106/comments/4 On 2017-10-28T15:31:44+00:00 Nate-b wrote: *** Bug 246471 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/kdebase- runtime/+bug/340106/comments/7 On 2017-10-28T15:39:38+00:00 Nate-b wrote: *** Bug 195012 has been marked as a duplicate of this bug. *** Reply at: https://bugs.launchpad.net/ubuntu/+source/kdebase- runtime/+bug/340106/comments/8 -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/340106 Title: Dolphin & Konqueror do not support browsing workgroups with spaces in their name To manage notifications about this bug go to: https://bugs.launchpad.net/kde-baseapps/+bug/340106/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 340106] Re: Dolphin Konqueror do not support browsing workgroups with spaces in their name
** Changed in: kdebase Importance: Unknown = Medium -- You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to kdebase-runtime in ubuntu. https://bugs.launchpad.net/bugs/340106 Title: Dolphin Konqueror do not support browsing workgroups with spaces in their name -- kubuntu-bugs mailing list kubuntu-b...@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 340106] Re: Dolphin Konqueror do not support browsing workgroups with spaces in their name
** Changed in: kdebase Status: Unknown = New -- Dolphin Konqueror do not support browsing workgroups with spaces in their name https://bugs.launchpad.net/bugs/340106 You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to kdebase-runtime in ubuntu. -- kubuntu-bugs mailing list kubuntu-b...@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 340106] Re: Dolphin Konqueror do not support browsing workgroups with spaces in their name
Reported in upstream: https://bugs.kde.org/show_bug.cgi?id=204423 ** Bug watch added: KDE Bug Tracking System #204423 http://bugs.kde.org/show_bug.cgi?id=204423 -- Dolphin Konqueror do not support browsing workgroups with spaces in their name https://bugs.launchpad.net/bugs/340106 You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to kdebase in ubuntu. -- kubuntu-bugs mailing list kubuntu-b...@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 340106] Re: Dolphin Konqueror do not support browsing workgroups with spaces in their name
Thanks for the upstream report. ** Package changed: kdebase (Ubuntu) = kdebase-runtime (Ubuntu) ** Changed in: kdebase-runtime (Ubuntu) Importance: Undecided = Low ** Changed in: kdebase-runtime (Ubuntu) Status: New = Triaged ** Also affects: kdebase via http://bugs.kde.org/show_bug.cgi?id=204423 Importance: Unknown Status: Unknown -- Dolphin Konqueror do not support browsing workgroups with spaces in their name https://bugs.launchpad.net/bugs/340106 You received this bug notification because you are a member of Kubuntu Bugs, which is subscribed to kdebase-runtime in ubuntu. -- kubuntu-bugs mailing list kubuntu-b...@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
[Bug 340106] Re: Dolphin Konqueror do not support browsing workgroups with spaces in their name
** Description changed: - Binary package hint: dolphin-kde4 + Binary package hint: dolphin Dolphin Konqueror do not support workgroups or domains with spaces in their name. I think this is a bug (as Windows can manage them), even if it's a bad practice to put spaces in workgroups names. Sometimes you can't choose to change the workgroup name, as in my case, because someone in my job decided it long time before, and no one is willing to change every machine's Workgroup just for my Ubuntu Box :P ** Package changed: kdebase-kde4 (Ubuntu) = kdebase (Ubuntu) -- Dolphin Konqueror do not support browsing workgroups with spaces in their name https://bugs.launchpad.net/bugs/340106 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 340106] [NEW] Dolphin Konqueror do not support browsing workgroups with spaces in their name
Public bug reported: Binary package hint: dolphin-kde4 Dolphin Konqueror do not support workgroups or domains with spaces in their name. I think this is a bug (as Windows can manage them), even if it's a bad practice to put spaces in workgroups names. Sometimes you can't choose to change the workgroup name, as in my case, because someone in my job decided it long time before, and no one is willing to change every machine's Workgroup just for my Ubuntu Box :P ** Affects: kdebase-kde4 (Ubuntu) Importance: Undecided Status: New -- Dolphin Konqueror do not support browsing workgroups with spaces in their name https://bugs.launchpad.net/bugs/340106 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 340106] Re: Dolphin Konqueror do not support browsing workgroups with spaces in their name
** Attachment added: Image shows the error in Dolphin http://launchpadlibrarian.net/23669882/test3.jpeg -- Dolphin Konqueror do not support browsing workgroups with spaces in their name https://bugs.launchpad.net/bugs/340106 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 340106] Re: Dolphin Konqueror do not support browsing workgroups with spaces in their name
I forgot to metion I'm using Kubuntu 8.10 with KDE 4.2 -- Dolphin Konqueror do not support browsing workgroups with spaces in their name https://bugs.launchpad.net/bugs/340106 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
