Re: [Bug 1617067] Re: [MIR] PolicyKit Unity8
Thanks for the review! On Thu, 2016-09-22 at 07:40 +, Seth Arnold wrote: > Please add -- or document here -- negative tests that exercise > failure > and 'cancel' pathways. If they don't yet exist, please have them > checked > into yakkety before release. For the user hitting the cancel button the test is in the authentication dialog tests: http://bazaar.launchpad.net/~unity-api-team/policykit-unity8/16.04/view /head:/tests/authentication-test.cpp#L200 For the agent cancelling: http://bazaar.launchpad.net/~unity-api-team/policykit-unity8/16.04/view /head:/tests/agent-test.cpp#L257 To ensure that we cancel on shutdown and free'ing of the internal objects: http://bazaar.launchpad.net/~unity-api-team/policykit-unity8/16.04/view /head:/tests/agent-test.cpp#L320 A cancel at the auth manager level (not really from outside, but more checking internal logic): http://bazaar.launchpad.net/~unity-api-team/policykit-unity8/16.04/view /head:/tests/auth-manager-test.cpp#L203 I think that covers most of the pathways in question, please note if there's others you think we should cover. -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1617067 Title: [MIR] PolicyKit Unity8 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/policykit-unity8/+bug/1617067/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
Re: [Bug 1617067] Re: [MIR] PolicyKit Unity8
On Fri, 2016-08-26 at 13:55 +, Michael Terry wrote: > - You say "This package has a test suite." Sure... but the suite is > explicitly disabled with -Denable_tests=OFF in debian/rules. We > should > be running tests during build (or in autopkgtests) if we can. Uhg, I didn't realize that. I will fix it. > - Is there a team bug subscriber in [1] that fits and could be > subscribed? (mentally add phablet-team, unity-ui-team, and unity-api- > team to that list) > The indicator-applet-developers team is subscribed. Not sure there's a better/worse team to add, we really need to do an LP team cleanup again :-( -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1617067 Title: [MIR] PolicyKit Unity8 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/policykit-unity8/+bug/1617067/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
