The proposal to merge ~didrocks/ubuntu/+source/gnome-shell:resolve-gdm-symlink
into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master has been updated.
Status: Needs review => Merged
For more details, see:
Marco Trevisan (Treviño) has proposed merging
~3v1n0/ubuntu/+source/gnome-session:ubuntu/master into
~ubuntu-desktop/ubuntu/+source/gnome-session:ubuntu/master.
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
Related bugs:
Bug #1799205 in gnome-session (Ubuntu): "Ubuntu wayland sessions
The proposal to merge ~3v1n0/ubuntu/+source/gnome-session:ubuntu/master into
~ubuntu-desktop/ubuntu/+source/gnome-session:ubuntu/master has been updated.
Status: Needs review => Approved
For more details, see:
Thanks for looking and thinking about changing the script name! LGTM.
--
https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-session/+git/gnome-session/+merge/357620
Your team Ubuntu Desktop is requested to review the proposed merge of
~3v1n0/ubuntu/+source/gnome-session:ubuntu/master into
I'd avoid to do the C changes, while you can just use something like this:
try {
while (GLib.file_test(path, GLib.FileTest.IS_SYMLINK))
path = GLib.file_read_link(path)
} catch (e) {}
Or even avoiding the file_test check (and replacing it with `true`, since the
catch will stop the
The proposal to merge ~3v1n0/ubuntu/+source/gnome-session:ubuntu/master into
~ubuntu-desktop/ubuntu/+source/gnome-session:ubuntu/master has been updated.
Status: Approved => Merged
For more details, see:
Also, wondering if having this inside st-theme instead of js would make sense,
so that once the stylesheet is loaded then we refer resources related to that
path.
It's something *maybe* upstreamable. Although probably still not :|
--
Review: Approve
--
https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-session/+git/gnome-session/+merge/357620
Your team Ubuntu Desktop is subscribed to branch
~ubuntu-desktop/ubuntu/+source/gnome-session:ubuntu/master.
--
ubuntu-desktop mailing list
ubuntu-desktop@lists.ubuntu.com
Didier Roche has proposed merging
~didrocks/ubuntu/+source/gnome-shell:resolve-gdm-symlink into
~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master.
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
For more details, see:
Went with the first approach you proposed, which is the more readable IMHO.
Thanks!
--
https://code.launchpad.net/~didrocks/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/357609
Your team Ubuntu Desktop is requested to review the proposed merge of
10 matches
Mail list logo
