[Merge] ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master

2019-04-11 Thread Gunnar Hjalmarsson
Gunnar Hjalmarsson has proposed merging ~gunnarhj/ubuntu/+source/gnome-control-center:serbian-fix into ~ubuntu-desktop/ubuntu/+source/gnome-control-center:ubuntu/master. Requested reviews: Ubuntu Desktop (ubuntu-desktop) For more details, see:

[Merge] ~3v1n0/ubuntu/+source/mutter:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master

2019-04-11 Thread Treviño
The proposal to merge ~3v1n0/ubuntu/+source/mutter:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master has been updated. Description changed to: Prepared packages at https://bileto.ubuntu.com/#/ticket/3699 For more details, see:

Re: [Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master

2019-04-11 Thread Daniel van Vugt
Review: Abstain Aside from the size, I'm not familiar with any of the changes here. But I know we're also in a hurry. So maybe land it ASAP and defer to manual testing instead of a code review. -- https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/365834 Your

Re: [Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master

2019-04-11 Thread Daniel van Vugt
Diff 18486 lines (+4062/-3431) Are you sure that's correct? Got the right branch? -- https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-shell/+git/gnome-shell/+merge/365834 Your team Ubuntu Desktop is requested to review the proposed merge of ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/master

Re: [Merge] ~3v1n0/ubuntu/+source/mutter:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master

2019-04-11 Thread Daniel van Vugt
Review: Approve Looks like what I was expecting... -- https://code.launchpad.net/~3v1n0/ubuntu/+source/mutter/+git/mutter/+merge/365833 Your team Ubuntu Desktop is requested to review the proposed merge of ~3v1n0/ubuntu/+source/mutter:ubuntu/master into

[Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master

2019-04-11 Thread Treviño
The proposal to merge ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master has been updated. Description changed to: Prepared packages at https://bileto.ubuntu.com/#/ticket/3699 As per theme changes, yaru isn't affected by neither

Re: [Merge] ~3v1n0/ubuntu/+source/mutter:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master

2019-04-11 Thread Daniel van Vugt
Review: Needs Fixing Listing things that this release does not change and calling them "changes" is a bit confusing. Maybe don't list such things... +mutter (3.32.0+git20190410-1ubuntu1) disco; urgency=medium + + * Merge with debian git snapshot (LP: #1820542), remaining changes: ++

Re: [Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master

2019-04-11 Thread Treviño
> Diff 18486 lines (+4062/-3431) > > Are you sure that's correct? Got the right branch? Yep, it's just that this contains both upstream and downstream diffs. To be sure just do `git diff de6512 marco/ubuntu/master --stat` or `git diff salsa/debian/master marco/ubuntu/master` (assuming your

Re: [Merge] ~3v1n0/ubuntu/+source/gnome-shell:ubuntu/master into ~ubuntu-desktop/ubuntu/+source/gnome-shell:ubuntu/master

2019-04-11 Thread Daniel van Vugt
Review: Needs Fixing Although... Listing things we didn't change is very confusing. Maybe don't do that: changelog: +gnome-shell (3.32.0+git20190410-1ubuntu1) disco; urgency=medium + + * Merging with debian git snapshot (LP: #1820775, LP: #1818790), +remaining changes: ... + all of