[Bug 1754671] Re: Full-tunnel VPN DNS leakage regression

2019-06-03 Thread Sebastien Bacher
bug #1831261 is also described as a potential side effect from this change -- You received this bug notification because you are a member of Network- manager, which is subscribed to NetworkManager. https://bugs.launchpad.net/bugs/1754671 Title: Full-tunnel VPN DNS leakage regression To

Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10

2019-06-03 Thread Tony Espy
I'm not clear if this commit is temporary or not? Did you mean to check this in so that you could test your CI changes, or are these changes intended to be permanent so that we can build the snap using CI? Do we disable a similar set of tests in the old HWE nm build too? If these changes are

[Bug 1754671] Re: Full-tunnel VPN DNS leakage regression

2019-06-03 Thread Dan Streetman
** Also affects: network-manager (Ubuntu Cosmic) Importance: Undecided Status: New ** Also affects: systemd (Ubuntu Cosmic) Importance: Undecided Status: New ** Changed in: systemd (Ubuntu Cosmic) Assignee: (unassigned) => Dan Streetman (ddstreet) ** Changed in: systemd

[Bug 1754671] Re: Full-tunnel VPN DNS leakage regression

2019-06-03 Thread Dan Streetman
> Is this going to be fixed in disco? speaking for systemd only, the commit needed is a97a3b256cd6c56ab1d817440d3b8acb3272ee17: https://github.com/systemd/systemd/commit/a97a3b256 that's included starting at v240, so is already in disco. -- You received this bug notification because you are a

Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10

2019-06-03 Thread System Enablement Bot
Review: Approve continuous-integration PASSED: Continuous integration, rev:fac4a6e925fc19ade02642f77901e60a1c362294 https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/378/ Executed test runs: SUCCESS:

Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10

2019-06-03 Thread System Enablement Bot
Review: Needs Fixing continuous-integration FAILED: Continuous integration, rev:c2fba4bc55e6f882d5e7a1ca96bde09f075ba515 https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-build-prepare/377/ Executed test runs: FAILURE:

[Bug 1754671] Re: Full-tunnel VPN DNS leakage regression

2019-06-03 Thread Dan Streetman
Uploaded patched systemd to b/c queues. -- You received this bug notification because you are a member of Network- manager, which is subscribed to NetworkManager. https://bugs.launchpad.net/bugs/1754671 Title: Full-tunnel VPN DNS leakage regression To manage notifications about this bug go

Re: [Merge] ~alfonsosanchezbeato/network-manager:test-ci into network-manager:snap-1.10

2019-06-03 Thread Alfonso Sanchez-Beato
It is permanent, otherwise the snap fails the build from launchpad. Yes, we did disable a few tests in the UC16 NM snap. I have re-worked the commit to be more specific. -- https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/367987 Your team

[Bug 1754671] Re: Full-tunnel VPN DNS leakage regression

2019-06-03 Thread Paul Smith
Is this going to be fixed in disco? -- You received this bug notification because you are a member of Network- manager, which is subscribed to NetworkManager. https://bugs.launchpad.net/bugs/1754671 Title: Full-tunnel VPN DNS leakage regression To manage notifications about this bug go to:

[Merge] ~marcustomlinson/epiphany/+git/snap:master into ~ubuntu-desktop/epiphany/+git/snap:master

2019-06-03 Thread Marcus Tomlinson
Marcus Tomlinson has proposed merging ~marcustomlinson/epiphany/+git/snap:master into ~ubuntu-desktop/epiphany/+git/snap:master. Commit message: bump to 3.33.1 and link gtk & libdazzle from source Requested reviews: Ubuntu Desktop (ubuntu-desktop) For more details, see:

Re: [Merge] ~marcustomlinson/epiphany/+git/snap:master into ~ubuntu-desktop/epiphany/+git/snap:master

2019-06-03 Thread Ken VanDine
Review: Approve Looks good, just one inline comment but nothing important. Diff comments: > diff --git a/snapcraft.yaml b/snapcraft.yaml > index 18543be..44cb10a 100644 > --- a/snapcraft.yaml > +++ b/snapcraft.yaml > @@ -83,6 +85,54 @@ parts: >- gcc-multilib >- g++-multilib >

[Bug 1754671] Re: Full-tunnel VPN DNS leakage regression

2019-06-03 Thread Dan Streetman
** Tags added: ddstreet-next -- You received this bug notification because you are a member of Network- manager, which is subscribed to NetworkManager. https://bugs.launchpad.net/bugs/1754671 Title: Full-tunnel VPN DNS leakage regression To manage notifications about this bug go to: