Using this small change to test auto-merge in CI.
--
https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/368906
Your team Network-manager is requested to review the proposed merge of
~alfonsosanchezbeato/network-manager:ignore-artefacts into
Proposed change built in this PPA:
https://launchpad.net/~gunnarhj/+archive/ubuntu/gnome-control-center
--
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-control-center/+git/gnome-control-center/+merge/368417
Your team Ubuntu Desktop is requested to review the proposed merge of
The proposal to merge
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master has been
updated.
Status: Needs review => Work in progress
For more details, see:
Gunnar Hjalmarsson has proposed merging
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session3 into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master.
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
Related bugs:
Bug #1786344 in gnome-settings-daemon (Ubuntu):
Hi Laney,
I have tested (by faking Japanese first logins) the idea to call
add_ibus_sources_from_locale() from maybe_convert_old_settings(). This is where
I put it:
if (g_variant_n_children (sources) < 1) {
convert_libgnomekbd_layouts (settings);
An attempt to summarize:
1. get_sources_from_xkb_config() needs to be called if no XKB layouts were
added previously.
2. add_ibus_sources_from_locale() needs to be run once regardless.
To meet both those conditions, you cannot call add_ibus_sources_from_locale()
from
Gunnar Hjalmarsson has proposed merging
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session2 into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master.
Requested reviews:
Iain Lane (laney)
Related bugs:
Bug #1786344 in gnome-settings-daemon (Ubuntu): "Default IBus
The proposal to merge
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session2 into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master has been
updated.
Status: Needs review => Work in progress
For more details, see:
I put a build of the branch in a PPA:
https://launchpad.net/~gunnarhj/+archive/ubuntu/gnome-settings-daemon
Also, the test case in the bug description suggests a convenient way to confirm
the effect.
--
Well, I couldn't let this go, and submitted yet another MP:
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368678
Letting maybe_convert_old_settings() return a boolean, which tells us whether
it's the first run, seems to be a more
The proposal to merge
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master has been
updated.
Status: Needs review => Work in progress
For more details, see:
Ok, you are of course right. I picked the second of those ideas and made an
attempt in a new MP.
--
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368409
Your team Ubuntu Desktop is requested to review the proposed merge of
Yeah, I agree; basically that's what I mentioned at the end of my previous
comment. But moving it out from the if() wouldn't make a difference wrt the
problem with installs without any XKB layout.
--
Talked with Laney on #ubuntu-desktop. Will try a different approach and get
back.
--
https://code.launchpad.net/~gunnarhj/ubuntu/+source/gnome-settings-daemon/+git/gnome-settings-daemon/+merge/368409
Your team Ubuntu Desktop is requested to review the proposed merge of
Alfonso Sanchez-Beato has proposed merging
~alfonsosanchezbeato/network-manager:ignore-artefacts into
network-manager:snap-1.10.
Commit message:
gitignore: ignore snaps and folder created by run-tests.sh
Requested reviews:
Network-manager (network-manager)
For more details, see:
Daniel van Vugt has proposed merging
~vanvugt/ubuntu/+source/mutter:fix-1809407-eoan into
~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master.
Commit message:
Fix wallpaper corruption on resume from suspend on Nvidia
https://bugs.launchpad.net/bugs/1809407
Requested reviews:
Ubuntu
Gunnar Hjalmarsson has proposed merging
~gunnarhj/ubuntu/+source/gnome-settings-daemon:ibus-live-session into
~ubuntu-desktop/ubuntu/+source/gnome-settings-daemon:ubuntu/master.
Requested reviews:
Ubuntu Desktop (ubuntu-desktop)
Related bugs:
Bug #1786344 in gnome-settings-daemon (Ubuntu):
I have checked again on Bionic, making sure that the installed systemd
actually comes from the bionic-proposed repository, that the behavior
according to the test case shown in the initial description of this bug
is correct, DNS queries of destinations in the VPN done through the
VPN's DNS and DNS
This was fixed in systemd 237-3ubuntu10.22 for bionic, and
239-7ubuntu10.14 for cosmic. I missed a "#" in the changelog (sorry) so
the tooling didn't automatically mark this bug as fix released.
** Changed in: systemd (Ubuntu Bionic)
Status: Fix Committed => Fix Released
** Changed in:
Thanks for trying that.
I think you should probably not put it in any if() in that function. In English
that says something along the lines of "the first time we try to convert the
settings, also add the IBus sources". I'd put the call right above "if
(!g_file_set_contents (stamp_file_path,
Review: Approve
Indeed, from the build log 'warning: undefined reference to
`gnome_settings_get_chassis_type' ... it's annoying that such problems don't
fail the build :/
Thanks for the fix, it makes sense
--
Come on, you can think of ways around this! A couple of ideas, but there are
probably more:
- Make maybe_convert_old_settings() return a boolean to indicate if it ran or
exited due to the stamp file. If it ran, then call
add_ibus_sources_from_locale() later on.
- Make it return the number
The proposal to merge
lp:~khurshid-alam/unity-settings-daemon/fix-airplane-switch into
lp:unity-settings-daemon has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/fix-airplane-switch/+merge/368880
--
Khurshid Alam has proposed merging
lp:~khurshid-alam/unity-settings-daemon/fix-airplane-switch into
lp:unity-settings-daemon.
Commit message:
Fix airplane mode switch not appearing on network panel.
Requested reviews:
Sebastien Bacher (seb128)
For more details, see:
24 matches
Mail list logo
