[Merge] lp:~khurshid-alam/unity-settings-daemon/libnm-port into lp:unity-settings-daemon

2019-05-03 Thread Sebastien Bacher
The proposal to merge lp:~khurshid-alam/unity-settings-daemon/libnm-port into lp:unity-settings-daemon has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~khurshid-alam/unity-settings-daemon/libnm-port/+merge/366761 -- Your team Un

Re: [Merge] lp:~khurshid-alam/unity-settings-daemon/libnm-port into lp:unity-settings-daemon

2019-05-03 Thread Sebastien Bacher
Review: Approve Thanks for the work, I don't think it makes sense to review the code there since it's a lot of change and basically a backport from upstream code already used in GNOME, let's rather go through functional testing. Landing the change (especially early in the cycle) is +1 from me,

[Merge] lp:~khurshid-alam/unity-settings-daemon/libnm-port into lp:unity-settings-daemon

2019-05-02 Thread Khurshid Alam
Khurshid Alam has proposed merging lp:~khurshid-alam/unity-settings-daemon/libnm-port into lp:unity-settings-daemon. Commit message: rfkill: Add RFKill support plugin. Unity-control-center has been ported away from libnm-glib to libnm 1.2. u-c-c will make use of this plugin. Requested