On 04/21/2011 11:49 AM, Ted Gould wrote:
On Thu, 2011-04-21 at 11:34 -0400, Tony Espy wrote:
On 04/19/2011 08:09 PM, Jason Warner wrote:
Hi Everyone - Sending this on behalf of John Lea, desktop design lead.
==
Currently Ubuntu contains two
On 04/22/2011 10:27 AM, Ted Gould wrote:
On Thu, 2011-04-21 at 12:06 -0400, Tony Espy wrote:
On 04/21/2011 11:49 AM, Ted Gould wrote:
On Thu, 2011-04-21 at 11:34 -0400, Tony Espy wrote:
On 04/19/2011 08:09 PM, Jason Warner wrote:
Hi Everyone - Sending this on behalf of John Lea, desktop
@Alfonso
To do so would mean we need to add CI support for the NM 1.10 snap. We'll talk
about it during the product sprint this week, and can follow up at our sprint
next week.
--
https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/361245
Your team
Diff comments:
> diff --git a/snap/hooks/install b/snap/hooks/install
> deleted file mode 100755
> index 8f4e7ca..000
> --- a/snap/hooks/install
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -#!/bin/sh -e
This hook is also used to prevent installation on classic desktop systems, not
just Ubuntu
Review: Needs Fixing
--
https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/361245
Your team Network-manager is requested to review the proposed merge of
~alfonsosanchezbeato/network-manager:add-connectivity-check into
network-manager:snap-1.10.
--
The proposal to merge
~alfonsosanchezbeato/network-manager:add-connectivity-check into
network-manager:snap-1.10 has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/361245
--
Note, I'm not able to successfully build this version using the latest stable
version of snapcraft. This may be due to virtualization, as I'm building from
Ubuntu running under Parallels w/nested virtualization enabled (to allow
multipass to run). Perhaps this is because the Parallels VM
Review: Approve
LGTM
--
https://code.launchpad.net/~alfonsosanchezbeato/network-manager/+git/network-manager/+merge/361245
Your team Network-manager is requested to review the proposed merge of
~alfonsosanchezbeato/network-manager:add-connectivity-check into
network-manager:snap-1.10.
--
I'm not clear if this commit is temporary or not? Did you mean to check this in
so that you could test your CI changes, or are these changes intended to be
permanent so that we can build the snap using CI? Do we disable a similar set
of tests in the old HWE nm build too?
If these changes are
