Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-1809407-eoan into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master

2019-07-17 Thread Daniel van Vugt
Review: Disapprove -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/368536 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-1809407-eoan into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master. --

Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-1809407-eoan into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master

2019-07-17 Thread Daniel van Vugt
I would like to reject this instead of deleting it, so we retain history. But Launchpad gives me no Reject option. Can someone else? -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/368536 Your team Ubuntu Desktop is requested to review the proposed merge of

Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-1809407-eoan into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master

2019-07-17 Thread Daniel van Vugt
Forget this MP. A simpler version has now landed in mutter master, so we'll get the fix from there. -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/368536 Your team Ubuntu Desktop is requested to review the proposed merge of

Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-1809407-eoan into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master

2019-07-11 Thread Iain Lane
I'll be uploading 3.33.4 once it's released next week. Ideally I'll just have to do one upload, so this fix can be incorporated into that same release. Double ideally it'll be in the upstream part of that upload, if Marco stops nit-picking and presses merge at some point soon. :-) Close this MP

Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-1809407-eoan into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master

2019-07-08 Thread Daniel van Vugt
There are now stylistic changes being made upstream. Nothing of substance though so I probably wouldn't bother reflecting them here. This merge proposal exists to avoid being blocked waiting for upstream. If we are now waiting for upstream then I would more likely close this and just wait for

Re: [Merge] ~vanvugt/ubuntu/+source/mutter:fix-1809407-eoan into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master

2019-06-25 Thread TreviƱo
Review: Approve This LGTM -- https://code.launchpad.net/~vanvugt/ubuntu/+source/mutter/+git/mutter/+merge/368536 Your team Ubuntu Desktop is requested to review the proposed merge of ~vanvugt/ubuntu/+source/mutter:fix-1809407-eoan into ~ubuntu-desktop/ubuntu/+source/mutter:ubuntu/master. --