[Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-26 Thread Diego Rivera
Here's my first crack at a patch. It's for Ubuntu 8.04LTS (package versions are referenced in each patch filename). It has the GUI change for the OpenVPN stuff only. For PPTP the new delegating routing mode doesn't really make sense since PPTP doesn't have a mechanism (that I know of) to

[Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-26 Thread Diego Rivera
Ok... here's my second (actually, third! :D), cleaner crack at the same patch. The above patch had a couple of bugs in deleting VPN connections (wouldn't be properly deleted), and wouldn't import the new route_mode value from files. Again - it still only covers network-manager and

Re: [Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-26 Thread Diego Rivera
-- network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7 https://bugs.launchpad.net/bugs/194487 You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to openvpn in ubuntu. -- Ubuntu-server-bugs mailing list

[Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-26 Thread Diego Rivera
I sort of expected this to be the case - I'll read up on how to refactor those patches as you metion. However, the important part is that it the patches are built and designed such that if you install the patched version over existing configs, nothing changes functionally - i.e. you have to

[Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-26 Thread Diego Rivera
This defect severely limits the functionality of the OpenVPN client. PPTP is unaffected since the functionality is consistent with the available feature set. VPNC might be a case similar to OpenVPN. ** Changed in: network-manager (Ubuntu) Status: Invalid = Confirmed --

[Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-26 Thread Diego Rivera
Here's my first crack at a patch. It's for Ubuntu 8.04LTS (package versions are referenced in each patch filename). It has the GUI change for the OpenVPN stuff only. For PPTP the new delegating routing mode doesn't really make sense since PPTP doesn't have a mechanism (that I know of) to

[Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-26 Thread Diego Rivera
Ok... here's my second (actually, third! :D), cleaner crack at the same patch. The above patch had a couple of bugs in deleting VPN connections (wouldn't be properly deleted), and wouldn't import the new route_mode value from files. Again - it still only covers network-manager and

Re: [Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-26 Thread Diego Rivera
-- network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7 https://bugs.launchpad.net/bugs/194487 You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com

[Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-26 Thread Diego Rivera
I sort of expected this to be the case - I'll read up on how to refactor those patches as you metion. However, the important part is that it the patches are built and designed such that if you install the patched version over existing configs, nothing changes functionally - i.e. you have to

[Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-26 Thread Diego Rivera
This defect severely limits the functionality of the OpenVPN client. PPTP is unaffected since the functionality is consistent with the available feature set. VPNC might be a case similar to OpenVPN. ** Changed in: network-manager (Ubuntu) Status: Invalid = Confirmed --

[Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-25 Thread Diego Rivera
Ok I've located the culprit logic. It's in NetworkManagerSystem.c - the logic first removes all routes attached to the new VPN interface, and then proceeds to force-feed what it believes to be the correct routing configurations. I think what's appropriate here is the addition of a flag in the

[Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-25 Thread Diego Rivera
Ok I've located the culprit logic. It's in NetworkManagerSystem.c - the logic first removes all routes attached to the new VPN interface, and then proceeds to force-feed what it believes to be the correct routing configurations. I think what's appropriate here is the addition of a flag in the

[Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-25 Thread Diego Rivera
Ok I've located the culprit logic. It's in NetworkManagerSystem.c - the logic first removes all routes attached to the new VPN interface, and then proceeds to force-feed what it believes to be the correct routing configurations. I think what's appropriate here is the addition of a flag in the

[Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-25 Thread Diego Rivera
Ok I've located the culprit logic. It's in NetworkManagerSystem.c - the logic first removes all routes attached to the new VPN interface, and then proceeds to force-feed what it believes to be the correct routing configurations. I think what's appropriate here is the addition of a flag in the

[Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-06 Thread Diego Rivera
Yes, this is still an issue. I can confirm what our friend said earlier about routes being correctly added by OpenVPN and subsequently being removed (presumably by NetworkManager or the NM-OpenVPN plugin). In my view the problem is that the options do not permit the selection of the correct

[Bug 194487] Re: network-manager[-openvpn] doesn't handle properly routes pushed by OpenVPN 2.1_Rc7

2009-08-06 Thread Diego Rivera
Yes, this is still an issue. I can confirm what our friend said earlier about routes being correctly added by OpenVPN and subsequently being removed (presumably by NetworkManager or the NM-OpenVPN plugin). In my view the problem is that the options do not permit the selection of the correct