Review: Needs Fixing
I have one small request to it, otherwise good.
Diff comments:
> === modified file 'src/UbuntuToolkit/ucqquickimageextension.cpp'
> --- src/UbuntuToolkit/ucqquickimageextension.cpp 2016-09-12 09:03:50
> +
> +++ src/UbuntuToolkit/ucqquickimageextension.cpp
The proposal to merge lp:~tpeeters/ubuntu-ui-toolkit/toolbarScroll into
lp:ubuntu-ui-toolkit/staging has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/toolbarScroll/+merge/307847
--
Your team Ubuntu SDK team is
Review: Approve
Ok, I'm fine with it.
--
https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/toolbarScroll/+merge/307847
Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging.
--
Mailing list: https://launchpad.net/~ubuntu-sdk-team
Post to :
Review: Needs Information
A small comment about the property, perhaps we would want to use the QQC2
ApplicationWindow's contentItem as property name?
http://doc.qt.io/qt-5/qml-qtquick-controls2-applicationwindow.html#contentItem-prop
--
Review: Approve
Fair point on null->undefined! Thanks for the fix!
--
https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/anchors_cant_be_null/+merge/318450
Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging.
--
Mailing list: https://launchpad.net/~ubuntu-sdk-team
The proposal to merge lp:~aacid/ubuntu-ui-toolkit/fix_ucstylehints_leak into
lp:ubuntu-ui-toolkit/staging has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/fix_ucstylehints_leak/+merge/318478
--
Your team Ubuntu
The proposal to merge lp:~aacid/ubuntu-ui-toolkit/anchors_cant_be_null into
lp:ubuntu-ui-toolkit/staging has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/anchors_cant_be_null/+merge/318450
--
Your team Ubuntu SDK
Review: Needs Information
Mostly clarification I need. Also few more tests to cover the group properties
please.
Diff comments:
> === modified file 'components.api'
> --- components.api2016-09-17 05:48:25 +
> +++ components.api2016-12-13 14:24:00 +
> @@ -45,13 +45,14 @@
>
Review: Approve
Looks good to me. Thanks for fixing!
--
https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/fix_popup_focus_restore/+merge/314156
Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging.
--
Mailing list: https://launchpad.net/~ubuntu-sdk-team
Post to
Review: Needs Fixing
I would love to see some test cases to guard this :)
--
https://code.launchpad.net/~artmello/ubuntu-ui-toolkit/ubuntu-ui-toolkit-clipboard-dbus/+merge/314072
Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging.
--
Mailing list:
Review: Approve
All fine for now, let's get this in.
--
https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow/+merge/301278
Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging.
--
Mailing list: https://launchpad.net/~ubuntu-sdk-team
Post to :
Review: Approve
All clear, approved.
--
https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/organizedWindow/+merge/314631
Your team Ubuntu SDK team is subscribed to branch
lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/outTheWindow.
--
Mailing list: https://launchpad.net/~ubuntu-sdk-team
The proposal to merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/organizedWindow
into lp:ubuntu-ui-toolkit/staging has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/organizedWindow/+merge/314631
--
Your team
The proposal to merge
lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/layoutMirroringInAdaptivePageLayout into
lp:ubuntu-ui-toolkit/staging has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
Fair change, thx!
--
https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/layoutMirroringInAdaptivePageLayout/+merge/319833
Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging.
--
Mailing list: https://launchpad.net/~ubuntu-sdk-team
Post to
The proposal to merge lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/ellipticSubTitles
into lp:ubuntu-ui-toolkit/staging has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/ellipticSubTitles/+merge/318390
--
Your
Review: Approve
Nahh, no brainer :D
--
https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/ellipticSubTitles/+merge/318390
Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging.
--
Mailing list: https://launchpad.net/~ubuntu-sdk-team
Post to :
The proposal to merge lp:~aacid/ubuntu-ui-toolkit/fix-borderimage-regression
into lp:ubuntu-ui-toolkit/staging has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/fix-borderimage-regression/+merge/319556
--
Your team
Review: Approve
Oh, what a weirdo :) Thanks for getting back to it.
--
https://code.launchpad.net/~aacid/ubuntu-ui-toolkit/fix-borderimage-regression/+merge/319556
Your team Ubuntu SDK team is subscribed to branch lp:ubuntu-ui-toolkit/staging.
--
Mailing list:
The proposal to merge
lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/realLayoutDirectionChange into
lp:ubuntu-ui-toolkit/staging has been updated.
Status: Needs review => Approved
For more details, see:
20 matches
Mail list logo
