[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
** Changed in: maas/1.2 Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/1.2/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
** Changed in: maas/1.2 Status: In Progress = Fix Committed -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/1.2/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
Either way, this shouldn't be solved in packaging.. it's core support needed in MAAS for backwards compatibility. More importantly, fixing this upsteam is better because it means that the monkey patching code and the code stolen from django 14 gets exercised when we run the test suite on a platform with Django 1.3. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
** Also affects: maas/1.2 Importance: Undecided Status: New ** No longer affects: maas ** Changed in: maas/1.2 Assignee: (unassigned) = Raphaël Badin (rvb) ** Changed in: maas/1.2 Importance: Undecided = Critical ** Changed in: maas/1.2 Status: New = In Progress -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/1.2/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
** Branch linked: lp:~rvb/maas/generic-field-1.2 -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/1.2/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
** Changed in: maas Assignee: Raphaël Badin (rvb) = (unassigned) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
I'm not sure fixing this in the packaging is the right solution here. If we have a patch to add the new classes (plural, there is the field model and the form model), then we will have to update the upstream code to match that (everywhere where it's imported plus in all the migration files where it's used). This mean that the packaging for Quantal (which will also use the same 1.2 upstream version) will have to contain that patch too. This leads me to the conclusion that changing this upstream is probably better. This would mean embedding a copy of the needed classes in our code and using them instead of the ones provided by Django. Also, if we keep trunk as is, we will have a problem when upgrading from quantal to raring because one version will use the version of the field in Django and the other our own copy. A solution would be to have a DB migration in raring but, for reasons we already discussed (see the dev ml), we don't want the DB migrations to diverge like that. So the solution would be to keep using own version of the field (i.e. something like maasserver.generipfield.GenericIPAddressField), which, in trunk, could be a simple copy (as in GenericIPAddressField=django.db.models.fields.GenericIPAddressField) of the version in Django. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
Julian suggested another way to do this: carry a packaging patch with the field and the changes required to the source to use it. My main concern is that this field (as a string 'django.db.models.fields.GenericIPAddressField') is used by South in the migration code and, although this solution is a bit simpler than the one I suggested, we need to make sure it will work and the upgrade from a patched version to an non-patched version will work. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
Does it make sense to monkey patch if django required version? Either way, this shouldn't be solved in packaging.. it's core support needed in MAAS for backwards compatibility. Thanks. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
On 02/20/2013 03:54 PM, Dave Walker wrote: Does it make sense to monkey patch if django required version? It's also a possibility, but given the way Django plays with imports, this could be a dangerous game. Either way, this shouldn't be solved in packaging.. it's core support needed in MAAS for backwards compatibility. Fixing it in the packaging would be very similar to what was done in https://code.launchpad.net/~andreserl/maas/precise.sru.jslibs/+merge/146252 for ths js libs we can't SRU in precise though. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
Oh btw... we need to make sure that this doesn't provide any regression or upgrade failures from those who have been using MAAS from ppa:maas- maintainers/stable. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
On 02/20/2013 08:32 PM, Andres Rodriguez wrote: Oh btw... we need to make sure that this doesn't provide any regression or upgrade failures from those who have been using MAAS from ppa:maas- maintainers/stable. Good point, that's another argument in favor of the monkey patch solution. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
On 02/20/2013 04:11 PM, Raphaël Badin wrote: On 02/20/2013 03:54 PM, Dave Walker wrote: Does it make sense to monkey patch if django required version? It's also a possibility, but given the way Django plays with imports, this could be a dangerous game. That being said, the monkey patch solution is appealing because it means we continue to import the field from django.db.models.fields and we use 'django.db.models.fields.GenericIPAddressField' in the migrations in 1.2 *and* in trunk, thus avoiding all the upgrade issues. By making sure the monkey patching code is called at the top of the src/maasserver/models/__init__.py file (which is imported by Django at start up time), it seems we can solve the import issue. I've created a patch that does that and includes the GenericIPAddressField (plus all the required utility methods): http://paste.ubuntu.com/1691108/ Testing against a Django package without the genericipaddressfield.diff patch, I get the entire test suite to pass. Now I need to test the created package because we've seen that the import pattern differs when a Django application is loaded in a wsgi container. -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
On Wednesday 20 Feb 2013 19:54:21 Raphaël Badin wrote: On 02/20/2013 08:32 PM, Andres Rodriguez wrote: Oh btw... we need to make sure that this doesn't provide any regression or upgrade failures from those who have been using MAAS from ppa:maas- maintainers/stable. Good point, that's another argument in favor of the monkey patch solution. Sadly I think it's the only viable solution :( -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
In that case, this bug is not a MAAS bug, it's a packaging bug. ** Changed in: maas Status: New = Invalid ** Also affects: maas (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
I think we just need to move the patch I did for the Django package right into the maas package (with file path changes etc etc) -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
[Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
Hi Julian, This bug does not belong to the packaging nor MAAS *in* Ubuntu, because GenericIpAddressField patch is not in django nor applied int he packaging of any Ubuntu packages in the Archives. This is a bug that affects upstream MAAS and Upstream packaging. For this reason, this does not belong to Ubuntu MAAS, but rather, this is for Upstream MAAS/Packaging. Cheers. ** Changed in: maas (Ubuntu) Status: New = Invalid ** Changed in: maas Status: Invalid = New -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
Re: [Bug 1130232] Re: Implement GenericIpAddressField in MAAS rather than django.
Hey Andres, Upstream doesn't have packaging really. The packaging branch that's there belongs to Ubuntu, it just happens to be owned by Maas maintainers. Cheers Andres Rodriguez andres...@ubuntu-pe.org wrote: Hi Julian, This bug does not belong to the packaging nor MAAS *in* Ubuntu, because GenericIpAddressField patch is not in django nor applied int he packaging of any Ubuntu packages in the Archives. This is a bug that affects upstream MAAS and Upstream packaging. For this reason, this does not belong to Ubuntu MAAS, but rather, this is for Upstream MAAS/Packaging. Cheers. ** Changed in: maas (Ubuntu) Status: New = Invalid ** Changed in: maas Status: Invalid = New -- You received this bug notification because you are subscribed to MAAS. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1130232/+subscriptions -- You received this bug notification because you are a member of Ubuntu Server Team, which is subscribed to maas in Ubuntu. https://bugs.launchpad.net/bugs/1130232 Title: Implement GenericIpAddressField in MAAS rather than django. To manage notifications about this bug go to: https://bugs.launchpad.net/maas/+bug/1130232/+subscriptions -- Ubuntu-server-bugs mailing list Ubuntu-server-bugs@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs
