[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Launchpad Bug Tracker]

This bug was fixed in the package freeradius - 2.1.12+dfsg-1.2ubuntu8.1

---
freeradius (2.1.12+dfsg-1.2ubuntu8.1) trusty; urgency=medium

  * Manage process in upstart properly and fix logrotate reload (LP:
#1406105)

 -- Robert C Jennings   Tue, 04 Aug 2015
21:00:25 -0500

** Changed in: freeradius (Ubuntu Trusty)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Sebastian Marsching]

I verified that the bug is fixed in version 2.1.12+dfsg-1.2ubuntu8.1 and
that the upgrade process (restart) works as intended.

Thank you very much for your efforts in fixing this bug.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Sebastian Marsching]

** Tags removed: verification-needed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Robie Basak]

Thanks! This looks good. I particularly appreciate the effort you took
to figure through any upgrade path issues and the comprehensive coverage
you have of that in the Regression Potential section. This gives me much
more confidence in sponsoring this.

One very minor nitpick - I used version 2.1.12+dfsg-1.2ubuntu8.1 instead
of 2.1.12+dfsg-1.2ubuntu9 to make it clear that this is an SRU.
Technically 2.1.12+dfsg-1.2ubuntu9 would work in this case though and
the SRU team have no specific policy against it. More information on
picking a version number here (for version numbers, the same scheme
works for both security and SRUs):
https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging

Uploaded. Thanks again!

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Chris J Arges]

Hello Sebastian, or anyone else affected,

Accepted freeradius into trusty-proposed. The package will build now and
be available at
https://launchpad.net/ubuntu/+source/freeradius/2.1.12+dfsg-1.2ubuntu8.1
in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: freeradius (Ubuntu Trusty)
   Status: In Progress = Fix Committed

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Launchpad Bug Tracker]

** Branch linked: lp:ubuntu/trusty-proposed/freeradius

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Robert C Jennings]

Robie, can you review the patch in comment #10 for this fix?  Thanks.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Robert C Jennings]

Updated the patch.   The post-install scripts will restart the daemon so
that an upgrade will restart the daemon so that future reloads do work.
This addresses the 3rd scenario in comment #7.  There would be no
regression for users on upgrade.  If the service has been reloaded prior
to the upgrade such that upstart can't manage the daemon then this won't
fix things but won't regress the user either.  In that case, the user
will need to kill the running, unmanaged freeradius process and then
start from upstart again.

** Patch added: trusty_freeradius_lp1406105.patch
   
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+attachment/4439874/+files/trusty_freeradius_lp1406105.patch

** Changed in: freeradius (Ubuntu)
   Status: Confirmed = In Progress

** Description changed:

  The freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS (Trusty Tahr)
  has a bug in the logrotate script (/etc/logrotate.d/freeradius):
  
  The command /etc/init.d/freeradius reload is used for reloading
  freeradius after its logfile(s) have been rotated. However, in Ubuntu
  14.04 LTS freeradius is managed by Upstart, so that the script cannot
  work (the PID file does not exist).
  
  Therefore, the logrotate script should use initctl reload freeradius
  instead. Please note that this might not work either at the moment, due
  to bug #1282683. However, when this bug is finally fixed, the command
  mentioned earlier should work.
+ 
+ WORKAROUND:
+ 
+ Add an 'exec' in /etc/init/freeradius.conf per the patch in comment #8
+ and change /etc/logrotate.d/freeradius to use 'service freeradius
+ reload' rather then '/etc/init.d/freeradius reload' as per the same
+ patch in comment #8.  Attempt a 'service freeradius stop' and check that
+ the freeradius process is not running (or manually kill it).  From there
+ the service can now be started with 'service freeradius start'

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Robie Basak]

** Changed in: freeradius (Ubuntu Trusty)
   Status: New = Triaged

** Changed in: freeradius (Ubuntu Trusty)
   Importance: Undecided = Medium

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Robie Basak]

** Also affects: freeradius (Ubuntu Trusty)
   Importance: Undecided
   Status: New

** Also affects: freeradius (Ubuntu Vivid)
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Robert C Jennings]

** Changed in: freeradius (Ubuntu Vivid)
   Status: New = Invalid

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Robert C Jennings]

Marking vivid as invalid as the this affects trusty (upstart) only not
systemd based releases (vivid/wily)

** Changed in: freeradius (Ubuntu)
   Status: In Progress = Invalid

** Changed in: freeradius (Ubuntu Trusty)
   Status: Triaged = In Progress

** Changed in: freeradius (Ubuntu Trusty)
 Assignee: (unassigned) = Robert C Jennings (rcj)

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Robert C Jennings]

** Description changed:

+ [Impact]
+ 
+  * freeradius can not be reloaded, upstart will lose track of the
+ process and leave the original process running (blocking future service
+ starts)
+ 
+  * log rotation will not function as intended. The service is not
+ reloaded and the file handles for the rotated logs will not be dropped.
+ Logging after rotation occurs will consume storage but be inaccessible
+ to the user for review.
+ 
+ 
+ [Test Case]
+ 
+  * 'service freeradius start'
+  * 'service freeradius reload'
+  * 'service freeradius status' Result stop/waiting
+  * 'ps -ef|grep freeradius' Result: prior freeradius process still running, 
new process can not be started.  Existing process can not be stopped
+  * 'service freeradius stop' Result: process does not stop, not tracked up 
upstart
+ 
+ OR
+  * 'service freeradius start' Result: PID displayed is for 'sh' not 
'freeradius'
+  * logrotate --verbose --force /etc/logrotate.d/freeradius
+  * 'service freeradius status' Result: stop/waiting
+  * 'ps -ef | grep freeradius' Result: freeradius still running (never 
received HUP)
+  
+ 
+ [Regression Potential]
+ 
+  * Upgrade testing needs to ensure that upgrade does not make a system
+ which still could stop/restart freeradius no longer able to stop/restart
+ without manually killing the freeradius process.  Mitigated because the
+ postinst for freeradius will restart the service.  The postinst for
+ freeradius-* will reload but will be run after the freeradius postinst
+ has restarted to use our fixed upstart configuration.
+ 
+  * If the user has attempted to reload the service prior to upgrade,
+ which results in freeradius running but no longer managed by upstart,
+ the upgrade will not regress nor fix this environment.  In that case the
+ workaround, below, will need to be run (or server restarted) so that
+ upstart can manage freeradius.
+ 
+ [Other Info]
+  
+  * None
+ 
+ ORIGINAL DESCRIPTION:
+ 
  The freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS (Trusty Tahr)
  has a bug in the logrotate script (/etc/logrotate.d/freeradius):
  
  The command /etc/init.d/freeradius reload is used for reloading
  freeradius after its logfile(s) have been rotated. However, in Ubuntu
  14.04 LTS freeradius is managed by Upstart, so that the script cannot
  work (the PID file does not exist).
  
  Therefore, the logrotate script should use initctl reload freeradius
  instead. Please note that this might not work either at the moment, due
  to bug #1282683. However, when this bug is finally fixed, the command
  mentioned earlier should work.
  
+ In this case, freeradius is not reloaded so the file handles for the
+ rotated logs will remain open.  Logging will cause the disk utilization
+ to increase (log rotation is ineffective) and due to rotation the user
+ can not view the logs from that point forward.
+ 
+ Additionally, if 'service freeradius reload' is run, the service will
+ not be HUP'ed and upstart will lose track of the service, leaving the
+ process running.
+ 
  WORKAROUND:
  
  Add an 'exec' in /etc/init/freeradius.conf per the patch in comment #8
  and change /etc/logrotate.d/freeradius to use 'service freeradius
  reload' rather then '/etc/init.d/freeradius reload' as per the same
  patch in comment #8.  Attempt a 'service freeradius stop' and check that
  the freeradius process is not running (or manually kill it).  From there
  the service can now be started with 'service freeradius start'

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Robert C Jennings]

Back to the prior patch to reduce scope by removing changes for 'init.d'
- 'service' for force-reload operations in postinst scripts if invoke-
rc.d is not available.  This is not changed as we can assume invoke-rc.d
is installed and the SRU change needs to be minimal.

** Patch added: trusty_freeradius_lp1406105.patch
   
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+attachment/4439936/+files/trusty_freeradius_lp1406105.patch

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Robert C Jennings]

Here is a debdiff to show how we can manage the process properly in an
upstart job (missing exec) so that a restart or reload works as we would
expect.  The patch also fixes the logrotate script to use the upstart
controls rather than the systemv init script (which should not have been
shipped because it isn't used on Trusty).

Prior to this patch you can't restart/reload the process because the
process isn't properly managed by upstart and logrotate's reload of
freeradius was a no-op.  With this patch, logstart will properly call
'service freeradius reload', ignoring failure due to the service not
running.

Package upgrade is a problem Is there a way  to fix the management
of a running freeradius process on a user's system when this package is
updated?  We would not want to perform an unexpected restart of the
service and without this fix reloading the service won't work (nor will
the restart because it kills the shell that start the freeradius process
but not the freeradius process itself).  However, having the upgraded
package on the system won't make the current situation any worse and
will resolve the issue on the first reboot (or manually killing
freeradius and starting again).

Best I know that we can do is put the fix in place and it will be
available after a restart; having the upgraded package on the system
won't make the current situation any worse but it won't fix the issue
prior to a restart or some manual intervention to clean up the unmanaged
freeradius process.

To illustrate the current process problem:
 1 - Install freeradius on trusty
 2 - Run 'start freeradius'
 3 - Get the PID upstart is using for freeradius with 'status freeradius'
 4 - Check ps for that PID
(e.g. if PID is 1023 run 'ps -ef | grep 1023 | grep -v grep'.  Upstart job 
PID will map to /bin/sh, the parent of freeradius)
 5 - Run 'reload freeradius'. 
  Expect success, exit 0 and freeradius is still running (SIGHUP was not 
delivered, check with a shim if you like)
 6 -  Run 'status freeradius' .
  Results in freeradius stop/waiting because the parent shell script died 
when it received HUP but freeradius is still running.
 7 - Run 'ps -ef |grep freeradius'.
  Expect freeradius still running (same PID as step 4 but PPID is now init)
  This process isn't tracked by upstart now.  You can't 'start freeradius' 
because the new process will exit upon failing to open the port already opened 
by the untracked freeradius.


** Patch added: trusty_freeradius_lp1406105.debdiff
   
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+attachment/4439415/+files/trusty_freeradius_lp1406105.debdiff

** Changed in: freeradius (Ubuntu)
 Assignee: (unassigned) = Robert C Jennings (rcj)

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Robert C Jennings]

Wily is using the systemV init scripts and is not affected by this bug.

Trusty is using upstart which lacks a reload function currently.

Changing the logrotate postrotate script on trusty to call 'service
freeradius reload' will not work without explicitly creating a reload
function in the upstart job.  The patch as included in comment #2 will
kill the parent of freeradius (which is the upstart shell script) and
will attempt to restart it but the original freeradius process is still
running and no longer managed by upstart.  When this occurs, upstart
will show that the freeradius service is not running and will not be
able to start it because the port is in use by the un-managed freeradius
process.

Next action:
 - Investigate adding a reload handler for the upstart job.  This will need the 
PID for the freeradius process that was started so that it can send a HUP 
signal as seen in the systemV init job.  In the case that the PID file is 
missing then the reload should do nothing and exit cleanly as the lack of PID 
file would indicate that freeradius is not running; we would not want to 
restart the service as this would have the affect of starting a stopped 
service.  Then change logrotate script in trusty to call 'service freeradius 
reload'  and consider removing the redirect to /dev/null.

I have run out of time today but have left these notes so that we can
pursue it further.

** Changed in: freeradius (Ubuntu)
 Assignee: Robert C Jennings (rcj) = (unassigned)

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Robert C Jennings]

** Changed in: freeradius (Ubuntu)
 Assignee: (unassigned) = Robert C Jennings (rcj)

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Robert C Jennings]

Robie / Chris,

Can you review comment #6 for the proposed patch and upgrade
issue/strategy?

The upstart config for freeradius is bad; reload(8) or restart(8) will
lose track of the process.  A reload won't send SIGHUP to the right
process and a restart(8) will  not stop the existing freeradius process;
in either case upstart loses track of the process and thinks the service
has stopped, further attempts to start the service will fail because of
the existing process holding the port open.  The patch fixes this for
new, clean starts of the service but on a running system I don't think
we have a way to make things better without manual intervention ('pkill
freeradius' when the user can afford to take the process down) or a
reboot.

I might be missing something clever, but I doubt there is a good way to
fix this for the different states we might find things in during
upgrade.

Scenarios:
1 - freeradius is not running.  Upgrading the package is great.
2 - freeradius is runing and 'reload/restart' has been called previously (i.e. 
upstart can't manage the freeradius process).  Upgrading will not regress the 
system because upstart could not manage the service prior to package upgrade.
3 - freeradius is running and 'reload/restart' has never been called  (i.e. 
upstart can still stop the process properly).  Upgrading will fix logrotate and 
the next rotation will call 'reload freeradius' causing upstart to lose track 
of the process.  It can no longer be stopped by upstart.

The only issue is scenario #3 which regresses the user's ability to stop
freeradius *if* they have not tried to reload or restart the service.  I
don't think that we can take the action to restart the service on
package upgrade if upstart can still manage the service due to service
interruption.  The next logrotation attempt will ensure that the user
can not manage freeradius from upstart.

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Launchpad Bug Tracker]

Status changed to 'Confirmed' because the bug affects multiple users.

** Changed in: freeradius (Ubuntu)
   Status: New = Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to freeradius in Ubuntu.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Sebastian Marsching]

I just realized that there is a better solution for the logrotate
script: By using service freeradius reload, the script will work when
Upstart is used but also when the traditional init script is used.

** Patch added: Revised patch for the logrotate script
   
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+attachment/4288787/+files/freeradius_logrotate.patch

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to freeradius in Ubuntu.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs

[Bug 1406105] Re: Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu 14.04 LTS

[Ubuntu Foundations Team Bug Bot]

The attachment Suggested patch for logrotate script seems to be a
patch.  If it isn't, please remove the patch flag from the attachment,
remove the patch tag, and if you are a member of the ~ubuntu-
reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by
~brian-murray, for any issues please contact him.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Server Team, which is subscribed to freeradius in Ubuntu.
https://bugs.launchpad.net/bugs/1406105

Title:
  Broken logrotate script in freeradius-2.1.12+dfsg-1.2ubuntu8 on Ubuntu
  14.04 LTS

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/freeradius/+bug/1406105/+subscriptions

-- 
Ubuntu-server-bugs mailing list
Ubuntu-server-bugs@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-server-bugs